We previously sent the top coordinate of the bubble bar to shell.
However when the screen height changes, launcher takes a bit longer
to update than shell. So instead of calculating the top coordinate
on the launcher side, we now send the amount of space between the
bubble bar and the bottom of the screen to shell, where we can offset
that as needed.
Bug: 392893178
Flag: com.android.wm.shell.enable_bubble_bar
Test: manual
- send some bubbles
- launch app
- expand
- swipe to home
- fold and unfold
Change-Id: I57b96db49dab1e2304fde8dc55a99eaaf85e40f8
This CL adds a display ID to the query to check the availability of
taskbar.
On an external display, we always show the taskbar regardless of the
launcher state, so the existing checks don't make sense on the external
display.
Flag: EXEMPT - test fix
Fix: 408631713
Fix: 414092022
Test: atest WMShellFlickerTestsDesktopMode:com.android.wm.shell.flicker.OpenAppWithExternalDisplayConnected
Change-Id: I0281a3cffd182e57ecf56e8fb5e4d28d6a4384c3
- Only primary displays should use LauncherTaskbarUIController.
- This change is required for overview on connected displays to work.
Bug: 362720616
Test: m
Flag: com.android.window.flags.enable_taskbar_connected_displays
Change-Id: I6945107e6072561b1904dcafd6106d4317eaba1d
... to launch an individual task window from desktop tile in Overview
when multi-desks is enabled, until the fix for b/413378320 is landed.
Note the changes in
http://ag/q/topic:%22activate-window-from-exploded-view%22 is the right
implementation, however it will only work for multi-desks with the fix
for b/413378320 is in place.
Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug: 413378320
Change-Id: I72914d60fb0ec2e80af6faa7441a67e743720c38
- scroll if the header is under gesture region and click in same scroll loop
Test: Local, Presubmit
Bug: 402828709
Flag: EXEMPT bugfix
Change-Id: I90a5cf2829591aafd18ef625244def2c4d9e3980
Fix to handle failures caught by launcher.checkForAnomaly so that they
are also reported to the test watcher.
Bug: 406906811
Test: presubmit
Flag: NONE Not production code
Change-Id: I379fcf09e3cd2e6321be9f4bc3dd6f3272e9c2fd
- When we clean up the recents window, the recents view gets dettached, which causes a activity leak in tests and prod through RecentsView.mOnTaskLaunchCancelledRunnable. Fixing this leak across all uses of RecentsView, rather than just for RecentsWindowManager
- Also cleaning up a potential leak in RecentsWindowManager.callbacks
Flag: com.android.launcher3.enable_launcher_overview_in_window
Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 377678992
Bug: 292269949
Test: swiped up from running app, checked leak canary and heap dump; pre/post-submit tests
Change-Id: Id95b36dad6e41e5b21d1af8ede489f84ef987e50
When we show a new flyout, it is possible for the previous flyout to
still be there and animating out.
We were removing the existing flyout, but did not cancel the animation.
This meant that there could have been a hide animation running for the
previous flyout. Once that animation finished, it removed the current
flyout from the container. It was possible for the current flyout to
already be updated to the new one. In which case the animation for the
previous flyout hid the new flyout.
Bug: 414808503
Test: atest PlatformScenarioTests:BubbleBarTest
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I4229297fa999d815c12eefd9d583bdfc915ec00a
It doesn't seem necessary anymore (and anyway, existing cases like
Taskbar being stashed while IME is showing handle this as well).
Removing the specific block fixes a bug where touches were going
to the underlying app even though Taskbar window is fullscreen
while editing a Folder name.
Fixes: 400859085
Test: TaskbarInsetsControllerTest
Flag: EXEMPT bugfix
Change-Id: If30acd0b3b9c3fd0b29b94ca963beb1c70162416
- In KQS existing code there is a check that returns early if a user is
trying to switch to a running task. This check returns true for a task
that is not running thus creating an issue when user tries to switch
to that task using KQS.
- While the root cause of the issue will take time to fix, this
temporary check ensures that we workaround it when flatenning
heirarchy feature is enabled. This issue happens when multi-desk
backend flag is true and flatenning flag will always be true when
multi-desk is true (given how the features are timed for release).
Flag: com.android.launcher3.enable_alt_tab_kqs_flatenning
Test: m
Bug: 414410702
Change-Id: Ia35d6706a1512efbb4feca0128a9d59cd930df2f
- A recent change applied IME insets equal to keyboard's height to Launcher's BaseDragLayer
- mSystemGestureRegion takes a max of both IME insets and gesture insets, and caused a bug that while a live tile have keyboard open is in Overview, bottom half of the screen ignored touches to dismiss the task
- The bug that ointroduceds IME insets consideration no longer repros, thus removing IME insets from mSystemGestureRegion to sovle the issue
Fix: 404376494
Test: manual
Flag: EXEMPT bug fix
Change-Id: I5d8861ea204df9898b10cb7ccdeba94e94e5909c
Reason: Recents app can only listen to key gesture events after ag/33295605, which is gated by a read only flag, com.android.window.flags.grant_manage_key_gestures_to_recents.
Test: atest NexusLauncherTests:QuickstepKeyGestureEventsHandlerTest
Test: atest NexusLauncherTests:AllAppsActionManagerTest
Flag: com.android.window.flags.grant_manage_key_gestures_to_recents
Bug: 406452076
Change-Id: I66f8c9b2f23eb65bafc986321ff971c855ce00a3
These were intended to be placeholders for non-quickstep builds,
but it seems soong ends up using the base version instead of the
override in quickstep. So now we always use the non-night version
which gets overridden correctly (and that color resource itself
defines a dark mode variant).
Test: mp launcherd - verify light and dark mode use themed colors.
Bug: 414732288
Flag: com.android.launcher3.all_apps_blur
Change-Id: I21bf8e66bf1715a8b3532931ed64725ccc3f86b9
The frameworks updated the Insets API signature to support relative
insets to make the insets system works better under desktop mode and to
support more flexible usage in the future. Update the corresponding call
to match the changed signature.
Test: InsetsStateTest InsetsPolicyTests
Test: WindowContainerTests
Flag: com.android.window.flags.relative_insets
Bug: 277292497
Change-Id: Ib0d866514dcac33b72e1715f8442b695d9e9b3a0
We decided to pass image content instead in a follow up CL.
Test: manual
Bug: 414869782
Flag: com.android.launcher3.enable_growth_nudge
Change-Id: I05167f81ac7b887cb5e00915f1ffdec0bb2dc720
Flag: com.android.launcher3.enable_launcher_icon_shapes
Flag: com.android.systemui.shared.new_customization_picker_ui
Bug: 414860182
Test: manually flipping icon shapes flag off and opening new picker
Change-Id: I1fdb1a5f790438055fae28c65e4653d97042ea7f
This cl includes :
- Refactor to remove unpinning/pinning in desktop mode with refactor of DisplayController, TaksbarPinningController, and its tests.
- Combined the auto stashing conditions under one method shouldAllowTaskbarToAutoStash() which takes in consideration isTransientTaskbar, isInDesktop, and Always Show Taskbar option is turned on/off in desktop mode.
- enabled taksbar divider popup support in desktop mode.
- Intorduced animation for pinned taksbar when autostadhing is enabled.
- Enable to onSwipeToUnstashTaskbar for TaskbarInputStashController for pinned taksbar in desktop mode.
Test: Presubmit, Unit, Manual
Bug: 381535785
Flag: com.android.window.flags.enable_desktop_windowing_mode
Change-Id: Ie5ecf3a3c72bf8dfadf2d0c908269305fe5bad0b
Sunny Goyal
Liran Binyamin
Schneider Victor-tulias
Toshiki Kikuchi
Alex Chau
Treehugger Robot
Ajinkya Chalke
Xiaoqian Dai
Bill Yi
Vadim Tryshev
Jagrut Desai
Brian Isganitis
Ats Jenk
Tony Wickham
Jordan Silva
Steven Ng
Andy Wickham
Yunfan Chen
Li Lin
Charlie Anderson
Willie Koomson
Shamali Patwa