The issue existed because of taskbar insets where set to the full height
of bubble and task bars. Added check that only adds bars touch area if
the user is currently not on the launcher home screen. Commented failing
tests.
Bug: 358301278
Bug: 359277238
Flag: com.android.wm.shell.enable_bubble_bar
Test: Manual.
http://recall/-/gx8ASgewUeUS3QYohfrd1J/hcgYuHUJwfbhlvPRsvdWYf
The touch area is within the red rectangle.
Change-Id: I3c2ad3633a049972b93fe5c5e45efd557c220e1f
- Nothing currently detaches the nav bar from the app until the recents
animation completes if onAnimationStart() happens after the end
target is set
Flag: EXEMPT bugfix
Fixes: 343457097
Test: Artificially introduce delayed onRecentsAnimationStart and verify
detachNavFromApp is called
Change-Id: I1ec0d8821d61f9fad9a811d6a12ce21e8417252f
Sometimes SmartspaceViewContainer is not the LastFocusedItem in ItemFocusIndicatorHelper when triggering changeFocus, it would skip the hiding outline animation which causes the stuck focus outline.
So the solution is to add a checking in "changeFocus" that if the LastFocusedItem is not the view calling changeFocus and it does not have focus now, it means no need to add or remove outline and could just return.
Bug: 349019294
Test: after going to notification panel, touch/click could make the outline disappears. https://drive.google.com/file/d/1aXQ38CEqvzJVj7gBM-KNTCJSpzfwYZsn/view?usp=sharing
Test: after going home from app in overview, touch/click make the outline disappears. https://drive.google.com/file/d/1DgYzAgIJqAHJ_DuYjswlCUBOiohprJze/view?usp=sharing
Flag: EXEMPT bugfix
Change-Id: I4613ba2fe92ec609055e48dc0b5ff53c2037a158
The RoundedDrawableWrapper applies rounded corners on each draw, so,
on scaling, the corners look odd for small widgets.
This change, applies the same scale to corner radius as well.
There are some widgets whose preview images have embedded transparency,
but we don't do much for such previews.
Bug: 359860747
Test: Manual
Flag: EXEMPT bugfix
Change-Id: I5e58e29765503454f286d99050b13b497531d306
Somehow deviceProfile.isGestureMode doesn't have the right signal for tests.
We need to look into why dp doesn't have the right signal for isGestureMode in tests. Temporary fix here to unblock pushing the flag to staging
Bug: 359196354
Test: https://android-build.corp.google.com/builds/abtd/run/L05600030005823769
Flag: com.android.wm.shell.enable_taskbar_on_phones
Change-Id: Ie6451812cf4b0c3f034cabdfd4cec726322af0bc
One case I missed was a bubble being added/removed AND the overflow
showing... this isn't the nicest, but when the add/remove animation
is done, animate the overflow in.
Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 358304168
Test: manual - don't have the overflow showing, add a 6th bubble,
observe that the overflow appears
Change-Id: I1a9cec3970f5535e935f3404fa6dbd6de2f69fa5
This is the unit testing for the updates to IconCacheUpdateHandler
Bug: 357725795
Test: SELF
Flag: TEST_ONLY
Change-Id: I159f5ef70fcc9a5aae7bb319f06a3ff935f28246
Flag: com.android.wm.shell.enable_bubble_bar
Test: manual - have bubbles in bubble bar, switch between transient
taskbar and pinned taskbar repeatedly.
Bug: 359096619
Change-Id: I02beacff64b12380ee6d134b7dcc64cfd27e4b0b
Revert submission 28703070-bubbles-defer-expand
Reason for revert: DroidMonitor. Potential culprit for b/359765550 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.
Reverted changes: /q/submissionid:28703070-bubbles-defer-expand
Change-Id: I5651cc8f740b1f0718abcfa8065e18c174657224
- See http://go/b320307512_problems for details
- Adding the following to DesktopTaskView's launch animation
- Problem 1: Animate away DesktopTaskView's background according to fullscreenProgress, instead of a jump cut
- Problem 2: Animate Overview's background to transparent to reveal the wallpaper behind
- Problem 3: Animate wallpaper's zoom back to 1
- Problem 4: Apply TaskRectTransltion in TaskViewSimualtor for DesktopTaksView as well, which is used to account for TaskView not in center.
- Problem 4: Also applied RecentsView zoom in animation when TaskView is not in center, to make the whole DesktopTaskView container (backgroundView) moves as a whole. This requires calculating a new pivot before applying the zoom.
- Problem 5: When swipe down or quick switch from home into Desktop, run DesktopRecentsTransitionController without animation to put everything in the end state immediately to avoid animating again
- Problem 6: For swipe down animation, we now let createAdjacentPageAnimForTaskLaunch handle the wallpaper zoom and splash alpha, instead of doubling the effort. In case of Desktop, wallpaper depth be aniamted to 0 (no zoom/blur)
- Problem 6: Bring Desktop live tile to front during swipe down to avoid wallpaper blur applying to the desktop
- Problem 7 and 8: Crop out desktop window outside full screen bound. This is done by calulating intersection between full screen Rect and desktop window's Rect
- Problem 8: Make swipe down to use thumbnailBounds instead of bounds of the first snapshotView, this fixes all situations that first snapshotView's height is different from TaskView (e.g. vertical split, DesktopTaskView)
- Problem 9: Desktop remote target's alpha should remain 1
Bug: 320307512
Test: TaplTestsOverviewDesktop, motion fixes are tested manually
Flag: com.android.window.flags.enable_desktop_windowing_mode
Change-Id: Iae6e594424dfc89851b4f7179b0fb5b5ac5e7f46
Signed-off-by: Alex Chau <alexchau@google.com>
After dragging the bubble bar to dismiss, don't reset its alpha
value.
Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 359804931
Test: manual
- Create a bubble in the bubble bar
- Drag bubble bar to dismiss
- Create another bubble
- Observe the new bubble does not flicker
Change-Id: I8d56f71d38ec33acda8efade50735b59254d77d4
With optional overflow, we need to check for actual bubble count
before animating the bubble bar to its initial state.
Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 359403793
Test: manual
- create first bubble on home
- observe bubble bar animates correctly to initial state
- add second bubble
- observe bubble bar bounces correctly and does not slide
in from the bottom of the screen
Change-Id: I53a34bc00b24e8a6504bcca0532054755554b9ac
The split screen app shortcut is not intended to work in Desktop Mode.
This change removes it from Taskbar and all apps in this mode to avoid
a crash.
Fix: 346333758
Test: Launch the app menu for different apps in Desktop mode and in
normal mode. Check that the split option only shows up in normal mode.
Flag: EXEMPT bugfix
Change-Id: I6e2535b41a490ad3eb5c0ebd924c49eaf5028669
Shamali Patwa
mpodolian
Luca Zuccarini
Pat Manning
Helen Cheuk
Treehugger Robot
Winson Chung
Android Build Coastguard Worker
Brandon Dayauon
Andrew Cole
Xin Li
Stefan Andonian
Liran Binyamin
Tracy Zhou
Mady Mellor
Sihua Ma
Saumya Prakash
Liana Kazanova (xWF)
Alex Chau
Bill Yi