Commit Graph

83004 Commits

Author SHA1 Message Date
Tracy Zhou e5be9281c5 Only call notifyUpdateLayoutParams when the params is changed
Bug: 361405157
Test: manual
Flag: com.android.wm.shell.enable_taskbar_on_phones
Change-Id: Ieddcfbc8a8deea9415fe9815926e5fa5552b4be3
2024-08-24 03:10:42 +00:00
Android Build Coastguard Worker e9363ee573 Snap for 12272146 from 19b9344636 to 24Q4-release
Change-Id: Ib7c70afb4c615ef6dc61a12607ba3f31498e949c
2024-08-24 01:21:08 +00:00
Andy Wickham 053997ed82 Honors three_button_corner_swipe flag.
This allows the corner swipe gesture to be recognized while in 3
button navigation mode.

Demo: https://drive.google.com/file/d/1cwma-K5Ht-CYYmFgHw4OgefCS8Zvp140/view?usp=drive_link&resourcekey=0-rYzpTFc0l8R53QnaLwBANg
 - Corner swipe works
 - Other swipes don't do anything
 - Buttons still behave as expected
 - Long Press Home still invokes Circle to Search

Bug: 361651619
Bug: 356441231
Test: See video
Flag: com.android.systemui.shared.three_button_corner_swipe
Change-Id: I0765868dd1ad9786dc5b5f0574d107221ef13556
2024-08-23 17:03:20 -07:00
Treehugger Robot 9de3b46abf Merge "Rename test helper filegroup to robo" into main 2024-08-23 23:44:00 +00:00
mpodolian dcd76d56c7 Fixed issue with the bottom zone of launcher is not touchable.
Updated logic of the touch area configuration. Only add the taskbar
bounds if the taskbar is being shown inside the app or on overview.

Fixes: 358301278
Fixes: 361653416
Test: Manual:
http: //recall/-/gx8ASgewUeUS3QYohfrd1J/lpzJER3iGI5PpZrQqv7b7
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: Id9902058c5ec873dab6257a34b4c3a87aec5ae6b
2024-08-23 16:43:37 -07:00
Vinit Nayak 8f53b7be9f Merge "Move CUJ trace start closer to AppPair launch animation" into main 2024-08-23 22:44:49 +00:00
Sihua Ma a9e4324bd5 Rename test helper filegroup to robo
Test: N/A
Flag: EXEMPT filegroup rename
Change-Id: I8afeccc69fbca8e317c6b74a051d6b94239b8c52
2024-08-23 22:13:33 +00:00
Bryce Lee 6668ab9cab Show Taskbar when Glanceable Hub is showing.
This changelist ensures that the Taskbar is not hidden when the
Glanceable Hub is showing. Logic for hiding the Taskbar when dreaming
was suppressing it from showing when Glanceable Hub was present. The
surrounding condition has been updated to now not trigger is Glanceable
Hub is showing.

Test: manual - verified Taskbar was properly displayed and hidden
      between glanceable hub and dreaming.
Flag: EXEMPT bugfix
Fixes: 353803584
Change-Id: I58a61617baff65041757ae0df96687a071120880
2024-08-23 13:31:09 -07:00
Charlie Anderson 19b9344636 Merge "Use bugfix flag for archived broadcast extras" into main 2024-08-23 20:07:06 +00:00
Treehugger Robot 8d18757f77 Merge "Fix wrong condition used to calculate clearAllShortTotalTranslation" into main 2024-08-23 19:56:10 +00:00
Vinit Nayak 71255b93f4 Move CUJ trace start closer to AppPair launch animation
Fixes: 361501841
Test: Logged CUJ and ensuring it gets hits when anim starts
Flag: EXEMPT bugfix
Change-Id: Ifecd2ccd21bf40a69fecad0c9634d122c058f059
2024-08-23 11:44:14 -07:00
Charlie Anderson 4c159412de Use bugfix flag for archived broadcast extras
Bug: 322314760
Test: locally
Flag: com.android.launcher3.enable_first_screen_broadcast_archiving_extras
Change-Id: I9e3944d35a1cf2a17d1b5fcbf249ecf488265a93
2024-08-23 18:08:15 +00:00
Jordan Silva 7775a4da34 Convert OverviewCommandHelper to Kotlin
This CL converts OverviewCommandHelper to kotlin prior to a refactoring CL and improvements in how the command queue is handled.

Bug: 352046797
Bug: 351122926
Flag: EXEMPT bugfix.
Test: Manual. Class conversion without behaviour changes.
Change-Id: I7edda0a5326ad2047546434214e048a5989124a4
2024-08-23 15:49:26 +01:00
Charlie Anderson cbbba7609c Merge "Fix cropped pre-archived app icons by converting to a fixed Adaptive Icon" into main 2024-08-23 14:22:56 +00:00
Shamali Patwa 9374094474 Merge "Fix issue that personal list shows on unfold while on work tab (paused)" into main 2024-08-23 13:41:21 +00:00
Alex Chau 24e03825cd Fix wrong condition used to calculate clearAllShortTotalTranslation
- We now calcualte the first task's start position, and compared against the expected position (mLastComputedTaskSize) to determine if we need extra translation for ClearAllButton
- The calculation is done with `mIsRtl = true`, and only only flip +/- when applying translation
- http://screen/brM3taew74Z3uZJ shows what happens without clearAllShortTotalTranslation:
  - Blue area is mLastComputedGridSize, green area is longRowWidth
  - firstTaskStart is caculated from left of grid size, adding longRowWidth
  - Red area is mLastComputedTaskSize, where focus task is in the middle (for grid-only-overview it's in top right)
  - clearAllShortTotalWidthTranslation is the yellow area

Fix: 354104098
Test: With normal/largest display size, LTR/RTL, focus task /grid only Overview, swipe up with 1/2/6/7 tasks
Flag: EXEMPT BUG_FIX
Change-Id: I324eebc0a2b2129a4ba62d4569bc555b74140c21
2024-08-23 12:03:40 +01:00
Android Build Coastguard Worker 9a39a05f43 Snap for 12265118 from 11290775f4 to 24Q4-release
Change-Id: Idfd627ea15b1618fa54123e31a074aed576f6aeb
2024-08-22 23:21:31 +00:00
Charlie Anderson 4609d53ecf Merge "For archived apps, reset icon span as soon as BubbleTextView starts unarchiving" into main 2024-08-22 20:46:25 +00:00
Shamali P b3153f0bee Fix issue that personal list shows on unfold while on work tab (paused)
Bug: 358041878
Flag: EXEMPT bugfix
Test: on fold device with test dpc
Change-Id: I4b6d758cd4d98af941e2222db21a0307e1088867
2024-08-22 19:17:32 +00:00
Charlie Anderson 2a7b221676 Fix cropped pre-archived app icons by converting to a fixed Adaptive Icon
Bug: 358123888
Test: locally testing B&R with pre-archiving
Flag: com.android.launcher3.use_new_icon_for_archived_apps
Change-Id: Id01ef1e1812dda14a8b456834506c28aebc34623
2024-08-22 18:59:14 +00:00
Tony Wickham 3a47759619 Merge "Fix Taskbar being visible over Hotseat when recreated in Overview" into main 2024-08-22 18:51:55 +00:00
Tony Wickham 39d0107ef2 Merge "Animate away Recent Apps section when going to home" into main 2024-08-22 18:45:08 +00:00
Sebastián Franco 6edce2ad75 Merge "Remove test to postsubmit while they are flaky" into main 2024-08-22 17:08:45 +00:00
Alex Chau 11290775f4 Merge "Refresh runningTaskView's thumbnail after setting shouldShowScreenshot to true" into main 2024-08-22 15:17:35 +00:00
Charlie Anderson 1a30d3ab8c For archived apps, reset icon span as soon as BubbleTextView starts unarchiving
Bug: 350758155
Test: locally verify
Flag: com.android.launcher3.use_new_icon_for_archived_apps
Change-Id: Icc76c1bf300b2aa7883e571333bef1d33698f899
2024-08-22 10:09:09 -04:00
Jordan Silva e7c300f8f5 Merge "Fix condition when should focus on running task" into main 2024-08-22 10:32:50 +00:00
Treehugger Robot 7369348ba8 Merge "Delete dead test SettingsActivityTest" into main 2024-08-22 10:01:55 +00:00
Alex Chau eececf272e Merge "Reset mTopRowIdSet in applyLoadPlan" into main 2024-08-22 09:49:27 +00:00
Uwais Ashraf 37752f5e19 Merge changes I31d9a51e,I1bc14be7 into main
* changes:
  Prevent requestLayout() when updating drawables that don't change size
  Fix splash icon size to 52dp
2024-08-22 09:13:41 +00:00
Jordan Silva 4fb37a8ffa Fix condition when should focus on running task
Bug: 353947137
Fix: 353947516
Fix: 353947467
Fix: 353947334
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Test: OverviewDesktopTaskImageTest
Change-Id: I6210335333163ba70c228215e01889c0d13ec896
2024-08-22 09:50:52 +01:00
Android Build Coastguard Worker 34dbce6028 Snap for 12260156 from cbd92ce7e4 to 24Q4-release
Change-Id: I1eaf67aa8b870c19b74b3f13af1e8063543e349c
2024-08-21 23:21:10 +00:00
Tony Wickham 79f3cefae2 Animate away Recent Apps section when going to home
Also fix calculation for divider position during this transition
when there are recent apps. Added tests as well.

Flag: com.android.launcher3.enable_recents_in_taskbar
Flag: com.android.window.flags.enable_desktop_windowing_taskbar_running_apps
Test: TaskbarViewControllerTest
Bug: 343522351

Change-Id: Ifffd620c1d4c156b37561584d6e3278b39804439
2024-08-21 22:48:06 +00:00
Sebastian Franco f989210f5b Remove test to postsubmit while they are flaky
Bug: 332527963
Test: ReorderAlgorithmUnitTest
Flag: TEST_ONLY
Change-Id: I29d631ba7dfe7f2c3a5323bfb414cb4da5b3321b
2024-08-21 15:20:18 -07:00
Tony Wickham 5c32af7e5b Fix Taskbar being visible over Hotseat when recreated in Overview
Debugging locally, it seems there were a couple of state changes
and the last one (which is correct) was getting clobbered by a
previously destroyed instance of TaskbarLauncherStateController.
Fixed this by updating the isDestroyed() call which previously
only checked TaskbarActivityContext to now check
TaskbarLauncherStateController's destroyed state directly. This
is needed because TaskbarLauncherStateController is part of
LauncherTaskbarUIController which can be destroyed independently
of the other Taskbar controllers when Launcher is destroyed.

Also fix a debug log that was not updated long ago in ag/21122190

Flag: EXEMPT bugfix
Test: Go to overview, change Font Scale or Dark Theme from Quick
settings, ensure Taskbar is not visible over Hotseat
Fixes: 302923055

Change-Id: I1299462955b51a2bf931f022177045b1cec039c5
2024-08-21 21:43:54 +00:00
Treehugger Robot 97b4046b39 Merge "Add animation for the predicted icon ring Animation is modeled after the notification dot animation." into main 2024-08-21 21:25:54 +00:00
Alex Chau 1ca8471ae5 Refresh runningTaskView's thumbnail after setting shouldShowScreenshot to true
- TaskThumbnailViewDeprecated won't redraw automatically unless refresh() is called

Fix: 346696742
Test: Invoke Omnient or Screenshot hardware button on live tile, verify running task switches to screenshot after overlay closes
Test: Select/Screenshot swithces to screenshot normally
Flag: EXEMPT BUG_FIX
Change-Id: I678fb155bd577afbacfde7233956ce6cfa5e569d
2024-08-21 21:39:48 +01:00
Jagrut Desai bb92ca0855 Merge "Do not register Taskbar System Action when device is in phone mode" into main 2024-08-21 20:31:26 +00:00
Luca Zuccarini c1f0506da0 2/3 Move some Shell utils to the Shared package.
Bug: 322791067
Flag: EXEMPT move only
Test: NA
Change-Id: I076d41404f23bd44fa6157a5dc39a60e467c79c3
2024-08-21 19:47:12 +00:00
Treehugger Robot cbd92ce7e4 Merge "Move DesktopTask to front of RecentsView (1/2)" into main 2024-08-21 18:38:34 +00:00
Sebastián Franco 1ac0438aac Merge "Adding debug logs for Test event emitter" into main 2024-08-21 18:01:46 +00:00
Jon Miranda 7d783ff70f Add animation for the predicted icon ring
Animation is modeled after the notification dot animation.

- This avoids the ring jumping in after swiping up to home to
  a predicted app.
- Also decreased the amount of time the icon has to fade out so
  that it shows up less during the animation.

Fixes: 360115794
Test: open predicted app from hotseat, swipe up to return home
Flag: EXEMPT bugfix
Change-Id: I59659610eb2e9f375a408d553bb4aa80947a28c4
2024-08-21 17:30:19 +00:00
Vinay Joglekar eff3722286 Merge "DesktopTaskView rendered incorrectly in RTL" into main 2024-08-21 17:06:40 +00:00
Jordan Silva b06ff83808 Move DesktopTask to front of RecentsView (1/2)
This CL updates the DesktopTasks in the RecentsView to be displayed after the focused task, separated from the other tasks in the grid. The DesktopTasks will be larger, following the same size used for focused tasks.
It was necessary to do the following changes to support DesktopTask at the front of the list.
1. Sort the GroupTasks in applyLoadPlan to move DesktopTasks after all other tasks.
2. Update the target page to take into account the DesktopTasks after the running task.
3. updateGridProperties had to support DesktopTask and Focused Task to be positioned at the front of the list. This function updates view translations to support the grid with two rows and rebalacing the position after a task is dimissed.
4. Update the max and min page scroll. Updated getFirstViewIndex to check for a DesktopTaskView, and if it doesn't exist, it uses the focused task as reference.
5. TaskView.updateTaskSize was updated to prevent DesktopTaskView being resized. This change makes DesktopTaskView to have the same size of our current focused task.
6. Update several places using focused task to use isLargeTile.

Bug: 353947137
Fix: 353947516
Fix: 353947467
Fix: 353947334
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Test: OverviewDesktopTaskImageTest

Change-Id: Ic7c0d8340ca259e8644de180aa6859a3c968d66e
2024-08-21 17:43:36 +01:00
Uwais Ashraf e0a0ebeece Prevent requestLayout() when updating drawables that don't change size
Fix: 354224963
Test: presubmits passing, manual
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I31d9a51ed621f411bcafbb5bf885ee2587df057f
2024-08-21 15:45:05 +00:00
Uwais Ashraf f1c14902ca Fix splash icon size to 52dp
Fix: 360804090
Test: presubmits passing, manual
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I1bc14be7d2d25a985d26709eb59b8aa4887d4764
2024-08-21 15:44:03 +00:00
vinayjoglekar 297f371b3d DesktopTaskView rendered incorrectly in RTL
Test: Manual
BUG: 357151780
Flag: com.android.window.flags.enable_desktop_windowing_mode
Change-Id: I1ea2bd7a6e6355a5a226c3516747c5b0205b9cbc
2024-08-21 12:46:42 +01:00
Alex Chau 9109b81a95 Reset mTopRowIdSet in applyLoadPlan
- All taskViewIds become obsolete after removing and re-adding, so we'll need to reset mTopRowIdSet when removing all taskViews
- OverviewActionsView.updateActionButtonsVisibility can be called before updateDimension (where mDp is set), so a null check is necessary
- Fixed TestStaibilityRule failing when running FallbackRecentsTest alone. FallbackRecentsTest runs with 3P Launcher, in that case launcherPackageName is our test activity, and launcherVersion can be null. This can only occur in a local run, thus return LOCAL in this case.

Fix: 355042336
Test: FallbackRecentsTest and manually testing dismiss
Flag: EXEMPT BUG_FIX
Change-Id: I9125ea38a567deb0d3028e7d7407397d1dc06ade
2024-08-21 12:37:14 +01:00
Alex Chau 1eebacf636 Merge "Clean-up debug logs" into main 2024-08-21 10:53:21 +00:00
Uwais Ashraf 06ffcf8c61 Merge "Migrate model tests to multivalent" into main 2024-08-21 10:05:40 +00:00
Liran Binyamin b93e454737 Update both width and height in BubbleBarView
We currently only update the width of the bubble bar but the
height is only updated when the icon size changes, so it's often
inaccurate. This affects screenshot testing where the bubble bar
isn't fully visible in the screenshot.

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 355454021
Test: manual
       - used the bar normally to make sure it's not broken
Change-Id: If780308e10e7478a3651654e5fc2b3f9c4e36c14
2024-08-21 05:18:20 -04:00