Commit Graph

4763 Commits

Author SHA1 Message Date
Hui Kang 4b87b9e521 Fix AddWidgetTest flake
Test: ABTD

200 all PASS: https://android-build.googleplex.com/builds/tests/view?invocationId=I20300010100881398

Without this CL, 1/100 FAIL: https://android-build.googleplex.com/builds/abtd/run/L73700000956982533

Change-Id: Ia9d7746144e9838798332f4eea223a9529551713
2022-10-24 18:09:15 +00:00
Sunny Goyal f34811d3a3 Revert "Revert "Updating the scroll calculation from recyclerView to avoid view inflation""
Test: ABTD
https://android-build.googleplex.com/builds/abtd/run/L52600000956969786

This reverts commit cee6ddf3de.

Reason for revert: Fixed in ag/20239136

Change-Id: I0e8446e66d9a86a94b40fcbd6de14da07abe8e5c
2022-10-22 15:37:47 +00:00
Ling Wo 7c35298a40 Merge "Add enable-suggestion option via TestProcotol so that test can opt-in to show live suggestion" into tm-qpr-dev am: ac29981a42 am: 12949e8abb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20158848

Change-Id: I3f79292d7c813808a61ca82ea31121daa5ee3eba
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-21 22:44:45 +00:00
Ling Wo ac29981a42 Merge "Add enable-suggestion option via TestProcotol so that test can opt-in to show live suggestion" into tm-qpr-dev 2022-10-21 21:44:35 +00:00
Schneider Victor-tulias ee0bc03d58 Decrease TAPL All Apps scrolling flakiness
scrolling in all apps did not factor in additional top padding in the all apps list recycler. This made it so that apps could occasionally scroll and be obcured by that top padding, making them un-tappable. Added this padding to the scrolling logic to make scrolling less flaky.

Test: TaplTestsTaskbar, TaplTestsLauncher3 and presubmit
Fixes: 248064856
Change-Id: Id76b92b4bc354917f3688ac53673d0ed7a905f02
2022-10-21 12:12:38 -07:00
Sukesh Ram c6d4df87f0 Added Tests for Secondary Display Launcher
These UIAutomator tests for secondary display launcher cover app drawer, drag-n-drop functionality, app predictions, pin/unpinning icons, and correct back press behavior.

We are deviating from  go/modify-tapl due to the time constraints of this project as outlined here (https://docs.google.com/document/d/1wLb2h8qCPGur-VsufCH4mLnnuLDLcmMq0FrCo7ichu8/edit#heading=h.brf6af3bno4g).

A preliminary design document has also been created to reference for future TAPL integration (https://docs.google.com/document/d/1H642SSu5DCM_zSXTsvTWumgm3OHIxsKEXvTlTeC4y54/edit?resourcekey=0-M9sTxdyQBi8bUy5cpjmJNA#heading=h.90f2s4sc5ic9).

Before TAPL integration, we need to follow up on test rewrite to eliminate antipatterns in the following bug: b/242776943.

Bug: 241166788
Test: Run Locally, on presubmit, and on a test on a cuttlefish emulator
Change-Id: I556a47b93a7ea3b2583dbc1efd2de7623d820e2a
Merged-In: I556a47b93a7ea3b2583dbc1efd2de7623d820e2a
2022-10-20 22:58:46 +00:00
TreeHugger Robot 7c9144328a Merge "Making Launcher TAPL check orientation only when the expected orientation is set by the test" into tm-qpr-dev 2022-10-17 22:58:51 +00:00
Hui Kang 70765883c5 Merge "Revert "Updating the scroll calculation from recyclerView to avoid view inflation"" into tm-qpr-dev am: 2a28ae8a3f am: da45ddb921
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20213328

Change-Id: Ib0198ed6d4c19b1889bde9144ed33b30a0dedae7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-17 22:24:43 +00:00
TreeHugger Robot be8c42e5a1 Merge "Making Launcher TAPL check orientation only when the expected orientation is set by the test" 2022-10-17 21:58:11 +00:00
Hui Kang 2a28ae8a3f Merge "Revert "Updating the scroll calculation from recyclerView to avoid view inflation"" into tm-qpr-dev 2022-10-17 21:20:09 +00:00
Hui Kang cee6ddf3de Revert "Updating the scroll calculation from recyclerView to avoid view inflation"
This reverts commit 20bbe95ddb.

Reason for revert: Causing flake in Ironwood test: b/248295569

Test: ABTD
Before: Flaky, 14/50 PASSED
https://android-build.googleplex.com/builds/abtd/run/L33900000956890639

Revert: 50/50 PASSED
https://android-build.googleplex.com/builds/abtd/run/L49200000956887317

Change-Id: I41f4428c74e581323f90c716a7852b5e553ae27d
2022-10-17 20:37:49 +00:00
vadimt 9853497f6c Making Launcher TAPL check orientation only when the expected orientation is set by the test
This makes life simpler for tests that don't care about orientation

Bug: 245576832
Test: presubmit
Change-Id: I3c247826c6cac0e20c93a2fad9b81775fd2ebaa8
Merged-In: I3c247826c6cac0e20c93a2fad9b81775fd2ebaa8
2022-10-17 19:48:46 +00:00
vadimt b18ac9a01a Making Launcher TAPL check orientation only when the expected orientation is set by the test
This makes life simpler for tests that don't care about orientation

Bug: 245576832
Test: presubmit
Change-Id: I3c247826c6cac0e20c93a2fad9b81775fd2ebaa8
2022-10-17 19:45:53 +00:00
TreeHugger Robot 17ccbb9058 Merge "Revert "Enable taskbar in overview by default"" into tm-qpr-dev am: 126d178358 am: 5b9e0cf902
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20207527

Change-Id: Id785ae174b5c77844457da44bf949280e689fcc9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-17 18:40:13 +00:00
TreeHugger Robot 126d178358 Merge "Revert "Enable taskbar in overview by default"" into tm-qpr-dev 2022-10-17 17:40:17 +00:00
Alex Chau 6f0b0fe742 Revert "Enable taskbar in overview by default"
This reverts commit 517131ae1c.

Reason for revert: Reverting until b/251747761 is addressed
Bug: 245320601

Change-Id: Ic5ebc071f092c8f91ff879a59d89c3be4326c90e
2022-10-17 14:38:09 +00:00
Pat Manning 1a2e1ea4fc Merge "Add screenshot test for edit state drop targets." into tm-qpr-dev am: 956631ec3a am: 423ad32120
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19852201

Change-Id: Ic7287a3a8e99e3b82c0fd28e3e4d0c14044c299f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-14 14:09:26 +00:00
Pat Manning 956631ec3a Merge "Add screenshot test for edit state drop targets." into tm-qpr-dev 2022-10-14 12:49:09 +00:00
Ling Wo 5c239ba4f7 Add enable-suggestion option via TestProcotol so that test can opt-in to show live suggestion
Bug: 242246407
Test: atest
Change-Id: Icde0185c82b1d34570d83bd8b9750acb57a8e39c
2022-10-13 01:46:45 +00:00
TreeHugger Robot 92d7ca5fe9 Merge "Enable taskbar in overview by default" into tm-qpr-dev am: 2613431914 am: afda58246e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20111701

Change-Id: I82afb64f29c925a4e39c5ab1bb2b0304733bfd43
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-12 13:22:02 +00:00
Alex Chau 517131ae1c Enable taskbar in overview by default
- Also changed expectation in test that taskbar is visible in overview

Fix: 245320601
Test: presubmit
Change-Id: If1ed44f542e5907860f7ab8182e4b45172346f3f
2022-10-11 18:48:45 +01:00
Sebastián Franco 28f5901264 Merge "Fix ReorderWidgets by removing faulty 4x4 cases" into tm-qpr-dev am: 9eeeeacf30 am: 35c4d65dc2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20003360

Change-Id: Iee094d591a60938cd2ba54ac7e66e45b23fdbf92
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-07 21:38:44 +00:00
Sebastián Franco 9eeeeacf30 Merge "Fix ReorderWidgets by removing faulty 4x4 cases" into tm-qpr-dev 2022-10-07 20:33:41 +00:00
Ming-Shin Lu cb4f9b8dc5 Merge "TAPL: add setIgnoreTaskbarVisibility in LauncherInstrumentation" into tm-qpr-dev am: 8ff85dc733 am: 6013ab3776
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20064292

Change-Id: I6aaeb6efe4af83a5c8621cceb3154be4d53be58c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-05 07:47:04 +00:00
Ming-Shin Lu 4d4f62ac77 TAPL: add setIgnoreTaskbarVisibility in LauncherInstrumentation
As now FlickerTests is leveraging TAPL to interact devices CUJs,
we realized in LauncherInstrumentation will verify task bar visibility
automatically to expect it always visible when quick-switch, which is
not always reliable since the task bar may be hidden by manual or
when the activity requests to show IME.

Add setIgnoreTaskbarVisibility in LauncherInstrumentation for the caller
to ignore taskbar visibility if the test does not need to verify it.

Bug: 228012334
Bug: 240306344
Test: atest FlickerTests:SwitchImeWindowsFromGestureNavTest
      in tablet device
Test: atest NexusLauncherOutOfProcTests:com.android.quickstep.\
       TaplTestsQuickstep#testQuickSwitchToPreviousAppForTablet

Change-Id: Id0a35561523d733b8434acb702ec7dcaa466a1c2
2022-10-05 11:37:37 +08:00
Michael Groover 5e0eecc064 Add unaudited exported flag to exposed runtime receivers
Android T allows apps to declare a runtime receiver as not exported
by invoking registerReceiver with a new RECEIVER_NOT_EXPORTED flag;
receivers registered with this flag will only receive broadcasts from
the platform and the app itself. However to ensure developers can
properly protect their receivers, all apps targeting U or later
registering a receiver for non-system broadcasts must specify either
the exported or not exported flag when invoking #registerReceiver;
if one of these flags is not provided, the platform will throw a
SecurityException. This commit updates all the exposed receivers
with a new RECEIVER_EXPORTED_UNAUDITED flag to maintain the existing
behavior of exporting the receiver while also flagging the receiver
for audit before the U release.

Bug: 234659204
Test: Build
Change-Id: I6660cfb00244470edfb2411dadfca81afed42343
2022-10-04 17:15:36 -05:00
Pat Manning a34a9a0a18 Add screenshot test for edit state drop targets.
see: go/tapl-run-on-hold-event

Bug: 241386128
Test: HomeScreenImageTest.java
Change-Id: I5d6421c8da7d06a9eb77da249957c64d413524f1
2022-09-29 11:12:31 +01:00
Sebastian Franco a44d255c8f Fix ReorderWidgets by removing faulty 4x4 cases
Fix: 242323136
Test: atest ReorderWidgets (the device has to be cf_x86_64_phone-userdebug)
Change-Id: Ic545409ecc20420be6c7377513c704822dbaf75e
2022-09-27 09:37:54 -05:00
Vadim Tryshev 8cfd3f699d Merge "Verifying a theory that sometimes a leak disappears while saving an object dump" into tm-qpr-dev am: af91a58659 am: c7f9e903bd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20009128

Change-Id: Icc1ff73190b117b1f1560daca9c8e2f9e147827f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-23 06:27:23 +00:00
Vadim Tryshev af91a58659 Merge "Verifying a theory that sometimes a leak disappears while saving an object dump" into tm-qpr-dev 2022-09-22 16:25:06 +00:00
TreeHugger Robot 2d180a5439 Merge "Fix LauncherInstrumentation for OOP tests from gradle" into tm-qpr-dev am: 4298b36ef4 am: 84959297d7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19865266

Change-Id: I70a93b0455820766f8c97b853e80b5db1c8d7b35
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-22 00:27:30 +00:00
vadimt 592b3f9885 Verifying a theory that sometimes a leak disappears while saving an object dump
Bug: 241585675
Test: presubmit
Change-Id: If9c559619507002ed7ec4b1a8b96a5f62e2dbe41
2022-09-21 10:56:04 -07:00
TreeHugger Robot 4298b36ef4 Merge "Fix LauncherInstrumentation for OOP tests from gradle" into tm-qpr-dev 2022-09-21 03:50:08 +00:00
TreeHugger Robot 9ec505fb2c Merge "Adding a comment for goHome()" into tm-qpr-dev am: 0dec527aae am: 67d76fa9b6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19994601

Change-Id: I8c13a6eff4822b6fb0d4b41d72baf8812fb17e0a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-20 09:44:06 +00:00
vadimt f132bd7d3f Adding a comment for goHome()
Bug: 187761685
Test: presubmit
Change-Id: I2917daa90f22cc0da0169c287b02cc4cf37a8f4b
2022-09-19 19:08:43 -07:00
TreeHugger Robot 8eed4f30a9 Merge "Explicit Nullbility in Launcher (Part 5)" into tm-qpr-dev am: 69c04c21c5 am: ab6be24eec
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19976255

Change-Id: Ie607c03fb5aa6ca01648ebfeeba10cecf2d3bf80
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-19 18:30:23 +00:00
TreeHugger Robot 69c04c21c5 Merge "Explicit Nullbility in Launcher (Part 5)" into tm-qpr-dev 2022-09-19 17:12:40 +00:00
Nicolo' Mazzucato d2521bf843 Fix LauncherInstrumentation for OOP tests from gradle
The previous logic was assuming that if the test and target package were different, the target one was the launcher.

However, in the sysui-studio case, the packages are different despite none of the packages being launcher.

This detects if the test process is a gradle instrumentation, and if so selects the default launcher package name.

Test: locally with sysui-studio + presubmits
Bug: 234414088
Change-Id: Ie625e7d526f254f4b5f66b3a2b989d02eb95ac9c
2022-09-19 14:35:53 +00:00
Alex Chau cdf753f7c6 Merge "Trying to fix flaky TAPL test on CF" into tm-qpr-dev am: 7c8ee4f8de am: 4773a10dc2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19886864

Change-Id: Icba9ad1d97653b379642bf1611b59cc65bd614eb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-17 05:04:11 +00:00
Alex Chau 7c8ee4f8de Merge "Trying to fix flaky TAPL test on CF" into tm-qpr-dev 2022-09-17 03:30:32 +00:00
TreeHugger Robot ca5a1a6c60 Merge "Updating the scroll calculation from recyclerView to avoid view inflation" into tm-qpr-dev am: 860657a5f2 am: cd4951f54b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19469421

Change-Id: I5f9c405e1bff93b3e96b051bcb9b6ad0a87eecb5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-17 01:14:58 +00:00
Pinyao Ting 777c13eb00 Explicit Nullbility in Launcher (Part 5)
This CL addresses the nullbility in LauncherModel and update tasks.

Bug: 242895652
Test: manual
Change-Id: Ied635c944c3656f0d493b295f772aa0329b354b9
2022-09-16 17:17:16 -07:00
TreeHugger Robot 860657a5f2 Merge "Updating the scroll calculation from recyclerView to avoid view inflation" into tm-qpr-dev 2022-09-16 23:07:54 +00:00
Yein Jo 40a0690301 Merge "Migrate Launcher to use the new OnBackInvokedCallback" into tm-qpr-dev am: dfaabbb499 am: f8804d8ccd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19934356

Change-Id: I5843a470ee7194f84899ad8fa3426c9c4af6d178
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 22:13:10 +00:00
Yein Jo dfaabbb499 Merge "Migrate Launcher to use the new OnBackInvokedCallback" into tm-qpr-dev 2022-09-16 21:44:49 +00:00
Sebastián Franco f1aa20d811 Merge "Revert "Prevent dragging widgets to another page in tests when starting a drag."" into tm-qpr-dev am: 09a98dfdbd am: 47c78bed9b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19969101

Change-Id: I01ad05d37ca822f501e6f2520249734c7e9de167
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 17:52:11 +00:00
Sebastián Franco 09a98dfdbd Merge "Revert "Prevent dragging widgets to another page in tests when starting a drag."" into tm-qpr-dev 2022-09-16 16:49:26 +00:00
Andras Kloczl 0a37f2b90e Trying to fix flaky TAPL test on CF
For some reason the drag gesture gets canceled during drag,
and it might be because the pointer goes out of bounds.

Test: run TwoPanelWorkspaceTest on CF
Bug: 241587421
Change-Id: I9a57548d5b03c3a3d7bd0da6e7e7f79688f5ac90
2022-09-16 07:55:13 +00:00
Sebastián Franco a798be2ff5 Revert "Prevent dragging widgets to another page in tests when starting a drag."
This reverts commit 749b2b8493.

Reason for revert: Causing tests to fail b/246972374

Change-Id: I9fc1f6d2e924f4ac5484c6674fd0adf49d04536f
2022-09-15 21:19:12 +00:00
Sebastián Franco b35ae4fc42 Merge "Prevent dragging widgets to another page in tests when starting a drag." into tm-qpr-dev am: 610db4fc94 am: 0eaacbc644
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19945446

Change-Id: Id8e822bf084248c7618cd23837ccb1f558eedc64
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-15 18:22:33 +00:00