Commit Graph

4763 Commits

Author SHA1 Message Date
Sunny Goyal 5daac6fbfb Merge "Removing some unnecessary interfaces and merging them to ActivityContext" into tm-qpr-dev am: d31c8baef1 am: deffe8f8df
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20676568

Change-Id: I97e64fbb701249aef7268421943f0e174a59c3bf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-09 16:14:28 +00:00
Sunny Goyal d31c8baef1 Merge "Removing some unnecessary interfaces and merging them to ActivityContext" into tm-qpr-dev 2022-12-09 15:35:59 +00:00
Fengjiang Li a6a67e347d Support mouse right click on HomeScreen to show the customization menu
Bug: b/250089861
Fix: b/250089861
Test: Manual Testing
Video: https://b.corp.google.com/action/issues/250089861/attachments/40243664?download=true
Change-Id: Ia23e302bf8f3e18fafd6ccd079740c8005ae7860
2022-12-09 02:44:09 +00:00
Sunny Goyal 54fa110bba Removing some unnecessary interfaces and merging them to ActivityContext
Bug: 259733681
Test: Everything compiles
Change-Id: If6b530f6e589a851cf8554f5de0849843bd66dd4
2022-12-08 10:15:55 -08:00
Brandon Dayauon 65de436e38 Merge "Change method name as suggested" into tm-qpr-dev am: f772ba18ab am: b4b23d848a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20646119

Change-Id: I98a81336fce29190f787f204716a4f1cba644876
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-08 01:01:31 +00:00
Brandon Dayauon f772ba18ab Merge "Change method name as suggested" into tm-qpr-dev 2022-12-08 00:18:26 +00:00
Brandon Dayauon bb3146271b Change method name as suggested
bug: 261098912
bug: 261099706

test: Manual - presubmit go/forest
Change-Id: I2e18ddaf2b9647bccaecccbfa7faf88e51b84f12
2022-12-08 00:15:06 +00:00
Sebastián Franco bdee8e4313 Merge "Ignore all launcher3 flaky test so that they come back online" into tm-qpr-dev am: 878ae3fc85 am: 64d68ce0c7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20647519

Change-Id: I255b21e3e06e93c90f7b718d265d166abc4b4e72
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-07 20:50:40 +00:00
Sebastián Franco 878ae3fc85 Merge "Ignore all launcher3 flaky test so that they come back online" into tm-qpr-dev 2022-12-07 20:13:13 +00:00
TreeHugger Robot 9b610cadbf Merge "Revert "Revert "Enable taskbar in overview by default""" into tm-qpr-dev am: 5e0d7ae019 am: 0a456b59ef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20640160

Change-Id: I81aefb87ac4dddc632884a8748fab9d0d58d9fda
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-07 18:57:44 +00:00
TreeHugger Robot 5e0d7ae019 Merge "Revert "Revert "Enable taskbar in overview by default""" into tm-qpr-dev 2022-12-07 17:14:15 +00:00
Alex Chau 766cd2b4b9 Remove unnecessary GridDisplayOption_defaultSplitDisplayLayoutId attribute
- Can use deviceCategory to make grid specific to splitDisplay instead
- Update TwoPanelWorkspaceTest for new workspace items

Fix: 233736588
Test: Clear launcher and check the default
Test: TwoPanelWorkspaceTest
Change-Id: I6ad3a2d866d847af281e10b802edbd4bcc892c39
2022-12-07 15:18:28 +00:00
Sebastian Franco 150e572e05 Ignore all launcher3 flaky test so that they come back online
Test dashboard: https://android-build.googleplex.com/builds/tests/search?filter=mediumFailureRate&filter=highFailureRate&query=config%3Av2%2Fgnl-eng%2Funbundled%2Flauncher%2Flauncher3_test_platform+latest%3A4d&tab=tests

Test: dashboard should not show flaky tests
Bug: 256832045
Change-Id: I06e879dec2703455b7be728c7afd3500d2edd54a
2022-12-06 17:08:45 -08:00
Sebastián Franco 8a1b517ad5 Merge "Creating a new alarm when drag X,Y change" into tm-qpr-dev am: 9adbab96b7 am: a3ac407d85
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20646376

Change-Id: I47537d6d811b1b3e4d723e2c7cc7efb387361e14
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-06 20:31:24 +00:00
Alex Chau 5dec2aceb1 Revert "Revert "Enable taskbar in overview by default""
This reverts commit 6f0b0fe742.

Bug: 245320601
Reason for revert: Re-land "Enable taskbar in overview by default"

Change-Id: Ie722a608d6bd7168744ffc81c156e4307d4c1d2d
2022-12-06 19:45:29 +00:00
Sebastian Franco 5356ff955c Creating a new alarm when drag X,Y change
If the user is changing the X and Y of the reorder, wich requires
the user to move at least one Workspace cell from the previous
position, then it doesn't make sense to wait for the previous alarm to finish
to start a new reorder.

Also, I added a new test to run on foldable devices.

Fix: 259995663
Fix: 259295374
Test: atest ReorderWidgets (it mostly fails on postsubmit)
Test: modify ReorderWidgets.fullReorder to run 20 times and it should work, before the chagne it would fail.
Change-Id: Ic6b436ea1088f8092c849e9791862947e9035c9f
2022-12-05 16:37:45 -08:00
TreeHugger Robot 1d4c44ce07 Merge "Make grid size migration less confusing for users." into tm-qpr-dev am: 33c348f573 am: a44e9370f0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20388826

Change-Id: I5df1ed1b272876e6ce64b19cd42410b840c10688
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-05 19:22:22 +00:00
TreeHugger Robot 33c348f573 Merge "Make grid size migration less confusing for users." into tm-qpr-dev 2022-12-05 18:19:59 +00:00
Pinyao Ting cc90d1b767 Make grid size migration less confusing for users.
Grid size migration is a confusing experience for users because the
content of the grid is not predicatable to the user. Part of the reason
was the dedupe logic which merges items from new grid into old grid,
this mean if user removes an item, change to another grid and go back,
user will see that same item re-appears.

This CL keeps the content of target grid the same as source gird, i.e
user will will get the exact same set of app icons/shortcuts/folders and
widgets (if size permits) across grid sizes. The only difference being
their placement in the grid.

Bug: 256859723
Test: atest GridSizeMigrationUtilTest
Change-Id: I1732c91e441ad44bc43e0a943566a83563d12b07
2022-12-02 13:33:04 -08:00
Sebastián Franco 36e03bdf47 Merge "Ignore test while the solution for the flaky tests improve." into tm-qpr-dev am: f9d418b9f2 am: fb725e8223
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20621715

Change-Id: I5996eb29348d4992a3eacb4eb06fb0b700403304
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-02 20:45:40 +00:00
Sebastián Franco f9d418b9f2 Merge "Ignore test while the solution for the flaky tests improve." into tm-qpr-dev 2022-12-02 19:34:11 +00:00
Sebastian Franco ac53846195 Ignore test while the solution for the flaky tests improve.
Bug: 261178121
Test: atest ReorderWidgets
Change-Id: Id0c6594e00486695c63e2cda53b1a5ee39478a1f
2022-12-02 11:33:00 -08:00
TreeHugger Robot 69c1eb4a28 Merge "Adding screenrecord to debug themeIconTest" into tm-qpr-dev am: ed882317da am: 897a8d8e71
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20590312

Change-Id: I8ea6ff7c9a30d96a46757adcf56774e41150ff5c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-30 08:54:06 +00:00
TreeHugger Robot ed882317da Merge "Adding screenrecord to debug themeIconTest" into tm-qpr-dev 2022-11-30 08:17:13 +00:00
Brandon Dayauon c531a94992 Merge "Searching for Golden Gate Bridge should show three queries and check if predicted app row and web suggest exists" into tm-qpr-dev am: 8267b7625f am: d203100fec
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20544528

Change-Id: I000e1623d0871c781ab694d194664734678b5e80
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-30 03:21:44 +00:00
Brandon Dayauon 8267b7625f Merge "Searching for Golden Gate Bridge should show three queries and check if predicted app row and web suggest exists" into tm-qpr-dev 2022-11-30 02:30:18 +00:00
Brandon Dayauon 7b53004999 Searching for Golden Gate Bridge should show three queries and check if predicted app row and web suggest exists
Add a method that checks if three web suggests exist and another method to check for
predicted app row and web suggest exists.

bug: 225583735
test: Manual - photo: https://screenshot.googleplex.com/3NoSUm7nzTvf3gX
Change-Id: I7f9340229aaf4a0a3928933035f193a576995525
2022-11-29 13:35:56 -08:00
Sunny Goyal d25f79c48f Adding screenrecord to debug themeIconTest
Bug: 260722220
Test: Updated
Change-Id: I20e590436e318f9a8914a8201d95584ab26de388
2022-11-29 09:31:13 -08:00
TreeHugger Robot 8e6fcd867f Merge "Fixing shortcuts not getting theme icons" into tm-qpr-dev am: 1330244f0a am: d813bddf99
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20546011

Change-Id: I72835e139741384fe31bad16920c46dcabe9ee99
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-29 01:44:06 +00:00
Sunny Goyal ce4896cff5 Fixing shortcuts not getting theme icons
Bug: 238650110
Test: Updated ThemeIconsTest
Change-Id: I803cd6eefa4e393bf19901a44712622adac7f4b1
2022-11-28 09:48:50 -08:00
Pinyao Ting 55621f4001 Merge "Refactor GridSizeMigrationTaskV2" into tm-qpr-dev am: ad932045ac am: ff521c99ad
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20535959

Change-Id: Ic7a3f0ac4db6facf7ce17208133bf6b85dc25644
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-22 17:52:26 +00:00
Pinyao Ting ad932045ac Merge "Refactor GridSizeMigrationTaskV2" into tm-qpr-dev 2022-11-22 17:22:39 +00:00
Pinyao Ting dec4305d0c Refactor GridSizeMigrationTaskV2
The majority of the logic in grid size migration should be implemented
as static functions in the first place since (1) they only runs once
after instantiation and (2) they are executed immediately after they are
instantiated.

This CL removes most of the instance variables from grid size migration
in favor of static methods since the later is more efficient, more
testable and therefore considered better programming practice in
general.

Bug: 256859723
Test: atest GridSizeMigrationUtilTest
Change-Id: Ief4654d79ad5cfd636e6145fdcc9dfe5a39cdf62
2022-11-21 15:24:38 -08:00
TreeHugger Robot 7b022b93f8 Merge "Increase icon size to be closer to spec" into tm-qpr-dev am: 81a994e9a7 am: 1414f12c14
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20500530

Change-Id: Ic92db57de677e39bb299f7d175b9ed191992d7d1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-21 19:26:39 +00:00
TreeHugger Robot 81a994e9a7 Merge "Increase icon size to be closer to spec" into tm-qpr-dev 2022-11-21 18:35:31 +00:00
Thales Lima ae0d7ef782 Increase icon size to be closer to spec
Also change paddings because spaces changed

Bug: 258463609
Test: DeviceProfileDumpTest
Change-Id: Iaee433ea3fb5ef633ad428699ce230317021b170
2022-11-18 12:38:14 +00:00
TreeHugger Robot a306c7a226 Merge "Add feature flag to control whether to inject fallback app results when AiAi fails to return app corpus results." into tm-qpr-dev am: c5b5044aff am: 4f366af03e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20240749

Change-Id: I6ca3d72be87eadb858ec185b0bf413316bcfb9bb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-18 02:02:32 +00:00
TreeHugger Robot c5b5044aff Merge "Add feature flag to control whether to inject fallback app results when AiAi fails to return app corpus results." into tm-qpr-dev 2022-11-18 01:09:23 +00:00
Sihua Ma 460b85f101 Merge changes If022ec8d,I34341937 into tm-qpr-dev am: c6bd4ad21f am: 1d678ad179
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20418246

Change-Id: Ib5183feebded858d4ebce4693d47d62151bb2899
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-17 02:13:21 +00:00
Sihua Ma c6bd4ad21f Merge changes If022ec8d,I34341937 into tm-qpr-dev
* changes:
  Move LauncherWidgetHolder to widget package
  Move most of the functions in LauncherAppWidgetHost to LauncherWidgetHolder
2022-11-17 01:46:55 +00:00
Sihua Ma 8bbfcb6581 Move LauncherWidgetHolder to widget package
Making LauncherAppWidgetHost package-private as well

Bug: 235358918
Test: N/A
Change-Id: If022ec8d429579a972991872b2dc11db76719341
2022-11-16 14:31:14 -08:00
Sihua Ma aa2b872d1c Move most of the functions in LauncherAppWidgetHost to LauncherWidgetHolder
Test: N/A
Bug: 235358918
Change-Id: I343419376491203a195154f2766b12e5def38879
2022-11-16 14:30:08 -08:00
Holly Sun 0d69c8dde9 Add feature flag to control whether to inject fallback app results when AiAi fails to return app corpus results.
Also add simple prefix matching method.

Bug: 255355348
Test: manual
Change-Id: I35f2089924d774f3bcc1c05638a5d6b45ed7443f
2022-11-15 16:55:29 -08:00
TreeHugger Robot fd49872770 Merge "Revert "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar.""" into tm-qpr-dev am: 87ccecb6fc am: 8c49ddde2f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20425196

Change-Id: I826fbc5897fff22e932a4d790e76a7adee21298e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-15 23:40:37 +00:00
TreeHugger Robot 8a03be1880 Merge "Added Tests for Secondary Display Launcher" into tm-qpr-dev 2022-11-15 22:41:51 +00:00
Jon Miranda f0349354ec Revert "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar.""
This reverts commit e7011d2b87.

Reason for revert: attempt to fix test issues

- Instead of using SharedPrefs which can be flaky anyways,
  we pass along a boolean to test transient taskbar when
  we are in the test harness

Bug: 257549303
Test: TaplTestsTaskbar
Change-Id: I7c15a97363adc377f29853c1fe60b1960c77bfc3
2022-11-10 11:11:14 -08:00
TreeHugger Robot 195e9ef499 Merge "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar."" into tm-qpr-dev am: 8dd01f3ac2 am: b5c134d72c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20416308

Change-Id: Ie5d094942e3e476a8be47de609a47cf52049e621
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-09 02:19:58 +00:00
TreeHugger Robot 8dd01f3ac2 Merge "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar."" into tm-qpr-dev 2022-11-09 01:07:11 +00:00
Jon Miranda e7011d2b87 Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar."
This reverts commit d5a6b5f688.

Reason for revert: Breaks tests due to "SharedPreferences in credential encrypted storage are not available until after user is unlocked"

Bug: 258256906
Change-Id: I1de69249685f9d2e71183357cf3eda8d443c7d97
2022-11-08 21:56:52 +00:00
TreeHugger Robot 4c88969413 Merge "Unstash taskbar when transitioning to fallback overview." into tm-qpr-dev am: 98f400397b am: 269c56df92
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20187724

Change-Id: I79602295bb72072c804bffd6e3d6f753babc43c5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-08 18:59:18 +00:00