Commit Graph

20057 Commits

Author SHA1 Message Date
Sebastián Franco aaee1ef060 Merge "If the app is archived, do not remove in case of playstore install error" into main 2024-06-14 00:50:39 +00:00
Randy Pfohl 69092b41f6 Merge changes from topic "windowPrototype" into main
* changes:
  Fixing tests related to abstraction
  Abstracting StatefulActivity from StateManager
2024-06-13 22:11:49 +00:00
Andrew Cole f77600260c Merge "Send additional Extras in first screen broadcasts, to help with app archiving." into main 2024-06-13 21:30:26 +00:00
Charlie Anderson 7cc4302f10 Send additional Extras in first screen broadcasts, to help with app archiving.
- refactor FirstScreenBroadcast.java into FirstScreenBroadcastHelper.kt
	- send Extras to include installed/archived items on first screen
	- send Extras to include installed/archived widgets on all screens.
	- truncate items to limit Broadcast size

Bug: 322314760
Test: unit testing and E2E test of B&R
Flag: launcher_broadcast_installed_apps

Change-Id: I214149ac0c63f177d3d1ca0b6d0cb11be37f4ae0
2024-06-13 21:29:50 +00:00
randypfohl 176ce85d27 Abstracting StatefulActivity from StateManager
Flag: NONE - abstraction with no logic changes.

Test: Built and ran locally, for launcher3 and third party launchers

Bug: 224595066

Change-Id: I9da15bdd649d3a20e98c6552bb9e9abaec72f97f
2024-06-13 10:26:12 -07:00
Sebastian Franco 6d200f63ac If the app is archived, do not remove in case of playstore install error
Fix: 339852615
Test: Manual
Flag: com.android.launcher3.enable_support_for_archiving
Change-Id: I675586d20d09f9e025dfe6a74cf7b79ddcb40cc2
2024-06-12 19:47:17 -06:00
Brian Isganitis e54c1462a3 Test TaskbarAllAppsController non-search behavior.
Flag: TEST_ONLY
Bug: 230027385, 346394798
Test: TaskbarAllAppsControllerTest
Change-Id: Id97e1b82cb8fba48687b5e23222e3bba6695ac4c
2024-06-12 23:59:51 +00:00
Treehugger Robot 8a281ff7a6 Merge "Convert ENABLE_FLOATING_SEARCH_BAR to aconfig." into main 2024-06-12 23:50:20 +00:00
Himanshu Gupta cf3a0ef2f0 Merge "Prompting the user to set Pixel/Quickstep as default Home app." into main 2024-06-12 21:13:19 +00:00
Mykola Podolian 590e662d70 Merge "Add outline to the bubble bar background view." into main 2024-06-12 16:46:55 +00:00
Andy Wickham cfafb55331 Convert ENABLE_FLOATING_SEARCH_BAR to aconfig.
Flag: com.android.launcher3.floating_search_bar
Test: Build (existing code unchanged)
Bug: 346408388
Fix: 346406981
Change-Id: Ia8d15ceb1b2b4754657844d602cb95b9555a4ece
2024-06-12 01:24:36 +00:00
Himanshu Gupta 261a62219b Prompting the user to set Pixel/Quickstep as default Home app.
requestQuietMode API throws SecurityException in case its called
from a non-default Launcher app.
To mitigate this, we catch the exception and prompt the user
to set their default launcher to the current app.

Video(Pixel): https://photos.app.goo.gl/ni5X1c6vBbYW2JMJ9
Video(Pixel-aosp): https://photos.app.goo.gl/cYLJpTYW76Jnbonc9

Bug: 320446272
Test: Manual
Flag: NONE Bug fix tweak.
Change-Id: I6afb2ae85cabc038e1503e9c34eebd974c4f7a50
2024-06-11 19:11:21 +01:00
mpodolian 84f9cfabb9 Add outline to the bubble bar background view.
Added outline to the bubble bar background. Updated pointer
appearing/disappearing animation - now pointer moves into the bubble
bar background.
Demo: http://recall/-/gx8ASgewUeUS3QYohfrd1J/e1wZMrFZTILq73ik8wwrwx

Fixes: 345489039
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: Manual. Expand and collapse bubble bar with the light and the
dark theme.

Change-Id: I095fdc12337955aa21ee0eb622a924ad424ef186
2024-06-11 19:03:24 +01:00
Pragya Bajoria d8522b7828 Update the flag check for back gesture to include tablet filtering to reduce the scope of desktop windowing logic.
Change-Id: I15edeceebfdc14569c1b98caf62c741b40049200
Bug: 346249587
Flag: EXEMPT (windowing is currently only limited to Tablet)
2024-06-10 19:29:30 +00:00
Liam Lee Pong Lam df709d9aef Merge "[Launcher3] Hide keyboard when fastscroller scrolling down and keyboard shown" into main 2024-06-10 17:40:24 +00:00
Federico Baron 4ebc6777cb Merge "Fix folder animation clipping and RTL issue" into main 2024-06-08 00:22:45 +00:00
Shamali Patwa 7902265f77 Merge "Fix the flaky screenshot test" into main 2024-06-07 23:14:15 +00:00
Brandon Dayauon 14fb9f27f4 Merge "Make private profile header scrollable" into main 2024-06-07 22:16:42 +00:00
fbaron 31d5b01ecf Fix folder animation clipping and RTL issue
Fix: 341433475
Test: NONE
Flag: EXEMPT bugfix
Change-Id: I05c1ca65efea2fdcebb6ff9435fda1f4bbafb9f1
2024-06-07 15:09:30 -07:00
Ats Jenk cdc0e2c9c9 Check the feature flag before showing bubbles shortcut widget
Flag: com.android.wm.shell.enable_retrievable_bubbles
Bug: 340337839
Test: manual

Change-Id: I39424de3c448a1991a62dd198c195db5418788ba
2024-06-07 11:05:10 -07:00
Mykola Podolian d00bc8a0e7 Merge "Remove scrim view alpha when bubble manage menu is shown." into main 2024-06-07 17:30:57 +00:00
Alex Chau 7656f3c604 Merge "Reserve space for system bars in both orientations in fake orientation" into main 2024-06-07 17:03:03 +00:00
Alex Chau f7c9466c8f Reserve space for system bars in both orientations in fake orientation
- In BaseContainerInterface.calculateTaskSize, combine both portrait and landscape/seascape insets to leave space for status bar/nav bar in either orientations.
- Rotate the paddings to portrait before applying
- Don't use getOverviewActionsClaimedSpace() in fake landscape/seascape

Bug: 344727200
Test: We can't currnetly autotest fake orientaiton
Test: With gesture/3-button, rotate Overview to portriat/landscape/seascape/fake-landscape/fake-seascape, launch task and enter overview
Flag: EXEMPT bugfix
Change-Id: Icda0f483781921cae78f1ea3ef003562b60ad75a
2024-06-07 16:28:19 +01:00
Shamali P 277a4f9d78 Use just the preview for drag and drop in the standalone activity
Bug: N/A
Test: Manual
Flag: EXEMPT bugfix
Change-Id: I62c42b649e720826979123ae2ff6c5e238fe59dc
2024-06-07 00:00:31 +00:00
Shamali P d69e21f8fe Ensure widgets from WidgetSections.xml are included in suggestions
Additionally, let only prediction system provide suggestions, since the
UI surface has been there for a while, adding locally filtered widgets
from app package isn't required.

Bug: 345520128
Test: Unit tests
Flag: EXEMPT bugfix
Change-Id: Ia97f0743fefeae750e07a694bb19d24a5cc11ffe
2024-06-06 22:23:35 +00:00
Shamali Patwa 50fa2e404f Fix the flaky screenshot test
The flake happened to be due to rebinding triggered on attachToWindow that reset the icon cache with placeholder icon

Based on what I see, instead of calling refresh and bind, just triggerring onWidgetsBound should be okay - assuming it was trying to bind view for case when theme or display size was changed while picker was open.

Bug: 337916664
Change-Id: Ic6f3ff9188e4c5eda141a948ffa0c2c7c685162e
Test: Screenshot test
Flag: EXEMPT bugfix for test
2024-06-06 14:07:03 +00:00
mpodolian 4d8ad445c0 Remove scrim view alpha when bubble manage menu is shown.
Updated logic for taskbar scrim view alpha calculation, setting it to 0
when bubble manage menu is shown.

Fixes: 337169457
Flag: NONE
Test: Visual.
For gesture navigation:
1) On foldable phone while device is being folded expand any
bubble, click mange button, then unfold. Observe no scrim view is
visible.
2) Enable persistent taskbar, pull down the notification shade then
swipe it back up while bubbles are open.
3) Enable persistent taskbar, pull down the notification shade then
swipe it back up while bubbles and mange menu is open.
4) Enable persistent taskbar. Fold device. Open bubble and click manage
button. Unfold device. Observe no scrim view is visible.

For 3 button navigation
1) Unfold the device, press the home key, pull down the notification
shade then swipe it back up while bubbles are open.
2) Unfold the device, press the home key, pull down the notification
shade then swipe it back up while bubbles and mange menu is open.
3) Fold device, open bubble and click manage button. Unfold device.
Observe no scrim view is visible.

Change-Id: Ic011ae9bd11801a479062cc51c60377823a926fb
2024-06-06 00:32:08 +01:00
Xiaowen Lei 5eae66429e Merge "Don't add padding for Smartspace (actual and preview)." into main 2024-06-05 22:56:07 +00:00
Treehugger Robot 4dc0025ebe Merge "Push a potential fix for hotseat aggregation" into main 2024-06-05 20:39:11 +00:00
Sihua Ma a44f4ac861 Push a potential fix for hotseat aggregation
This could be caused by landscape layout not receiving inset changes

Adding logs for hotseat layout info as well

Bug: 335141365
Flag: EXEMPT bugfix
Test: N/A
Change-Id: I987f8622907a10fac5375ddddac3db2c5eba41c1
2024-06-05 18:58:23 +00:00
Brandon Dayauon 901edc82e6 Merge "Consolidate the header views updating into a single method" into main 2024-06-05 16:25:38 +00:00
Treehugger Robot 6a69160999 Merge "Add debug logs to TopTaskTracker" into main 2024-06-05 16:17:19 +00:00
Schneider Victor-tulias 86b9ad4ff7 Add debug logs to TopTaskTracker
Flag: NONE debug logs
Bug: 342247547
Test: checked TIS logs
Change-Id: I6c8440af122a0376ffd77df6c8c9b9aeb742d447
2024-06-05 10:34:15 -04:00
Brandon Dayauon 05e963c245 Make private profile header scrollable
bug: 345007467
Test: manually video:
before: https://drive.google.com/file/d/1XzpD-R48WRKFBeDlHXU5xSGgc50ZON8o/view?usp=sharing
after: https://drive.google.com/file/d/1VBKZluzxvpP8ucs_uylk5esRlm9KzrZb/view?usp=sharing
Flag: Aconfig com.android.launcher3.enable_private_space Nextfood
Change-Id: I1db4bdf244b37b4c4cf55cb0d70d4011fee7de90
2024-06-04 17:23:43 -07:00
Xiaowen Lei 6c76501e0e Don't add padding for Smartspace (actual and preview).
As demonstrated in ag/27287153, the actual Smartspace doesn't have any
top padding, but the qsb_preview does.
  - Turns out, ShortcutAndWidgetContainer sets padding on its children.
  - The actual Smartspace has padding removed by overriding the
    `setPadding` method in SmartspaceViewContainer. (See ag/13562740.)

This CL updates ShortcutAndWidgetContainer.java to not add padding for
either the actual or the preview Smartspace. It makes use of
`R.id.search_container_workspace` to identify the applicable cases,
rather than checking class types or names. This way, there is no
Pixel-specific logic added.

Before: https://hsv.googleplex.com/6335187293044736?node=18
After: https://hsv.googleplex.com/5450651931770880?node=18
Actual Smartspace, for reference:
  - https://hsv.googleplex.com/6083634648842240?node=14

Note the `isChildQsb` also returns true for the QsbContainerView. Since
that class already has the same `setPadding` override:
  - https://cs.android.com/android/platform/superproject/main/+/main:packages/apps/Launcher3/src/com/android/launcher3/qsb/QsbContainerView.java;l=147-150;drc=e58aaf1802e43f73bbd417658c1c4c42e2fe28fd
This CL does't affect its padding.

Flag: EXEMPT bugfix
Bug: 338601960
Test: Go to Wallpaper & style preview for Home screen.
Change-Id: I5b6f7752cfee556b815c83e9df85f9e74f23ab4b
2024-06-04 14:19:30 -07:00
Brandon Dayauon 2c40b8366d Consolidate the header views updating into a single method
Call this updateView() in reset to ensure states are correct before animating.

bug: 341053089
Test: manually - video: https://drive.google.com/file/d/18ZSAEplL1Lk5ij3IHlwtRh1GQ6GhrXX1/view?usp=sharing
Flag: Aconfig com.android.launcher3.enable_private_space Nextfood
Change-Id: I2c825a7fd7d9a5faad8fbbb70d0f40294f715a42
2024-06-04 10:09:40 -07:00
Liam, Lee Pong Lam e48009919d [Launcher3] Hide keyboard when fastscroller scrolling down and keyboard
shown

Implement keyboard hiding logic: Hide keyboard when scrolling down (y > mLastY) unless already requested (mRequestedHideKeyboard). Track hide request state to prevent redundant calls.

New added logic: Only hide keyobard while dragging the scrollbar

result video: https://photos.app.goo.gl/e4dYUUiUN3BujNUz9

Bug: 333967597
Flag: EXEMPT bugfix
Test: Manual
Change-Id: Id672763c69cbb37aeb7a1fd3f17eb168de9f49b4
2024-06-04 00:43:30 +00:00
Liam Lee Pong Lam 61ac47e675 Merge "Revert "[Launcher3] Hide keyboard when fastscroller scrolling down and keyboard"" into main 2024-06-04 00:25:19 +00:00
Schneider Victor-tulias 38b9e1438e Merge "Clean up unused debug logs for b/319168409" into main 2024-06-03 20:31:42 +00:00
Shamali Patwa 54d8924415 Merge changes from topic "image-previews-wrap" into main
* changes:
  Adjust previews in a row to align with each other and remove whitespace.
  Move item animator to its own class and use it only for full sheet
  Measure recommendation children using the provided available height
2024-06-03 19:47:22 +00:00
Anton Vayvod ee38224910 Guard Flags references with a check for running on Android V.
Otherwise, Launcher3 next build crashes on non-V devices.

Bug: NONE Trivial cleanup.
Test: manual
Flag: NONE The change deals with flags

Change-Id: I9d9335ea1cb0f299aa5af8095ff1ea2f98c23542
2024-06-03 19:04:41 +00:00
Liam Lee Pong Lam ee5867e980 Revert "[Launcher3] Hide keyboard when fastscroller scrolling down and keyboard"
This reverts commit 883a79db71.

Reason for revert: Revert this change because it caused other bug b/343285163

Change-Id: I1fdb21cc4a5cdcf2c22e9b1927753b290626289c
2024-06-03 19:00:14 +00:00
Brandon Dayauon f839b1121d Merge "Create a bug fix flag for the FloatingMaskView." into main 2024-06-03 18:18:05 +00:00
Shamali P 7a183e4051 Adjust previews in a row to align with each other and remove whitespace.
- Introduces a WidgetTableRow that identifies preview height for all of
its children while keeping them aligned with minimum whitespace
- The fullSheet's move / change animations can conflict with the resize
so, we wait for them before performing resize of the row.

Bug: 335715046
Test: Manual
Flag: NONE BUGFIX
Change-Id: Id843430c7adfc228c219ba54d504baddba792df0
2024-06-03 18:07:30 +00:00
Shamali P 01d1c31ec7 Move item animator to its own class and use it only for full sheet
Bug: 335715046
Test: Manual
Flag: NONE BUGFIX
Change-Id: I6977e9854edcee385f5b7075f62dd1d8ff8dfdce
2024-06-03 18:07:21 +00:00
Shamali P 93ee47f729 Measure recommendation children using the provided available height
We always want to measure the pages based on the provided height.

Bug: 335715046
Test: Manual
Flag: NONE BUGFIX
Change-Id: I9de2ed1e0d4cc37d24435b9077e60bf5f0456091
2024-06-03 18:07:11 +00:00
Schneider Victor-tulias 43592a83c8 Clean up unused debug logs for b/319168409
Flag: NONE removing debug logs
Fixes: 319168409
Test: TaplDragTest#testDragAppIcon
Change-Id: I73208b042248df04281d52eaf3ed6832abbfc144
2024-06-03 12:05:40 -04:00
Brandon Dayauon 6b65956a5c Merge "Make PrivateSpaceSettingsButton instead of having just the imageView." into main 2024-06-03 15:02:59 +00:00
Brandon Dayauon 6f1ca642ee Merge "Rename add* to update* and call setQuietMode() itself" into main 2024-06-01 00:09:52 +00:00
Brandon Dayauon 582790c56a Merge "Fading PS container on hide." into main 2024-06-01 00:07:34 +00:00