Commit Graph

20057 Commits

Author SHA1 Message Date
Sihua Ma e2dde4e468 Merge "Add unit test for CustomAppWidgetProviderInfo" into main 2024-07-18 15:47:32 +00:00
Sihua Ma b648a0f386 Merge "Add unit test for CustomWidgetManager" into main 2024-07-18 15:47:15 +00:00
Shamali Patwa 1407aeca8d Merge changes from topic "ls-picker-filter" into main
* changes:
  Consider the widget option menu choice in search results
  Show only filtered / default widgets in standalone activity by default
  Add a 3 dot vertical menu and styles (child cl makes it functional)
  Set default widgets and all widgets separately from standalone activity
  Update the widget picker activity theme for popup menus styling
2024-07-18 14:14:42 +00:00
Sebastián Franco 0eafdad0f5 Merge "Adding testin for Utilities.java" into main 2024-07-18 03:05:44 +00:00
Sebastián Franco 51c8ae668d Merge "Remove unused methods" into main 2024-07-18 03:05:15 +00:00
Anushree Ganjam 696d3f48f7 Add SEARCH_TARGET_UTIL_LOG for debugging searchtargetutil logs
Bug: 352067203
Test: Manual
Flag: EXEMPT bugfix
Change-Id: I27b7c29ae0400f2ff3fb8336cee0eec0d962ac1b
2024-07-17 18:34:40 -07:00
Brandon Dayauon 1710cbeb6e Don't add floatingMaskView if it will not fit.
See this screenshot for math explanation: https://screenshot.googleplex.com/9x256x5uk7qNZDg
We use the Y values of the views to determine if the header will be clipped by the
floating mask view.

Also added logs for private space.

bug:343478928
Test manually before: see bug.
after: https://drive.google.com/file/d/1FZXDQG-hV-V3wErVR0-nVCMgjUDk910Z/view?usp=sharing
Flag: com.android.launcher3.enable_private_space

Change-Id: I025e4e62f9ba60e8493d2aceb139d2c4ed6a84dd
2024-07-17 17:12:34 -07:00
Brandon Dayauon ef81b5c630 Merge "Remove enableLayoutTransitions for private space." into main 2024-07-17 23:54:59 +00:00
Sihua Ma 1f3f951b70 Add unit test for CustomAppWidgetProviderInfo
Number of methods covered: 2

Test: atest NexusLauncherRoboTests:CustomAppWidgetProviderInfoTest
Test: SysUI studio
Flag: TEST_ONLY
Bug: 353303621
Change-Id: I4235569878a9f1c1b2ec040b26190f97d9734679
2024-07-17 23:38:33 +00:00
Sebastian Franco c794aca69f Refactoring FolderPagedView to make it more testable
Bug: 353588686
Test: Compiles
Flag: NONE refactor
Change-Id: I612523282a57beac90b14a890a333a1670ab0d48
2024-07-17 23:32:17 +00:00
Kevin Lim 0c7079ece0 [UniversalSearchInput] Support search box dynamic height adjustment in
ActivityAllAppsContainerView

Previously, ActivityAllAppsContainerView assumed a static height for the
search box and relied only on FloatingHeaderView's height calculation.
With multi-line search bar, we need to add to the FloatingHeaderView's
mMaxTranslation to update the clipping position for the recycler views
belowe

Bug: b/341795751
Flag: com.android.launcher3.multiline_search_bar
Test: http://recall/clips/32f64e77-3522-4873-bc7b-86d844912724
Change-Id: I67aab186e96d7bdecbba454f660d73f0f4408a98
2024-07-17 23:07:58 +00:00
Shamali P 6211e86009 Consider the widget option menu choice in search results
Makes the search related code separate from popup provider.

Bug: 347288851
Flag: EXEMPT flag in sysui
Test: Unit tests
Change-Id: I4534d5f70876ec0cf4e2d78030864f78a8bfabb9
2024-07-17 22:56:58 +00:00
Shamali P 9aabb9a9cb Show only filtered / default widgets in standalone activity by default
Bug: 347288851
Flag: EXEMPT flag in sysui
Test: b/339716822 to set it up
Change-Id: I71baac8897ce600f3c588eb3d48b9677e507145b
2024-07-17 22:56:49 +00:00
Shamali P 8654ff0116 Set default widgets and all widgets separately from standalone activity
Bug: 347288851
Flag: EXEMPT standalone picker
Test: Manual
Change-Id: I4eaeb7cb44b8b9c4187f7cf8fdc1b80143bb322e
2024-07-17 22:56:30 +00:00
Shamali Patwa 45b5acef28 Merge "Cleanup widgetsModel and add tests" into main 2024-07-17 22:55:01 +00:00
Sihua Ma 71a48d9ac5 Add unit test for CustomWidgetManager
Number of methods covered: 5

Test: atest NexusLauncherRoboTests:CustomWidgetManagerTest
Test: SysUI studio
Flag: TEST_ONLY
Bug: 353303621
Change-Id: I69c9567391d3a874c7b2abcd473887194ec2dcfc
2024-07-17 22:21:40 +00:00
Andrew Cole f0bdb71e38 Merge "Test Week - FolderAccessibilityHelperTest" into main 2024-07-17 20:16:39 +00:00
Sebastian Franco 3780e096d6 Adding testin for Utilities.java
Happy testing week.

Bug: 353588686
Test: LauncherUtilitiesUnitTest
Flag: TEST_ONLY
Change-Id: I321aa9197a53801282591198aef0229d44da60d3
2024-07-17 11:28:24 -07:00
Charlie Anderson 7dc0ce4019 Merge "[Test Week] Add tests for each operation in PackageUpdatedTask" into main 2024-07-17 17:55:45 +00:00
Brandon Dayauon 0e5640376e Remove enableLayoutTransitions for private space.
Get rid of layoutTransitions as they are not reliable, see here: https://docs.google.com/document/d/1ExSemBvzzVv-I9tUCVzdLeN-lDb2hTSOM886UYSH-Qk/edit?usp=sharing&resourcekey=0-aBCCLnrB7KtkhIeyUOkKyw
Instead use actual animatorSet to do the animating.
- This also fixes the timings so that the pill transition happens at the same time of the icon alpha animation.
Made member variable for lockText and settingButton.

bug:346298256
Test:
before: See bug
after manually- video: https://drive.google.com/file/d/1B7PIgrGWMJTphc1b5CvCkyg-QYx3TTN3/view?usp=sharing
Flag: com.android.launcher3.enable_private_space

Change-Id: I049b84dbe1279a0becb090db8660975dc5c5961e
2024-07-17 10:35:53 -07:00
Andrew Cole 6ce5c66356 Test Week - FolderAccessibilityHelperTest
Adding unit tests for FolderAccessibilityHelper. In order to write these tests we have also included a refactor of DragAndDropAccessibilityDelegate to get mDragLayer and the accessibility delegate from ActivityContext instead of Launcher. This allows us to pull that from test context in ActivityContextWrapper during testing.

* Tests 1 class previously untested
* Tests 3 methods
* Includes 1 class refactor

Bug: 353303621
Test: FolderAccessibilityHelperTest
Flag: TEST_ONLY

Change-Id: I8d13113fc09d3ee902faecc426deb80bcbae0b0d
2024-07-17 09:48:30 -07:00
Charlie Anderson 98c3cafcaf [Test Week] Add tests for each operation in PackageUpdatedTask
Bug:353303621
Test: unit test
Flag: TEST_ONLY

Change-Id: Ic2194fd1506c4ff5a542eac62a492f395d12886e
2024-07-17 11:06:38 -04:00
Shamali P 3ae39c72de Cleanup widgetsModel and add tests
1. Removes unused method `getAllWidgetComponentsWithoutShortcuts`
2. Exposes widgets either as component map or package item map - to
eliminate the duplicate logic around widget sections.
3. Add tests that validate that each package is unique - to help
cover the redirect issue seen in past.
4. In follow up cls, other methods that deal with picker specific data
types like WidgetsListBaseEntry will also be moved out - leaving the
model to only be responsible for providing all widgets map or widgets
by package.

Bug: 341611976
Flag: EXEMPT BUGFIX
Test: Unit test
Change-Id: Ife70874d312b51c66025a6ec678480f2b5c41793
2024-07-17 14:29:31 +00:00
Charlie Anderson db7b6a0104 Merge "Add new Cloud archived app icon and support for inline icons for BubbleTextView" into main 2024-07-17 13:57:38 +00:00
Sebastian Franco c275326e40 Remove unused methods
Bug: 353303621
Test: compiles
Flag: NONE Removing code
Change-Id: Ibfdc983c5d29d8e928e4277dac285d4e62bdc1fd
2024-07-16 19:10:32 -07:00
Charlie Anderson d5acd6a016 Add new Cloud archived app icon and support for inline icons for BubbleTextView
- Can now set start drawable for BubbleTextView title with setTextWithStartIcon()
 - App Archiving cloud overlay icon will be disabled when flag on

Bug: 350758155
Test: locally tested B&R with pre-archiving
Flag: com.android.launcher3.enable_new_archiving_icon

Change-Id: I4d395a7ea7dc5ee11259f897d45b83eabdabb766
2024-07-16 19:39:03 -04:00
Stefan Andonian f50dca1138 Merge "[Test Week] Unit test for WidgetManagerHelperTest." into main 2024-07-16 23:07:40 +00:00
Stefan Andonian 19c5f7ae71 [Test Week] Unit test for WidgetManagerHelperTest.
6 public methods covered.

Bug: 353303621
Test: Unit Test
Flag: EXEMPT unit test
Change-Id: I549d97f5b57f0e6e9af44bd1695d94ebfa0538f2
2024-07-16 20:58:11 +00:00
Stefan Andonian 9fb11f4d95 Merge "[Test Week] Move ListenableHostView into it's own class for ease of unit testing." into main 2024-07-16 18:51:55 +00:00
Brian Isganitis 984d782024 Merge changes from topic "taskbar-pinning-preference-rule-fixes" into main
* changes:
  Add subrule for controlling an individual Taskbar preference.
  Taskbar Pinning Preference Rule fixes.
2024-07-16 18:05:33 +00:00
Stefan Andonian 487a21726d [Test Week] Move ListenableHostView into it's own class for ease of unit testing.
Bug: 353303621
Test: Verified with follow-up unit test CL.
Flag: EXEMPT unit test
Change-Id: Idfdaca0bee7f162f6e6ac60b1ddb53458603c227
2024-07-16 16:50:43 +00:00
Fengjiang Li f04eeb5eee Merge "[Test Week] Add ViewCacheTest" into main 2024-07-16 16:36:28 +00:00
Sihua Ma 5132315aee Merge "Add test for LauncherWidgetHolder" into main 2024-07-16 15:49:44 +00:00
Brian Isganitis e3d3d653d1 Taskbar Pinning Preference Rule fixes.
- Actually evaluate statement in tests.
- Enable aconfig flag for taskbar pinning.
- Allow DisplayController Taskbar mode to change in test harness.
- Make DisplayController think it's in desktop mode when needed.

Flag: TEST_ONLY
Bug: 230027385
Test: TaskbarPinningPreferenceRuleTest

Change-Id: I1c55f73cb5a4bb903cd2d628fa47fbd5e8b1bb86
2024-07-15 22:34:01 -04:00
Fengjiang Li 7c8f90f04a [Test Week] Add ViewCacheTest
Number of new tested methods: 3

Bug: 353303621
Test: This is the unit test
Flag: NONE - unit test
Change-Id: I235ba375db12b9f3fac6f204018b32e692835eab
2024-07-15 16:51:10 -07:00
Sihua Ma 7098ba260f Add test for LauncherWidgetHolder
Number of new tested methods: 8

Test: atest NexusLauncherRoboTests:LauncherWidgetHolderTest
Test: SysUI studio
Flag: TEST_ONLY
Bug: 353303621
Change-Id: I8751c8de8d719e567775368d988794b2d7abc37e
2024-07-15 22:51:04 +00:00
Cosmin Băieș 1a0406e1be Merge "Add IME switch button long click support" into main 2024-07-15 18:06:02 +00:00
Treehugger Robot 21b2215968 Merge "Add debug logs to print stack trace for Private space flaky test." into main 2024-07-11 21:48:41 +00:00
Fengjiang Li dd7471f3bf Merge "[Launcher Jank] Improve SimpleBroadcastReceiver.java" into main 2024-07-11 20:22:22 +00:00
Fengjiang Li b87ad6f945 [Launcher Jank] Improve SimpleBroadcastReceiver.java
Bug: 348649441
Flag: NONE - jank fix
Test: manual - presubmit
Change-Id: I17bd7e4d7f0640522476e94edae691f983835f62
2024-07-11 11:12:29 -07:00
Treehugger Robot 9ef16e5cd3 Merge "Fix NPE of BaseContainerInterface#calculateTaskSizeInternal" into main 2024-07-11 16:30:31 +00:00
Cosmin Băieș 33f8bfbadf Add IME switch button long click support
This adds support for handling long clicking on the IME switch button.
Initially it will behave exactly like short clicking, i.e. show the IME
switcher menu.

Flag: android.view.inputmethod.ime_switcher_revamp
Test: atest
  TaskbarNavButtonControllerTest#testPressImeSwitcher
  TaskbarNavButtonControllerTest#testLongPressImeSwitcher
Bug: 311791923
Change-Id: Ibd0d6bce2bab11511bc082f46731ec86038c8cf8
2024-07-11 11:42:16 +02:00
Treehugger Robot d529345e0e Merge "[Launcher Jank] Add TODO for LauncherPreviewRenderer to set bg handler on smartspace BaseTemplateCard" into main 2024-07-11 08:51:29 +00:00
Fengjiang Li eef1599c06 Fix NPE of BaseContainerInterface#calculateTaskSizeInternal
Fix: 351861547
Flag: NONE - Bug fix
Test: Presubmit
Change-Id: I984748a6c5487a946a96aa3e2183b5d13a370b6d
2024-07-10 14:43:15 -07:00
Anushree Ganjam f828683fa8 Add debug logs to print stack trace for Private space flaky test.
From the failure test videos, it looks like scrollToTop gets called https://b.corp.google.com/issues/339737008#comment15.

Bug: 339737008
Test: Manual
Flag: TEST_ONLY
Change-Id: I61a95ff45fa4409f8f1b243ac435002556a16677
2024-07-10 13:44:11 -07:00
Sebastián Franco 6e43c6aadf Merge "Moving ReorderWidgetsTest to an integration test instead of E2E" into main 2024-07-10 18:28:08 +00:00
Alex Chau c378e64b75 focusTransitionScaleAndDimOut should always go from 1f to 0f
- Also updated AnimatedFloat to accept a Consumer<Float>, so a lambda can be used as updateCallback with refernce to udpated value
- Also updated PendingAnimation to accept Animator with TimedInterpolator without specifying SpringProperty

Fix: 352195519
Test: manual
Flag: EXEMPT bugfix
Change-Id: Ifb78c1bcd3ca215a5d214f986a107d0988bff13b
2024-07-10 13:40:22 +01:00
Sebastian Franco 224f67a046 Moving ReorderWidgetsTest to an integration test instead of E2E
Flag: TEST_ONLY
Test: IntegrationReorderWidgetsTest
Bug: 324261526
Fix: 343761044

Change-Id: I9bfe8b587e1024260ddeeb48157c3d204f2d58f2
2024-07-10 04:20:41 +00:00
Kevin Lim b89cd5e91a Merge "[AllAppsStore] Dump class name in addition to package name for debugging" into main 2024-07-10 00:02:12 +00:00
Fengjiang Li 6944c9e63f [Launcher Jank] Add TODO for LauncherPreviewRenderer to set bg handler on smartspace BaseTemplateCard
Fix: 347775522
Flag: NONE - performance change
Test: manual
Change-Id: I19ba67e1eabfe02c45909d85d723bc28a78ae6df
2024-07-09 13:38:32 -07:00