Commit Graph

2243 Commits

Author SHA1 Message Date
Fengjiang Li e81f4b8dc5 Revert "Fix small gap between widget resize frame and widget background."
This reverts commit 1e6bbf368b.

Reason for revert: b/317375712 TAPL is failing

Change-Id: Ib6b200f99c9feb7986ffca50015c02f3e558fc84
2024-01-02 23:00:03 +00:00
Tracy Zhou 5ad10ff6f6 Adjust the layout of nav buttons in 3 button mode with task bar / nav bar unification
In nav bar, we assign layout weight 0.25:0.5:1(for home but the content width of home is set to 80dp):0.5:0.25 with a LinearLayout. Since we use a FrameLayout for taskbar (to support both folded and unfolded task bar), in this change we are matching the layout by manually calculating the width of each section (since we are already manipulating like so in different layoutters)

Bug: 230395757
Test: https://screenshot.googleplex.com/3P6vDrgb6geqTUm
Change-Id: I6ba201477621f173e42c5211fcc68b24e3022122
2024-01-02 14:34:51 -08:00
Brandon Dayauon 46884202f5 Merge "Fix padding between text and (x) icon in work profile card." into main 2023-12-21 22:25:41 +00:00
Fengjiang Li f63532e610 Merge "Fix small gap between widget resize frame and widget background." into main 2023-12-21 01:34:16 +00:00
Fengjiang Li 1e6bbf368b Fix small gap between widget resize frame and widget background.
There is a 1dp gap on left/top/right/bottom between widget resize frame and widget background. Increasing the margin by 1dp will fill this gap.

Fix: 291104076
Test: See https://b.corp.google.com/issues/291104076#comment9
Flag: NA
Change-Id: I05143d76c98de7bbcfdca5cfacb21b3ace669861
2023-12-20 14:26:21 -08:00
fbaron 7bc30906c4 Update folder preview dark theme color
Fix: 314843350
Test: Verify on device
Flag: NONE
Change-Id: I2a4cb62dacb05193412b99aca0d3bfabfb77f959
2023-12-19 19:21:59 +00:00
Brandon Dayauon 6ac1d24876 Fix padding between text and (x) icon in work profile card.
- Simplified the .xml to just use linear layout and remove the extra relativelayout that was used for the button when it can just be a
Framelayout.

- Now according to spec https://www.figma.com/file/mf67dbMngw0a3aev2HTinD/Work-Profile-%26-Bluechip?type=design&node-id=2185-0&mode=design&t=n0pl6vP5rnSrTyyv-0
the additional padding is now included.

bug: 309120438
Test: Manual photos-
before: https://screenshot.googleplex.com/48kUpYCVQGYMwdm
after: https://screenshot.googleplex.com/AcisTmXQeZ3NT3C
Flag: None
Change-Id: I3c1850a20f49a2a4e809410b4aaef688ea9b3e2c
2023-12-18 13:37:16 -08:00
Helen Cheuk 9c0f738cdb Merge "Add focus outline to launcher" into main 2023-12-15 18:03:36 +00:00
helencheuk b4626f4698 Add focus outline to launcher
Fix: 310953377
Test: TBC
Flag: ACONFIG com.android.launcher3.enable_focus_outline Development
Change-Id: Ie395ec74c8a4a13a68539ca7ec6496481d96b860
2023-12-15 16:56:31 +00:00
Charlie Anderson 797ed83700 Merge "Add wrapper for logging backup & restore metrics from Launcher" into main 2023-12-13 19:33:26 +00:00
Tracy Zhou 9ccd5d4257 Introduce taskbar_phone_size
In small screen, we use 48dp for nav bar height, while it's 60dp for task bar.

Bug: 230395757
Test: manual
Change-Id: Ia7083a1b2246981466e1163404c63b645a6bf5b1
2023-12-13 00:38:15 -08:00
Brandon Dayauon d7f0ccf52e Merge "Move UnionDecorationHandler to Launcher" into main 2023-12-13 00:00:14 +00:00
Charlie Anderson 489f1ada5c Add wrapper for logging backup & restore metrics from Launcher
Bug: 25177913
Flag: ACONFIG com.android.launcher3.enable_launcher_br_metrics DEVELOPMENT
Test: locally

Change-Id: I220721f705eb7244a1f13ef8997682999d799f51
2023-12-11 17:01:28 -05:00
Brandon Dayauon 763e40d747 Move UnionDecorationHandler to Launcher
- Create base SectionDecorationInfo.java and RecyclerViewAnimationController.java
- SearchTransitionController now inherits from RecyclerViewAnimationController where RecyclerViewAnimationController will control
animation for private space

Bug: 299294792
Test: Verified SearchTransitionController didn't regress by turning off BACKGROUND_DRAWABLES flag.
- Verified QL highlight still works
- video: https://drive.google.com/file/d/15yjBWofebn6m7VgEnLK6kEYqhC_adJQ3/view?usp=sharing

Flag: None
Change-Id: If34f4bb199be0e113485279931d2927cb9fad397
2023-12-11 11:27:25 -08:00
Thales Lima 1faa4edc42 Make numFolderRows/Columns accept more values
InvariantDeviceProfile hold values that are not related to current DP in use. Now other classes get the value correctly from DeviceProfile, and each posture can hold different values, making it akin to iconSize.

Fix: 309800141
Test: DeviceProfileResponsiveDumpTest
Test: DeviceProfileResponsiveAlternativeDisplaysDumpTest
Test: DeviceProfileDumpTest
Test: DeviceProfileAlternativeDisplaysDumpTest
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Change-Id: I32295738585de67205dcd6c8942d08a3d07d169a
2023-12-08 22:00:48 +00:00
fbaron eee16c7ac5 Update widget picker two pane to support foldables
Bug: 301918659
Test: WidgetPickerImageTest
Flag: ACONFIG com.android.launcher3.enable_unfolded_two_pane_picker DEVELOPMENT
Change-Id: I5beecf4f8c46235f3e89c7bd8aed65fd292883ce
2023-12-06 12:48:24 -08:00
Pat Manning f9e64bc0ce Merge "Revert^2 "Update cell drop visualizer radius"" into main 2023-12-04 11:06:00 +00:00
Pat Manning 27efab01f3 Revert^2 "Update cell drop visualizer radius"
This reverts commit 311afc6987.

Reason for revert: Resubmitting with updated screenshots

Change-Id: Ieb114c06376cf46b90b140490a54cbae592c8f5a
2023-12-01 13:56:26 +00:00
Uwais Ashraf 205d707579 Merge "Revert "Update cell drop visualizer radius"" into main 2023-12-01 10:16:29 +00:00
Uwais Ashraf 311afc6987 Revert "Update cell drop visualizer radius"
This reverts commit 77e0faa670.

Reason for revert: Causes a 100% failing test see b/314206230

Change-Id: Icfc5bb4bace17b630bfd74a1460f6d1748d8d9d3
2023-12-01 10:14:54 +00:00
Federico Baron b89fde7a9a Merge "Update cell drop visualizer radius" into main 2023-11-30 20:07:47 +00:00
Thales Lima 09d42d5340 Revert "Make numFolderRows/numFolderColumns accept more values"
Revert submission 25438456-5x5_folder
Reason for revert: http://b/313567919
Reverted changes: /q/submissionid:25438456-5x5_folder

Revert "Use DeviceProfile numFolderRows and numFolderColumns"
Revert submission 25313018-numFolder
Reason for revert: http://b/313567919
Reverted changes: /q/submissionid:25313018-numFolder

Change-Id: I4890016e310c0a2122861f36fcdbf33e98e727c0
2023-11-30 11:47:37 +00:00
fbaron 77e0faa670 Update cell drop visualizer radius
Fix: 313665319
Test: NONE
Flag: NONE
Change-Id: I1a6ab76f2feb8175eca3af5fa62efa2cf8be01ba
2023-11-29 13:49:48 -08:00
Vinit Nayak eabb37822f Merge "Change SplitInstructionsView cancel from X to "Cancel"" into main 2023-11-29 00:18:42 +00:00
Vinit Nayak d6efde5cbb Change SplitInstructionsView cancel from X to "Cancel"
* Styling (accent color) is still a TODO,
just made it bold for now.

Flag: ACONFIG com.android.wm.shell.enable_split_contextual DEVELOPMENT
Bug: 295983387
Test: Tested w/ flag on and off, cancel doesn't show
with flag off

Change-Id: Id5214a86abbe0cf095e32f6f75522ea51d6b1f3c
2023-11-28 14:34:12 -08:00
Sunny Goyal a481659e51 Merge "Merging widget item click listener to default click listener" into main 2023-11-28 21:36:15 +00:00
Sunny Goyal 464509b375 Merging widget item click listener to default click listener
> Also removing check for dragHandle, since dragHandle is already removed

Bug: 307306823
Test: atest Launcher3Tests
Flag: N/A
Change-Id: I0b452dd1fbccf15ed686370471e8866b179fd77e
2023-11-28 12:07:16 -08:00
Thales Lima 24051842c7 Make numFolderRows/numFolderColumns accept more values
Now they can hold values for different configurations, making it akin to iconSize.

Bug: 309800141
Test: DeviceProfileResponsiveDumpTest
Test: DeviceProfileResponsiveAlternativeDisplaysDumpTest
Test: DeviceProfileDumpTest
Test: DeviceProfileAlternativeDisplaysDumpTest
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Change-Id: I9d5cccda88a0311dbe0beecef194cc8d60c5c280
2023-11-24 15:54:56 +00:00
Jordan Silva 999dd2a06f Extract cell size information to responsive grid structure
Bug: 287975993
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: ResponsiveCellSpecsProviderTest
Test: DeviceProfileDumpTest
Test: DeviceProfileResponsiveDumpTest
Change-Id: I26a87d9b690fdfcff1599d862c09e97fe9f9f930
2023-11-24 12:39:36 +00:00
Sunny Goyal f7e7843a2b Merge "Removing unused title change logic in settings" into main 2023-11-17 18:18:08 +00:00
Pat Manning d3f3308d12 Merge "Update Icon App Chip Menu to new specs." into main 2023-11-17 15:06:42 +00:00
Sunny Goyal 2e005e1e28 Removing unused title change logic in settings
Bug: 305084752
Test: Manual
Flag: N/A
Change-Id: I93e8a58c579223d5892528a47cff5bcafd69dbf1
2023-11-16 12:54:19 -08:00
Pat Manning 43c4b50c17 Update Icon App Chip Menu to new specs.
Fix: 304228083
Test: TaplOverviewIconAppChipMenuTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu DEVELOPMENT

Change-Id: Ib018c7f59e1141b6f21618b28d411facc937ac7c
2023-11-16 18:18:48 +00:00
Himanshu Gupta 08badb3f6f Adding Private Space views to Launcher.
This CL adds the following:
* Static View Elements to be added to AllApps recycler View
* View Controller to load the above elements dynamically
* Private Space Section Decorator
* PrivateProfile Manager containing the logic related to Private Space
* Abstract UserProfileManager as the super class of Work/Private
ProfileManager

Private Space Views Figma
[link](https://www.figma.com/file/K6bIIcG882EiJNjxvSWsFT/V%E2%80%A2-Private-Space?type=design&node-id=14535-111985&mode=design&t=JLz9W0O551TpzQYH-0)

Flag: ACONFIG com.android.launcher3.Flags.enable_private_space DEVELOPMENT
Bug: 289223923
Test: Ran Launcher3 tests
Change-Id: I8aa4247c78064a551e5e0d0b46d3fc033873f99d
2023-11-14 11:58:16 +00:00
Jordan Silva 8f7986abae Responsive grid cleanup
This CL renames some of the variables to keep it consistent across the code. It removes workarounds that were made to facilitate easy code reviews without breaking the tests.
It is a cleanup of the responsive grid feature.

Bug: 299889733
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: CalculatedAllAppsSpecTest
Test: CalculatedFolderSpecTest
Test: CalculatedHotseatSpecTest
Test: CalculatedWorkspaceSpecTest
Test: AllAppsSpecsTest
Test: FolderSpecTest
Test: HotseatSpecsTest
Test: WorkspaceSpecsTest
Change-Id: I198fadfbcfc0d1b32a62a3076949b42ee1fbcf33
2023-11-09 22:06:03 +00:00
Charlie Anderson ee78d44eb2 Merge "Fixing polish issues with the U app shortcut popup design" into main 2023-11-08 18:08:30 +00:00
Liran Binyamin 4d9157be73 Merge "Adds content description to the overflow bubble." into main 2023-11-08 15:52:58 +00:00
Jordan Silva f2402e25f1 Refactoring Responsive Grid XML specs for more flexibility
It merges portrait and landscape XML specs for responsive grid. This update allows the responsive grid to rely on other properties like aspect ratio and not solely the orientation from resource qualifiers.

Bug: 299889733
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: CalculatedAllAppsSpecTest
Test: CalculatedFolderSpecTest
Test: CalculatedHotseatSpecTest
Test: CalculatedWorkspaceSpecTest
Test: AllAppsSpecsTest
Test: FolderSpecTest
Test: HotseatSpecsTest
Test: WorkspaceSpecsTest
Change-Id: I39ee54d49c9d2a54fcbe91c8a1327a21a8126032
2023-11-07 11:51:28 +00:00
Charlie Anderson a2d85dec47 Fixing polish issues with the U app shortcut popup design
Test: locally verified against design
Flag: NONE
Bug: 304807548

Change-Id: Iff22b3515b638700fb66e856944ec4aa1287e401
2023-11-03 11:46:44 -04:00
Uwais Ashraf 6eb006ed90 Merge "Add margins to top and bottom when grid only overview enabled" into main 2023-10-25 13:53:24 +00:00
Uwais Ashraf aa7fa886d6 Add margins to top and bottom when grid only overview enabled
Fix: 299100244
Test: OverviewImageTest and dump tests
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Change-Id: I22ebced5bf1e27974036d6e2ef72d2b8d63df824
2023-10-24 16:15:39 +00:00
Thales Lima 24ceca6993 Decrease text size if it doesn't fit the cell
Bug: 293467738
Test: ResponsiveHomeScreenImageTest
Test: ResponsiveAllAppsImageTest
Test: DeviceProfileResponsiveDumpTest
Flag: ENABLE_RESPONSIVE_WORKSPACE
Change-Id: Ic0b2d3cde1d4b8b9089f93b96c9bb386247603ce
2023-10-24 13:07:22 +00:00
Pat Manning 5643e7c047 Increase pinned taskbar height to fit tooltips.
Fix: 305706286
Flag: ACONFIG com.android.launcher3.enable_cursor_hover_states TRUNKFOOD
Test: TaskbarHoverToolTipControllerTest

Change-Id: I767947a752eae7a928d59fe332bc62b9fd5b5f37
2023-10-23 15:52:48 +01:00
Liran Binyamin 78f444bdad Adds content description to the overflow bubble.
Flag: LEGACY persist.wm.debug.bubble_bar DISABLED
Bug: 273994695
Test: SystemUIMicrobenchmark:android.platform.test.scenario.sysui.bubble.BubbleBarTest

Change-Id: Ie3fe451c69a39560aa91a6dfd4d615f172cf3299
2023-10-19 14:00:41 -04:00
Holly Jiuyu Sun 6b47dccd73 Merge "[PS] Add private space icon and strings." into main 2023-10-17 22:16:16 +00:00
Holly Sun 6ec3d23a4b [PS] Add private space icon and strings.
Bug: 298227797
Test: manual and unit
Flag: inject_private_space_tile
Change-Id: Ic7ec649ac69f02a82a6ee0b4e63262d8ad3e0916
2023-10-13 12:29:19 -07:00
Charlie Anderson 102a06f810 Merge "Fix status bar flicker on adding widgets requiring configuration." into main 2023-10-11 22:00:40 +00:00
Charlie Anderson 2934c460c4 Fix status bar flicker on adding widgets requiring configuration.
- Changes ProxyActivityStarter theme to draw transparent navigation and status bar

Test: locally
Flag: N/A
Bug: 202485497

Change-Id: I88d14099ec9b1f433fbcdc9184fe5af557bc180b
2023-10-10 11:00:05 -04:00
Jeremy Sim 9d6dbd0a8d App Pairs: Implement app pairs icon
[App Pairs 5/?]

This patch implements the app pairs icon, which displays the two member apps and rotates with the device.

Flag: ENABLE_APP_PAIRS (set to false)
Bug: 274835596
Test: Manual
Change-Id: I07085339d1e2d28f004c1661f0948c59e605c76a
2023-10-06 18:57:09 -07:00
Federico Baron 48a9a3d198 Merge "Cleanup SHOW_DOT_PAGINATION flag" into main 2023-10-04 17:00:45 +00:00