Commit Graph

2243 Commits

Author SHA1 Message Date
Shamali P d4997cf063 Align the margins between handle, text, and container with main picker.
Also aligns style to match main picker which doesn't set header style.

Requested by Jane / UX.

Bug: 328812171
Flag: N/A
Test: Manual - need to build a SS test for this opened - 336284716
Change-Id: I15fb82e807fdaa55bbfaaf73872273d1d6e84f97
2024-04-24 19:15:11 +00:00
Shamali P 9478a40898 Update the app-specific picker to have a container like the main picker
This is to ensure widgets are displayed with same container across the
two pickers.

* http://screencast/cast/NDYxNjMzNDExNjY1MTAwOHwwMTBlYzkwZC0wNg
* http://screencast/cast/NjY1NzAyNzY5NzgwMzI2NHwyYTg3ZWIzNS0wNw
* http://screencast/cast/NTYyMzcwMTc4NDQ5NDA4MHw3Y2JlZDEwZS04Mw

Bug: 328812171
Flag: N/A
Test: Manual - need to build a SS test for this opened - 336284716
Change-Id: I42b743b99cf6f47b7bade57de01b130df78ac1e9
2024-04-24 19:14:50 +00:00
Himanshu Gupta 6d40d42976 Increasing Header height to 72dp.
As per UX spec, the header height needs to
be 72 dp, with the settings gear, unlock button
in middle occupying 48dp, leaving 12dp padding
above and below the latter in header.

Before: https://photos.app.goo.gl/j4vtTQXWy93DRwGA6
After: https://photos.app.goo.gl/7SxLdCQh7KJzYYLx5

Fix: 336510036
Test: Verified on device.
Flag: NA
Change-Id: I7c8115bf3c9b5832a2abcc4a710a2ccf78784c2b
2024-04-24 14:58:59 +01:00
Saumya Prakash 17cd6ca62a Only run search edu when enabled, also make code more generic.
We only need to run the Search edu if it is enabled on devices. The code
itself is also made more generic in terms of method and variable names.

Fix: 330401405
Test: Enable and disable the search function and check whether the edu tooltip shows
up for each specific use case.
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning NEXTFOOD

Change-Id: I1cea3ee56922c0b47ae7e8379aad4b36570daa17
2024-04-23 22:02:15 +00:00
Himanshu Gupta faafb3a19a Fix horizontal spacing in PS Header
1. Removes padding between settings cog and lock button,
as the insets already provide the required padding.
2. Reduces the lock button margin from left to accomodate
the inbuilt inset in the button.

Fix: 336510036
Test: Verified on device.
Flag: NA
Change-Id: I077097c7beb2cc8fe14f4367c66ca4e1ad4270d0
2024-04-23 15:28:01 +01:00
Shamali Patwa a80e199798 Merge "Keep rounded corners while scrolling in right pane & fix scrollbar size." into main 2024-04-19 22:43:39 +00:00
Shamali P 5f7eb1f2ee Keep rounded corners while scrolling in right pane & fix scrollbar size.
[demo](http://screencast/api/gif/NDU4MTQ5ODE3Mzc4NDA2NHxhYmUzMDcxNy04MA/image)

Bug: 333734241
Test: screencast
Flag: N/A
Change-Id: Ifb522ca2c0a1092bf41c630e336b19c81d504c26
2024-04-18 22:32:30 +00:00
Brandon Dayauon baf5f6ec3d Polish workFAB with updated spec.
Updating the workFAB to the new spec: https://docs.google.com/presentation/d/1tTODboxGqJ3ypEyYnr0-bUpSXcvX1cl6Sj8y0Nut5hU/edit?resourcekey=0-9GT8EJG43kTT4aKPWVWRig#slide=id.g2c8f3ae8e02_0_0
Have the background endPadding to be 4 and icon have an endMargin of 12 and the text endMargin of 16.
So that when the text is disappeared, the space between the icon and the right bound is 16dp to spec.

bug:332761814
Test manually:
after LTR expanded:https://drive.google.com/file/d/1NZQW0CF9VFZBoM3673LFiUknqW2nf4r8/view?usp=sharing
after LTR collapsed: https://drive.google.com/file/d/1NRpdTuYQntSs5-yeRL1fJIJy2ETDOYLM/view?usp=sharing
after RTL collapsed: https://drive.google.com/file/d/1NE51MIsS5Fk0DwAuzCehEQzTa42OGj_o/view?usp=sharing
after RTL expanded: https://drive.google.com/file/d/1NPgiPfzw3DOa_xbB_TtlwK-G1Y5WCi53/view?usp=sharing
Flag:None

Change-Id: Ied2efcf6b1bd19c191d80e47bae4f8f6e3794803
2024-04-18 14:40:42 -07:00
Willie Koomson f01687ab5a Merge "Scroll to show WidgetCell when it is tapped." into main 2024-04-16 20:42:12 +00:00
Federico Baron 6188ec4157 Merge "Make hotseat column span responsive" into main 2024-04-16 17:17:55 +00:00
fbaron e4b0b71faa Make hotseat column span responsive
Flag: NONE
Test: DeviceProfileDumpTest, DeviceProfileAlternativeDumpTest, HomeScreenImageTest
Bug: 325084912
Change-Id: Ifa9e8066662a1ab053f66b8800b739d813d2dab8
2024-04-16 06:19:16 +00:00
Willie Koomson dcc2d82d4e Scroll to show WidgetCell when it is tapped.
Scroll to show WidgetCell when it is tapped in a widget sheet.
Otherwise, the add button may show/hide without the user seeing
it if the bottom is clipped.

Bug: 329861721
Test: manual- tap WidgetCell when top or bottom is scrolled out of view
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add TEAMFOOD

Change-Id: Ie21730c193e845cb1c1fa447b7c0a7e719984a8f
2024-04-15 22:32:48 +00:00
Sunny Goyal 4396a935c2 Merge "Using resource overrides for PluginManager instead of code-swap" into main 2024-04-12 20:29:36 +00:00
Sunny Goyal 4a22ed81ea Using resource overrides for PluginManager instead of code-swap
Bug: 330920490
Test: Presubmit
Flag: None
Change-Id: Ib1cd50f95873928b9ce104e8e95d21f1dca9c6e3
2024-04-12 11:38:32 -07:00
Saumya Prakash 5bb103246b Merge "Adjust where the back button is rendered for new SUW requirements." into main 2024-04-11 19:05:52 +00:00
Saumya Prakash da26e19dd8 Adjust where the back button is rendered for new SUW requirements.
Large screen devices in landscape mode and devices that have mostly a
square aspect ratio are undergoing a redesign in Setup wizard that makes
most screens two-pane. As part of this redesign, the back button is
aligned in this change. This change doesn't use a flag because the Setup
Wizard change is not flagged.

Fixes: 323778778
Fixes: 328017929
Test: Run Setup Wizard and see if the back button aligns with the Skip
button in two pane screens.
Flag: N/A

Change-Id: I22680f40c0ddf7cd03ab1da69406eb14184b0174
2024-04-11 16:53:41 +00:00
Vinit Nayak cdaabc6199 Add placeholder divider view when starting split tasks
* This prevents launcher underneath from peaking through
while the split apps are loading

Bug: 299640096
Test: Launched from recents, home and all apps
Doesn't seem to affect small screen since recents scrolls
away and the scrim is only left

Change-Id: I32e394a0bc361489473ee657161c8f3bcbf1e422
2024-04-11 05:09:49 +00:00
Sunny Goyal 11117d9b2a Using resource override instead of code-swap for ApiWrapper
Bug: 330920490
Flag: None
Test: Presubmit
Change-Id: Iac19f32e64d2c76ed5b4f8592943ee4ae7af51b5
2024-04-09 11:14:44 -07:00
Jeremy Sim a7ce667e3a Merge "Fix launch flow when one app in an app pair is paused" into main 2024-04-05 21:30:09 +00:00
Sunny Goyal 21f498c5f3 Merge "Moving all configs from overrides.xml to config.xml" into main 2024-04-05 20:04:15 +00:00
Jeremy Sim 17db14b107 Fix launch flow when one app in an app pair is paused
This CL changes the error handling logic in ItemClickHandler to continue with app pair launch when only one app in an app pair is paused. It also changes AppPairIconGraphic so that the disabled state of the app pair is drawn modularly (if only one app is paused, only one app will appear visually paused).

Bug: 330795643
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual
Change-Id: Ieaf0120cced07b6ac0f3eb07c75b66666a8dcc85
2024-04-05 11:24:33 -07:00
Sunny Goyal bd07c05446 Moving all configs from overrides.xml to config.xml
> Removing some used configs
> Moving ids to id.xml

Bug: 330920490
Flag: None
Test: Presubmit
Change-Id: I86bd22db49a3980c55f5d42350a7c6368fa86d21
2024-04-05 11:20:17 -07:00
Jeremy Sim 324c2478d8 Merge "Update app pair icon colors when switching containers" into main 2024-04-05 00:00:56 +00:00
Zak Cohen ea3fe15fa8 Merge "Widget Picker - Always center add widget button text vertically" into main 2024-04-04 22:19:21 +00:00
Jeremy Sim 05617cb11f Update app pair icon colors when switching containers
This CL updates the color for the app pair background, and adds a way for an app pair icon to redraw as a different color when switching containers.

Bug: 315731527
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual
Change-Id: I615cb95d51f7c4c120ad306246d9491bf4452229
2024-04-04 15:07:30 -07:00
Hyunyoung Song d0eb878d90 Merge "Add 16dp between nav bar and container by setting extra padding to the recyclerView." into main 2024-04-04 18:33:52 +00:00
Zak Cohen d00650bec3 Widget Picker - Always center add widget button text vertically
https://screenshot.googleplex.com/6aLoQSeADh2Ds6V

Bug: 331493703
Test: screenshot tests
Flag: NA layout bug fix
Change-Id: I6399474c42d3cd8ee172bbbbc0789044aac8cbe0
2024-04-04 10:01:18 -07:00
Shamali P 8f44617191 Remove unused badge logic on WidgetCell now that we don't show badges.
See ag/26786552 that removed the usage.

Bug: 331838199
Test: Manual validation
Flag: N/A
Change-Id: I4393df1f8c6c7568925428bb3489081df17aa623
2024-04-04 13:10:00 +00:00
Brandon Dayauon 7e50fa9624 Fix private space settings cog margin
Inset on the lock button already exists, so in reality there are 4dp +
8dp margin from the settings button. To fix this, we can just reduce
8dp -> 4dp on the settings button.

bug: 331742915
Test: before: https://drive.google.com/file/d/1z6-U5eO5oM6h6uULNdmJciMCP_F33rDn/view?usp=sharing
after: https://drive.google.com/file/d/1yzCysJRaRKDp0kivhi6GWE83qsloh39U/view?usp=sharing
Flag: none
Change-Id: Iafb1101b8029398c139ba02f31a027db272132f3
2024-03-28 22:01:55 +00:00
Brandon Dayauon bdb5836ada Add 16dp between nav bar and container by setting extra padding to the recyclerView.
bug:298593161
Test: manual:
(Adjusting bottom padding of recyclerView):
3button nav after closed: https://drive.google.com/file/d/1xTXtzOC-n3_vGXs34FjL_52jiY60piAA/view?usp=sharing
3button nav after opened: https://drive.google.com/file/d/1xS4Wu41-4ogYzVRh1UxDW39DZW214vSz/view?usp=sharing
gesture nav after closed: https://drive.google.com/file/d/1xQGL-Qi5sGwWqQsOLQAsvxpNlJGklBSg/view?usp=sharing
gesture nav after opened: https://drive.google.com/file/d/1xQ9YNUv89RsT9Tsa85BlEt64twDHk-l6/view?usp=sharing

(USING DIVIDER METHOD):
3button nav after closed: https://drive.google.com/file/d/1YG1pFmU4023-wO2okC_wkwsW5L8IUTkl/view?usp=sharing
3button nav after opened: https://drive.google.com/file/d/1YCBIqzFkxNH9fNuE0o2YTz_221ZRAmSA/view?usp=sharing
gesture nav after closed: https://drive.google.com/file/d/1YIBRglQk6SsSe7_nbggcQZBE7aERGT74/view?usp=sharing
gesture nav after opened: https://drive.google.com/file/d/1YGzbgQPRFKhuSZ95BF6fx_8NfPyocCxN/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space

Change-Id: Ibfd4896c1477b3e498389d6451ca458a01d98952
2024-03-27 11:01:22 -07:00
Holly Jiuyu Sun 84f8002586 Merge "[PS] Update PS tile subtitle." into main 2024-03-26 20:42:48 +00:00
Anushree Ganjam 6dadf21a7f Add FastScrollSectionInfo with "info icon" when work educard exists.
Before: https://b.corp.google.com/issues/325490294#comment1

After: https://b.corp.google.com/issues/325490294#comment5

Bug: 325490294
Test: Manual
Flag: NA
Change-Id: I557971cddd5829f46697004159d62a9343e75f69
2024-03-21 12:29:47 -07:00
Helen Cheuk 8896580b58 Merge "Change single stroke focus outline to double stroke" into main 2024-03-21 12:09:19 +00:00
Holly Sun 2509fa72f2 [PS] Update PS tile subtitle.
Screenshot: https://screenshot.googleplex.com/4mUyLoXh5zHchgx
Test: manual
Flag: aconfig com.google.android.apps.nexuslauncher.enable_inject_private_space_tile trunkfood
Bug: 324585814
Change-Id: I22a5448632cf1db628953287ba6ad362165e5351
2024-03-20 14:20:56 -07:00
Fengjiang Li c19e337202 Merge "[Predictive Back] Support WidgetsTwoPaneSheet" into main 2024-03-19 01:53:10 +00:00
Fengjiang Li c51363fc46 [Predictive Back] Support WidgetsTwoPaneSheet
Fix: 325930715
Test: Manual - attached video to bug
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Change-Id: I44098de12253f803526160bce6457a940b2153c7
2024-03-18 15:31:13 -07:00
Willie Koomson 078737f22b Merge "Add tap-to-add button to widget picker" into main 2024-03-15 23:26:05 +00:00
Willie Koomson cdc26951ff Add tap-to-add button to widget picker
This change introduces an "Add" button that appears when a widget
preview is clicked in the widget picker. This button disappears when the
preview is clicked again, or another preview is clicked. When the button
is pressed, it adds that widget to the picker. The add button is
available in the app-specific widget sheet as well.

Bug: 323886237
Test: Manual
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add DEVELOPMENT

Change-Id: I86a8a4c22119960c54a885fd2efeb91916b4f9a0
2024-03-15 20:10:45 +00:00
helencheuk 7b83b8e011 Change single stroke focus outline to double stroke
Add paint for inner stroke, add padding for launcher widget

Bug: 327386149
Test: Manual
Flag: ACONFIG com.android.launcher3.enable_focus_outline Teamfood
Change-Id: I59cf1088209370b89f2faffdab80787f1b0c1e3b
2024-03-15 18:16:20 +00:00
Shamali Patwa a835a2dc92 Merge "Rename the color attr for paging dot indicator used in launcher." into main 2024-03-15 13:33:40 +00:00
Shamali P 34d1db731b Rename the color attr for paging dot indicator used in launcher.
Additionally, make the widgetPickerActivity theme support dark mode.

http://screencast/cast/NDY5OTUzNTA0ODcwNDAwMHxmZWU3ZDBjZS04ZQ

Bug: 326092660
Test: Manual
Flag: N/A
Change-Id: Ic2816853bd25bd04e07d661682d720d1940c268c
2024-03-14 19:38:37 +00:00
Federico Baron 719075b56c Merge "Update min next page visible to 48dp" into main 2024-03-14 16:32:39 +00:00
Luca Zuccarini c9cbc9d5a1 Introduce a new Home animation for workspace and the outgoing task.
The values are currently the same for all display and orientation
configurations, but they might change before launch.

There are a couple known imperfections:
* Swiping out of a hotseat app with very low velocity doesn't look
  great
* Sometimes, if the window movement reaches its final location faster
  than the background is done scaling, there is a small snap in icon
  position

Bug: 298089923
Flag: ACONFIG com.android.launcher3.enable_scaling_reveal_home_animation DISABLED
Test: verified with the flag on and off

Change-Id: Id54c7f0a76f62108d8b92a3b5e78634fff64dbef
2024-03-14 10:48:02 +00:00
Shamali P 927dd27ece Update the widget previews to use the container sizes
Additionally, adjusts the margins on sides, to make space for displaying
multiple previews side by side.

As a result of this change, previews aren't cropped anymore (indirectly
also fixing b/317366201).

There is one more follow up pending - to limit the height of
recommendations in two pane sheet to only visible area to keep the
suggestions quick to look and concise. It will also help with better
scroll experience when size is same across pages.

* http://screencast/cast/NTQ0Njc4ODgyNjc5MTkzNnxjYzZiYTU2Ny02Yw
* http://screencast/cast/NTk4ODMyMDkxOTE1ODc4NHw3NzdlNTgxZS1kMw
* http://screencast/cast/NTYxOTc5NjIxNjM4MTQ0MHxiMjQ2Njc3OC0zOQ
* http://screencast/cast/NDk4MjIxNjI0MDEzNjE5MnxjY2IwYmIxNi00Mw

Bug: 319152349
Flag: N/A
Test: Image test and table utils test
Change-Id: I07465bd4d84597b560a2b998ff1ccbf9867c0192
2024-03-12 23:47:07 +00:00
fbaron a64ce4eb71 Update min next page visible to 48dp
Fix: 326623964
Flag: NONE
Test: HomeScreenEditImageTest DeviceProfileDumpTest
Change-Id: I0a2de73589bf769eb2efb8d66d9ab3836cbee6d2
2024-03-11 22:40:40 +00:00
Shamali P 20a5f4e8d1 Update labels for the categories to match the UX writer provided strings
Also fix issue that user was not passed when getting application info.
(error noticed by Zak)
http://screen/8fiiTSHvo2SfYdE

Bug: 318410881
Flag: N/A
Test: Unit test
Change-Id: Id85feec0d95d3d4d183a673f7eed40906b0043e2
2024-03-08 19:58:23 +00:00
Zak Cohen e3e00c6e26 Merge "Widget Picker - show app icon next to recommended app label." into main 2024-02-29 21:55:37 +00:00
Jeremy Sim 164d162ec6 Merge "Update app pair error strings with UXW-approved ones" into main 2024-02-29 19:47:41 +00:00
Federico Baron 835b9610bc Merge "Update some dimens for portrait edit state" into main 2024-02-29 17:17:19 +00:00
Jakob Schneider a9338897a4 Merge "Add dedicated a11y label for archived apps." into main 2024-02-29 10:54:31 +00:00