When taskbar is in pinned mode with bubble bar expanded, in some
scenarios, we hide taskbar contents (i.e. when bubbles overlaps with
taskbar) and the scrim still shows.
One of the existing tests in TaskbarScrimViewController checks that
the scrim would be 0 when taskbar is not visible, however, in the
bubble bar case this isn't always true... I think there probably are
cases where taskbar isn't visible for other reasons (e.g. shade is
pulled down, but there are other tests specific to that). I'm
setting this test to only run when bubble bar isn't running, because
in that case bubbles never impacts taskbar visibility.
I added a test case to ensure scrim is hidden when pinned BUT bubble
bar is on home -- in this case we shouldn't show the scrim.
When adding the enableFlag/disableFlag I saw some NPEs in onDestroy
methods of some controllers so I protect against those as well.
Flag: EXEMPT test change
Test: atest NexusLauncherTest:TaskbarScrimViewControllerTest
atest NexusLauncherRoboTest:TaskbarScrimViewControllerTest
Bug: 377764181
Change-Id: I71001222aa8a4393b341dd2b43a4b2e46e617a70
- Extract newClearAllShortTotalWidthTranslation out from the last grid task visible case, to use it to predict new clearAllShortTotalWidthTranslation after focus task is staged, then use newClearAllShortTotalWidthTranslation to compensate getScrollForPage of grid tasks not on top-right corner for tasks close to clearAllButton
- Applied ag/28945919's fix to dismiss animation as well
- Fixed next focused task translation using wrong sign in RTL
Fix: 378403770
Test: With LTR/RTL, test focused task staging / dismiss with 1-6 tasks, dismiss grid end tasks with 1-6 tasks
Flag: EXEMPT BUG_FIX
Change-Id: Ie5b597c4318c5de84377fde50090491e78581af9
When modalness is >0, the user is in select mode and the icon menu is
hidden, therefore Talkback shouldn't pick it up.
Fix: 320203664
Flag: NONE bugfix
Test: Manual. Turn Talkback on, navigate to Overview, enter select mode,
select the whole TaskView, Talkback shouldn't have any accessibility
actions to execute.
Change-Id: I83dffce60f42cc32d83c499dfb08ddf97888f527
When app is in DesktopTask being split, we need to bring tasks after last desktop task to correct position during split animation. Solution is to add additional primary translation from current desktopview to first non desktopview.
Refactored how primary translation is being calculated.
Test: Manual, split app from taskbar which is in desktop window
Fix: 377230397
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Change-Id: Ic76b0e7d9a627158e5d521ed40f17279130a974a
When persistent taskbar is used, bubbles align with hotseat when
launcher state is home. But when user navigates to the -1 page or all
apps, we show the persistent taskbar instead of hotseat.
3 button navigation container shifts in this case. Apply the same shift
to bubble bar.
Bug: 376141984
Flag: com.android.wm.shell.enable_bubble_bar
Test: atest PersistentBubbleStashControllerTest
Change-Id: I2765936e0bac43a790b628e7df2a1b4ddad32cae
- Stuff related to updating internal TIS state need to also run on the
main thread
Bug: 374197142
Flag: EXEMPT bugfix
Test: Presubmit
Change-Id: Ia62b665d9a39bc4a4c119fce8538bb147d92957a
- Provide both launch and minimize animations from
DesktopAppLaunchTransition
- Add support to TaskbarRecentAppsController to check whether an app is
visible vs. minimized vs. not showing at all in Desktop Mode
- Use DesktopAppLaunchTransition when clicking a Taskbar/AllApps app
icon (when in Desktop Mode and the app is not visible) to animate the
app launch
- The animation / transition is passed to Shell through ActivityOptions
Note: this CL does not add animations for launching managed/work
profile apps. That will be handled in b/376819104.
Test: launch apps in Desktop from Taskbar/AllApps
Bug: 327428659
Flag: com.android.window.flags.enable_desktop_app_launch_transitions
Change-Id: I44be96b9c53718b2082d2f630e1921356785fc4b
Making LauncherInstrumentation optional and removing some reduntant constants.
This allows less dependency on AbstractLauncherUITest
Bug: 377772352
Test: Presubmit
Flag: EXEMPT test refactor
Change-Id: I7cf78d6acc5fef0359dee141a06fd51ff9d4f5a8
When a bubble is updated, we now suppress the animation when needed.
This prevents the animation from playing on the lock screen, when
the shade is open, when the IME is visible, etc.
Note that for new bubbles we were already suppressing the animation.
The issue fixed by this change is only observed for updated bubbles.
Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 377618253
Fixes: 377624611
Test: manual
- tap qsb or launch any app and show the keyboard
- send an update to a bubble
- observe the flyout is not appearing
- repeat with shade open and on lock screen
Change-Id: Id78e0cfbc413bcebaf6445cecacaaf34b36ed411
Shell can use the location update trigger information for logging
purposes.
Bug: 349845968
Test: manual
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I5af4375f88ea438b1aed9b3b2bd02d0c33fff53f
When a bubble is added or removed while we're collapsed, animate the
badge scale to make sure that only the badge for the top bubble is
visible.
Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 360652359
Test: manual
- add bubble while collapsed
- observe that badge only shows for top bubble
- remove bubble while collapsed
- observe that badge only shows for top bubble
Change-Id: I91472bb2ddeeeebd33ca64e20e065b2336c08589
When enough widgets are not passing the filter, additional randomly
selected widgets are added.
The count to decide whether to add more is a configuration, so that,
if some OEMs don't want any suggestions, can override the value to 0.
Bug: 356127021
Flag: com.android.launcher3.enable_tiered_widgets_by_default_in_picker
Test: Unit tests
Change-Id: Iffa8619149a1a4b468d367fc7bbee381be59469d
The OtherActivityInputConsumer inverted log was inadvertently
added in ag/28270874.
Flag: EXEMPT logs only
Bug: NA
Test: Manual
Change-Id: Iab5de4ec26bd40d18bdcdea62ec7ecb685fec6a1
This CL updates a test to verify the behaviour while swiping up from a fullscreen app to Overview and checking if that TaskView is between DesktopTasks (right side) and Grid Tasks (left side).
The test adds the following validations:
- Launches adjacent task while DesktopTask is at the center of the screen
- Swipe up from a fullscreen app to Overview to validate whether the task is between other tasks and desktop tasks.
- Fling back to DesktopTask to dismiss the adjacent focused task
Fix: 353948167
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Test: TaplTestsOverviewDesktop
Change-Id: Iaa15d4061c3b6ba8fc0d03416b4721cdf3f047c3
Treehugger Robot
Mady Mellor
Ats Jenk
Alex Chau
Uwais Ashraf
samcackett
Johannes Gallmann
Bill Yi
vinayjoglekar
Sihua Ma
Liran Binyamin
Sunny Goyal
Tracy Zhou
Gustav Sennton
Shamali P
Artsiom Mitrokhin
Jagrut Desai
Andy Wickham
Brandon Dayauon
Sukesh Ram
Schneider Victor-tulias
Jordan Silva
Riddle Hsu