Commit Graph

23356 Commits

Author SHA1 Message Date
Jordan Silva 75395e3425 Merge "Fix TaskMenuView bottom row divider and translation." into main 2025-03-07 06:12:57 -08:00
Jordan Silva 97b3389cd7 Fix split screen app chip position in portrait mode
Adjusted the secondary app chip's split translation in portrait mode to account for the divider size, ensuring correct positioning in split screen.

Fix: 314326993
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Change-Id: I39eae8b5f1ac8cff6b466cff5b6fb16f0a6e9647
2025-03-07 11:40:12 +00:00
Uwais Ashraf 270093cdcf Merge "Revert "Update Split-Screen icons with new icons."" into main 2025-03-07 03:36:59 -08:00
Jordan Silva 65aff4c6bb Fix TaskMenuView bottom row divider and translation.
Adjusts the positioning logic for the task menu when displayed for tasks on the bottom row of the grid. The changes ensure the menu is visible and does not overlap with other UI elements, such as the taskbar. It defines min and max bounds of the menu when it's opened on bottom row. It also moves the menu on top of the taskbar.

A follow-up CL will manage the max height to make the bottom row menu scrollable.

Fix: 322953749
Bug: 326952853
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewMenuImageTest
Change-Id: I44fb70d8537c0b52af4314e818d02ccfcd35d8d3
2025-03-07 11:31:20 +00:00
Jordan Silva fd066b2d7a Merge "Add app chip flag to prevent skipping settledProgress and fullscreenProgress for the current IconView." into main 2025-03-07 02:04:12 -08:00
Pechetty Sravani (xWF) 16bcecc4e8 Revert "Update Split-Screen icons with new icons."
This reverts commit 50c33f271e.

Reason for revert: <Droidmonitor created revert due to b/401425778.Will be verified through ABTD for standard investigation.>

Change-Id: Ie3d9508864f51572307f9a16ddb14dc86b9d57ad
2025-03-06 22:30:40 -08:00
Simon (Qiong) Sun 4b152d80d9 Merge "Update Split-Screen icons with new icons." into main 2025-03-06 19:09:37 -08:00
Treehugger Robot 80ffe676d1 Merge "[CD Taskbar] Remove External Taskbar's Rounded Corners" into main 2025-03-06 17:58:42 -08:00
Jorge Gil 5d3f714944 Disable multi-desks in createDesktopTaskPerDisplay test
loadTasksInBackground_freeformTask_createsDesktopTaskPerDisplay assumes
that when FLAG_ENABLE_SEPARATE_EXTERNAL_DISPLAY_TASKS is enabled, all
desktop tasks (regardless of the GroupedTaskInfo.deskId) will be grouped
into one GroupTask per display.

However, if multi-desks is enabled, this logic does not apply, and
GroupTasks are created for each desk. Given that this test uses deskId=0
with the expectation that it is an unused/invalid field when testing
FLAG_ENABLE_SEPARATE_EXTERNAL_DISPLAY_TASKS, this CL disables
FLAG_ENABLE_MULTIPLE_DESKTOPS_BACKEND to match that expectation.

Flag: com.android.window.flags.enable_multiple_desktops_backend
Flag: com.android.launcher3.enable_separate_external_display_tasks
Bug: 362720497
Test: atest NexusLauncherTests:com.android.quickstep.RecentTasksListTest
Change-Id: I88cceaa37582fdcf1a3ad4f59712abbfa7e428a8
2025-03-07 01:05:30 +00:00
Li Lin 6be6102a44 Merge "Add Growth Framework nudge payload model." into main 2025-03-06 17:03:21 -08:00
Federico Baron 0fe4d89821 Revert "Add screenrecord for testLaunchShortcut_fromTaskbarAllApps"
This reverts commit 486016efd6.

Reason for revert: issue no longer happening 

Change-Id: If1128f59808162f26cc5c32c017eda758126ea27
2025-03-06 16:36:39 -08:00
Bill Yi abe6cc4ce8 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ie19b5b66db4054578ea143d8b5ba42cab4871c19
2025-03-06 15:13:29 -08:00
Shamali P 992facdff3 Unregister widget prediction callback on clear
Noticed that predictor holds the registered callback and caused leak.
Using named listener classes for better stacks and also unregisters them

Bug: N/A
Flag: EXEMPT BUGFIX
Test: WidgetPredictionsRequesterTest
Change-Id: I94211ddbc77077c98b804827bb1cecdefe57703b
2025-03-06 14:25:13 -08:00
Jagrut Desai d5e5fca0dc Merge "Fix Taskbar not present in Desktop Mode after unlocking" into main 2025-03-06 13:18:33 -08:00
Jordan Silva 02a0119032 Add app chip flag to prevent skipping settledProgress and fullscreenProgress for the current IconView.
Bug: 398318613 
Flag: com.android.launcher3.enable_overview_icon_menu
Test: Manual
Test: systemui-thermal-throttling-3-suite
Change-Id: I96d8889752287510e760d4367b2ef981689e106d
2025-03-06 12:31:54 -08:00
Schneider Victor-Tulias aeb8831239 Fix gesture nav tutorial done button focus issue
Flag: EXEMPT bug fix
Fixes: 400888489
Test: launches and completed tutorial with and without talkback
Change-Id: I5ec1fc6b812667c79136e82a8553e4b857200cdb
2025-03-06 15:16:42 -05:00
Simon (Qiong) Sun 391a00630e Update Task Bar and Split-Screen with new font type.
The change applies new font type to Task Bar and Split-Screen if gsf is enbled.

Bug: b/393610004
Test: Check that the fonts change when gsf is enabled.
Flag: com.android.wm.shell.enable_gsf
Change-Id: I704763dc9aec26aa0a6fe6b95c054c8e563cdc16
2025-03-06 10:59:26 -08:00
Will Osborn a4e2288717 Merge "DeviceProfile refactoring for connected displays" into main 2025-03-06 10:46:44 -08:00
Simon (Qiong) Sun 50c33f271e Update Split-Screen icons with new icons.
Fix: 379959026
Test: Check that Split and save Split-Screen icons.
Flag: EXEMPT icons change
Change-Id: I0c159d083c175b560acfa33122bc2a03859f103e
2025-03-06 10:36:29 -08:00
Treehugger Robot e3d58f1ecb Merge "Fix NPE in TaplTestsQuickstep.tearDown" into main 2025-03-06 10:13:36 -08:00
Toni Barzic 200c5ee980 Don't show more apps button in KQS opened from taskbar
The button is shown when "hidden" non-desktop mode apps are open, and
KQS gets shown in desktop mode. Per UX, the button should be removed
when KQS is shown from taskbar, as taskbar overflow bubble.

Bug: 399860396
Test: Open apps in fullscreen, switch to desktop mode, open enough apps
     for taskbar to enter overflow, tap taskbar overflow icon, verify
     that the overflow bubble does not show "X more apps" button.
     Separately, press Alt+Tab, and verify the button gets shown.
Flag: com.android.launcher3.taskbar_overflow
Change-Id: Ic4050b1b29fe22a1e0d2be661acfca18561b4ed1
2025-03-06 17:16:10 +00:00
Schneider Victor-Tulias 07dd9944f3 Fix NPE in TaplTestsQuickstep.tearDown
Fixing NPW caused by ag/31415696. The recents view container can be null in tearDown

Flag: EXEMPT test fix
Fixes: 399657343
Test: TaplTestsQuickstep
Change-Id: I3665fc4bc131b90b22f43282f0c4e9e1188d0eb4
2025-03-06 11:07:07 -05:00
Will Osborn 787dcec135 DeviceProfile refactoring for connected displays
Test: locally tested on Tangor
Flag: com.android.launcher3.enable_overview_on_connected_displays
Bug: 392858637
Change-Id: I0f45710eb60c7ea3359153c7961461532fec8e97
2025-03-06 14:33:00 +00:00
Treehugger Robot 872ef49247 Merge "Add TaskContentView parent to TaskThumbnailViewHeader and TTV" into main 2025-03-06 03:37:25 -08:00
Alex Chau d81a7835ac Merge "Update live tile's pivot when ReccentsView's pivot is updated" into main 2025-03-06 03:29:39 -08:00
Sergey Pinkevich f3ea2ed42c Merge "Change launch change requirement within DesktopAppLaunchAnimatorHelper" into main 2025-03-05 23:55:30 -08:00
Jagrut Desai bf0727b60d Fix Taskbar not present in Desktop Mode after unlocking
The problem: with taskbar animation for Desktop mode we were checking, if we are already in DW then don't recreate taskbar. This was put in as condition so where DisplayController Info change we don't recreate twice. first being from transilition listerners and second being form info change in display controller.

The solution: Ignore the info change listener when there is already ongoing recreation is in progress.

Test: Presubmit
Bug: 399826787
Flag: EXEMPT bugfix

Change-Id: Ib86e79b3b4c86e515e44d1d1dd7ca98ed694c365
2025-03-05 18:58:38 -08:00
Sukesh Ram 850179005f [CD Taskbar] Remove External Taskbar's Rounded Corners
Remove Taskbar's Rounded Corners for External Display.

Flag: com.android.window.flags.enable_taskbar_connected_displays
Bug: 400799093
Test: Manual
Change-Id: I6808850647cd4136aae23de13fa54ecaba3c1025
2025-03-05 15:14:56 -08:00
Li Lin ebb8fe35bb Add Growth Framework nudge payload model.
This model will be used to drive Growth Framework nudge rendering and
behavior in follow up CL.

More details at: go/al-growth-framework-nudge

Test: Manual
Bug: 398026145
Flag: EXEMPT add separately
Change-Id: Icfd53f2587fe7b184f21f7e180c795bd6f586040
2025-03-05 15:14:54 -08:00
Treehugger Robot 7a7a92999c Merge "Making ActivityContext extend SavedStateRegistryOwner" into main 2025-03-05 11:44:19 -08:00
Liran Binyamin 6b18e3811d Handle bubble bar drag and bubble drag to fullscreen
This change wires bubble bar dragging as well as bubble dragging to
full screen behind a flag. Note that when the bubble is dragged to
full screen we remove the bubble from the bubble bar and notify
sysui but on the sysui side the bubble doesn't yet get converted.

Flag: com.android.wm.shell.enable_bubble_to_fullscreen
Bug: 388858013
Test: manual
       - with flag off
         - verify existing dragging works
       - with flag on
         - verify bubble bar can be dragged across
         - verify bubble is removed when bubble dragged to full screen zone
Change-Id: I9e4d8ee3d2ba9dffff3dd4ba91dfce1a5c723d68
2025-03-05 10:04:58 -08:00
Wen-Chien Wang 3c74827da7 Adds tests for popup menu
This cl creates some basic tests for popup menu on hotseat items
and recent tasks.

Bug: 3446576299
Test: The cl itself is for tests
Flag: EXEMPT adding test
Change-Id: I872078969d9c3d20b5bf47a43cd8e3c940dd4d8f
2025-03-05 10:03:47 -08:00
Mykola Podolian e5c9aadf2c Merge "Added logic to show the shell drop target and update the bubble location" into main 2025-03-05 09:24:38 -08:00
Sunny Goyal 84e0e6a188 Making ActivityContext extend SavedStateRegistryOwner
Bug: 390572144
Test: Presubmit
Flag: EXEMPT refactor

Change-Id: I8272e95a8d2da95b3c93ec616fdf877b89db5b26
2025-03-05 09:22:47 -08:00
Sergey Pinkevich fe17dd475b Change launch change requirement within DesktopAppLaunchAnimatorHelper
Add freeform check and update logs

Return early instead of crashing if a launch change is not available

Bug: 395495925
Flag: NONE only adding logs, not change of actual code
Test: DesktopAppLaunchAnimatorHelperTest

Change-Id: I0d51c563a26e7d6020222cb84757e0ea8d561d69
2025-03-05 16:23:18 +00:00
Will Osborn 19bdf47a31 Merge "Make separate dependency scopes and graphs for different RecentsViews" into main 2025-03-05 07:29:04 -08:00
Treehugger Robot 806a9f1368 Merge "Use the safe getDisplayId() API when building the recents desktop task list." into main 2025-03-05 05:30:51 -08:00
Liran Binyamin d3a0c94067 Merge "Wire up bubble dragging to DropTargetManager" into main 2025-03-05 04:18:18 -08:00
Alex Chau d2c77361a2 Update live tile's pivot when ReccentsView's pivot is updated
Fix: 397890144
Test: App to Overview, check live tile animation in 1) swipe up from bottom 2) Dismiss 3) Task launching
Flag: com.android.launcher3.enable_grid_only_overview
Change-Id: I143d8ca241505ab2f45c49348dc41885b364b859
2025-03-05 12:14:06 +00:00
Vania Desmonda 0d3cc4e75a Use the safe getDisplayId() API when building the recents desktop task list.
This avoids using -1 as the task's display ID and use the default
display ID instead.

In `TaskbarRecentAppsController#reloadRecentTasksIfNeeded()`, it filters
the first DesktopTask instance from allRecentsTask. Previously, the list
is built as nested lists with the same deskId = -1. This causes the
taskbar to show the running/minimized desktop apps incorrectly.

Fixes: 399859320
Fixes: 397956083
Flag: EXEMPT minor bug fix
Test: manual testing
Change-Id: Ie0a8817fc44dab69523547c79a6dfbcaef25ec20
2025-03-05 03:28:34 -08:00
Will Osborn 074a605827 Make separate dependency scopes and graphs for different RecentsViews
Test: locally tested on Tangor
Flag: EXEMPT - bugfix
Bug: 399364544

Change-Id: I788c5644f198ead206bb7512ec96eab838e51cdb
2025-03-05 10:56:25 +00:00
wilsonshih 6c6d51f0ed Remove DepartingAnimationTarget from BackMotionEvent(2/2)
This would create another SurfaceControl object through IPC, which is
unnecessary because the animation should run through
BackAnimationRunner.

Flag: EXEMPT bugfix
Bug: 395035430
Test: execute back-to-home transition several times, verify no
predict_back animation leash left in offscreen layer.

Change-Id: I96176100fb28c24a635415799e0ed7a590ee8250
2025-03-05 18:15:49 +08:00
Treehugger Robot 325545ac2f Merge "Allow recent task to have long-press menu" into main 2025-03-04 20:11:42 -08:00
Treehugger Robot 57cab7794a Merge "Simplifying some view iteration methods" into main 2025-03-04 18:42:06 -08:00
Treehugger Robot 14eec9f1fc Merge "Spring neighboring tasks into place on task reflow after dismiss." into main 2025-03-04 18:14:33 -08:00
Treehugger Robot 15049ba552 Merge "Fix issue where tasks were not reliably marked as Perceptible" into main 2025-03-04 17:39:13 -08:00
Treehugger Robot 9b775dfdac Merge "Check horizontal touch slop for non-vertical flings" into main 2025-03-04 17:29:35 -08:00
mpodolian 132c99e4dd Added logic to show the shell drop target and update the bubble location
This change leverages a bubble bar location parameter when an app icon
is dropped and displays the shell expanded view drop target when an icon
is dragged over the bubble bar drop zone.

Fixes: 397459664
Flag: com.android.wm.shell.enable_create_any_bubble
Test: Manual.
Drag a taskbar app icon to the same side as the bubble bar. Confirm that
the expanded view from shell is displayed.
Continue dragging to the opposite side of the bubble bar location drop
zone. Confirm that the expanded view drop target is displayed on the
opposite side.
Release the dragged icon in the drop zone. Confirm that the bubble bar
expands at the new location.

Change-Id: I956d66b81810abce074b10e012cf5c873003d84c
2025-03-04 16:44:37 -08:00
Wen-Chien Wang 5ada92b966 Allow recent task to have long-press menu
Bug: 375648361
Bug: 344657629
Test: Manual, Recording uploaded to buganizer
Flag: com.android.launcher3.enable_pinning_app_with_context_menu

Change-Id: If496c56a3fe47905a3e9947407f51077f180d5a2
2025-03-04 21:47:32 +00:00
Jagrut Desai f26460f852 Merge "Support launching minimized task into desktop" into main 2025-03-04 12:51:18 -08:00