Commit Graph

23356 Commits

Author SHA1 Message Date
Randy Pfohl 0678d08e87 Merge "Move flags to desktopmodeflag" into main 2025-03-10 14:50:38 -07:00
Sunny Goyal 42975c39db Making various model objects injectable
Bug: 361850561
Test: Updated tests
Flag: EXEMPT dagger
Change-Id: Ibb45b72c186e6aeeed7a37b0ae3f8083472019d7
2025-03-10 14:37:43 -07:00
Ahmed Fakhry 30d39caacb Merge "Propagate desks changes" into main 2025-03-10 14:06:52 -07:00
Sukesh Ram c166a373a9 [CD Taskbar] Make External Taskbar 3-Button & Persistent
The gesture handle still persists in conjunction with the three buttons. In addition to being forced into three button mode, the taskbar on external displays needs to never enter transient mode. More info and before/after images on bug.

Flag: com.android.window.flags.enable_taskbar_connected_displays
Bug: 399718805
Test: Manual
Change-Id: Iff5c297c8ac4823fa24e7a8e4becd0447224cac0
2025-03-10 13:58:21 -07:00
Mykola Podolian 595433f1eb Merge "Fixing NPE caused by postponed action relaying on controllers." into main 2025-03-10 13:38:08 -07:00
Jon Miranda d6b9eff743 Check for isAttachedToWindow before dispatching touch event
Otherwise we get an IllegalStateException

Fixes: 380318615
Test: repos in production
Flag: EXEMPT bugfix
Change-Id: Id72b76ab288f40ee50ba8485d4b0636c525e22e3
2025-03-10 13:10:53 -07:00
Treehugger Robot a6533ae04b Merge "Improve KQS accessibility" into main 2025-03-10 12:49:00 -07:00
Treehugger Robot a4fc3ad45d Merge "Introducing a wrapper over binder to simplify lifecycle management for IPC" into main 2025-03-10 12:46:34 -07:00
Brian Isganitis dfdab91337 Fix layout transition crash for phone with QSB inline.
Phone can now have QSB inline when in landscape. Need to adjust layout
transition initialization to reflect that.

Flag: com.android.window.flags.enable_taskbar_recents_layout_transition
Bug: 343521765
Test: go/testedequals
Change-Id: I9f0b61108170188da1a37b99c9e1411da6b71946
2025-03-10 15:21:13 -04:00
Randy Pfohl d94ca57547 Move flags to desktopmodeflag
Flag: com.android.launcher3.enable_fallback_overview_in_window
Flag: com.android.launcher3.enable_launcher_overview_in_window
Flag: com.android.launcher3.enable_state_manager_proto_log
Flag: com.android.launcher3.enable_recents_window_proto_log

Test: built and ran locally with flags on and off

Bug: b/401073215
Bug: b/401073401
Bug: b/401075030
Bug: b/401076625

Change-Id: I1bd2822d20f677445610b912dd82ff160bff4143
2025-03-10 19:08:55 +00:00
Jordan Silva 298ed152f3 Fix TaskMenuView to calculate bottom menu's max height
Fix: 402145575
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewMenuImageTest
Change-Id: I9cc02ea501bb599e8ec614912389b04130552089
2025-03-10 11:25:10 -07:00
Simon (Qiong) Sun ebdcf7ba8a Merge "Update Task Bar and Split-Screen with new font type." into main 2025-03-10 11:09:58 -07:00
Ahmed Fakhry 6a19fc0765 Propagate desks changes
This CL propagates desk changes events to `RecentTasksList` and
`RecentsView`.

Bug: 395908683
Test: m
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Change-Id: I77457d5e2e66166dd8c7d6505317d9add5b886a2
2025-03-10 18:06:03 +00:00
Shamali Patwa af883adedc Merge changes from topic "flags-cleanup" into main
* changes:
  [Part 3] Clean up references for flags from past release.
  [Part 2] Clean up references for flags from past release.
  [Part 1] Clean up references to flags from past release.
2025-03-10 10:54:42 -07:00
Toni Barzic 394d5e0010 Improve KQS accessibility
Adds accessible pane name, and content description for keyboard quick
switch view. Improves content description for task views, by having it
provide the task position in the task list. Also, sets a task content
description immediately when it gets associated with a task, even if the
task description is not available at the time. Accessibility focus for a
task may be requested as the KQS view is shown, so the task view should
have a meaningful content description from the start.

While here, update KQS to focus first task  by default when opened from
taskbar.

Bug: 399032757
Test: Manual, with Talkback enabled - open KQS via taskbar overflow view,
      and Alt+Tab, and verify Talkback announcements are informative
      (e.g. no "Pixel launcher" utterance).
      Also atest NexusLauncherTests:TaplTestsKeyboardQuickSwitch
Flag: EXEMPT bug fix

Change-Id: I3688954ab383035c1db35c5eb7a0ddf9a39a123f
2025-03-10 17:35:04 +00:00
Sunny Goyal 018356d3c3 Introducing a wrapper over binder to simplify lifecycle management for IPC
Fix: 400733213
Flag: NONE - release code
Test: manual
Change-Id: I5e143fce6a4cbc1dbb246bc6e0141ebbbc8bd274
2025-03-10 10:27:58 -07:00
Sebastián Franco 0d8df93275 Merge "Sync landscape rotation with Overview rotation" into main 2025-03-10 09:30:11 -07:00
mpodolian c7390ce4e3 Fixing NPE caused by postponed action relaying on controllers.
This change addresses a NullPointerException (NPE) caused by a postponed
action that relied on controllers. Logic has been added to verify the
availability of controllers prior to checking bubble bar visibility.
Additionally, the destruction sequence of LauncherTaskbarUIController
has been modified: the DeviceProfileListener is now unregistered before
the controller reference is cleared.

Fixes: 396336136
Test: N/A
Flag: EXEMPT bugfix
Change-Id: I1a7f716b3ad0dd4f8431773ea447b95ade4d87ef
2025-03-10 09:29:33 -07:00
Massimo Carli 156b9b3184 Consider userId in transparent policy heuristic
Flag: com.android.window.flags.enable_modals_fullscreen_with_permission
Bug: 401583497
Test: atest NexusLauncherTests:com.android.quickstep.DesktopSystemShortcutTest
Test: atest NexusLauncherTests:com.android.quickstep.ExternalDisplaySystemShortcutTest

Change-Id: Ife36b3a7e2ba0376cf72ca545fa05c5a90d52f07
2025-03-10 14:30:43 +00:00
Alex Chau 2642bfb210 Merge "Check before casting to TaskMenuView on rotation" into main 2025-03-10 06:57:59 -07:00
Uwais Ashraf 6b44fe4432 Merge "Move overlay setup functionality to TaskView/Container" into main 2025-03-08 15:55:41 -08:00
Uwais Ashraf 33c6559d41 Move overlay setup functionality to TaskView/Container
Bug: 395294954
Bug: 396064850
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Perfetto trace comparison
Test: OverviewDesktopTaskImageTest
Change-Id: I69ac43350b261532a47f7989848a650ae8a70e9a
2025-03-08 13:49:23 +00:00
Treehugger Robot 6721777d9d Merge "Fix task menu height calculation for bottom row handling." into main 2025-03-08 05:13:19 -08:00
Liran Binyamin a5c9d86e1d Merge "Address flakes in BubbleBarViewAnimatorTest" into main 2025-03-07 18:17:59 -08:00
Treehugger Robot 9a993d2b9d Merge "pin-shortcut: Implements the actual pinning functionality" into main 2025-03-07 18:09:10 -08:00
Artsiom Mitrokhin b673fbf897 Merge "Update taskbar overflow view to match the spec" into main 2025-03-07 18:06:50 -08:00
Treehugger Robot bac3844525 Merge "Adds tests for popup menu" into main 2025-03-07 17:40:46 -08:00
Brian Isganitis 0dc5fac084 Merge "Animate changes in Taskbar recents indicators." into main 2025-03-07 14:47:08 -08:00
Liran Binyamin c2edd1c79a Address flakes in BubbleBarViewAnimatorTest
- Fix some mockito issue by using a fake implementation rather
   than a mock.
 - Return early in the bubble bar animation if there's no animating
   bubble. The issue here is that the scaleY property of the bubble
   bar is set to 1 when the animation is interrupted. However, in
   the test environment, the cancellation of the animator is posted
   to a different thread, and another animation frame is running
   after the scaleY was already reset to 1.

Flag: EXEMPT test only
Test: atest BubbleBarViewAnimatorTest
Bug: 399934422
Bug: 399720438
Change-Id: I271f670c50168237aeaf867c8171ae3023ee09ff
2025-03-07 14:13:31 -08:00
Jordan Silva aacd9295fd Fix task menu height calculation for bottom row handling.
Adjust the max height calculation logic in on measure to use a different translationY for the bottom row menus. The bottom row menu animates translating up to show more items. Thus, we use the min translationY accepted for the menu to calculate its max height size.

Fix: 326952853
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewMenuImageTest
Change-Id: I0b32c16e020033feccbfeef8f96c196d193ac0cb
2025-03-07 14:06:57 -08:00
Li Lin 0f02bd269a Add skeleton Growth Framework nudge controller.
Bug: 398033012
Test: Manual
Flag: EXEMPT add separately
Change-Id: I682c723efc935737403678c84da94ee9ee63db27
2025-03-07 13:40:49 -08:00
Dave Mankoff 7c06fbd2fe Merge "Nullability fixes for Kotlin 2.1" into main 2025-03-07 13:31:39 -08:00
Brian Isganitis 26f9468db1 Animate changes in Taskbar recents indicators.
Flag: com.android.window.flags.enable_taskbar_recents_layout_transition
Fix: 356394053
Test: go/testedequals
Change-Id: Ic018695254bbfea11469c3579e242089b00b90f5
2025-03-07 15:47:48 -05:00
Treehugger Robot 522a869e01 Merge "Show screenshot and select in task menu" into main 2025-03-07 12:28:33 -08:00
Treehugger Robot 8800f6d068 Merge "Fix RTL menu position for icon app chip." into main 2025-03-07 11:52:17 -08:00
Sebastian Franco 0e0fffd81c Sync landscape rotation with Overview rotation
Bug: 390487996
Test: NA
Flag: com.android.launcher3.one_grid_specs
Change-Id: Ib564c21befd06edd5c720fe33f36780761035fee
2025-03-07 11:48:43 -08:00
Treehugger Robot b6001773da Merge "desktop-exploded-view: Launch desktop task view should reverse its exploded animation" into main 2025-03-07 11:45:18 -08:00
Treehugger Robot b1489ad9f3 Merge "Revert "Add screenrecord for testLaunchShortcut_fromTaskbarAllApps"" into main 2025-03-07 11:03:38 -08:00
Treehugger Robot 9cc284aa17 Merge "Don't show more apps button in KQS opened from taskbar" into main 2025-03-07 10:39:05 -08:00
Jordan Silva cccec098e8 Merge "Fix split screen app chip position in portrait mode" into main 2025-03-07 09:50:52 -08:00
Treehugger Robot 6b9b5b54c4 Merge "Fix gesture nav tutorial done button focus issue" into main 2025-03-07 09:45:42 -08:00
Jordan Silva 59e6fd541a Fix RTL menu position for icon app chip.
Changed the gravity of the task menu layout parameters from `START` to `LEFT` because `sTempRect.left` measures left distance, not start distance. This ensures correct positioning, particularly in Right-to-Left (RTL) layouts where `START` may align to the left instead of right, according to search result.

Fix: 400867857
Flag: EXEMPT BUG_FIX
Test: Manual. Using RTL and app chip, expands the app chip menu.
Change-Id: Ia3165563c2f87cf7f2d17eee554386d96f30860b
2025-03-07 09:45:40 -08:00
Xiaoqian Dai 3dfd8bb2b5 desktop-exploded-view: Launch desktop task view should reverse its
exploded animation

Following CLs will support launching individual task window in the
desktop task view.

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug: 353948437
Change-Id: I5d084a7d8b231522bf5db1704cee1d6124affc22
2025-03-07 17:40:14 +00:00
Bill Yi 3fb19185de Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2025-03-07 09:18:51 -08:00
Alex Chau df7bb7966c Check before casting to TaskMenuView on rotation
- Added a instanceof check to avoid ClassCastException

Fix: 400957867
Flag: EXEMPT BUG_FIX
Test: manual testing rotation on phone and tablet
Change-Id: I2b094fdca4f380128b50d5086548cbac3ef09bf4
2025-03-07 16:55:06 +00:00
samcackett 0946c8c123 Show screenshot and select in task menu
Hide screenshot and select from menu if thumbnail is null

Bug: 383662632
Flag: com.android.launcher3.enable_show_enabled_shortcuts_in_accessibility_menu
Test: OverviewMenuImageTest & manual. See bug.
Change-Id: Idf41de7e36b63f7bcc8639f5f3932a61e56ebfcd
2025-03-07 08:41:41 -08:00
Jorge Gil cf40e5607a Merge "Disable multi-desks in createDesktopTaskPerDisplay test" into main 2025-03-07 08:26:28 -08:00
Liran Binyamin fd1cb45975 Merge "Handle bubble bar drag and bubble drag to fullscreen" into main 2025-03-07 08:11:24 -08:00
Artsiom Mitrokhin dcf37ce078 Update taskbar overflow view to match the spec
This includes:
1) updating the color token used in dark mode,
2) adjusting sizes of individual app icons and their strokes.

See screenshots in http://b/383556682#comment7.

Bug: 383556682, 380386440
Flag: com.android.launcher3.taskbar_overflow
Test: manual
Change-Id: Ia05d803c5602552ce4f3e4675411b281107ac843
2025-03-07 10:38:37 -05:00
Dave Mankoff 9768fba0b0 Nullability fixes for Kotlin 2.1
Bug: 399463072
Flag: EXEMPT minor refactor
Tests: presubmits
Change-Id: I758a7ba2d62d2f096f1ceb775ee3f23275dd1c53
2025-03-07 15:28:37 +00:00