This CL will fix the issue when the app chip is bigger than the TaskView and doesn't respect its maxWidth value.
Also fixes the bug when the first chip expands when taps over the second app chip.
Fix: 406225230
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Change-Id: Id1c806a320522e6d5bda3d4d8712a43637c57834
- Move the logic to query for focused displayId from
OverviewCommandHelper to TouchInteractionService.
- This way the OverviewCommandHelper code always uses command.displayId
in its code.
Bug: 404757863
Test: manual run CUJ
Flag: com.android.launcher3.enable_alt_tab_kqs_on_connected_displays
Change-Id: Ia9b05e64b549895f029bc5204169cf84474af125
- With com.android.window.flags.enable_task_stack_observer_in_shell
enabled, the correct task visibilty is reported to TTT, which in
combination with the incomplete TaskStackListener signals results
in tasks being reported as visible when they shouldn't be. This is
most apparent when the top task is excluded from recents, which
results in us attempting to pull the next visible non-excluded task
to show as the current running task (resulting in the live tile/
thumbnail being shown on the wrong task).
Instead, we're expanding the workaround behavior to also check for
any fullscreen task that fills its parent (ie. is not transparent)
and using that as a signal to reset the visiblity of tasks behind it.
Bug: 390564114
Flag: EXEMPT bugfix
Test: Manual, expand PIP above another task and ensure that the other
task's visibility (as reporting in TTT) is invisible if the
expanded PIP task occludes it
Change-Id: Ieaa5460c2671d91f30b75aaf5317ab5ddb42315b
These resources changes will be used in a follow up CL that implement
the nudge view.
Note that most of the values and layout are temporarily placeholder and subject
to change in follow up CL as the mock is being finalized.
Bug: 398033012
Test: Manual
Flag: com.android.launcher3.enable_growth_nudge
Change-Id: I1d88da404637200b44bd2a3a5719f52d68011fbf
With this change, we can now using long-press menu to pin a single
task to the taskbar.
Note that some of the code in this cl is filtered by the flag.
Bug: 375648361
Test: Adding in the next cl
Flag: com.android.launcher3.enable_pinning_app_with_context_menu
Change-Id: Id0f2a9dce03a6c94da2cf8bd0deffd4c48656a7a
The flag will be applied at the code using this use case.
Bug: 405974619
Fix: 405974619
Flag: com.android.launcher3.enable_refactor_digital_wellbeing_toast
Test: GetRemainingAppTimerDurationUseCaseTest
Change-Id: I939b3447b93e7e84eb69032aa0f67c1629f916c1
The usage of this chain will be flagged
Bug: 405359454
Fix: 405359454
Flag: com.android.launcher3.enable_refactor_digital_wellbeing_toast
Test: AppTimersRepositoryTest
Change-Id: Ife0db79175dd30982a0cb179369a3cea470ef7ba
This is a follow up to ag/32333172. With that change, task thumbnails
are immediately placed in the exploded position and then transformed
into the intermediate positions/sizes that is controlled by the explode
progress.
This CL fixes a glitch where thumbnailView.outlineBounds was not
computed properly. The bounds are now computed per frame (since the task
may animate in from a position that is partially off-screen). The
intersection with the screen bounds rectangle is now done with the
per-frame position of the task window and then crucially scaled to
account for the transformation that is applied to the thumbnail itself.
Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
BUG=399822967
Change-Id: I66d6d9f662f0e70e86ea1befcec4c43d2434fb35
This can happen because when callback is ran after onDestroy.
We call the runnable as part of the cleanup process to avoid
a leak.
Bug: 319162553
Fixes: 405316024
Test: Launch an app, note the two animations are synced
Verified by locally introducing a startDelay (since otherwise it is hard to tell)
Flag: com.android.launcher3.sync_app_launch_with_taskbar_stash
Change-Id: I961b9a185b2751a8a908d1a7b2cbfdb8bfe0b8f9
The taskbar shown on freeform display taskbar when
enable_desktop_taskbar_on_freeform_displays feature is enabled is
expected to remain in persistent taskbar state (and never
transition to transient taskbar). Given that transitions to transient
taskbar is not expected, use actual peristent taskbar sizing to layout
the taskbar in this case (similar to three-button navigation taskbar).
Bug: 390665752
Flag: com.android.window.flags.enable_desktop_taskbar_on_freeform_displays
Test: manual on desktop device - keep opening apps in desktop mode, and
verify that taskbar does not enter overflow based on transient
taskbar icon dimensions (i.e. that taskbar keeps filling up until
it hits intended horizontal margins)
Change-Id: If6cdadccf0fe4da1462b437a13def78f6050e3bb
This change will prevent the split menu and app chip translation when in Fake Landscape and Fake Seascape.
Fix: 406239562
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Test: OverviewMenuImageTest
Test: Manual. Instructions in the bug.
Change-Id: Id4aade8ce15cc51e81d5b1b7a82597924cdce7ca
- Consolidates the two TextViews (collapsed and expanded) in `IconAppChipView` into a single `appTitle` TextView.
- Updates the app name's width based on the current chip status (expanded/collapsed)
- Removes the `icon_text_collapsed` and `icon_text_expanded` from layout and uses only `icon_title`.
- Adds marquee support to handle text ellipsis in the collapsed state.
- Refactors text width calculation for collapsed state to take into account maximum available width.
- Updates text animations to use the new `appTitle`.
- Updates the maximum width to not be set to less than the min width.
Bug: 403193877
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Change-Id: Ic82790d0a79b65adb7ba14dad7848748cd568f62
Update usages of TaskbarActivityContext.inDesktopMode to account for a
possibility of a desktop flavour taskbar (i.e. pinned taskbar that
shows desktop tasks) being shown outside desktop mode, which may be the
case on freeform displays (e.g. when
enable_desktop_taskbar_on_freeform_displays feature is enabled, or on
home). Tasks launched from this taskbar should preferably be launched
into desktop mode.
Bug: 390665752
Flag: com.android.window.flags.enable_desktop_taskbar_on_freeform_displays
Test: manual on desktop device. verify correct taskbar is shown
on home screen, in overview, in desktop mode, with fullscreen
app shown. Verify opening/launching apps from taskbar works
as expected.
Change-Id: I8f198216d84fd165c2dcbf437c82e418e5c7405e
- the recents view container's root view can be null, which is valid with the flag enabled
- The taskbar is now also present in 1P with flag enabled
Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/postsubmit
Change-Id: I4d822a8ea20cc7a28d7a703acbf9b589aa18593e
This prevents old scopes still being active when new TaskView state emissions are being sent to main. They were previously cancelled in time but still result in empty continuations occuring on main.
Bug: 395294954
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Manual - checking perfetto traces
Change-Id: I539a6fde8c9315ceeac74c9bf622d1e2dca1403a
Surface reparenting was happening on every frame since we call
applyDepthAndBlur on each frame during animation. Instead we can do it
only when base surface is set. mBlurSurface should always be parented to
mBaseSurface so no point in calling it again and again.
Relative layer changes only when we either draw above or recents. While
drawing above recents, mBaseSurface relative layer should be used.
mBaseSurfaceOverride otherwise. No point to call this during animation.
Added perfetto traces comparison home->all apps, alongwith all other
generic overview scenarios which possibly could have caused jank is
added here:
https://drive.google.com/drive/folders/146K_4WLaOGQcZ1gsuhCFlOCzfZ-mJBw8?resourcekey=0-r1-NnNtYGH88d8DGEvnXZg&usp=sharing
Bug: 404647629
Test: Manual. Enter overview from Desktop tile / home.
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I9dae7c5ece37e51664d82c680ea247f89bb5664b
We were checking whether recents is visible or not while opening all
apps and calling RecentsView#reset. Since Recents is not visible, we
were always calling reset which was making additional blur. Adding check
here of what current state is, will reduce these calls.
Added perfetto traces comparison here
https://drive.google.com/drive/folders/146K_4WLaOGQcZ1gsuhCFlOCzfZ-mJBw8?resourcekey=0-r1-NnNtYGH88d8DGEvnXZg&usp=sharing
Bug: 404647629
Test: Manual. Launcher home -> all apps.
Flag: EXEMPT bugfix
Change-Id: If0e31638adee50d36974abd7a4c809e3747f37a0
This reverts commit adb3bf5a8d.
Reason for revert: Likely culprit for b/406159877 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.
Change-Id: I9bad89e9ffa082bc8a1505e699048a7739aaf24d
This fixes an issue with the desktop task view unexpectedly jumping
first to the right, and then back to the left. See the bug for more
information.
Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug=399822967
Change-Id: I3713b20effa2a7f25ca04ed83ed524772d23ca2f
Remove the wallpaper task and tasks below from
`TopTaskTracker.getCachedTopTask` thus the empty task can be
really empty.
Also update the usage of the cached top task to avoid crash
because it can be empty now.
Bug: 402218420
Flag: EXEMPT refactor
Test: m
Change-Id: I15835ec3bf84b9ea5b6b2aba731f9f5b8a17353f
Treehugger Robot
Jordan Silva
Ajinkya Chalke
Li Lin
Bill Yi
Vinay Joglekar
Winson Chung
Wen-Chien Wang
Shamali P
Daniel Andersson
Jon Miranda
Jagrut Desai
Toni Barzic
Priyanka Advani (xWF)
Schneider Victor-Tulias
Brian Isganitis
Uwais Ashraf
Pat Manning
Alex Chau
Chaitanya Cheemala (xWF)
minch