Commit Graph

23227 Commits

Author SHA1 Message Date
Jonathan Miranda f496ea4634 Revert "Fix bug where double swipe gets us stuck in Hint state while in Overview."
This reverts commit a8c08584a7.

Reason for revert: "caused a regression with quick switch from home: if you start the gesture then swipe back to the left, it ends up launching the task anyway"

Change-Id: I8e12e2de46b6fc6a3faeb0336762da08080c61d6
2020-07-29 19:03:29 +00:00
Jon Miranda a8c08584a7 Fix bug where double swipe gets us stuck in Hint state while in Overview.
With the second swipe, we never complete the swipe to Overview

NoButtonNavbarToOverviewTouchController#maybeSwipeInteractionToOverviewComplete
- mReachedOverview = true
- mDetector.isSettlingState = false

And then the second swipe starts the state transition to Hint but then
it never gets completed because:
1. The animation starts
2. Gets cancelled
3. Starts again
4. Finishes, but is not marked as success since the cancel in #2 was never
   set back to false

Bug: 160759508
Change-Id: I8c3972e6209c3d5a4a0bdd9f9b7683de18105d57
2020-07-20 10:29:29 -07:00
TreeHugger Robot dbca5a4190 Merge "Notify TaskViews of updated orientation state" into ub-launcher3-rvc-qpr-dev 2020-07-17 23:31:54 +00:00
TreeHugger Robot 9ad6b3011c Merge "Persist prediction cache on every update" into ub-launcher3-rvc-qpr-dev 2020-07-17 19:48:40 +00:00
Tracy Zhou 011fa1bac1 Merge "Infinite loop when migrating calendar widget" into ub-launcher3-rvc-dev am: 8c46b20958
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12151323

Change-Id: Ifc101b5e4b76976cb835d3d0210320fe332ff323
2020-07-17 19:20:37 +00:00
TreeHugger Robot 297b64fad5 Merge "Calculate all apps cell height based on actual sizes." into ub-launcher3-rvc-dev am: 2a22f3686d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12153143

Change-Id: I426249f3d22465128990514f45354cd74f6114f2
2020-07-17 19:20:32 +00:00
Tracy Zhou a1d5ebefbf Improve grid preview performance am: b023873bc3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12153148

Change-Id: I00c2cee5ddcbd27201de2043408109e553c3434b
2020-07-17 19:20:26 +00:00
Sunny Goyal 41be7aef51 Fixing swiping up on home interrupting animation am: 369501d8aa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12152001

Change-Id: I5f41916fb2fa2fcf90979bb9c0a593fb7264b551
2020-07-17 19:20:21 +00:00
Sunny Goyal 7d9c18392d Merge "Preventing disambiguation screen when swiping up" into ub-launcher3-rvc-dev am: c031040a2f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12141301

Change-Id: I59ec7dd9e689d4f3a712364a74f341d730f00f8e
2020-07-17 19:20:16 +00:00
Bill Yi 66b33c2fdf [automerger skipped] Import translations. DO NOT MERGE am: bda86377d5 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12140156

Change-Id: I98d84d8f50aafd90a7761c828b3a0261e380e2f7
2020-07-17 19:20:11 +00:00
TreeHugger Robot adc7b6780b [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into ub-launcher3-rvc-dev am: c8a69873dc -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12130602

Change-Id: I5c1016161eb01f600045e8425d10729cb3b764e9
2020-07-17 19:20:05 +00:00
Bill Yi 11f740d013 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 6adc72a4ca -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12131831

Change-Id: I917a8ab94be0752df9e734329528368df541c81b
2020-07-17 19:19:59 +00:00
TreeHugger Robot 5c4e41e69b [automerger skipped] Merge "Import translations. DO NOT MERGE" into ub-launcher3-rvc-dev am: d524036b24 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12118863

Change-Id: I3cafeacb013ffef35f17753cd3cc503944af7cea
2020-07-17 19:19:51 +00:00
Bill Yi 4d6b234c04 [automerger skipped] Import translations. DO NOT MERGE am: 812f466f48 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12118569

Change-Id: I13ca6f3a8098a48b6add131983ac9e892c33633f
2020-07-17 19:19:45 +00:00
TreeHugger Robot 21ff5c4ff0 Merge "Persist prediction cache on every update" into ub-launcher3-rvc-dev am: 1cc0010eba
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12077679

Change-Id: I5f2cbe314dfb249594a2dff70cda5188cad60fa1
2020-07-17 19:19:40 +00:00
Sunny Goyal 1e068bc2da [automerger skipped] Fixing recents orientation (when home rotation is allowed) during swipe-up am: 141c231d2f -s ours
am skip reason: Change-Id I27be09febcdb6f19687469db34b002ce682aa0cb with SHA-1 12f46d521a is in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12039320

Change-Id: I48c9c9316f74997ef331790de1c6fe52e3155702
2020-07-17 19:19:27 +00:00
Tracy Zhou 8c46b20958 Merge "Infinite loop when migrating calendar widget" into ub-launcher3-rvc-dev 2020-07-17 19:11:51 +00:00
Sunny Goyal 56cc3a4aaa Persist prediction cache on every update
Test: Manual
Bug: 160058750
Change-Id: Icb0b7322b7f9754d3f1c3012e1c98a760f83c787
(cherry picked from commit 451b09ea75)
2020-07-17 19:10:47 +00:00
TreeHugger Robot 2a22f3686d Merge "Calculate all apps cell height based on actual sizes." into ub-launcher3-rvc-dev 2020-07-17 19:06:23 +00:00
Sunny Goyal 12f46d521a Fixing recents orientation (when home rotation is allowed) during swipe-up
Bug: 158781568
Bug: 160149607
Change-Id: I27be09febcdb6f19687469db34b002ce682aa0cb
Merged-In: I27be09febcdb6f19687469db34b002ce682aa0cb
(cherry picked from commit 141c231d2f)
2020-07-17 18:53:01 +00:00
TreeHugger Robot 4b1d1a0f18 Merge "Prevent showing TaskMenuView if icon isn't present" into ub-launcher3-rvc-qpr-dev 2020-07-17 00:04:41 +00:00
Tony Wickham 94be66acd6 Fix tracking window being slightly off when swiping from an app
Test: swipe up from an app in landscape, seascape, and portrait,
and verify the window tracks with the finger 1:1 until pullback

Bug: 149934536
Change-Id: Ia469877e7152c8135e0b9153f69c191ba86cbd14
(cherry picked from commit f0a1b2ccd8)
2020-07-16 20:03:36 +00:00
Sunny Goyal 4ef25b0122 Merge "Fixing shortcut popop non-clicable on the icon" into ub-launcher3-rvc-qpr-dev 2020-07-16 05:58:23 +00:00
Tracy Zhou b814c3bb23 Infinite loop when migrating calendar widget
Second page can take y = 0

Fixes: 161201598
Test: manual
Change-Id: I6654db5c2c358dfb132268218dd044674e302e83
2020-07-16 05:40:37 +00:00
TreeHugger Robot eb2eb38cc2 Merge "Move rotation logic to RotationTouchHelper" into ub-launcher3-rvc-qpr-dev 2020-07-16 05:14:25 +00:00
Vinit Nayak 0affd89031 Move rotation logic to RotationTouchHelper
No functional changes.

Fixes: 159764370
Change-Id: Ie7739a62242377bda69c86bd46e24d2f847f17e0
2020-07-15 22:03:14 -07:00
Sreyas Rangaraju e1037c63dd Merge "Disabling overview actions when thumbnail is not loaded." into ub-launcher3-rvc-qpr-dev 2020-07-15 23:31:51 +00:00
Sreyas 0d2eea3316 Reset disabled flags when action buttons lose visibility.
Bug: 159993889
Change-Id: Id2a38eee5de067d5e8f1df425644dfdcb3334cdb
2020-07-15 16:16:43 -07:00
Sreyas 68330a93fa Disabling overview actions when thumbnail is not loaded.
Bug: 160331177
Change-Id: I05eaec7d6f2e3f2ba71d8148a4e97dcf5a1522c6
2020-07-15 19:46:09 +00:00
Tracy Zhou b023873bc3 Improve grid preview performance
After breaking down the time we spend in rendering preview under a different grid setting, I found out that we spend a huge amount of time loading the workspace. It takes a long time in non preview case (launcher workspace init), so to optimize we should try to cut down things that are not necessary for preview. Widget model loading (widget and shortcut updates) takes half of the time, and can be optimized with minimal risks / code changes.

Bug: 160662425
Test: Manual

Change-Id: I89029d0ddf6e2517077a0ba3fbbcfdcd60b268d9
2020-07-14 23:30:03 +00:00
Jon Miranda ee0ebe6875 Calculate all apps cell height based on actual sizes.
This ensures that the cell contents always fit.

Bug: 160716074
Change-Id: I3d85adec3e7e3652fe4a258bd659382a3e696211
(cherry picked from commit 3535944395)
2020-07-14 22:13:41 +00:00
Sunny Goyal 369501d8aa Fixing swiping up on home interrupting animation
Bug: 161180005
Change-Id: Ida59b87b2fb5905d98b0090630a6ce32fc9c36c8
(cherry picked from commit 93188d61da)
2020-07-14 19:07:51 +00:00
TreeHugger Robot 4c7ced91c0 Merge "Focuses on folder container for Accessibility when no contents to focus on." into ub-launcher3-rvc-qpr-dev 2020-07-14 16:41:25 +00:00
Sunny Goyal ec78aef4fc Merge "Fixing swiping up on home interrupting animation" into ub-launcher3-rvc-qpr-dev 2020-07-14 16:01:43 +00:00
Andy Wickham f865551ff0 Focuses on folder container for Accessibility when no contents to focus on.
This happens when you drag an app into a folder when the current page is
already full. The new page has no apps in it until you drop the one you
want to add.

Fixes: 161040039
Change-Id: Iaa857e7a114e859fa7e6a0653028856a3a8a94a6
2020-07-13 20:56:38 -07:00
Sunny Goyal 93188d61da Fixing swiping up on home interrupting animation
Bug: 161180005
Change-Id: Ida59b87b2fb5905d98b0090630a6ce32fc9c36c8
2020-07-13 17:44:56 -07:00
TreeHugger Robot add69c70c4 Merge "Fix velocity in StaggeredWorkspaceAnimation." into ub-launcher3-rvc-qpr-dev 2020-07-13 22:20:33 +00:00
TreeHugger Robot 054280dba4 Merge "Using original taskInfo to create the taskKey instead of fake data" into ub-launcher3-rvc-qpr-dev 2020-07-13 22:06:13 +00:00
Jon Miranda aee792403d Fix velocity in StaggeredWorkspaceAnimation.
* Velocity should match the direction of the spring values.
  (Swipe direction is upwards, but icons move downwards on screen).
* Remove additional conversion to pxPerS since getDimension already does that.

Bug: 160003774
Change-Id: I12912edb2354c4a30c538da6ca3789c46d82b94d
(cherry picked from commit 54003963d8)
2020-07-13 21:48:19 +00:00
Sunny Goyal 55a9b544c9 Using original taskInfo to create the taskKey instead of fake data
Change-Id: Ie4e35b35484e0f6cb939febe6357b37381d81682
(cherry picked from commit fabfb3ae90)
2020-07-13 21:47:16 +00:00
Pinyao Ting 9d51e49cec Fixes the issue Launcher state propagation is slower than onDeferredResume.
There's currently a bug prevents Launcher release drag lock for two step
widgets. Supposedly, onDeferredResume should release the drag lock; However,
in 3-button navigation mode, the transition from Overview -> Normal is
triggered in Launcher#onNewIntent, which happens after onDeferredResume.

This issue is not reproducible with gesture navigation because its
transition from Overview -> Normal is handled in NavBarToHomeTouchController

Test: manual verified with following steps
1. Enable 3-button navigation
2. Long press in WorkSpace -> Widgets
3. Drag Settings Widget to WorkSpace
4. When the config activity is shown, press "recents" button to see Overview
5. press "home" button to go back to workspace
6. repeat 2 and 3, verify the widget can be dragged
Bug: 149659788

Change-Id: I396ffa8a7db44bf3872a10de4208340a99a7efe8
(cherry picked from commit 3bf889a02f)
2020-07-13 21:46:05 +00:00
TreeHugger Robot 36a1600d66 Merge "Calculate all apps cell height based on actual sizes." into ub-launcher3-rvc-qpr-dev 2020-07-13 21:44:57 +00:00
Vinit Nayak de43fb6323 Notify TaskViews of updated orientation state
There was a race condition between when recent
tasks get loaded for overview and when the
RecentsOrientationState gets updated based on
which orientation was touched. Now notify
tasks view every time orientation state
updates.

Fixes: 160912655
Test: Kill launcher while landscape app
is open then swipe up to recents.
App in correct location.

Change-Id: If2b239f748c000257bd91b14a23d68ba026e3a48
2020-07-13 14:31:24 -07:00
TreeHugger Robot 5491b2e2e0 Merge "Fix shelf tracking distance for landscape app over portrait launcher" into ub-launcher3-rvc-qpr-dev 2020-07-13 20:44:30 +00:00
Tony Wickham 032db3289a Merge "Wait until activity present before calling onEndTargetCalculated()" into ub-launcher3-rvc-qpr-dev 2020-07-13 20:37:15 +00:00
Tony Wickham 452db0db0c Fix shelf tracking distance for landscape app over portrait launcher
Bug: 149934536
Change-Id: I14fa62fa9f51356613f4a3827446b00af774dbf5
2020-07-13 13:21:02 -07:00
Sunny Goyal 44a3b2030d Fixing shortcut popop non-clicable on the icon
Bug: 160819504
Change-Id: I182399aa271a2ad290c33fb39356f8f2c99e105f
2020-07-13 13:15:28 -07:00
Tony Wickham ddbaadb562 Wait until activity present before calling onEndTargetCalculated()
At least one code path relies on the activity to be created: if the
end target is RECENTS, we add a state manager listener to see when
user goes to NORMAL state.

Fixes: 160903658
Change-Id: I3449dec773399f7e9cf2e7ef8b79734b1baa59b4
2020-07-13 12:32:37 -07:00
Sunny Goyal c031040a2f Merge "Preventing disambiguation screen when swiping up" into ub-launcher3-rvc-dev 2020-07-13 19:23:17 +00:00
Sunny Goyal a639d46c8b Preventing disambiguation screen when swiping up
Bug: 161052537
Change-Id: Ibeeba0841963dc5eb1b5a09847cafc26eb6e4adc
2020-07-13 10:42:47 -07:00