Commit Graph

22209 Commits

Author SHA1 Message Date
Winson Chung f26d98e870 Merging ub-launcher3-qt-dev, build 5619253
Test: Manual
Bug:112282235 P3 Starting an app from Launcher very rarely takes > 10 sec
Bug:121279417 P2 Why LauncherInstrumentation.WAIT_TIME_MS == 60000?
Bug:123892607 P1 Test broken: WellbeingTests.testPauseAppFromAllApps
Bug:123900446 P1 App to home animation should zoom into the app icon
Bug:125844074 P2 Final UX and animations for Launcher DWB integration
Bug:131360075 P1 [Gesture Nav] Polish/finish landscape
Bug:131698989 P2 Add task callback for locked state change
Bug:131741395 P2 Allow windows to scale/move past overview positioning
Bug:131768436 P1 Bad placement of search bar
Bug:131854153 P1 Lots of Cuttlefish (and not only) tests are broken
Bug:131867841 P1 Changing display size does not update the grid
Bug:132460627 P1 Unable to swipe to all apps screen on devices
Bug:132687470 P1 Swiping home from forced landscape app creates cutoff task thumbnail
Bug:132756514 P1 Sometimes (when quick switching?) user gets stuck in full-screen recents view
Bug:132900132 P1 Apparently, tests start running while provisioning is still in progress
Bug:132917885 P1 Reduce swipe-up gesture region height in landscape
Bug:132975416 P1 Flake in NexusPredictionAppTracker.getAppPredictionContextExtras
Bug:132993129 P1 If predictions disabled, app predictions loading bar appears briefly on device restart
Bug:133113732 P1 [B1/C1][QT][CTS_Verifier_9.0_r1]Device Owner Tests-LockTask UI-Enable Overview button failure
Bug:133167096 P1 It is way too easy to dismiss apps from the lock screen
Bug:133651528 P1 [QT]"Pixel Launcher isn't responding" dialog pop up ,after DUT restored.
Bug:133765434 P1 [Flaky test] Launching task didn't open a new window
Bug:133765491 P1 App docked in split screen flickers with emptiness observed while rotating the device
Bug:133783088 P1 Footer showing up on all overview task snapshots even with no items showing.
Bug:133867119 P2 Lab-only flake: want to switch from workspace to all apps; Swipe failed to receive an event for the swipe end
Bug:64712476 P3 Import translations for dev branches

Change-Id: Ib4bcefdbb4027992e75e2742d72f199e13467875
(cherry picked from commit 0ef6fe00b0)
2019-05-31 20:37:38 +00:00
android-build-team Robot 38c06e80f7 Snap for 5616560 from a8d4085ee2 to qt-c2f2-release
Change-Id: Id8a8d2d0d40506df02ed44ede2fad1c6be2f2930
2019-05-30 03:06:41 +00:00
Sunny Goyal a8d4085ee2 Fix crash when launching some apps which require icons to be loaded on the model thread
am: 8be337b8a7

Change-Id: Id37f54a1374315a6c2d17ff3af029cfe75b5ed1d
2019-05-29 14:27:38 -07:00
android-build-team Robot 37af49a76f Merge cherrypicks of [7796490, 7796819, 7796821, 7796671, 7796765, 7796766, 7796673] into qt-c2f2-release
Change-Id: I310c71c417be23a649ef3d9338af3b08ade3bce1
2019-05-29 20:46:42 +00:00
Sunny Goyal 46258a1bcc Fix crash when launching some apps which require icons to be loaded on
the model thread

Bug: 133639322
Test: Manual

Change-Id: I945a94c458d872b41e44b4b3a2d023f85d8a7c88
(cherry picked from commit 9fd2d0ee0a)
(cherry picked from commit 8be337b8a7)
2019-05-29 20:46:00 +00:00
Sunny Goyal 8be337b8a7 Fix crash when launching some apps which require icons to be loaded on
the model thread

Bug: 133639322
Test: Manual

Change-Id: I945a94c458d872b41e44b4b3a2d023f85d8a7c88
(cherry picked from commit 9fd2d0ee0a)
2019-05-29 17:29:32 +00:00
android-build-team Robot 3d06c327d0 Snap for 5611873 from d405653c86 to qt-c2f2-release
Change-Id: I342f5241150e3bde3160e787f6209eb6e90a7862
2019-05-29 03:16:38 +00:00
android-build-team Robot 9531eb5203 Merge cherrypicks of [7773042, 7773101, 7772813, 7772985, 7772987, 7772989] into qt-c2f2-release
Change-Id: Iaf1c2438d66b8a68b4f2860d6b07ab4f4243f8db
2019-05-28 23:05:03 +00:00
Winson Chung ec7ae4ce4c Merge branch 'ub-launcher3-qt-dev' into merge_5609112
Test: Manual
Bug:112282235 P3 Starting an app from Launcher very rarely takes > 10 sec
Bug:121279417 P2 Why LauncherInstrumentation.WAIT_TIME_MS == 60000?
Bug:123900446 P1 App to home animation should zoom into the app icon
Bug:131360075 P1 [Gesture Nav] Polish/finish landscape
Bug:131854153 P1 Lots of Cuttlefish (and not only) tests are broken
Bug:132687470 P1 Swiping home from forced landscape app creates cutoff task thumbnail
Bug:132756514 P1 Sometimes (when quick switching?) user gets stuck in full-screen recents view
Bug:132917885 P1 Reduce swipe-up gesture region height in landscape
Bug:132975416 P1 Flake in NexusPredictionAppTracker.getAppPredictionContextExtras
Bug:132993129 P1 If predictions disabled, app predictions loading bar appears briefly on device restart

Change-Id: Ibfa1ed3ab6241fdb9412df2a80c11e83032008d9
(cherry picked from commit c3b21dd0480be4c64df6ac854ccb6d4923a992b2)
2019-05-28 23:04:34 +00:00
android-build-team Robot 29da25b4ad Snap for 5606075 from d405653c86 to qt-c2f2-release
Change-Id: Ie15534e3b1af6e38f84893484d3a84ce1fbdf946
2019-05-25 23:10:53 +00:00
Sunny Goyal d405653c86 Merging ub-launcher3-qt-dev, build 5595491
am: cf7e6c4a32

Change-Id: I6d490f8d51fd10ef6fe2b4e9bdf3c222fb4c8de6
2019-05-23 01:49:57 -07:00
Sunny Goyal cf7e6c4a32 Merging ub-launcher3-qt-dev, build 5595491
Test: Manual

Bug:122345781 P1 Inflation happens and a binder call during swipe up gesture, that may cause jank
Bug:123900446 P1 App to home animation should zoom into the app icon
Bug:124510042 P1 [Gesture Nav] Home animation polish
Bug:126744445 P1 Add chips support for Overview UI library
Bug:127783075 P1 When swiping up to recents, sometimes velocity is really wrong
Bug:129036789 P2 [a11y] Talkback doesn't indicate App paused in Home/Apps list.
Bug:131839392 P2 Ensure Go Launcher follows theming standards
Bug:132283018 P1 Shelf Jump
Bug:132356358 P1 Fix invocation animation for fling
Bug:132588097 P1 Launcher folder shadow and image flickers on going home
Bug:132716177 P4 Swiping right at home shows alphabet index
Bug:132900132 P1 Apparently, tests start running while provisioning is still in progress
Bug:132917885 P1 Reduce swipe-up gesture region height in landscape
Bug:133009122 P2 Rare flake: dragged launchable to workspace, but the current state is not WORKSPACE; Can't find a launcher object; selector: BySelector [RES='\Qcom.google.android.apps.nexuslauncher:id/apps_view\E']
Bug:133010447 P2 Blueline: flake: test manages to click search box instead of starting an app
Bug:133010773 P2 qt-dev / crosshatch: flake: java.lang.AssertionError: http://go/tapl : want to switch from background to overview; Swipe failed to receive an event for the swipe end: 720, 2959, 720, 2050
Bug:133011252 P2 flake: Launching an app didn't open a new window: Calendar
Bug:133265591 P1 Blocked touches in thin region over home
Change-Id: Iac4013556a2a49418d1634762698ea59bbf95a75
2019-05-22 17:24:58 -07:00
TreeHugger Robot a338daa261 Merge "Adding a utility class to cache views at an activity level" into ub-launcher3-qt-dev 2019-05-22 23:35:03 +00:00
Sunny Goyal 5686333117 Adding a utility class to cache views at an activity level
Bug: 122345781
Change-Id: I9a939e0b19c06c1089c1ceb515f8b97fb5dbb49e
2019-05-22 14:23:12 -07:00
Adam Cohen a09cfe2340 Fix issue where AllAppsContainerView was blocking touches to part of the home screen
=> After the scrubber was engaged, it would continue to intercept touches forever
   (seems like a long standing issue)
=> Also fixed issue where the All Apps scrubber could be engaged from the Home / Overview
   states

b/133265591
b/132716177

Change-Id: I8c7b9d45be65216f2f1a69f69ab1636accd812c0
2019-05-22 14:21:12 -07:00
TreeHugger Robot 9fb137bb73 Merge "Recents Go: Conform to device default style" into ub-launcher3-qt-dev 2019-05-22 20:52:32 +00:00
Kevin 3c7d5fb9db Recents Go: Conform to device default style
System apps in Q should attempt to conform to device style, so naturally
Recents Go should also conform to this so that text changes with the
device style changing. This CL ensures all text views change font based
off system theming title fonts.

Bug: 131839392
Fix: 131839392
Test: Change device theme body font, see that change is propogated to
Recents Go app texts, clear all, and empty recents message
Change-Id: Ib85ff49383221ef18ed8aa9e53eff129129e37c2
2019-05-22 13:39:32 -07:00
vadimt 3ab80bb734 Enable debug tracing for a lab-only non-starting app from all apps
Bug: 132900132
Change-Id: I9c5bb51e49f865ea1e1d3d2209a8dfb149f66e87
2019-05-22 12:58:35 -07:00
Tony Wickham 9e26fccacc Merge "Fix some issues with shelf jumping/duration" into ub-launcher3-qt-dev 2019-05-22 19:21:37 +00:00
Vadim Tryshev 07b985b5e5 Merge "TAPL: switching all swipes to model time" into ub-launcher3-qt-dev 2019-05-22 18:26:21 +00:00
Jon Miranda 4c76bb8b3e Fix bug where recycled FloatingIconView stays clipped to outline.
Bug: 123900446
Change-Id: I9507dab86cc0da27626d1b48e0f6a236f2b3f219
2019-05-22 07:33:31 -07:00
Adam Cohen 47f21e8a08 Merge "Fix issue where Assistant could be invoked at the same time as all apps" into ub-launcher3-qt-dev 2019-05-22 03:48:36 +00:00
Tony e246dff69f Fix some issues with shelf jumping/duration
Don't use OvershootParams for 0 button mode, since that interpolator
assumes the shelf is moving in conjunction with recents/app window.
Instead, use OVERSHOOT_1_2 like we do when not flinging.

Also bound the duration when entering recents, since scroller
duration could be 750ms if we are snapping to the current page.
Now we cap at MAX_SWIPE_DURATION (350ms). This case is most likely
to be hit when ending a slow swipe near the final recents scale,
since in that case duration is close to 0 and the scroller duration
is taken instead.

Test:
- Artificially always detect a pause, fling up in 0 button mode;
  ensure shelf doesn't jump
- Either with the above artifical change in 0 button, or 2 button
  mode, end a swipe to recents near its final scale with a slight
  scroll to the right; ensure duration is 350 instead of 750

Bug: 132283018
Bug: 127783075
Change-Id: I8d5fbd0b30af21b9587fba47d141ba90b3b6e778
2019-05-21 20:27:55 -07:00
TreeHugger Robot 0ef504aa71 Merge "Adding tracing for a lab-only flake" into ub-launcher3-qt-dev 2019-05-22 03:12:56 +00:00
vadimt cfc2e02a94 TAPL: switching all swipes to model time
Bug: 133010773
Change-Id: I3334ac4ac434bf1c6470c806bb216eb7bd8e22c2
2019-05-21 18:29:19 -07:00
vadimt e17d1feb79 Adding tracing for a lab-only flake
We had a resolved case in the past where an app's context menu didn't
open on a long click (thanks to app updates), now the menu opens, but
the drag gesture doesn't drag the icon.

Bug: 133009122
Change-Id: I45d104a92fab6556ecd937aef76f0a8147e67f56
2019-05-21 17:19:23 -07:00
Adam Cohen 8f7d2b0dfd Fix issue where Assistant could be invoked at the same time as all apps
issue 132366412

-> First, we shouldn't accept flings when the delegate has intercepted. This prevents any situation
   where both are triggered.

-> Modified the slop to be the standard 8dp. This acts as a standalone fix because
   it means that there are no situations where we cross all apps slop before assistant slop.
   ie. in a purely vertical gesture from the corner, without this change, it's possible to trigger
   all apps instead of Assistant.

Change-Id: I39e3d8a525e165024399d9802d4cc1d7ae329ee6
2019-05-21 15:52:34 -07:00
TreeHugger Robot 4b41793155 Merge "Not allowing applying dot state to override "disabled" description" into ub-launcher3-qt-dev 2019-05-21 21:05:03 +00:00
Miranda Kephart 49e5d8227b Merge "Pass in fling velocity for gesture progress" into ub-launcher3-qt-dev 2019-05-21 21:05:00 +00:00
vadimt da6dad5101 Not allowing applying dot state to override "disabled" description
Disabled apps were always accessibility-marked like "Disabled Messenger"

With introduction of dots, this degraded, the the "Disabled" part was
never added.

Restoring the old behavior here.

Bug: 129036789
Change-Id: Icb97ea9a190643449d90f558a78039df30c53cbf
2019-05-21 13:24:23 -07:00
TreeHugger Robot 32ba3c1125 Merge "Using squared hypot to optimize some comparisions" into ub-launcher3-qt-dev 2019-05-21 19:48:37 +00:00
vadimt 3479cf80e7 More logging in AllApps + a fix
Change-Id: Iebcb336beee36b0aea47404f8c5d31dec14e7383
2019-05-21 12:08:15 -07:00
vadimt a1a417c994 Searching icons only in apps_list_view
This should help avoiding situations when an icon is intermittently
found in the suggested row vs. the recycler.

Change-Id: I71b17caa5f827999f0901d5c4d4348de7e16f053
2019-05-21 11:49:49 -07:00
vadimt 1053de165e Marking sure the center of icon is not under search box in all apps
Change-Id: I9cfc9941be2bed7834d58039fbfc2741fcf50cba
2019-05-21 11:10:03 -07:00
android-build-team Robot b696cb4fee Snap for 5588664 from d0993b2b6c to qt-c2f2-release
Change-Id: Ib4a472a25c8a4a2c5f7f39152c23405c3e023a46
2019-05-21 15:01:03 +00:00
Hai Zhang d0993b2b6c Align badging logic with platform IconDrawableFactory.
am: b0be237b3f

Change-Id: I4cb15de478dd232e3f16c00b379b89a921b6d4a4
2019-05-21 01:17:10 -07:00
vadimt 982ea56122 Making sure that the icon in all apps is not under search box
Bug: 133011252
Bug: 133010447
Change-Id: Ie735ac36fa063d0d9290c59f6ad4af9e05600ddf
2019-05-20 16:53:39 -07:00
Sunny Goyal 878aa33567 Using squared hypot to optimize some comparisions
Change-Id: Ia5b99c2e60eedf02dea26857819f0e13127db4e2
2019-05-20 15:20:47 -07:00
Miranda Kephart b063775eb9 Pass in fling velocity for gesture progress
Calls SystemUIProxy.onGestureCompletion for a completed gesture
(either drag or fling) and passes in the velocity (0 for drags).

Bug: 132356358
Test: manual

Change-Id: I080adc401e19a6141627d1806b425056f7eefcbd
2019-05-20 18:07:44 -04:00
TreeHugger Robot 2445ca0777 Merge "Fix bug where FolderIcon stays visible during swipe up to home animation." into ub-launcher3-qt-dev 2019-05-20 20:16:47 +00:00
Hai Zhang b0be237b3f Align badging logic with platform IconDrawableFactory.
The current logic in BaseIconFactory is only trying to add the user
badge if the user passed in isn't null and isn't the current user,
then if no such attempt is made, try to add an instant app badge. This
is causing user badge to disappear if the current user is a work
profile. Meanwhile, the badging logic in IconDrawableFactory is to try
to add the instant app badge first, and then always try to add the
user badge.

Bug: 132625654
Test: manually test as in b/128625591
Change-Id: Ia5b456f1f27095d546504266a1a90034105c9ae9
2019-05-20 13:11:12 -07:00
TreeHugger Robot 692b5a26d9 Merge "Swipe up to home into FolderIcon animation bug fixes." into ub-launcher3-qt-dev 2019-05-20 20:10:18 +00:00
TreeHugger Robot dea6ee23c6 Merge "Fixing inset map in case of display cutouts" into ub-launcher3-qt-dev 2019-05-20 19:11:19 +00:00
Sunny Goyal c79bd21471 Fixing inset map in case of display cutouts
Change-Id: Ia2969688d9ae4c89a2da45eb6361f4476e1877ec
2019-05-20 12:00:17 -07:00
TreeHugger Robot 662a14f2de Merge "Using different resource size for touch region in landscape" into ub-launcher3-qt-dev 2019-05-20 18:57:00 +00:00
android-build-team Robot 6b7261d09e Snap for 5583738 from 1a01d4fe94 to qt-c2f2-release
Change-Id: Iee358289132fe8a5a1854e795f05c1837df4a4ef
2019-05-20 18:15:41 +00:00
Jon Miranda ae975a613d Swipe up to home into FolderIcon animation bug fixes.
- Fixes clipping issues.
- Fixes badge being shifted.

Bug: 124510042
Change-Id: I2520d963fb2041a049650c2b8c12ddb3de7b8d87
2019-05-20 11:10:25 -07:00
Zak Cohen 418b9bc5fc Adapt the task footer container to be a named container.
Bug: 126744445
Test: manual
Change-Id: Id00ffac4581bbbe5dfd73a63b05c4512394745c1
2019-05-20 10:44:20 -07:00
Sunny Goyal 1b40b731b2 Using different resource size for touch region in landscape
Bug: 132917885
Change-Id: Ib702fd17fecff980db2e1d00f05cd055bcc3185a
2019-05-20 10:09:26 -07:00
Jon Miranda e543818bb6 Fix bug where FolderIcon stays visible during swipe up to home animation.
This can happen when opening an app from a folder, and then immediately
swiping up back to home.

This happens because when we swipe up to go home, there's a race condition
where the folder close animation finishes and sets the FolderIcon to VISIBLE
right before FloatingIconView sets it to INVISIBLE.

To fix it, in OverviewState#onStateEnabled we call
AbstractFloatingView#closeAllOpenViews(animate=false). Then we added logic
to cancel any Folder closing animation (which there is,
from WindowTransformSwipeHandler#onLauncherStart) and to just close the
folder right then and there.

Bug: 132588097
Change-Id: I4379431815e7cbddede5ea0213fe9323f001484b
2019-05-20 10:01:15 -07:00