This could not be reproduced until I removed a line that wouldn't call
onAssistantVisiblityChanged if the argument was the same value as the
argument as the previous call.
After that, the bug became readily reproducible. I traced through
Launcher till I found that FallbackActivityControllerHelper
.onAssistantVisibilityChanged was being called while the screen was
locked, proving that onAssistantVisiblityChanged was _not_ reaching
launcher.
Test: Verify bug no longer reproduces.
Bug: 134981174
Bug: 135247753
Bug: 135572849
Bug: 135733393
Bug: 136386749
Bug: 136776987
Bug: 137534772
Bug: 137764419
Change-Id: Ib5e8df3b5030a77c5df351a1fcd993db6bd602fc
hardcoding it to 16ms
> Creating a utility class for caching display property changes
Bug: 128940249
Change-Id: I6f9a214548de65bd1c8530508d665ee88312da4a
In particular, we check that the stable Launcher state equals its
current state. This can help detect Launcher being in a corrupted state
as in b/133867119.
The check gets called by tests when the Launcher is not transitioning
from state to state.
Bug: 137307838
Change-Id: I3d36edff35e42d14be6b9a52351bd6f709be75e8
mMidProgress is intended to be the point at which we reach Overview when
swiping up and thus start scrimming it as All Apps shows above it. For
that reason, mMidProgress needs to match OverviewState's progress. In
contrast, the drag handle (accessibility arrow) can move up sooner to
avoid overlapping with the QSB; for this, we added mDragHandleProgress.
Bug: 136800511
Change-Id: I2825ff798707530420855257350e492b4b9b77dc
- Skip the assistant as the running task when handling swipe up
- Also ensure that we fall into the overview input consumer if we are
swiping it from the assistant over home
- Skip accounting for the scroll offset when there is no running task
Bug: 136282913
Change-Id: I28e45e407702d6d6aebaa0232cd96ccb10047644
When we draw the icon to the DragView, we draw it
with the current scale, which is > 1 when animating
the icon down. Instead, we should always draw the
icon with scale 1 since the DragView itself is scaled.
Bug: 138236583
Change-Id: I6bca5cf28c54d58476240e0e68900a8f08ffe60b
The original bug that was solving seems to be fixed by other changes,
and this allows users to scroll, dismiss, etc on recent tasks before
fully reaching overview from an app.
Bug: 137487381
Change-Id: I28a708811bba3ce739ce261f19eb29558d8f0e7d
This regressed in ag/8542000, where we cancel the animation instead of
ending it. We should only cancel when going to home; in other cases, we
should still call end().
Bug: 137487381
Change-Id: I093954908c3ac747ec3132aa700c8be2f927631a
This allows other components to get it directly from the view, rather
than retaining their own copy.
Bug: 137129923
Tested: Manual
Change-Id: Ibab307517c31cd3cb59b4d77ff390fd97546e86d
Bill Yi
Winson Chung
vadimt
TreeHugger Robot
Hyunyoung Song
James O'Leary
Tony Wickham
Sunny Goyal
Anna Wasewicz
Zak Cohen