Commit Graph

27584 Commits

Author SHA1 Message Date
Sunny Goyal f130c29882 Preventing disambiguation screen when swiping up
Bug: 161052537
Change-Id: Ibeeba0841963dc5eb1b5a09847cafc26eb6e4adc
2020-07-13 19:03:56 +00:00
Sunny Goyal e9bf882158 Import translations. DO NOT MERGE
Force snapping translations from unbundled branch
Bug: 159176821

Test: N/A
Change-Id: I2406edf7eef6aa683f99b2b5f897d16b8968a28d
2020-07-10 12:07:45 -07:00
TreeHugger Robot 7f1f8030db Merge "Persist prediction cache on every update" into rvc-dev 2020-07-08 18:35:26 +00:00
Sunny Goyal 52f2392405 Fixing recents orientation (when home rotation is allowed) during swipe-up
Bug: 158781568
Bug: 160149607
Change-Id: I27be09febcdb6f19687469db34b002ce682aa0cb
Merged-In: I27be09febcdb6f19687469db34b002ce682aa0cb
(cherry picked from commit 141c231d2f)
2020-07-08 00:24:29 +00:00
Sunny Goyal f16456f686 Persist prediction cache on every update
Test: Manual
Bug: 160058750
Change-Id: Icb0b7322b7f9754d3f1c3012e1c98a760f83c787
2020-07-07 18:22:37 +00:00
Greg Kaiser 8f490e21c9 Go Launcher: Fix icon placement retention
We need dbFile set when MULTI_DB_GRID_MIRATION_ALGO is in
use.  This was set for other launchers, but not the Go launcher.

Bug: 157557047
Test: Built, flashed, moved icons on home screen, rebooted, and confirmed icons retained their position.
Change-Id: Icfcb56e00a8ac2f74e5f7a1957fd46cee5cb8b5b
2020-07-07 04:58:57 +00:00
Thiru Ramasamy 6f5d4bb8ab Merge "Fixes NPE with system shortcuts." into rvc-dev 2020-06-29 23:35:59 +00:00
thiruram 43bf883841 Fixes NPE with system shortcuts.
Bug: 160109140
Change-Id: I35c00fc1792fcf11fc61e1876f9184bd5fb309ce
(cherry picked from commit 53925ff9c6)
2020-06-29 19:44:28 +00:00
Zak Cohen 19797b419b Thumbnail Cache - check canceled status on the right thread.
The cache was checking the canceled status on the background
thread, but the cancel call was being made on the main thread.
This was leading to canceled requests still delivering this thumbnail
in some cases.

Bug: 159840851
Test: local build and non-repo of bug
Change-Id: I9a3556f6570eee1db39ebec202c115d58010d7f8
2020-06-29 04:11:04 +00:00
TreeHugger Robot 0538863c58 Merge "During accessible drag, hover events were not properly getting dispatched to the DragAndDropAccessibilityDelegate" into rvc-dev 2020-06-26 21:59:15 +00:00
TreeHugger Robot f8e12b78bf Merge "Add NPE check for prediction controller" into rvc-dev 2020-06-26 19:39:34 +00:00
Adam Cohen 9e3aebd8dd During accessible drag, hover events were not properly getting dispatched to the DragAndDropAccessibilityDelegate
=> regressed in ag/10634216 which attemped to use onHoverListener
=> the problem is that onHoverListener is only triggered when the event is passed to the CellLayout, however, as with all dispatching, these events are handled depth first, and so in cases where a child handled the event, it would never bubble back up to the parent.
=> instead we have to continue to override dispatchHover event to always give presecedence to the delegate when it exists

Bug: 155956518

Change-Id: Ic3ecf1b422c1821456328035a66a2fc1277e6746
(cherry picked from commit 6e7c37a205)
2020-06-26 17:15:03 +00:00
thiruram e148652075 Fixes missing folder label after launcher restarts.
Rootcause: FolderInfo was persisted into DB only when folder options are updated. Hence when folder was created (Folder option remains suggested) its title was not persisted into DB.

Fix: Persists folderInfo into DB always whenever title is updated

Bug: 159904890
Change-Id: If0d20b0d7fa6966dd7bb40a2c07bcb22bd0893e0
(cherry picked from commit 6ab4da8aa0)
2020-06-26 16:30:31 +00:00
Tracy Zhou 6b79a3767d Do preview grid migration in a worker thread
Also remove USE_SURFACE_VIEW_FOR_PREVIEW flag

Fixes: 159755324
Test: manual
Change-Id: I6517c34911e217a69063226b01e4583194902f9c
(cherry picked from commit 633a4bdf57)
2020-06-25 21:05:04 +00:00
Samuel Fufa 0036b2b67a Add NPE check for prediction controller
Bug: 159835714
Test: Manual
Change-Id: I9cc03f6491f4e14462be6c01edf3ed4ca1d82136
2020-06-25 20:10:01 +00:00
TreeHugger Robot ccf588d36b Merge "Pass isLikelyToStartNewTask to onGestureStarted()" into rvc-dev 2020-06-25 16:38:47 +00:00
Tony Wickham 9e84745e4b Pass isLikelyToStartNewTask to onGestureStarted()
This ensures we immediately setRecentsAttachedToAppWindow(). As
mentioned in the bug, there was an edge case where we would animate
the attached state if the first move event passed the touch slop,
causing the adjacent task view to lag behind during the gesture.

Fixes: 159742520
Change-Id: Ie47bb84fdd3dbd69e3b74ca504d487fb9aedb551
(cherry picked from commit c6a56ef7a2)
2020-06-25 02:11:04 +00:00
Andy Wickham d2731957ea Updates Assistant gesture regions when no longer tracking multiple.
This should prevent states where Assistant triggers from
the vertical-center of the screen in portrait (see bug).

Also fleshes out OrientationTouchTransformerTests and
adds some new ones that fail without this change:
 - enableMultipleRegions_assistantTriggersInMostRecent
 - enableMultipleRegions_assistantTriggersInCurrentOrientationAfterDisable

Fixes: 158686674
Change-Id: I6d045a485f62e4010e9e3d00805a50fdd953a2fc
(cherry picked from commit 4b531b972d)
2020-06-24 22:32:14 +00:00
TreeHugger Robot ca493d1426 Merge "Fixing NPE befre ActionsView first initialized." into rvc-dev 2020-06-24 06:52:16 +00:00
TreeHugger Robot d6cd14d179 Merge "Remove hotseat edu flag" into rvc-dev 2020-06-24 04:43:52 +00:00
Sreyas 20024f4447 Fixing NPE befre ActionsView first initialized.
Bug: 159728260
Change-Id: I00e6f8fccf8057495f77873f2f0a1ab01e63ed23
(cherry picked from commit 88f1f2046c)
2020-06-24 04:11:05 +00:00
Zak Cohen b2b0d4d478 Merge "Fixing TaskMenu positioning." into rvc-dev 2020-06-24 03:58:19 +00:00
TreeHugger Robot 7f5a670cc3 Merge "Use isolated display context to get display info" into rvc-dev 2020-06-24 03:44:07 +00:00
TreeHugger Robot 738b1af342 Merge "Merging from ub-launcher3-rvc-dev @ build 6621659" into rvc-dev 2020-06-24 03:29:19 +00:00
TreeHugger Robot 1c90b51de6 Merge "Prevent premature resetting of quickswitch mode" into rvc-dev 2020-06-24 02:48:38 +00:00
Samuel Fufa 6293af5575 Remove hotseat edu flag
Launcher should not restrict user migration to a one time event if we want users to migrate their hotseat by enabling hotseat prediction from suggestion settings.

Test: Manual
Bug: 159731272
Change-Id: I0e42dd6b6cf6374928e5b399d121d17fe8024ae1
2020-06-24 02:01:07 +00:00
Sreyas 98ef53458d Fixing TaskMenu positioning.
Bug: 159728554
Change-Id: I4a666363f092b5416edecd0731a0f448916c8def
2020-06-24 00:14:21 +00:00
Sunny Goyal 315eb02012 Merging from ub-launcher3-rvc-dev @ build 6621659
Bug:150504032
Test: manual, presubmit on the source branch
x20/teams/android-launcher/merge/ub-launcher3-rvc-dev_rvc-dev_6621659.html

Change-Id: Id9689e3dfa641c0e004c9dc975e281358bed7ad7
2020-06-23 16:28:38 -07:00
Tracy Zhou cb2473cf3f Merge "Disable grid option feature in ThemePicker" into rvc-dev 2020-06-23 23:09:09 +00:00
Tracy Zhou 0c88238966 Disable grid option feature in ThemePicker
Fixes: 158790001
Test: manual
Change-Id: I5419738d9b3be996cdcea0a7b5dc2d31ceff0055
2020-06-23 23:07:53 +00:00
Vinit Nayak d92946356e Prevent premature resetting of quickswitch mode
Previously, whenever a user returned to the same
rotation that they had started quickswitch in,
we were sending sysui the reset flag(-1) indicating
that quickstep was complete instead of sending
the rotation of the device the user was in.

This was intentional and it worked, however we now
always send the active rotation while the user
is in a quickswitch session because sysui needs
to show the fake home handle for immersive apps,
which can occur in any rotation. This state is
distinct from not being in quickswitch at all, in
which no fake handles are shown.

Fixes: 158677967

Change-Id: I910324abf781b4b30fe981139712bcb5b653c318
(cherry picked from commit f2daafcdf8)
2020-06-23 22:45:44 +00:00
TreeHugger Robot 359a28e934 Merge "Prevent premature resetting of quickswitch mode" into ub-launcher3-rvc-dev 2020-06-23 22:42:48 +00:00
TreeHugger Robot d0fcfe2bb7 Merge "Fix hotseat button alignment" into ub-launcher3-rvc-dev 2020-06-23 22:08:42 +00:00
Vinit Nayak f2daafcdf8 Prevent premature resetting of quickswitch mode
Previously, whenever a user returned to the same
rotation that they had started quickswitch in,
we were sending sysui the reset flag(-1) indicating
that quickstep was complete instead of sending
the rotation of the device the user was in.

This was intentional and it worked, however we now
always send the active rotation while the user
is in a quickswitch session because sysui needs
to show the fake home handle for immersive apps,
which can occur in any rotation. This state is
distinct from not being in quickswitch at all, in
which no fake handles are shown.

Fixes: 158677967

Change-Id: I910324abf781b4b30fe981139712bcb5b653c318
2020-06-23 15:07:22 -07:00
vadimt efa3acddba Making LauncherProvider think that clear-db request comes from Launcher
If it comes from the test process, the request won't be honored.

Bug: 159728364
Change-Id: I90029c1198634f1f1e94f61ba8ab9b41609d9ad5
2020-06-23 13:59:11 -07:00
Samuel Fufa a44c09d6c9 Fix hotseat button alignment
Screenshot: https://screenshot.googleplex.com/Vr9FXe3oN2t
Bug: 159731214
Change-Id: I9e413f5d9bf0144edd413cc5995e7f1fda152f28
2020-06-23 12:46:30 -07:00
Tony Wickham b47a99e3cc Store newGestureState before onConsumerAboutToBeSwitched clears it
Bug: 159659393
Change-Id: If98d54b7ca397ef56a5c6d50c0fd92f25a9494b4
(cherry picked from commit efb7e60edc)
2020-06-23 16:45:51 +00:00
Tracy Zhou b1e003c1fb Merge "Support having dup items in folder for migration" into ub-launcher3-rvc-dev 2020-06-23 16:12:25 +00:00
Riddle Hsu 8108009929 Use isolated display context to get display info
While display is in landscape, and the launcher is transformed to
portrait, the display rotation from activity or application context
will get the rotation in portrait.

In order to transform the input event when the orientations are
different, the actual device rotation is still needed. By creating
the display context from application context, the resources of
the new context won't be affected by the activity/application level
display info adjustments. That provides the actual device states.

Additionally, DefaultDisplay#INSTANCE should only be used for the
operations related to physical orientation/size because it won't
contain the override information from activity.

Bug: 157456493
Test: Use a device which may switch refresh rate.
      Open Maps and put device in landscape.
      Use gesture navigation to swipe up.
      The direction of movement should be consistent with UI.
Change-Id: I03108b1ab057e28727b6a6db3629d2c1c069e828
2020-06-23 17:09:33 +08:00
TreeHugger Robot a271085506 Merge "Merging from ub-launcher3-rvc-dev @ build 6617269" into rvc-dev 2020-06-23 07:29:27 +00:00
Tracy Zhou 76773cd210 Support having dup items in folder for migration
Fixes: 159312066
Test: Have two dup items in a folder under one grid setting. Migrate. Make sure the folder is migrated correctly to the new grid setting.
Change-Id: Ic5aeb30a1c8acb382bccf744d7553913d8a8a320
2020-06-23 00:29:23 -07:00
TreeHugger Robot 7cb6d738c0 Merge "Eliminating messages that launcher activity is frozen" into ub-launcher3-rvc-dev 2020-06-23 06:09:26 +00:00
Hyunyoung Song 85d90a16bc Merging from ub-launcher3-rvc-dev @ build 6617269
Bug: 150504032
Test: manual, presubmit on the source branch
https://android-launcher.teams.x20web.corp.google.com/merge/ub-launcher3-rvc-dev_rvc-dev_6617269.html

Change-Id: I7a13230553f9c42d5f67164234c33cf77efa9cf2
Merged-In: I2a168bfa8e3979ade26ab1d3cddbbae84cf79590
2020-06-23 05:11:31 +00:00
TreeHugger Robot ea3edf1247 Merge "Log query_length & parent_container for actions on search results." into ub-launcher3-rvc-dev 2020-06-23 02:16:44 +00:00
TreeHugger Robot 7551b6191f Merge "Store newGestureState before onConsumerAboutToBeSwitched clears it" into ub-launcher3-rvc-dev 2020-06-23 01:33:55 +00:00
thiruram dbd61d4026 Log query_length & parent_container for actions on search results.
Bug: 154717227
Change-Id: I8e7d725014f60a2fd9a7fe13fce705acbc7623ad
2020-06-22 18:14:12 -07:00
Tony Wickham efb7e60edc Store newGestureState before onConsumerAboutToBeSwitched clears it
Bug: 159659393
Change-Id: If98d54b7ca397ef56a5c6d50c0fd92f25a9494b4
2020-06-22 17:37:07 -07:00
vadimt 839fb7b3ae Eliminating messages that launcher activity is frozen
They were ultimately caused by killing Launcher process from tests.

Now having a test info handler request to clear db.

Bug: 152629799
Change-Id: Ia81ddc3e338718c4cff08c7396b9fda1b7091024
2020-06-22 15:39:19 -07:00
Thiru Ramasamy 51ece1847c Merge "Adds additional folder label states (UNLABELED & EMPTY_LABEL)" into ub-launcher3-rvc-dev 2020-06-22 21:04:12 +00:00
TreeHugger Robot ceaad08f06 Merge "Fixing rotation watcher not enabled in landscape" into ub-launcher3-rvc-dev 2020-06-22 21:00:07 +00:00