Commit Graph

76709 Commits

Author SHA1 Message Date
Jon Miranda f044d12fcc Merge "Fix taskbar bg delay for the case when user is going home." into main 2024-06-21 23:16:11 +00:00
Tracy Zhou 170092ef5d Merge "Enable taskbar on phones when the flag is turned on" into main 2024-06-21 22:47:13 +00:00
Treehugger Robot b938fa20b2 Merge "Close floating views before fake rotation" into main 2024-06-21 22:46:03 +00:00
Jon Miranda 09aa46b88e Fix taskbar bg delay for the case when user is going home.
The default value was not set. I decided to flip the variable to make
it more readable.

Bug: 345768019
Test: swipe up fast to go home, note no taskbar bg
      swipe up slow to reveal taskhome, note taskbar bg shows immediately
Flag: com.android.launcher3.enable_scaling_reveal_home_animation
Change-Id: I7fb4bbdce45a14312e42abcf71f7f0643376ddc6
2024-06-21 14:27:01 -07:00
Tony Wickham 74fc385999 Merge "Load and draw Recent/Running tasks that aren't in Hotseat" into main 2024-06-21 21:01:41 +00:00
Tony Wickham a79bc15cd0 Merge changes from topic "taskbar-running-minimized" into main
* changes:
  Maintain Running Tasks order in Desktop mode
  Change running apps section to use GroupTask instead of AppInfo
2024-06-21 21:00:01 +00:00
Tony Wickham 59e8952fc9 Merge "Handle running task launch properly in desktop mode" into main 2024-06-21 20:57:38 +00:00
Treehugger Robot f4934108bb Merge "Fix bubble bar bounce animation issue" into main 2024-06-21 20:44:10 +00:00
Brian Isganitis d3d2607a10 Merge "Extract RoboApplication object caching to Launcher3 interface." into main 2024-06-21 18:37:14 +00:00
Alex Chau bde639236f Close floating views before fake rotation
- We do the same in Launcher for real rotation

Fix: 348113790
Test: manual
Flag: EXEMPT bugfix
Change-Id: Ibd5f42db439cd94a389f7aaf6fe2db317c11cd67
2024-06-21 18:37:21 +01:00
Mady Mellor a2146c8f10 Merge "Update bubble bar overflow to have a unique resId" into main 2024-06-21 15:55:04 +00:00
Hongwei Wang a648d13ea8 Merge "Position PiP animation based on actual coordinates" into main 2024-06-21 02:51:37 +00:00
Liran Binyamin cdc3e4d8b4 Fix bubble bar bounce animation issue
The bubble bar bounce animation was assuming that the initial translation
of the bubble bar is also the translation the bubble bar should have at
the end of the animation. This is normally correct except when the
bubble bar is initially hidden. What happens in that case is that the
translation is 0 so the bubble bar gets animated incorrectly.

This change gets the target animation from stash controller.

ABTD 100 runs: https://android-build.corp.google.com/abtd/run/L26900030004638356/

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 347856510
Test: atest BubbleBarTest#selectDifferentBubble
Change-Id: I661bf006c6f23ff871c221f8d9da74d79a2dff11
2024-06-20 18:03:52 -04:00
Xin Li da3f972261 [automerger skipped] Merge 24Q3 (ab/11976889) to aosp-main-future am: 020c6204dd -s ours
am skip reason: Merged-In I5059553cb9b6c02810e9638bfaf29dde9ab6140f with SHA-1 263932e729 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27907054

Change-Id: Icbb39fe46616eb1eee1c7d468f006b728cb243d9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-20 21:46:13 +00:00
Liran Binyamin 8af78f19a3 Merge "Animate bubble removal from the bar" into main 2024-06-20 20:57:34 +00:00
Hongwei Wang cd6172911e Position PiP animation based on actual coordinates
In the previous patchset, we assumed the left/top to be 0/0 which is not
always the case. This could break, for instance, in ActivityEmbedding
setup, where the pip-ing app is on the left side.

Flag: NONE test fix
Bug: 345327260
Test: Verify with apps support auto-enter PiP such as YouTube
Change-Id: Ic2f3289cf0663d0687d5ccd7f4d0250066cb3f67
2024-06-20 13:24:18 -07:00
Liran Binyamin 7b426af15f Animate bubble removal from the bar
This change creates a BubbleAnimator class that handles animating
both new bubbles in and removed bubbles out.

Demo: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/dMHGANplWjGC5HZT6MXyA4

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 345687290
Test: atest BubbleAnimatorTest
Test: see demo

Change-Id: Ie060495f4b1421d1c8af48a861cd3e12dd0adbe8
2024-06-20 14:57:03 -04:00
Jordan Silva c9ec536f07 Merge "Fix recents button not navigating to Overview" into main 2024-06-20 16:42:16 +00:00
Luca Zuccarini 11fa93f25d Merge "Fix widget jump at the end of the new home animation." into main 2024-06-20 15:58:55 +00:00
Treehugger Robot 264a7e3336 Merge "Move testQuickSwitchFromHome to possubmit" into main 2024-06-20 14:41:18 +00:00
Luca Zuccarini 4b4e426b30 Fix widget jump at the end of the new home animation.
The window animation wasn't being updated correctly, which resulted in a
jump at the end.

Bug: 298089923
Fix: 347880952
Flag: com.android.launcher3.enable_scaling_reveal_home_animation
Test: manual
Change-Id: Idbbd2e8485ae6f2bcbc1b42aa3744c2c659d1cfc
2024-06-20 13:40:45 +00:00
Alex Chau 91602f658c Move testQuickSwitchFromHome to possubmit
Bug: 325659406
Test: presubmit
Flag: EXEMPT test
Change-Id: Iccc2c1f06da85a0df79b5f3e0881535ce226f953
2024-06-20 13:50:19 +01:00
Jordan Silva 3d088e3899 Fix digital wellbeing banner position in portrait mode
The banner should be aligned to the start of the screen, not the center. This CL fixes DWB position for split tasks when device is unfolded.

Change-Id: I0544b4a8eb85b00196373c8a4368e680abab222b
Fix: 348200661
Bug: 345789862
Flag: EXEMPT bugfix
Test: Manual. Add a Digital Wellbeing (DWB) timer to 2 apps. Open these two apps in split mode. Unfold the device and go to Overview. The DWB banner should aligned correctly.
2024-06-20 09:46:30 +00:00
Tracy Zhou 1983e4fb13 Enable taskbar on phones when the flag is turned on
Bug: 348017501
Test: N/A
Flag: com.android.wm.shell.enable_taskbar_on_phones
Change-Id: I8f283609b24c49e4ecd37142b0d94e449d1dc118
2024-06-19 18:45:22 +00:00
Fengjiang Li 622a7e37c5 Merge "[Launcher Jank] Avoid LauncherWidgetHolder and QuickstepWidgetHolder calling IAppWidgetService$Stub$Proxy.setAppWidgetHidden from main thread" into main 2024-06-19 15:19:22 +00:00
Jordan Silva 6a4c142b5b Fix recents button not navigating to Overview
This CL prevents returning launcher in getVisibleLauncher method when isHomeVisible is true but Launcher is not started.

Bug: 337954957
Bug: 331947116
Flag: EXEMPT bugfix
Test: Manual. With 3-button-nav. Open a video from -1 scren (not in Youtube app), press recent button. More instructions in b/337954957#comment26.
Change-Id: I40edafdab5457666474de2c0368158a9c1c05fb0
2024-06-19 15:08:43 +01:00
Ivan Tkachenko f58d227f61 Fix back gesture navigation in Launcher with DW
The windows back functionality with the
`enable_desktop_windowing_wallpaper_activity` flag enabled works as
expected and doesn't require changes in `#updateDisallowBack`.

- Added the `enable_desktop_windowing_wallpaper_activity` flag check in
  `Launcher#updateDisallowBack`
- The early return statement will get removed after flag is fully rolled
  out (b/333533253)

Bug: 330183377
Test: manual
Flag: com.android.window.flags.enable_desktop_windowing_wallpaper_activity
Change-Id: I2eaaa44da82da6cbdfe534793830d0f44c4668ba
2024-06-19 11:57:06 +00:00
David Lin 7fdd393b06 [automerger skipped] Merge "Fix flickering issues with divider during split animation" into 24D1-dev am: 6ec11da650 -s ours
am skip reason: Merged-In I3b37f2b0478035d7a3181ae7c23962fe75a13b2c with SHA-1 91fb2f2e5e is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27849399

Change-Id: I181b94e850d3cd9b866317f06ba3ebfaa1f26323
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-19 01:18:50 +00:00
Jeremy Sim 4f87501544 [automerger skipped] Fix flickering issues with divider during split animation am: fe9a7f3f38 -s ours
am skip reason: Merged-In I3b37f2b0478035d7a3181ae7c23962fe75a13b2c with SHA-1 91fb2f2e5e is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27849399

Change-Id: If0f02ac646d61d16f54b43418946a827c64c9cbc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-19 01:18:46 +00:00
David Lin 6ec11da650 Merge "Fix flickering issues with divider during split animation" into 24D1-dev 2024-06-19 00:48:33 +00:00
Tony Wickham c5995c8f6d Load and draw Recent/Running tasks that aren't in Hotseat
- Re-support GroupTask as a tag on TaskbarView BubbleTextViews
- Can tap to launch (startActivityFromRecents) or drag and drop
- Move divider when enable_recents_in_taskbar is true

Behavior:
- While in Desktop mode, all open tasks show up in TaskbarView,
  either in the Hotseat section or the Running apps section
  past the divider. Each one also has a running line indicator.
- While in Fullscreen mode, up to 2 Recent apps that are not
  part of Hotseat will be added to the right of the divider.

Flag: com.android.launcher3.enable_recents_in_taskbar
Test: TaskbarRecentAppsControllerTest
Bug: 315354060
Change-Id: I2e2870cca434b51f276a701860edb32069109159
2024-06-19 00:27:30 +00:00
Tony Wickham 7c7c90528d Maintain Running Tasks order in Desktop mode
Fixes: 345034545
Test: TaskbarRecentAppsControllerTest
Flag: com.android.launcher3.enable_recents_in_taskbar
Change-Id: I4ab856c5293625c5279d4713450e5ea2d3b0ed85
2024-06-19 00:27:30 +00:00
Tony Wickham 2021727f1e Change running apps section to use GroupTask instead of AppInfo
- No longer bind All Apps to TaskbarRecentsController, and register
  RecentsModel.RecentTasksChangedListener instead
- The source of truth for "running tasks" in Desktop mode is the
  DesktopTask#tasks list itself, instead of
  RecentsModel.RunningTasksListener (which is no longer used)
- Added TaskInfo.TaskKey#isVisible to distinguish minimized running apps
- Next CL will hook up the UI for Recent/Running tasks that are
  not part of the Hotseat.

Flag: com.android.launcher3.enable_recents_in_taskbar
Test: TaskbarRecentAppsControllerTest
Fixes: 335398876
Bug: 315354060
Change-Id: I1313f97a791c5c0c1db7443a5d4f1d5bc761981f
2024-06-19 00:27:30 +00:00
Tony Wickham 4e1befb394 Handle running task launch properly in desktop mode
- Move logic from KeyboardQuickSwitchViewController to handle
  bringing desktop tasks to front, and still support recent
  tasks for non-desktop mode.

Flag: com.android.launcher3.enable_recents_in_taskbar
Test: manually launch tasks from the Recents section in both
Desktop mode and full screen mode (running vs recent)
Bug: 315354060

Change-Id: I0520351b4d0095a3538c6165acd82a7b4c45a5e2
2024-06-19 00:25:45 +00:00
Charlie Anderson df204b585e Merge "Only send new first screen broadcast on first load after restore" into main 2024-06-19 00:10:49 +00:00
Mady Mellor 58a6bbac4a Update bubble bar overflow to have a unique resId
This allows the overflow to be tested properly in end-to-end tests.

Flag: com.android.wm.shell.enable_bubble_bar
Test: atest OverflowBubbleTest (with other CL)
Bug: 347312208
Change-Id: Ice969434f9c40602c4b2d1a5baf6ba0509534a56
2024-06-18 16:43:32 -07:00
Fengjiang Li 880de362f1 [Launcher Jank] Avoid LauncherWidgetHolder and QuickstepWidgetHolder calling IAppWidgetService$Stub$Proxy.setAppWidgetHidden from main thread
Fix: 347991067
Test: manual - jank fix
Flag: NONE - jank fix
Change-Id: I881e5961ee4422d89e761c95ee8371902ded7ae6
2024-06-18 15:47:31 -07:00
Brian Isganitis d0261a8e57 Extract RoboApplication object caching to Launcher3 interface.
Multivalent tests in Launcher3 can use the interface to override
MainThreadInitializedObject instances.

Test: n/a
Flag: TEST_ONLY
Bug: 230027385
Change-Id: I9c7c4fd004ca573a003fb11cd0a19a400e95afe4
2024-06-18 18:36:53 -04:00
Charlie Anderson 30a3acc779 Only send new first screen broadcast on first load after restore
Flag: EXEMPT launcher_broadcast_installed_apps
Bug: 322314760
Test: manually tested

Change-Id: I28a3ee1fb2c5c382ea8789b6e966c80db1abf0e0
2024-06-18 18:19:46 -04:00
Jagrut Desai 5074ef975a Merge "Fixing TaplUninstallRemoveTest#uninstallWorkspaceIcon" into main 2024-06-18 21:52:33 +00:00
Fengjiang Li 52c8595224 Merge "[Launcher Jank] Avoid making IWindowManager$Stub$Proxy.registerCrossWindowBlurEnabledListener bind calls from DepthController" into main 2024-06-18 21:48:07 +00:00
Xin Li 020c6204dd Merge 24Q3 (ab/11976889) to aosp-main-future
Bug: 347831320
Merged-In: I5059553cb9b6c02810e9638bfaf29dde9ab6140f
Change-Id: I924cc14ed3c2cee644125b91fa498cf5dc7865f8
2024-06-18 14:13:43 -07:00
Fengjiang Li 05ad8912bc [Launcher Jank] Avoid making IWindowManager$Stub$Proxy.registerCrossWindowBlurEnabledListener bind calls from DepthController
Fix: 347965970
Test: manual - jank fix
Flag: NONE - jank fix
Change-Id: I59605d22ebc215e171c3b93fb1efc3becf2a4ade
2024-06-18 20:18:55 +00:00
Treehugger Robot b47bed0fe6 Merge "Add logging and error detection around quick switching" into main 2024-06-18 16:24:34 +00:00
Jagrut Desai 66dfe90240 Fixing TaplUninstallRemoveTest#uninstallWorkspaceIcon
Test: Presubmit
Bug: 319501259
Flag: TEST_ONLY
Change-Id: I4a2af445fe51f4f3ffcc11748ff921baf6be9bd0
2024-06-18 09:19:22 -07:00
Schneider Victor-tulias 78e5bab45a Add logging and error detection around quick switching
Also adding a fallback case for when quick switch could otherwise fail

Flag: NONE debug logs
Bug: 320215753
Test: checked logs
Change-Id: I2c6b6d2c6beee77d8c2bf9e81329c4b16839c328
2024-06-18 10:49:37 -04:00
Xin Li f6d91d2d37 [automerger skipped] Merge "Merge Android 14 QPR3 to AOSP main" into main am: cc71aa83e1 -s ours am: e9c9245de6 -s ours
am skip reason: Merged-In Ib58ffbc33000d37eb9066354f217c95ca56091ac with SHA-1 667b7f5d7a is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/3132279

Change-Id: I1323b1afb1b48ff8d7ff62766f0c93ee8a4f7b43
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-18 05:57:09 +00:00
Xin Li 294dccb604 [automerger skipped] Merge Android 14 QPR3 to AOSP main am: f39ebbd606 -s ours am: db6763feca -s ours
am skip reason: Merged-In Ib58ffbc33000d37eb9066354f217c95ca56091ac with SHA-1 667b7f5d7a is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/3132279

Change-Id: I2089df7d0611ba93c5b3e5363f264579c56be81b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-18 05:55:19 +00:00
Mykola Podolian 490858bfba Merge "Added return before the animation is started." into main 2024-06-18 05:45:53 +00:00
Fengjiang Li 76b1669a48 Merge "[Launcher Jank] Avoid making binder call IContentService$Stub$Proxy.registerContentObserver from SettingsCache" into main 2024-06-18 03:17:52 +00:00