Commit Graph

78507 Commits

Author SHA1 Message Date
Saumya Prakash 40fc6eb323 Ensure taskbar insets for camera cutout only apply on the needed sides
For devices with a camera cutout, we only need the increased inset to
accomodate a camera cutout on the sides/orientations where the cutout
interrupts the taskbar. This change ensures that the insets are only
added when necessary.

Fix: 325508089
Test: Open an app and ensure the insets remain unchanged for 0 and 90
degree rotations. Ensure the insets for 180 and 270 degrees are still
covering the camera cutout.
Flag: N/A

Change-Id: I3ee14ffc84d72512acdb750d0f614acacefc7639
2024-02-23 19:15:44 +00:00
Treehugger Robot 45181a668b Merge "Focus a task by default when using keyboard to go to overview." into main 2024-02-23 19:08:01 +00:00
Sihua Ma a5ac9107b8 Enforce parent outline for widgets
This bounds the widget view inside BaseLauncherAppWidgetHostView
to reduce the overlap

Bug: 322919716
Flag: N/A
Test: Manual
Change-Id: I270d94e3fff96724e95f9a38ab41f83beebd1271
2024-02-23 10:22:56 -08:00
Priyanka Advani d0a1c2c023 Merge "Revert "Remove Unused parts of LauncherPrefs causing cyclical dependency."" into main 2024-02-23 18:11:50 +00:00
Priyanka Advani a80997d9eb Revert "Remove Unused parts of LauncherPrefs causing cyclical dependency."
This reverts commit 21ab3b979b.

Reason for revert: Culprit for b/326611479. Will be verifying through ABTD for confirmation and before submitting the revert.

Change-Id: Ib71791d159b3ac65ca332f58500341a1a0fe36e1
2024-02-23 18:05:39 +00:00
Sebastian Franco e28239053d Adding grid_migration_fix and narrow_grid_restore flag
Flag: ACONFIG grid_migration_fix disabled
Flag: ACONFIG narrow_grid_restore disabled
Test: NA
Bug: 325286145
Bug: 325285743
Change-Id: Ibac4f8f7df7b020582bfa6cbc5756fcb743a3d09
2024-02-23 17:55:10 +00:00
Eghosa Ewansiha-Vlachavas 957bbcd97f [2/n] Remove use of persist.wm.debug.desktop_mode_2
`persist.wm.debug.desktop_mode_2` is no longer needed as desktop
windowing now uses a runtime flag which can be modified using the command: `adb shell device_config put lse_desktop_experience
com.android.window.flags.enable_desktop_windowing_mode (true/false)`.

Flag: NONE
Fixes: 326060855
Bug: 304778354
Test: build & `adb shell device_config put lse_desktop_experience
com.android.window.flags.enable_desktop_windowing_mode true && adb
reboot` desktop windowing mode should be enabled.

Change-Id: I25d509c0912ab3266a32ad992333460332b8b0a2
2024-02-23 17:42:04 +00:00
Johannes Gallmann f3fe3b47a4 Merge "Fix flickers when invoking overview transition during predictive back-to-home" into main 2024-02-23 17:15:46 +00:00
Jakob Schneider 07c1c98dab Remove archiving test because it tests platform specifics instead of
launcher logic.

Sunny suggested to remove this test b/325283522 because we shouldn't
have any platform logic in these launchers tests.

Test: N/A
Bug: 325283522
Flag: NA
Change-Id: I6a8eea815e0cf5951f98030063447fe5fd0142eb
2024-02-23 16:20:30 +00:00
Pat Manning 5aa23d41dd Focus a task by default when using keyboard to go to overview.
Fix: 322898816
Test: TaplTestsQuickstep.java
Flag: None.
Change-Id: I6d4b0ca6593ed2ac7c7d8793954c36e55b5978de
2024-02-23 12:22:06 +00:00
Alex Chau 58bd15c6ab Fix setContentAlpha skipping all TaskViews when runningTaskId is -1
- Currently when runningTaskId is -1, it can skips setting contentAlpha for all TaskViews if they haven't been loaded, this cause RecentsView to become empty in the bug
- Can be reproduced with excludeFromRecents=true apps

Bug: 324495241
Test: swipe up from an app that has excludeFromRecents=true, e.g.
Volume Dialog, Home quick settings tile, and Routines widget; ensure RecentsView is visible after gesture settles
Flag: None

Change-Id: I9f1b4ffed6d09805c83c6e2241903c73d4ead9ad
2024-02-23 11:59:48 +00:00
Johannes Gallmann c71b48c658 Transfer coordinate into new Rect instead of in-place
Other parts of the animation rely on currentRectF to remain stable, therefore we shouldn't modify the RectF object in place.

Bug: 323628523
Flag: NONE
Test: Manual, i.e. verifying that widget close (and app close) animation animates correctly regardless of device orientation
Change-Id: I48e9ed047b956db654192eef39e5d94fbac53553
2024-02-23 12:30:46 +01:00
Johannes Gallmann 0ccdb91990 Fix flickers when invoking overview transition during predictive back-to-home
Bug: 321923510
Bug: 321968468
Flag: ACONFIG com.android.systemui.predictive_back_system_animations TEAMFOOD
Test: Manual, i.e. verifying that recents transition is not invokable during the predictive back to home animations and instead the flickerless overview transition is is invoked (same as for regular back-to-home)
Change-Id: I90029de8d0c98853d38ed8984cbe7cda3b566b5a
2024-02-23 10:29:26 +01:00
bvineeth fdf6df3226 Add tags for CUJ_TASKBAR_EXPAND/COLLAPSE
Test: Checked traces
Flag: None
Bug: b/263362887
Change-Id: I28652b0629b8033fe931809bacceeede3c36ea93
2024-02-23 03:27:54 +00:00
Vineeth Bhende 510886fc14 Merge "Fix taskbar_expand/collapse jank monitor" into main 2024-02-23 03:01:58 +00:00
Bill Yi e7815c1547 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-qpr-dev am: c966f3b8a8 -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26323009

Change-Id: Id0d0faff847be478de2ce897b2b15cc1cdd77010
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-02-23 00:47:52 +00:00
Bill Yi 26c14ffb8f [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 50923131e3 -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26323009

Change-Id: I6806e4e30f01b108d237697f42d509b932f8cb7b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-02-23 00:47:47 +00:00
Bill Yi 61002e9485 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-qpr-dev am: ee4be05240 -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26323005

Change-Id: If886573fd061b59b89b4a94564b4fbd39abe8da5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-02-23 00:47:41 +00:00
Bill Yi 31c865c058 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: d7c8a65c7d -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26323005

Change-Id: I62a6b2ba7229d1f2ae46065b8b38ed9f927ce230
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-02-23 00:47:34 +00:00
Bill Yi 786957c3e5 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: e599d65d99 -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26321152

Change-Id: Ie7c79894aa0562ad2980958b30244e2ed5b4e360
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-02-23 00:47:19 +00:00
Federico Baron cda8adfad3 Merge "Fix testDragToFolder()" into main 2024-02-23 00:41:55 +00:00
Android Build Coastguard Worker 99df364357 Snap for 11486189 from ca261fda97 to 24Q3-release
Change-Id: Iabdd6d09b594c9f40236c1f3f15aa0f94286887e
2024-02-23 00:21:16 +00:00
Android Build Coastguard Worker 3336f8c447 Snap for 11486370 from ca261fda97 to 24Q2-release
Change-Id: I0d238edc6231d44632a286dd2e86d03fea86599b
2024-02-23 00:21:06 +00:00
Vadim Tryshev c94b2a7045 Add tracing for a bug where current RecentsActivity is null
Bug: 321775748
Test: presubmit
Flag: N/A
Change-Id: I46fde7a73a3bfe02ed6276b4ac5f3e6c33bda387
2024-02-22 16:19:16 -08:00
Bill Yi 54287dcd43 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-02-23 00:10:50 +00:00
Bill Yi 697cb554a6 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-02-23 00:10:50 +00:00
Bill Yi c713939ea5 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-02-23 00:10:50 +00:00
Bill Yi c966f3b8a8 Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-qpr-dev 2024-02-23 00:07:23 +00:00
Bill Yi ee4be05240 Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-qpr-dev 2024-02-23 00:07:23 +00:00
Treehugger Robot 8b9bb8ed0b Merge "In 3-button landscape/seascape, override nav insets to always present" into main 2024-02-22 23:47:03 +00:00
Treehugger Robot b6cbb2a419 Merge "Make getTaskSize actaully a getter that does not modify member variables" into main 2024-02-22 23:03:03 +00:00
Jeremy Sim 1a98a9d874 Fix app pair launches with certain apps
This CL changes the way app pairs are saved. Previously, we saved the app pair using WorkspaceItemInfos directly from Recents, which caused certain apps to fail on launch because they weren't being launched with the correct Intent.

Now, we look up a proper launchable WorkspaceItemInfo from the AllAppsStore and save that to the app pair, which should fix the launch issues.

Bug: 323112914
Bug: 323110399
Test: Can launch Slides, Play Store, and Calendar when part of an app pair.
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I475afa1a237c50ffb0ffaf85af43912a803b8011
2024-02-22 22:58:44 +00:00
Sunny Goyal 1d6f76f811 Merge "Adding support for async view inflation" into main 2024-02-22 22:38:41 +00:00
Brandon Dayauon b177c9226e Use setFlags to disable two line toggle flag in tests.
disableFlags for Flags.FLAG_ENABLED_TWOLINE_TOGGLE

bug: 316027081
Test: presubmit/gantry/manual
BubbleTextViewTest: https://screenshot.googleplex.com/8zFHWbwCFyxTTHC
Flag: com.android.launcher3.enable_twoline_toggle DEVELOPMENT
Change-Id: I530126de6ac63395acd2d176935e6f6f9759d4c3
2024-02-22 14:19:31 -08:00
Anushree Ganjam cc971f67f5 Merge "Remove Unused parts of LauncherPrefs causing cyclical dependency." into main 2024-02-22 21:53:21 +00:00
fbaron d0f392db6e Fix testDragToFolder()
The issue here was that we were dragging to the folder icon when it was already a folder. We need to drag to the folder icon, wait for the folder to open, and then drag into the middle of the opened folder.

Fix: 320742556
Flag: NONE
Test: TaplDragTest#testDragToFolder
Change-Id: I82816f8e249cbe55fb4eef79c27e19b6fe00318e
2024-02-22 13:21:18 -08:00
Will Leshner 0467404c25 Tweak WidgetPickerActivity size filtering.
Better conform to documentation about how to use widget sizes when
filtering for sizes in WidgetPickerActivity.

Bug: 322191186
Test: atest Launcher3Tests
Flag: NA
Change-Id: I4239e64dd620e00a3c55046bfb66fe3099336aac
2024-02-22 12:50:50 -08:00
Charlie Anderson ca261fda97 Merge "Do not set click listener for CellLayout during accessible drag, to prevent double tap to activate message." into main 2024-02-22 20:26:14 +00:00
Charlie Anderson a88605df5e Merge "Add additional debug logging for when Launcher cannot find a valid activity to launch an app with." into main 2024-02-22 19:20:47 +00:00
Vinit Nayak 56392d2f65 Merge "Move updating layoutParams outside of dispatchDraw()" into main 2024-02-22 19:02:32 +00:00
Sunny Goyal 72a74669e7 Adding support for async view inflation
Bug: 318539160
Test: atest AsyncBindingTest; atest ItemInflaterTest
Flag: aconfig enable_workspace_inflation DEVELOPMENT
Change-Id: I77a373db7a5805f68f4b8cbfa9b586b5674252de
2024-02-22 10:58:48 -08:00
Saumya Prakash 502f7b94f0 Merge "Increase taskbar edu Done button size to meet accessibility requirements." into main 2024-02-22 18:40:35 +00:00
Sebastián Franco 6a55a7b4b8 Merge "Remove the initialize method from setUp since is now on being called on the super method." into main 2024-02-22 18:38:50 +00:00
Jagrut Desai 08a4e68bae Merge "Handle SystemGestureRegion in TaskbarDragLayer" into main 2024-02-22 17:55:28 +00:00
Rohit Goyal de66327e47 Merge "Bugfix: Ensure archived app icons persist when app main activity name changes post unarchival." into main 2024-02-22 17:52:02 +00:00
Alex Chau acf37d29db In 3-button landscape/seascape, override nav insets to always present
- In 3-button landscape/seascape, Launcher should always have nav insets regardless if it's initiated from fullscreen apps
- This avoid inset to change mid-way during app->overview transition via recents button
- This bug doesn't happen in portrait because bottomNav is always overriden in WindowManagerProxy, we're now applying the same fix in landscape/seascape

Test: Recents button from fullscreen app in 3-button landscape/seascape, and launch adjacent fullscreen app in Overview
Test: Homescreen and widget picker in 3-button landscape/seascape
Fix: 316085856
Flag: None
Change-Id: Ia4ae7948fe794b71c49f89c43dd2d1d14031abb9
2024-02-22 17:35:22 +00:00
Charlie Anderson 79b8ed0b9e Do not set click listener for CellLayout during accessible drag, to prevent double tap to activate message.
This is because there is no click action for CellLayout during accessible drag, as only the individual cells need to be clickable.

Bug: 318312177
Test: locally
Flag: N/A
Change-Id: I26f18a948b77a0ee889dfafa626b9176d8481aeb
2024-02-22 12:27:52 -05:00
Sebastián Franco 747ee169ed Merge "Investigating test" into main 2024-02-22 17:25:15 +00:00
Orhan Uysal 6d73b0a201 Make taskbar visibilty change only in desktop.
Make the DesktopVisibilityController not change the taskbar visibility
when there are no freeform tasks visible.

Test: Go from freeform to fullscreen, observe taskbar doesn't pop up
Bug: 323129412
Flag: ACONFIG com.android.wm.shell.enable_desktop_windowing DEVELOPMENT
Change-Id: I67f246cfc2ddc198326c093fd0af83886de8b0a9
2024-02-22 17:13:42 +00:00
Eghosa Ewansiha-Vlachavas 80232ea229 [2/n] Replace read-only desktop windowing flag with runtime flag
Replace use of `enable_desktop_windowing` flag with
`enable_desktop_windowing_mode` flag

Flag: NONE
Bug: 304778354
Fixes: 326060018
Test: build & `adb shell device_config put lse_desktop_experience
com.android.window.flags.enable_desktop_windowing_mode true && adb
reboot` desktop windowing mode should be enabled.

Change-Id: Idc44e2b7a8b738f15f8d3812a0c4fc1a4b4861c1
2024-02-22 17:02:45 +00:00