Since the widget cells are is recycled, some times, the cell occupies
more space based on the previous cell that it was recycled from. So,
we request layout to update it.
The issue is easily reproducible by first expanding app that has
single item but with large spanY. Then, expanding app with one item
but with smaller spanY (e.g. settings or sheets apps).
* Before: http://screencast/cast/NDkwOTMwOTcyMzkzNDcyMHxjMDdmZDE1Yi05Yg
* After: http://screencast/cast/NTA0NzU3Nzc5MDY0NDIyNHw1NzhkZmM0MS04OA
Bug: 289147379
Flag: N/A
Test: Manual
Change-Id: I4d003024e1db437a50de759f9390190b038a114a
This CL fixes 2 issues with app pairs:
- When an app pair is incompatible with the screen size due to a non-resizeable app (e.g. Camera), the app pair will now be properly disabled and display an error message. If the user is on a foldable, it will prompt the user to unfold their phone.
- The app pair icon will now properly redraw with lower opacity when it is disabled.
Fixes: 323088270
Test: Manually paused and unpaused apps, created Camera app pairs and tested with foldable
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I66514c96bc19f480c9788661e4dffaa5b1cdc2ca
Launcher preview could crash when unfolding a foldable device due to the
folded state display id no longer being valid, resulting in getting a
null display. This was leading to an empty preview bundle being
returned, which is unexpected because null is expected in the case of an
exception. Instead of crashing in getDisplayId, it's better to throw an
exception earlier on if the display is null and return null.
Flag: NA
Bug: 326637851
Test: manually verified by testing unfold in WPP in old and new preview
Change-Id: Ibc353d9447a71d33092d96029a812017487d0970
I’ve never seen a useful failure from these checks, and now I’m seeing a false positive error. That error is fixable by reworking the code, but I think the value of these checks is not worth the effort.
Bug: 322823209
Test: presubmit
Flag: N/A
Change-Id: If675dad254fb82a2a842ef3f9054936f38de1cff
When saving app pairs, we should grab attributes[0] and attributes[1] instead of attributes[0] and attributes[0].
Fixes: 326854996
Test: App pairs saves the correct two apps
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I8d2fc4597cf1f1bd36bc0b910cc022c79a48f067
Flag: N/A
Fixes: 324228222
Test: forcicly set SystemUiProxy.mRecentTasks to null. multiple startRecentsActivity call attempts were made rather than just one
Change-Id: I2e5f8cc0cf47a143dcd7985b31292bb4d8cbbcad
* TL;DR Loading workspace icons only requests high res icons for apps
on workspace or in hotseat, not for folders or app pairs. They need to
request that separately
* See notes on bug for root cause
Test: Created many app pairs, empty icons does not repro.
If I remove my change issue consistently repros, not a race condition
Fixes: 323106492
Change-Id: I05ba5e8e8b0eddd4041642f89d06deff85511e40
The predictive back infra checks the opt-in status when a callback is registered, and drops the registration if the Application / Activity is not opted-in
Fix: 326627953
Test: manual
Flag: ACONFIG launcher.enable_predictive_back_gesture DISABLED
Change-Id: I8f2e2378d0bf966b3784cf08c12045509b6d5682
This change addresses a recent regression that caused quick switch to not scale up to full screen during the launch animation.
Fix: 326625526
Test: Launch quick switch from home and ensure it is a smooth transition
Flag: N/A
Change-Id: Id94d5d3eae0625225f880897e1e5f3cf9e4fea6c
Sam Cackett
Shamali Patwa
Treehugger Robot
Himanshu Gupta
Uwais Ashraf
Luca Zuccarini
Helen Cheuk
fbaron
Jeremy Sim
Fengjiang Li
Android Build Coastguard Worker
Brandon Dayauon
Vadim Tryshev
LaMont Jones
Catherine Liang
Jakob Schneider
Schneider Victor-tulias
Vinit Nayak
Jordan Silva
Orhan Uysal
Andy Wickham
Saumya Prakash
William Leshner
Johannes Gallmann