Commit Graph

78507 Commits

Author SHA1 Message Date
Fengjiang Li e24af582c6 Merge "Use Matrix.setRectToRect() replace RectUtils.letterBox()" into main 2024-03-07 17:28:11 +00:00
Sebastian Franco bd43b9344f Removing all restored backups except one so we don't have old backups
Adding test to make sure this is the case.

Bug: 325285743
Flag:  ACONFIG narrow_grid_restore disabled
Test: BackupAndRestoreDBSelectionTest
Change-Id: I84c3a92f40598137d5c5c52d34af7583b384122c
2024-03-07 11:23:55 -06:00
Himanshu Gupta e2ae040e35 Merge "Revert Accidental tweak of work profile behaviour" into main 2024-03-07 13:54:11 +00:00
Xin Li 7982d20b7d [automerger skipped] Merge "Merge Android 14 QPR2 to AOSP main" into main am: 17dabff1dd -s ours am: aaa0ea8b80 -s ours
am skip reason: Merged-In Ic9b3be62af2271286292cfaf30bda03351c1aaf6 with SHA-1 962f362912 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2989920

Change-Id: Ia206f8e1985d35cfd63b6df2650be2f53358eb8d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-07 10:49:10 +00:00
Xin Li ac83be1cbe [automerger skipped] Merge Android 14 QPR2 to AOSP main am: 7e8ae158f4 -s ours am: 462787eaed -s ours
am skip reason: Merged-In Ic9b3be62af2271286292cfaf30bda03351c1aaf6 with SHA-1 962f362912 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2989920

Change-Id: Id82c1d5adc73eb2a12607ad3c1ce87bd194b34cb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-07 10:46:18 +00:00
Xin Li aaa0ea8b80 [automerger skipped] Merge "Merge Android 14 QPR2 to AOSP main" into main am: 17dabff1dd -s ours
am skip reason: Merged-In Ic9b3be62af2271286292cfaf30bda03351c1aaf6 with SHA-1 962f362912 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2989920

Change-Id: If7a0f00e42b2c43fd41362738028bbf8e8b1449a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-07 09:57:48 +00:00
Xin Li 462787eaed [automerger skipped] Merge Android 14 QPR2 to AOSP main am: 7e8ae158f4 -s ours
am skip reason: Merged-In Ic9b3be62af2271286292cfaf30bda03351c1aaf6 with SHA-1 962f362912 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2989920

Change-Id: Ia850c7cb3ae50af55d83fef5e368c505451214e0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-07 09:54:53 +00:00
Himanshu Gupta 68532621bb Merge "Disable Saving App Pairs for Private Space Apps" into main 2024-03-07 08:49:59 +00:00
Xin Li 17dabff1dd Merge "Merge Android 14 QPR2 to AOSP main" into main 2024-03-07 06:41:07 +00:00
Brandon Dayauon 5b5110a782 Change collapse to use adapterItems instead of getting the childCount()
Using childCount() doesn't work since it only shows what is visible on the screen.
This is an issue because if the header was somewhat slightly off screen, it wouldn't scroll up upon
clicking the button.

bug: 299294792
Test:
before: https://drive.google.com/file/d/1T4rvfR3_rNmR8tRZheBXNbYjCrSubmy7/view?usp=sharing
after: https://drive.google.com/file/d/1T4UdddM7MH4onEfNdyhDM-RowKHfvjop/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.private_space_animation TRUNKFOOD
Change-Id: I209e3ec707bfbdc2ef5e98034149459286903854
2024-03-06 18:13:16 -08:00
Android Build Coastguard Worker cb17c2449f Snap for 11540345 from 189f3f8621 to 24Q3-release
Change-Id: Ic44d16ba5065ebd328ce5c12bd2f0bef169955ae
2024-03-07 02:10:33 +00:00
Brandon Dayauon d0bec45d37 Upon expanding, expand just enough so the header shows.
This issue only happens when there is a lot of private space apps that scrolling to the bottom
will not sure the private space header.

Formula to calculate how many rows to scroll to =
	(appListHeight - privateHeaderHeight - headerProtectionHeight) / cellHeight.

bug: 299294792
Test:
manually - https://screenshot.googleplex.com/76UJPT2Jnpnp2Ab
before: it just scrolls all the way to the bottom
after: https://drive.google.com/file/d/1AbprxFm1RWTQKvpt7M4khbUfc1o6-XGF/view?usp=sharing
after PHONE WITH TABS:
2x2- https://drive.google.com/file/d/1SLPsWPHenCuZuisiS7HeEy5JwtNPeONs/view?usp=sharing
3x3- https://drive.google.com/file/d/1SK82jeNZMzFJK2odIuHnfTNLYfppne83/view?usp=sharing
4x4- https://drive.google.com/file/d/1T7EhFRq2tDv2zYIvs_FMsTKcFZXwGUaD/view?usp=sharing
4x5- https://drive.google.com/file/d/1SMUPuKjO1Yg36U6P6cDOb6dTkHn6Bh7D/view?usp=sharing
5x5- https://drive.google.com/file/d/1SJCQn1O_Yq5P7C__VUfZHc5I67CEdIpb/view?usp=sharing

AFTER PHONE NO TABS:
2x2: https://drive.google.com/file/d/1THU2xrAIt0hTmN5_GwBrgN9Lqj-W4Kfr/view?usp=sharing
3x3: https://drive.google.com/file/d/1TPTUx7PcHW3GsVwVAg_L5rCcn0QYoiY2/view?usp=sharing
4x4: https://drive.google.com/file/d/1TWVWpAX6bZp_JfFKtmXYO0askl4e5qKO/view?usp=sharing
4x5: https://drive.google.com/file/d/1TDJK-swmY3Y3C4ARH_2eljqUkBGEnD3e/view?usp=sharing
5x5- https://drive.google.com/file/d/1TBJtAynwvZrGyOc-29f637wyrJZpMXBJ/view?usp=sharing

Tablet:
landscape: https://drive.google.com/file/d/1SfyPdoUnCV7e7BWLnpxXWN2HiBOQkRo2/view?usp=sharing
portrait: https://drive.google.com/file/d/1SgZq0iE9WMvIFtc8mBb577nYlS9jBa_g/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.private_space_animation TRUNKFOOD

Change-Id: If70df1299572f8f2edc6376dd2a6df5d74287264
2024-03-06 18:04:09 -08:00
Vinit Nayak 583739f1dd Disable gestures when split apps are animating in from shell
Bug: 286509643
Test: See other CL in topic
Change-Id: Idf16d6db15ea5ed46c3249a10856c7ee96e981ef
2024-03-06 17:28:10 -08:00
Fengjiang Li c6ae88f904 Use Matrix.setRectToRect() replace RectUtils.letterBox()
Bug: 284236964
Flag: aconfig launcher.enable_add_app_widget_via_config_activity_v2 DISABLED
Test: manual
Change-Id: Ia83f3415442c2359bffb1efcfd1ee96bf17ab9ff
2024-03-06 17:04:02 -08:00
Uwais Ashraf 21393f4651 Merge "Add required setup for quickstep tests to be run devicelessly" into main 2024-03-06 23:32:14 +00:00
Ats Jenk 4186cf1b96 Fix bubble bar arrow visibility during animation
Bubble bar pointer arrow was being drawn outside of BubbleBarView
bounds.
This caused issues when alpha was applied to the BubbleBarView. With
alpha, BubbleBarView draw was clipped to its bounds and arrow was no
longer visible. This led to the arrow flickering during move animations.
Move animation updates alpha.
Move the pointer arrow inside the bounds of the bar view. Update the bar
height to include the arrow.
Update callers who rely on bubble bar content height to take into
account extra height for the arrow.

Bug: 313661121
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: move bubble bar left and right, observe arrow is visible
Change-Id: I05866b5c944361b2f10437c3641527ed3c594047
2024-03-06 15:06:05 -08:00
Ats Jenk 77b6225d91 Animate bubble bar location changes
When it is not the initial bubble data, animate bubble bar location
change.

Bug: 313661121
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: manual, move expanded view from one side to the other, observe the
  location change animates

Change-Id: I52117a31d02e7160ca1d3dc3e724bda2e38f6cbf
2024-03-06 15:03:57 -08:00
Himanshu Gupta 189f3f8621 Merge "Fixing Layout height for Private Space container" into main 2024-03-06 21:56:45 +00:00
Jeremy Sim 46aa4a58f8 Merge "Fix bug with app pairs appearing in wrong orientation in pinned Taskbar" into main 2024-03-06 21:56:34 +00:00
Anushree Ganjam a61e05ebab [automerger skipped] [DO NOT MERGE] Enable omnient flags in P8a branch. am: 0d3016943c -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26418344

Change-Id: I95903f796710719885d396e0d91379cb9dfad3f0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-06 18:53:44 +00:00
Vinit Nayak d1fb97ae64 Merge "On disabled app pairs, set color tint instead of changing alpha" into main 2024-03-06 18:39:19 +00:00
Vadim Tryshev 7a4b8a4513 Further syncing Launcher3 atest XML config with the GCL one
Test: abtd
Flag: N/A
Bug: 271324404
Change-Id: I51f02c290fa2efba2d7dac68090105e67b017f51
2024-03-06 10:36:55 -08:00
Ats Jenk cd0f35383f Introduce bubble bar location that is driven by shell
Adds bubble bar location to the update object that is sent by shell.
Allows repositioning the bubble bar if the location changes.

Bug: 313661121
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT

Test: manually sending the update to reposition, dragging coming soon
Change-Id: Id430a98116d860a7badcf607edc166c751e12cf8
2024-03-06 10:17:11 -08:00
Jakob Schneider 343d99781f Improve "isActiveArchive" check by moving it a bit earlier into the
method.

Apply progress level doesn't need to be called unless the app is
actively being unarchived.

Previously this was fixed by adding a check directly in
"setIsDisabled()" which is not quite the right place (we can exit
earlier).

Bug: 326218355
Test: manual
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving TRUNKFOOD
Change-Id: Ia12013dbcec2d40413a6cf819f8d1787b815adc1
2024-03-06 18:12:53 +00:00
Brandon Dayauon b2f5bb00f4 Merge "Update icon background color of the private space widget tile" into main 2024-03-06 18:07:03 +00:00
Xin Li 7e8ae158f4 Merge Android 14 QPR2 to AOSP main
Bug: 319669529
Merged-In: Ic9b3be62af2271286292cfaf30bda03351c1aaf6
Change-Id: I2af35abec8a5f2c046192cac6006d9cc759d93c9
2024-03-06 09:30:05 -08:00
Catherine Liang d56332892d Merge "Fix Launcher preview crash" into main 2024-03-06 16:57:16 +00:00
Anushree Ganjam 0d3016943c [DO NOT MERGE] Enable omnient flags in P8a branch.
Bug: 327638681
Test: NA
Flag: legacy ENABLE_LONG_PRESS_NAV_HANDLE_MPR ENABLED
Change-Id: Ic2565c5c67f6877b88138f527e09a63dfcda47bf
2024-03-06 16:45:19 +00:00
Rohit Goyal 877da31569 Bugfix: Remove widgets and deep shortcuts of app which gets archived.
* Once app is archived, remove widgets and deep shortcuts corresponding to the app from the home screen.
* However during backup & restore, widgets should not be removed if they are being restored.

Test: verified bugfix locally.
Bug: 326567866
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:bef2930f5a29655f6c403f2d5eefd4e99a733b04)
Merged-In: Ib3a112aadc7bd901fd6a0ba86f472ec6acf8d626
Change-Id: Ib3a112aadc7bd901fd6a0ba86f472ec6acf8d626
2024-03-06 14:48:09 +00:00
Uwais Ashraf 45cd460cef Add required setup for quickstep tests to be run devicelessly
Fix: 325090628
Flag: NA
Test: gradlew :NexusLauncher:testGoogleWithQuickstepDebugUnitTest
Test: atest NexusLauncherRoboTests
Test: presubmits passing
Change-Id: I9ef80d4bf03e9bdb6c23d776df621a32248e6b0d
2024-03-06 14:01:21 +00:00
Himanshu Gupta e7b86b22b8 Disable Saving App Pairs for Private Space Apps
This change disables saving App Pair from recents
into launcher workspace when any of the app in pair
belongs to Private Space.
Private Space are still allowed in Split Mode

Bug: 322892793
Test: Manual on device
Flag: ACONFIG com.android.launcher3.private_space_restrict_accessibility_drag TRUNKFOOD
Change-Id: I204b721ce3a2bf4ebfd7419c25d72a77fd8174ac
2024-03-06 10:45:40 +00:00
Andreas Agvard d632f22258 Merge "Adds new AssistStateManager settings" into main 2024-03-06 09:37:17 +00:00
Jeremy Sim 999ab5215a Fix bug with app pairs appearing in wrong orientation in pinned Taskbar
This CL makes it so that app pairs do an orientation check in dispatchDraw() instead of only on init().

Previously we only checked orientation on AppPairIcon.inflateIcon(), and the issue was that orientation was not re-checked when pinned Taskbar was rotated to different sides of the screen. Added a DeviceProfileListener to update orientation when DP changes.

Fixes: 323288812
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual, app pair icon always has correct otientation on pinned taskbar
Change-Id: If2de1a4c7334fef1ba4c2edcca09bef9338bc73f
2024-03-05 22:32:36 -08:00
Jeremy Sim 09fe96b95a On disabled app pairs, set color tint instead of changing alpha
This CL changes the way disabled app pair icons are drawn: instead of setting alpha, it sets a color filter to indicate disabled status. This brings it in line with other apps icons and V's design specs.

Fixes: 326665140
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual
Change-Id: Ifc8ac694f321a6b28996ba9a42860dfc419d5901
2024-03-05 21:45:00 -08:00
Fengjiang Li 7dea7f0b42 Merge "[2/n] Avoid flicker to drop a widget that needs a config activity" into main 2024-03-06 02:03:48 +00:00
Fengjiang Li f114ec5b26 Merge changes Iab1de455,I0c6585e6,I125670d1 into main
* changes:
  [Predictive Back] Recover taskbar all apps scale to 1f with animation if user swipe back within search [3/n]
  [Predictive Back] Dismiss taskbar all apps's scroll bar during swipe gesture [2/n]
  [Predictive Back] Fix predictive back swipe on task bar all apps [1/n]
2024-03-06 01:32:17 +00:00
Holly Sun 20c30c9cdc [PS] Do not use AppInfo and use PrivateSpaceInstallAppButtonInfo instead.
BaseAllAppsAdapter.AdapterItem's itemInfo needs to be an AppInfo. Create PrivateSpaceInstallAppButtonInfo extending from AppInfo and use different itemType (AppInfo has default itemType ITEM_TYPE_APPLICATION). In this case, shortcuts is disabled in ShortcutUtil#supportsShortcuts because `isApp` is false (https://source.corp.google.com/h/googleplex-android/platform/superproject/main/+/main:packages/apps/Launcher3/src/com/android/launcher3/util/ShortcutUtil.java;l=30?q=shortcututil&sq=repo:googleplex-android%2Fplatform%2Fsuperproject%2Fmain%20b:main).

After the fix, long click on Install button quits Toast, which is the same with drag action on the button.

Since we have a specific itemType for PS install button now, the previous `FLAG_PRIVATE_SPACE_INSTALL_APP` is no longer needed. Remove it.

Bug: 324211283
Test: manual
Flag: aconfig com.google.android.apps.nexuslauncher.private_space_app_installer_button trunkfood
Change-Id: Ic5d4284afb93cef77f2ad8f0c1588523e0ed3ae3
2024-03-05 17:13:35 -08:00
Android Build Coastguard Worker 2c52916286 Snap for 11533280 from e874bd603d to 24Q3-release
Change-Id: I08de8977345db0db689aa1639e76f04d496c718b
2024-03-06 00:20:37 +00:00
Fengjiang Li fb16517fea [2/n] Avoid flicker to drop a widget that needs a config activity
1. Don't show background in PendingAppWidgetHostView if we are showing preview bitmap
2. Extract bitmap from DropView instead of LauncherAppHostView
3. Letterbox bitmap into PendingAppWidgetHostView's canvas if canvas has different aspect ratio

Fix: 284236964
Flag: aconfig launcher.enable_add_app_widget_via_config_activity_v2 DISABLED
Test: manual
Change-Id: I76de215186b96ffe65c909b28155fb19ac90d4f1
2024-03-05 14:49:09 -08:00
Federico Baron 944ed16981 Merge "Page resets when scrolling slowly fix" into main 2024-03-05 22:43:01 +00:00
Fengjiang Li cc1c582d89 [Predictive Back] Recover taskbar all apps scale to 1f with animation if user swipe back within search [3/n]
Fix: 327490078
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Test: manual
Change-Id: Iab1de455bf23d73b34f4a0d60f7e7a143bd028d1
2024-03-05 14:02:53 -08:00
Fengjiang Li 9280a68bbd [Predictive Back] Dismiss taskbar all apps's scroll bar during swipe gesture [2/n]
Bug: 327490078
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Test: manual
Change-Id: I0c6585e6374db9412c8399ce3fdaf57348043d36
2024-03-05 14:02:53 -08:00
Fengjiang Li cad1f13d27 [Predictive Back] Fix predictive back swipe on task bar all apps [1/n]
For taskbar all apps, the background scrim is child view of AbstractSlideInView, thus scaling AbstracSlideInView during PB swipe will scale down background scrim. There is no need to re-apply scale effect on background scrim separately.

Bug: 327490078
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Test: manual
Change-Id: I125670d14bc788664a1371008589e4106496ae2e
2024-03-05 14:02:45 -08:00
Catherine Liang 0089efe18a Remove createWindowContext in Launcher preview renderer
The line causes an error in Window Manager. When removed, it doesn't
seem to have an effect for the Wallpaper Picker use case. The preview
render still shows correctly after config changes including rotation
and dark/light theme because the picker restarts and re-requests a
preview.

Flag: NA
Bug: 328089367
Test: manually tested with config changes and different lifecycle cases
Test: manually tested with multi crop flag on and off
Change-Id: Id1bd30c7ab4c50d29622b647bd368aafbd5c043f
2024-03-05 20:32:45 +00:00
Brandon Dayauon 40ea056886 Update icon background color of the private space widget tile
This icon background should be the same as the web icon backgrounds in Toast which is: materialColorSurfaceContainerLowest

bug: 320562455
Test: Manual - photos:
after private space qstile quicklaunchable dark theme: https://drive.google.com/file/d/1UZUxOdyEMEyLmPhnuPWJ085gQHrGgUdC/view?usp=sharing
after private space qstile nonquicklaunchable dark theme: https://drive.google.com/file/d/1UOoR0VHxdIIvMFfvhc_5MwHsg40wURA3/view?usp=sharing
after private space qstile quicklaunchable light theme: https://drive.google.com/file/d/1Ub1Nra_5rMlWuciI_a6yJM48EL6IdEsp/view?usp=sharing
after private space qstile nonquicklaunchable light theme: https://drive.google.com/file/d/1UidMqcHI2rXTtwmwIRXkGiKJkaeP8ubi/view?usp=sharing
Flag: com.google.android.apps.nexuslauncher.enable_inject_private_space_tile

Change-Id: Id118a6cc69d091b216c49b7fe778d8b6c84966b2
2024-03-05 12:00:12 -08:00
Jeremy Sim e874bd603d Merge "Remove finished TODO" into main 2024-03-05 19:59:40 +00:00
Vadim Tryshev c96bfc32bf Merge "Syncing Launcher3 atest XML config with the GCL one" into main 2024-03-05 19:29:36 +00:00
Saumya Prakash af85ef74cc Merge "Increase the delay in between gesture tutorials" into main 2024-03-05 19:25:23 +00:00
Sunny Goyal 28ade08654 Merge "Using fractions in MultiValueUpdateListener instead of absolute durations" into main 2024-03-05 19:07:46 +00:00
fbaron cae498032f Page resets when scrolling slowly fix
Fix: 324071635
Flag: NONE
Test: Verified manually on RTL and non-RTL
Change-Id: Id778a0a01505d30bca4f216322f3ef3b951e63a7
2024-03-05 10:06:14 -08:00