> Making SafeCloseable implementation mandatory, to prevent leaks during test and preview
> Removing getNoCreate method and defining executeIfCreated to avoid null pointer exceptions
> Fixing sandbox value leaking into main, by Checking sandbox against App context
> Converting sanbox to an interface instead a class
Bug: 335280439
Test: Presubmit
Flag: None
Change-Id: I951dcde871898e745ff6490a1c4f8fd1512888f5
* changes:
If the user only had the default db, then migrate to the new default
Set default grid when doing a backup and restore
Making 2 flags read only since they are used on backup and restore
In the case the gird migration goes to a taller grid keep the grid configuration
Revert^4 "Removing all restored backups except one so we don't have old backups"
Add testing for GridMigration.
Refactor migrateGridIfNeeded to pass the grid states and make it easier for unit testing
For taskbar unification, we should reset this bit to false when folding
into phone orientation. Otherwise, we will reinit Taskbar AllApps over
the phone UI which is unexpected behavior.
Test: Manual
Flag: N/A
Fix: 293379641
Change-Id: I53c38c8b4df477191be3c21b7750c55a71c7336f
(cherry picked from commit 6d63e7796d)
Merged-In: I53c38c8b4df477191be3c21b7750c55a71c7336f
Taskbar All Apps exists regardless of the default launcher. Thus, we can
toggle it on large screen devices. This CL ties registering the system
action to default launcher and taskbar's enablement.
Test: adb shell input keyevent 117
Test: AllAppsActionManagerTest
Flag: LEGACY ENABLE_ALL_APPS_SEARCH_IN_TASKBAR ENABLED
Fix: 317259709
(cherry picked from commit c113b277e6)
Change-Id: Ib4d029617442ebf0f637f7e146aa5d001a065515
Merged-In: I26f0ed9e921beac762f3f9e6aaceb1002ad4801a
Taskbar tests are flaking when desktop windowing is enabled due to calculator app being launched in splitscreen unexpectedly during test setup (due to unexpected effect of DesktopModeLaunchParamsModifier on activity launch.) While looking into root cause, this temporary fix to address the test failures ensures that calculator app is always launched in fullscreen, by enforcing it with ActivityOptions.
Bug: 333446588
Bug: 333446588
Flag: None
Test: atest NexusLauncherTests:com.android.quickstep.TaplTestsTaskbar
Test: forrest build with CL (https://android-build.corp.google.com/builds/abtd/run/L47500030003265061)
Change-Id: If12e8490214aa1dd5de89ff8535495c2a0c1fe82
b/336326937 shows that getAppUsageLimit is being called a lot and it's scheduled on a thread pool, which is causing quite a lot of contention and should be scheduled on a single thread
Fix: 336326937
Flag: NONE
Test: presubmit
Change-Id: Ie041e72f2bff9f5d2dbfa4ce3c63a4bb2e5b08d4
The time in between each gesture's finish page and the start of the next
gesture tutorial was too short. We increased the time we spend on the
finish page by 1000 ms based on this feedback.
Fix: 293967263
Test: Run through the gesture tutorial and note the longer pause in
between each gesture
Flag: LEGACY ENABLE_NEW_GESTURE_NAV_TUTORIAL ENABLED
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:959dff122049349e25cfec82e78c6ae6db9fa7d6)
Merged-In: I2c22e19dff91ac720877e596df90efe7f3cfcd80
Change-Id: I2c22e19dff91ac720877e596df90efe7f3cfcd80
for Pixel own widgets.
The pixel own widgets can have categories and getWidgetProviderInfoByProviderName
might not find the right widget if the widget has a category.
Flag: NA
Test: Manaul testing =(
Test: Make sure the placement in the widget picker is correct.
Test: All widgets in widget_section.xml with alsoKeepInApp set to false will previously dissapear on the preview.
Fix: 331628371
Change-Id: I1e4c8ae3dd21f8aef3e4aac99ce6ce6701e94760
We also check if the new default is bigger than or equal to the
previous one.
Flag: ACONFIG enable_grid_migration_fix enabled
Flag: ACONFIG enable_narrow_grid_restore enabled
Bug: 325286145
Bug: 325285743
Test: BackupAndRestoreDBSelectionTest.kt
Test: GridMigrationTest.kt
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:12678a536b747279bb7ce04557696aae6725ce33)
Merged-In: I98315a4e4c112ca96a74200dd76016803dfaf820
Change-Id: I98315a4e4c112ca96a74200dd76016803dfaf820
When restoring from a tablet because phones don't have
the same table some issues can ocure because we setup a
non valid grid, the correct thing is to setup a default.
Bug: 325285743
Fix: 332964986
Flag: ACONFIG narrow_grid_restore enabled
Test: BackupAndRestoreDBSelectionTest
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:df7d2b08614adfd19245577724588307ff439a7d)
Merged-In: I28bf02e83dddf5ae84818d879a5e21600eddf67e
Change-Id: I28bf02e83dddf5ae84818d879a5e21600eddf67e
For example going from 4x5 to 4x6 it will keep the 4x5 configuration
which fits in the 4x6 grid.
Also, it fixes GridMigrationTest which was flaky because of
how it sorted arrays.
Bug: 325286145
Flag: ACONFIG grid_migration_fix disabled
Test: NA
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:2eaf15c37a051fd17c18c4443a8bd19d39057bf0)
Merged-In: I6063e3c303320096f7429a3b1d909e107d2ef2a0
Change-Id: I6063e3c303320096f7429a3b1d909e107d2ef2a0
- This is in preparation for other things that can be loaded with
PMH initialization and prevents duplicate temporary helpers from
loading this many times.
- Most calls in PMH can use the app context, but one call requires
starting activities/showing toasts so that one needs to take the
context and can be made static instead.
Bug: 323112914
Test: atest NexusLauncherTests
Change-Id: Id11c780955880cf49c022cbf2744c41e1b696355
This change adds an unlabeled activity to test the overview select action. The test evaluates the overview modal task state to verify that the UI displays correctly.
Using an activity without a label prevents flakiness from AiAi, which sometimes shows the activity title as selected and sometimes does not.
Bug: 332750488
Flag: NA
Test: OverviewTaskSelectImageTest
Change-Id: I6b63f1410bc466ac6711b0ca3d609d8f7a31d8c1
Sebastián Franco
Sunny Goyal
Android Build Coastguard Worker
Jagrut Desai
Brian Isganitis
Treehugger Robot
dakinola
Liran Binyamin
Federico Baron
Bill Yi
Randy Pfohl
Fengjiang Li
Julie Pan
Saumya Prakash
Schneider Victor-tulias
Jordan Silva
Mykola Podolian
Winson Chung