Commit Graph

78507 Commits

Author SHA1 Message Date
Alex Chau 576d6ba60e Avoid unnecessarily add stub task for Desktop task
- ag/27016210 caused a regression for DesktopTaskView, where shouldAddStubTaskView returns false whenever DesktopTaskView have multiple tasks
- This is because for an unknown reason, runningTasks for Desktop task is always a single element array. This will be further investigated in b/249371338
- For now, shouldAddStubTaskView will still match DesktopTaskView if any runningTasks matches any of the tasks

Bug: 333844287
Test: With 2 split tasks, unsplit one, go to Overview, launch the other split, unsplit, go to Overview
Test: Swipe up from desktop
Flag: NONE
Change-Id: I40cff473595a21ad1619bcdbde30bb8bfd600e15
2024-04-24 12:25:03 +01:00
helencheuk ce0f8595b7 Disable launcher focus outline animation
Bug: 335424188
Test: Manual
Flag: ACONFIG com.android.launcher3.enable_focus_outline Teamfood
Change-Id: I31c63607c914da956d7c6139cc5089fe419f40e1
2024-04-24 11:37:30 +01:00
Treehugger Robot f87a1ec91e Merge "Add permanent TaskView logs to track taskIds being launched" into main 2024-04-24 10:14:44 +00:00
Himanshu Gupta 6fc5e7a010 Merge "Adding Tapl tests for User Installed App in PS." into main 2024-04-24 09:25:28 +00:00
Alex Chau aa10f54ace Add permanent TaskView logs to track taskIds being launched
Sample logs:
```
04-24 09:26:08.713 12608 12608 D TaskView: launchTaskInternal - launchExistingSplitPair: [1078, 925]
04-24 09:26:11.092 12608 12608 D TaskView: launchTasks - composeRecentsLaunchAnimator: [1078, 925]
04-24 09:26:13.940 12608 12608 D TaskView: launchTaskAnimated - startActivityFromRecents: [933, -1]
04-24 09:26:16.254 12608 12608 D TaskView: launchTasks - composeRecentsLaunchAnimator: [933, -1]
```

Bug: 310064698
Test: manual
Flag: None
Change-Id: Ic190bc9ea749ba4c8324832be8bc86112947b9ba
2024-04-24 09:26:20 +01:00
Alex Chau b014f6485b [automerger skipped] Add stub task when matching TaskView is grouped while runningTasks is not grouped am: f7555925c1 -s ours
am skip reason: Merged-In I2f33f91956d485957cedf43ccd684f16d42803be with SHA-1 492965326e is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27076768

Change-Id: I1c94b22c32eaaf516c3b75e69b90ec2cb13e8d9d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-24 08:06:51 +00:00
Alex Chau f7555925c1 Add stub task when matching TaskView is grouped while runningTasks is not grouped
- Completely rewrote shouldAddStubTaskView to simplify the logic

Fix: 333844287
Test: With 2 split tasks, unsplit one, go to Overview, launch the other split, unsplit, go to Overview
Flag: None
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:492965326e7391c8427b6fca7875508e7a957b49)
Merged-In: I2f33f91956d485957cedf43ccd684f16d42803be
Change-Id: I2f33f91956d485957cedf43ccd684f16d42803be
2024-04-24 07:08:50 +00:00
Alex Chau 0e5a4bb4bd Merge "Add stub task when matching TaskView is grouped while runningTasks is not grouped" into main 2024-04-24 07:07:50 +00:00
Sunny Goyal ee6f471f3f Merge "Using settings cache for listening to haptic feedback setting" into main 2024-04-24 01:25:50 +00:00
Android Build Coastguard Worker d5f6792616 Snap for 11753769 from 48d7c10a82 to 24Q3-release
Change-Id: I1c286558b56dde01774d0b56b8b7034558dcc91a
2024-04-23 23:21:54 +00:00
Julie Pan f3296f800d Merge "Remove mateuszc@google.com from quickstep/tests/OWNERS" into main am: 2eadab3702 am: f18ee90f03
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/3038502

Change-Id: I47a7f594de62981ca4252c524e218597002d29b0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-23 22:38:21 +00:00
Julie Pan f94f2c1b33 Merge "Remove mateuszc@google.com from tests/OWNERS" into main am: f6519bd225 am: d2a665cc7f
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/3041215

Change-Id: Ie2f658f4f67033c5e1de6327f6e53016d97ba132
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-23 22:37:48 +00:00
Daniel Akinola a0ce634e2c Merge "Force calculator to launch in fullscreen for quickswitch tests" into main 2024-04-23 22:33:50 +00:00
Julie Pan a9cf79324a Merge "Merge "Remove mateuszc@google.com from tests/shared/com/android/launcher3/testing/OWNERS" into main am: 06b1e6da76 am: f3d584f4f6" into main 2024-04-23 22:32:30 +00:00
Brian Isganitis a5af76bbde [automerger skipped] Merge "Support toggling Taskbar All Apps with 3P Launcher." into 24D1-dev am: 0db4a1aac5 -s ours
am skip reason: Merged-In I26f0ed9e921beac762f3f9e6aaceb1002ad4801a with SHA-1 176f186a6d is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27057905

Change-Id: I75207310d4e6503942a32f804c4247d6dd777c57
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-23 22:32:20 +00:00
Brian Isganitis 6138534c2b [automerger skipped] Support toggling Taskbar All Apps with 3P Launcher. am: c383204356 -s ours
am skip reason: Merged-In I26f0ed9e921beac762f3f9e6aaceb1002ad4801a with SHA-1 176f186a6d is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27057905

Change-Id: I0323d6d5f9af93bebfbb34917fb5c661a13063d6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-23 22:32:17 +00:00
Brian Isganitis 5247849454 Make IME force stash the Taskbar.
This change moves the IME flag to be part of FORCE_STASHED rather than
STASHED_IN_APP, since there are cases where we are not in an app but
still want to stash the IME.

You can still bring up transient taskbar over IME since we do not set
the IME flag for transient mode (see TaskbarStashController#shouldStashForIme() first guardrail).

Test: Manual
Flag: N/A
Fix: 336592511
Change-Id: Iafa32b1a52f4bfbc0d3a4e77b19c82149dc42d0a
2024-04-23 18:30:24 -04:00
Brian Isganitis 0db4a1aac5 Merge "Support toggling Taskbar All Apps with 3P Launcher." into 24D1-dev 2024-04-23 22:13:11 +00:00
Uwais Ashraf e21525da40 Add a refactored TaskThumbnailView
- Live Tile, swipe (left+right) and dismiss working
- Tests of ViewModel state transitions
- Deprecate the old TaskThumbnailView
- Renaming TaskThumbnailView to TaskThumbnailViewDeprecated

Fix: 335440878
Fix: 331754672
Bug: 331753115
Test: TaskThumbnailViewModelTest
Test: Attached video on bug
Flag: ACONFIG com.android.launcher3.enable_refactor_task_thumbnail DEVELOPMENT
Change-Id: I063b957fe6e56960970dcaadc641848fbd73251c
2024-04-23 23:05:14 +01:00
Saumya Prakash 17cd6ca62a Only run search edu when enabled, also make code more generic.
We only need to run the Search edu if it is enabled on devices. The code
itself is also made more generic in terms of method and variable names.

Fix: 330401405
Test: Enable and disable the search function and check whether the edu tooltip shows
up for each specific use case.
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning NEXTFOOD

Change-Id: I1cea3ee56922c0b47ae7e8379aad4b36570daa17
2024-04-23 22:02:15 +00:00
Brandon Dayauon 782af232e3 Merge "Update badge color to textColorPrimaryInverse" into main 2024-04-23 20:42:56 +00:00
Treehugger Robot f005766ff3 Merge "Fix horizontal spacing in PS Header" into main 2024-04-23 20:17:20 +00:00
Sebastián Franco 48d7c10a82 Merge "Make sure we keep the screen record even if the test succeeds" into main 2024-04-23 19:49:44 +00:00
Alex Chau 492965326e Add stub task when matching TaskView is grouped while runningTasks is not grouped
- Completely rewrote shouldAddStubTaskView to simplify the logic

Fix: 333844287
Test: With 2 split tasks, unsplit one, go to Overview, launch the other split, unsplit, go to Overview
Flag: None
Change-Id: I2f33f91956d485957cedf43ccd684f16d42803be
2024-04-23 20:37:44 +01:00
Willie Koomson f88bf7e23f Merge "Fix issue with tap-to-add on recycled WidgetCells" into main 2024-04-23 18:53:33 +00:00
Sunny Goyal 99d9c7efbd Using settings cache for listening to haptic feedback setting
Bug: 335280439
Test: Presubmit
Flag: None
Change-Id: I5732875c1e3ce6468078b4bfdc2fa0eb7a29f0de
2024-04-23 11:30:00 -07:00
Treehugger Robot 62a1a8a336 Merge "Move PreInstalled App List to UserCache." into main 2024-04-23 18:24:01 +00:00
Brandon Dayauon 4f781aeac0 Update badge color to textColorPrimaryInverse
Just got updated textColorPrimaryInverse color to use on badge to support the themedness. This color
is consistent with the popup icon colors that is already being used.

bug:324574278
Test after:
dark theme: https://drive.google.com/file/d/1Q9BKlbw0bi5yz-wzPa160JMBEqK7QKcJ/view?usp=sharing
light theme: https://drive.google.com/file/d/1QH_FSOo8H63K_8WKfiDuV1ypGqctYMqt/view?usp=sharing
Flag: None

Change-Id: If59e20356d80b234ad405cfe6995d474dbfe5c57
2024-04-23 11:13:22 -07:00
Winson Chung a9ccb34d1c Merge "Migrate PackageManagerHelper to MainThreadInitializedObject" into main 2024-04-23 18:10:56 +00:00
Sunny Goyal edbe8e5ffc Merge "Fixing MainThreadInitializedObject" into main 2024-04-23 18:06:38 +00:00
Treehugger Robot 2f39e3f4d3 [automerger skipped] Merge "Reland slow gesture callback handling" into 24D1-dev am: 8114a7ffb5 -s ours
am skip reason: Merged-In I9805114da34bf44e6b28c2a8a665e4cca88904c2 with SHA-1 f3f0e28762 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26997920

Change-Id: Ib3e109ea7693ee2a56f67e24b0a9808997d68722
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-23 18:02:17 +00:00
Schneider Victor-tulias a64f844e54 [automerger skipped] Reland slow gesture callback handling am: c30642b97f -s ours
am skip reason: Merged-In I9805114da34bf44e6b28c2a8a665e4cca88904c2 with SHA-1 f3f0e28762 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26997920

Change-Id: Ibe23a72efc2c9ad7fedac57fe3633e5ed51cf3a9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-23 18:02:14 +00:00
Treehugger Robot 8114a7ffb5 Merge "Reland slow gesture callback handling" into 24D1-dev 2024-04-23 17:47:37 +00:00
Fengjiang Li 02ff0add09 Merge "[Launcher Jank] Schedule LauncherApps#getAppUsageLimit on single bg thread" into main 2024-04-23 17:46:26 +00:00
Sukesh Ram 36ce5c8840 Fix Taskbar Background Visibility After Entering IME then Overview.
Fixed issue whereby taskbar background disappears as expected when the IME switcher is present, but does not appear again if the overview button is pressed after this state.

Flag: NONE
Test: Manually tested in Felix Landscape mode.
Bug: 297472865
Change-Id: If1074b28870c794db8a87dd6cd59f9656dc7c15d
(cherry picked from commit 5c34cf2d06)
2024-04-23 17:41:25 +00:00
Sebastian Franco ad15dd719e Make sure we keep the screen record even if the test succeeds
Bug: 322823478
Test: testEdu
Test: testDevicePressMenu
Flag: NA
Change-Id: Ia11d3cbc0a10e15d716b1845e3590bca2bd1ff76
2024-04-23 10:37:22 -07:00
dakinola 41fcfc1f72 Force calculator to launch in fullscreen for quickswitch tests
Follow on to ag/27050655 to fix last flaking test suite, while investigating proper fix

Bug: 333446588
Bug: 333446588
Flag: None
Test: atest NexusLauncherTests:com.android.quickstep.TaplTestsKeyboardQuickSwitch
Test: forrest build with CL (https://android-build.corp.google.com/builds/abtd/run/L47500030003265061)
Change-Id: I28df139779af49b7bc8da567cfe67e5d43b224e9
2024-04-23 16:49:23 +00:00
Jagrut Desai 8626de9fdb Merge "Customize BubbleTextView for Taskbar Icon Size" into 24D1-dev am: 7a5aeb3544
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27053620

Change-Id: Ie05af3548bffcc125475400321e940b82030e7d6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-23 16:34:37 +00:00
Jagrut Desai 7a5aeb3544 Merge "Customize BubbleTextView for Taskbar Icon Size" into 24D1-dev 2024-04-23 16:17:07 +00:00
Schneider Victor-tulias c30642b97f Reland slow gesture callback handling
Now that b/329324086 has been fixed, we can be more certain that launcher always gets a signal to clean up from WM.

- Relanding original fix for b/285636175 with some additional error checking
- We will now check whether the recents animation start is pending on ACTION_UP
- We will now block entire swipes to prevent sending additional inputs an input consumer while the recents animation start is pending
- We will now only stop blocking inputs on ACTION_DOWN

Flag: LEGACY ENABLE_HANDLE_DELAYED_GESTURE_CALLBACKS TEAMFOOD
Bug: 329324927
Fixes: 285636175
Test: added a delay in RecentsAnimationCallbacks.onAnimationStart and attempted several rapid gestures
Change-Id: I9805114da34bf44e6b28c2a8a665e4cca88904c2
(cherry picked from commit f3f0e28762)
Merged-In: I9805114da34bf44e6b28c2a8a665e4cca88904c2
2024-04-23 15:36:01 +00:00
Himanshu Gupta faafb3a19a Fix horizontal spacing in PS Header
1. Removes padding between settings cog and lock button,
as the insets already provide the required padding.
2. Reduces the lock button margin from left to accomodate
the inbuilt inset in the button.

Fix: 336510036
Test: Verified on device.
Flag: NA
Change-Id: I077097c7beb2cc8fe14f4367c66ca4e1ad4270d0
2024-04-23 15:28:01 +01:00
Himanshu Gupta ae4631e6a3 Move PreInstalled App List to UserCache.
Bug: 333543006
Test: atest PrivateSpaceHeaderViewTest, AlphabeticalAppsListTest
Flag: NA
Change-Id: I84233c5a6406325d9e641b72ea8455911b46f65f
2024-04-23 15:28:01 +01:00
Himanshu Gupta 102b723d63 Adding Tapl tests for User Installed App in PS.
This test verifies that a user installed app
is shown above the sys apps divider, within the
Private Space container.

Bug: 322882655
Test: atest NexusLauncherTests:com.android.quickstep.TaplPrivateSpaceTest
Flag: NA
Change-Id: Id85105339ae45c263d9ef52a3bb55784587e887d
2024-04-23 15:22:43 +01:00
Gustav Sennton 568e0bff90 Merge "Show running apps in Taskbar when in Desktop Mode" into main 2024-04-23 14:02:11 +00:00
Alex Chau 0e64dbe149 Make TaskMenuViewWithArrow width wrap content with a minimum width
- Also add a end padding for the text
- http://screen/3yTa8tmJfJuVf2t

Fix: 331555315
Test: OverviewMenuImageTest
Flag: NONE
Change-Id: Ic9bc2799cd25f87d2ec6c7ce83d50d060513a292
2024-04-23 11:53:48 +01:00
Gustav Sennton 0b33b172fb Show running apps in Taskbar when in Desktop Mode
In Desktop Mode: show currently running (Desktop) apps in Taskbar

Bug: 332504528
Test: DesktopTaskbarRunningAppsControllerTest
Flag: ACONFIG com.android.window.flags.Flags.enableDesktopWindowingTaskbarRunningApps DEVELOPMENT

Change-Id: I10dec022f4b16562e81d7cbd5f9ce835474e9d20
2024-04-23 10:43:27 +00:00
Daniel Akinola 3c8762f88a Merge "Force calculator to launch in fullscreen for taskbar tests" into main 2024-04-23 08:47:57 +00:00
Fengjiang Li fa0a4c1c11 Merge "[Predictive Back] Swipe back within workspace all apps should only scale down content view, rather than whole all apps sheet" into main 2024-04-23 03:45:32 +00:00
Sebastian Franco ea78903380 Adding screenrecord to get more information about the test
Test: testWorkspace
Flag: NA
Bug: 331261431
Change-Id: Ifeaa0fe287c2cbf0b9c1c468c494752fe7f35d37
2024-04-22 19:38:23 -07:00
Sebastián Franco a67a53eeed Merge "Make getWidgetProviderInfoByProviderName return the correct WidgetItem for Pixel own widgets." into main 2024-04-23 02:11:50 +00:00