Commit Graph

78507 Commits

Author SHA1 Message Date
Ats Jenk ca009e4e93 Skip depth and scrim if freeform tasks are visible
If freeform tasks are shown, skip applying depth effect and scrim
changes. These cause the background to flicker while showing freeform
tasks and for example showing the transient taskbar.

Bug: 263264985
Test: swipe up to show transient taskbar, observe launcher background
does not blur or flicker to black

Change-Id: I5b10d0f0c7065e903cb761488367c02d7e31d8b2
2023-01-12 10:15:30 -08:00
TreeHugger Robot 318da8ce22 Merge "Support predictive back from all apps to home" into tm-qpr-dev am: 944348a522
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20789107

Change-Id: Ib53aa807f447aeba483f6a4a10f078a5b39bf660
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 17:50:42 +00:00
TreeHugger Robot 944348a522 Merge "Support predictive back from all apps to home" into tm-qpr-dev 2023-01-12 17:01:02 +00:00
Tony Wickham 7d192c0e71 Remove extra overview threshold if the transient taskbar is already open
Test: Swipe to overview when taskbar is already opened vs not
Fixes: 264555943
Change-Id: Ib4c31b085ca51e50fd7442ff9a27a5f47822c242
2023-01-12 16:48:35 +00:00
Sebastian Franco 9db35f7a37 Remove unused Throw Throwable from clearHomescreen method
Test: presubmit
Bug: 263802298
Change-Id: I4b81e044eb4f6a84730fb4d61403cbfcadefd282
2023-01-12 10:41:34 -06:00
Chavi Weingarten 80995574bd Updated SurfaceSyncGroup API definition.
Test: Builds
Bug: 237804605
Change-Id: I0c1ebefb123d73df797fe6a6ee9eda456f1f0ccc
2023-01-12 16:12:10 +00:00
Luca Zuccarini 7495d0f873 Merge "Revert^2 "Update timings for the Home <> All Apps transition."" into tm-qpr-dev am: 51c89ca493
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20929144

Change-Id: I3629ade53ed1be9d596a158e0f71efd999428aa5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 14:51:20 +00:00
Luca Zuccarini 51c89ca493 Merge "Revert^2 "Update timings for the Home <> All Apps transition."" into tm-qpr-dev 2023-01-12 14:06:07 +00:00
Nicolo' Mazzucato 696238e086 Provide single threaded executor to UnfoldUnfoldTransitionFactory
This fixes a concurrency issue where HingeSensorAngleProvider was being stopped and started at the same time in a thread-pool after a fast fold/unfold, despite not providing concurrency guarantees.

In sysui, the background executor provided was already single threaded, so no issue arisen. From Launcher, THREAD_POOL_EXECUTOR was provided.

In a follow up cl, I'll add a @SingleThreadBackground annotation to the executor used in the unfold lib.

Bug: 261320823
Test: manually stress tested fold/unfold.
Change-Id: Iccf1f1f7246d8592d4d80a032479aa75f0050655
2023-01-12 09:19:48 +00:00
Johannes Gallmann 031fbcc564 Prevent workspace enter animation for predictive back
Bug: 263913711
Test: Manual, i.e. testing predictive back for four scenarios: Back to all apps, Back to home. Both with the closed app icon visible or not.
Change-Id: Id87686098e6ad413819dc75545071da00291db65
2023-01-12 10:06:18 +01:00
Tracy Zhou 6fb8b3cec4 Update onOverviewShown interface to get signal of whether it should be
iterated in forward or backward direction

For more information, check out the change in the same topic.

Bug: 258854035
Test: manual
Change-Id: Id4a201c1979645ec319478f634039a4e9e495a35
2023-01-12 07:17:58 +00:00
Xin Li 0df11b5d91 Merge tm-qpr-dev-plus-aosp-without-vendor@9467136
Bug: 264720040
Merged-In: I75ef387d8a3b8da1239b8ca39372a75a77435acd
Change-Id: Ie4834ea71e62cbf53da19b9b017ba4e8b957f8c2
2023-01-11 22:47:23 -08:00
Vinit Nayak 1d7e050bc6 Respect nav button tinting in SUW
* Check was originally added with rationale in
b/204384193#comment26, however presently we
do provide insets to SUW as of b/253538830
so looks like now we are getting the correct
info from SysUI
* There is a possibly related issue where buttons
are not tinted correctly on the final page of
SUW (b/265238238)

Test: Went through setup manually via adb
and observed that on light theme with dark
dialog scrim the button changes color
adb shell am start -a android.intent.action.MAIN -n com.google.android.setupwizard/.SetupWizardTestActivity
Bug: 256521774

Change-Id: I080033e21d22fbc366b7248b2d647fec610a5fb9
2023-01-11 21:29:37 -08:00
Android Build Coastguard Worker 35c7efae7d Snap for 9480469 from f1963f7e86 to udc-release
Change-Id: I3037e7d1f5181035f54fc9bf187b83159a5bca16
2023-01-12 02:27:32 +00:00
Christophe Pinelli 9d46bca1b9 Make mutable PendingIntent explicit
Starting from target SDK U, we will block creation of mutable
PendingIntents with implicit Intents because attackers can mutate the
Intent object within and launch altered behavior on behalf of victim
apps. For more details on the vulnerability, see go/pendingintent-rca.

From a quick analysis, we concluded that the PendingIntent here was only
destined to the test app/to the app, so it was made explicit. Reviewers,
please call out if this is not the case.

Bug: 236704164
Test: atest NexusLauncherTests:com.android.quickstep.DigitalWellBeingToastTest
Test: atest RequestPinItemTest
Change-Id: I81311b0588b7b712c97de6cb016a62bb91c7a77c
2023-01-12 01:51:44 +00:00
Shan Huang 6677aeab1d Merge "Add background protection for back to home animation." 2023-01-12 01:03:49 +00:00
Stefan Andonian 53b21fae3b Merge "Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and into its own class." into tm-qpr-dev am: fb602d4db7 am: 167d350981
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20878611

Change-Id: I7591e1af8af6bcd6b11dea1571668d80ada06201
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-11 23:57:55 +00:00
Sunny Goyal 738f4033a8 Merge "Fetching the session info on the background thread when launching pening icon" into tm-qpr-dev am: 96bfea9d32 am: 1ef2eea43c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20878612

Change-Id: I075d04814f405dc406bbbc1e4b1950c8f1256d05
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-11 23:57:39 +00:00
Stefan Andonian e78b34daab Merge "Rename LoaderResults to LauncherBinder." into tm-qpr-dev am: bf69ef034a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20543148

Change-Id: I6099c3312aac8cfeed3d6dafaaf8470f9c8f3687
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-11 23:11:36 +00:00
Stefan Andonian 167d350981 Merge "Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and into its own class." into tm-qpr-dev am: fb602d4db7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20878611

Change-Id: I16987862cffc3730518fe14adf61595d62b8faad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-11 23:11:16 +00:00
Sunny Goyal 1ef2eea43c Merge "Fetching the session info on the background thread when launching pening icon" into tm-qpr-dev am: 96bfea9d32
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20878612

Change-Id: I2ea28c6e83d33c47ddd794b6f520d277ea92a60e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-11 23:10:59 +00:00
Fengjiang Li e884c2c79f Support predictive back from all apps to home
bug: b/238475505
Test: manual

Change-Id: Ibf4f7f41a26b044a538e2cd566d2297ed88f1b99
2023-01-11 22:55:28 +00:00
Stefan Andonian bf69ef034a Merge "Rename LoaderResults to LauncherBinder." into tm-qpr-dev 2023-01-11 22:47:34 +00:00
Stefan Andonian fb602d4db7 Merge "Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and into its own class." into tm-qpr-dev 2023-01-11 22:46:31 +00:00
Sunny Goyal 96bfea9d32 Merge "Fetching the session info on the background thread when launching pening icon" into tm-qpr-dev 2023-01-11 22:32:01 +00:00
Tracy Zhou f1963f7e86 Merge "Swipe-up from the bar area on the home screen should pull up overview" 2023-01-11 22:06:58 +00:00
Shan Huang a0fb0bf717 Add background protection for back to home animation.
Bug: 238475118
Test: Swipe back on Settings in light theme. Switch to dark theme and
try again. Make sure scrim looks nice in both cases.

Change-Id: Ic099d7b8e84a04105712f13c94d0c6f82863e844
2023-01-11 13:57:33 -08:00
Stefan Andonian e82476ad3b Rename LoaderResults to LauncherBinder.
LoaderResults implies a data object, not binding code specific to
Launcher UX containers. This CL merely renames this class and its
usages. It also adds a comment that explains why the functionality is
split into a base class and an implementing class.

Bug: 251502424
Test: Compilation worked correctly.
Change-Id: I01b5ac2f717e9b20612538d5c1e0ca947beb593f
2023-01-11 20:32:25 +00:00
Jagrut Desai cc96cf3345 Adding margin height for transient taskbar to allow users to stash taskbar from full height. am: 50f1e8dfc2 am: 9ef3dff40d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20903089

Change-Id: Ic564353b9e1b992d0647dcafdfbbb91d07094fbc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-11 20:06:02 +00:00
Stefan Andonian 2a58ddb89f Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and
into its own class.

Bug: 251502424
Test: Compilation threw no errors and user unlock behavior worked
correctly.

Change-Id: Ifa42dc32f90dfa4fda8df0e52811ddfe20cc5a9b
2023-01-11 19:33:32 +00:00
Jagrut Desai 9ef3dff40d Adding margin height for transient taskbar to allow users to stash taskbar from full height. am: 50f1e8dfc2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20903089

Change-Id: I886944c8f9a8ad2083cd84f2cc29cf9c41497b75
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-11 19:09:20 +00:00
Treehugger Robot a26bb5cb0f Merge "Assign default bug component for Launcher3" am: e78e42fcf3 am: c72d17fc28 am: fdbf120a04
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2382992

Change-Id: I37e56f95785ba581a1e6e2b198ab097957660a77
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-11 18:17:44 +00:00
Brandon Dayauon f54e016c82 split the scrolling logging into work,personal, and search
- moved collapse/extend logging with the other scroll logging

bug: 263817965
test: Manual - WW
Change-Id: I9cd57b895c0c2edb7fe39ef98dced574d09a0953
2023-01-11 10:09:27 -08:00
Miranda Kephart aaa77b8035 Update ImageActionUtils to construct a ScreenshotRequest
Bug: 264457397
Test: atest
Merged-In: Ib629f5d9eed2091f2bc4c1082d5e0dd3d2f9176b
Change-Id: Ib629f5d9eed2091f2bc4c1082d5e0dd3d2f9176b
2023-01-11 12:44:07 -05:00
Treehugger Robot fdbf120a04 Merge "Assign default bug component for Launcher3" am: e78e42fcf3 am: c72d17fc28
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2382992

Change-Id: Id9dfd686f40cdf673e0fa046d93ae702e859073a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-11 17:38:11 +00:00
Treehugger Robot c72d17fc28 Merge "Assign default bug component for Launcher3" am: e78e42fcf3
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2382992

Change-Id: I96d630b9eed0dcddbcd7703af3702ddd2b8c81da
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-11 17:02:40 +00:00
Treehugger Robot e78e42fcf3 Merge "Assign default bug component for Launcher3" 2023-01-11 16:27:55 +00:00
Alex Chau 7351218fab Update overview actions top margin
Bug: 260596114
Test: manual
Change-Id: Ic5f51a8d0505571272e5ad03bd16db2b903fd697
2023-01-11 15:41:52 +00:00
Sebastian Franco a955403ba9 Change the access of cellX/Y of CellLayoutLayoutParams to private
Cherry pick needed for changes on workspace lily

Bug: 188081026
Test: no op change, should compile
Test: ReorderWidgets
Change-Id: I20367974e5a4cead406e18eb66dafd4d59651b2a
2023-01-11 15:25:23 +00:00
Luca Zuccarini 50ef8004e0 [Toast] Add a feature flag for result launch animations.
Bug: 250588519
Test: manual
Change-Id: I6d605bf8b1008a3b12497e1d04601735ad79c001
2023-01-11 13:16:02 +00:00
Tony Huang f1a43efa0b Merge "Fix divider visibility issue on transient taskbar" into tm-qpr-dev am: d058f55578 am: 9898e5cc44
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20747781

Change-Id: I9e780abb3987bf8c40f24fafb5f906ff659ddee8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-11 04:58:05 +00:00
Tony Huang 9898e5cc44 Merge "Fix divider visibility issue on transient taskbar" into tm-qpr-dev am: d058f55578
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20747781

Change-Id: Ifbd4ea9766123d4c5943f0ea75600416a6b39312
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-11 04:17:34 +00:00
Jagrut Desai 50f1e8dfc2 Adding margin height for transient taskbar to allow users to stash taskbar from full height.
Test: visual(video in buganizer)
Fix: 263526574
Change-Id: I21fd1273b83a4e5efdf7aeacae1303513b9b4d97
2023-01-11 04:16:07 +00:00
Tony Huang d058f55578 Merge "Fix divider visibility issue on transient taskbar" into tm-qpr-dev 2023-01-11 03:45:14 +00:00
Android Build Coastguard Worker 8956dffb82 Snap for 9475114 from 927a806dff to udc-release
Change-Id: Ibd48972c7995255279c6f9a4a832887721e731b4
2023-01-11 02:31:37 +00:00
Jagrut Desai 036e99d048 Merge "Checking can start system gesture before creation of TaskbarStashInputConsumer, so that taskbar does not show up when user performs swipe up from lock screen or notification panel." into tm-qpr-dev am: 4aac33824d am: dc70ea4d65
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20861033

Change-Id: I9be46c3a5bfa91dc707bb2257f205fa6976db0d2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-11 00:02:47 +00:00
Jeremy Sim 5f8dd20236 Fix transition animations for launch-from-staged operation
This change makes it so that a smoother animation will play when the user cancels the splitscreen flow by tapping the staged app to launch the app in fullscreen. Since this was the only blocker to activating the feature, this change also enables launch-from-staged by default and removes the flag.

Fixes: 257513449
Test: Manual
Change-Id: Iabff2fc72bfcd6975d216b5cd86e0df7a772b308
2023-01-10 15:44:23 -08:00
Jagrut Desai dc70ea4d65 Merge "Checking can start system gesture before creation of TaskbarStashInputConsumer, so that taskbar does not show up when user performs swipe up from lock screen or notification panel." into tm-qpr-dev am: 4aac33824d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20861033

Change-Id: I2b508ca826aa1eda8443a51bdf166871019e591c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-10 23:25:59 +00:00
Jagrut Desai 4aac33824d Merge "Checking can start system gesture before creation of TaskbarStashInputConsumer, so that taskbar does not show up when user performs swipe up from lock screen or notification panel." into tm-qpr-dev 2023-01-10 22:58:30 +00:00
Jagrut Desai ef35e84d19 Checking can start system gesture before creation of TaskbarStashInputConsumer, so that taskbar does not show up when user performs swipe up from lock screen or notification panel.
Test: visual(video in buganizer)

Fix:261524189, 262589756

Change-Id: I5252281025953753f9184f1b19c534513b5800fa
2023-01-10 22:57:35 +00:00