Don't include taskbar height when calculating TaskView size, otherwise
this results in an unnecessary jump when the taskbar changes, either
when navigating from DesktopWindowing to Overview or pinning the
Taskbar in Overview
Bug: 343882478
Fix: 373319262
Test: unbundled/launcher/nexus_image_test_platform OverviewImageNoTransientTaskbarTest
Flag: NONE Bugfix
Change-Id: I09de0e8b4386dd9b8ccbe5330ff0c6075ef773f2
The logic for updating hotseat items in taskbar involved adding all
available recent items to the view, and then removing ones that
overflow. It also preemptively added overflow icon, and then removed it
when no overflow was detected.
This cl updates logic to stop adding recent items before they cause
overflow, and add overflow icon only when needed.
Bug: 368119679
Test: Keep opening apps until taskbar enters overflow, and verify that
expected number of app icons is displayed, and overflow icon is shown in
the correct place.
Flag: com.android.launcher3.taskbar_overflow
Change-Id: Icaad4386b54bbfccba8ace5876d7fe5c90cb7798
Based on the bug, it seems that onHandleConfigChange was not called via the perfetto trace. Here is the call order:
1) Loader Task is created
2) Loader task runs
3) Preinflation happens from setApps() in bindAllApplications() via ModelCallbacks.kt
4) When show long app names toggle happens: it eventually triggers an onHandleConfigurationChanged() which is traceable in perfetto.
5) After configChange, preinflation happens again.
In step 4) there is an early return that happens and makes it so it doesn't call the reinflation of views that happens in the mModel.rebindCallbacks().
When the force configUpdate happens upon toggle, reset the variable after it is done.
bug: 370121944
Test: presubmit/manually/perfetto in bug
Flag: NONE trying to fix edge case
Change-Id: Id0ba591bfe583b300cc241fcfc37db6dd5a85363
* changes:
Add spannedDrawable for the divider in the letter fastScroller.
Only have private space drawable section for beginning of private space section and keep letters for everything else.
Updates calculation for max number of icons that can be shown in the
taskbar before hitting overflow to:
* account for size of the three button nav, if shown
* size of margins between icons
* difference in all apps button and divider icon sizes (compared
to baseline icon size)
Bug: 368119679
Test: Keep adding app icons to taskbar in desktop session until it hits
overflow with three button nav enabled, both in landscape and portrait
orientation - verify the taskbar enters overflow before icons start to
overlap with nav buttons.
With button navigation disabled, taskbar enters overflow as it starts
nearing screen edge. Transition between transient and persistent taskbar
keep consistent number of icons shown.
Flag: com.android.launcher3.taskbar_overflow
Change-Id: I66a12b390295dd50937e66a5bdf0e3e616b4a850
> Converting various if-else-if blocks to when
> Moving SessionMailureTask to its own class
> Moving install session callbacks to ModelCallbacks
Bug: 372553045
Test: Presubmit
Flag: EXEMPT refactor
Change-Id: I027b35f271b84f079fa3135b56dc15bb7375b2e0
> This will make it easier to migrate to dagger as it will
increase the number of constructor parameters significantly
Test: presubmit
Bug: 361850561
Flag: EXEMPT dagger migration
Change-Id: Id06246ec74c678d7614f4c6a798c5644b40a0545
Splitting allows easily making a fake that doesn't have to override the implementation details of LauncherPrefs. The fake should not deal with SharedPreferences.
LauncherPrefs could be an interface, but then the companion object has more limitations. The solution there is to have a dedicated object class, e.g. `LauncherPrefItems`. I went with an abs class to make the refactor simpler.
Flag: EXEMPT refactor
Bug: 369641781
Test: go/testedequals
Change-Id: I97a2d495d3b5fa892fa53a11fb3f7a7dfb98515b
Test: Built and ran locally
Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug:292269949
Change-Id: I05042834912accc9720d41d79a6222109d53a6e0
This cl simply updates taskbar corner roundness after it finishes initializing all the controllers.
Test: Presubmit
Bug: 370984727
Flag: com.android.window.flags.enable_desktop_windowing_mode
Change-Id: Ieb98835c74cc992f47354dbfa86ededeadf5c786
* changes:
decoupling task animation lifecycle from recents lifecycle
fixing a state cycle issue in recents window where we set home instead of bg_launcher
Remove extra screen & go to normal state only if widget
addition was complete. If a config activity was started, then
don't change to remove screen yet or go to normal state. Else,
QuickStepLauncher clears the existing activity open requests when
going to normal state. When animations are off, this led to config activity to never launch and hence, such widgets not being added.
Bug: 369422714
Test: Manual
Flag: EXEMPT BUGFIX
Change-Id: I4e7e29fd998a0cc5ca18a7a48b91a5b788a60a52
Moved out logic that computes the translation X for the hotseat icons.
Fixes: 368379159
Test: Manual. Have the hotseat adjusted. Open any application from the
hotseat bar. Go back to home.
Flag: EXEMPT refactoring
Change-Id: If9dfa70be537f87b075bd865e7f9c5cd1ae78f00
this will fix a few bugs but create acouple others. Luckily this is all behind a flag for now but will prevent us building on broken code
Test: Built locally and tested
Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug:292269949
Change-Id: Ifd147d6f3dd3234dfb1afe369f83c241a205c6af
The container will be used to inflate the bubble bar flyout view
Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: builds successfully -- code is not wired up yet
Change-Id: I3012caa801c73f9e13f26c8803595b59e250ae1e
Brian Isganitis
Graciela Wissen Putri
samcackett
Tracy Zhou
Treehugger Robot
Sunny Goyal
Brandon Dayauon
Toni Barzic
Vinit Nayak
Randy Pfohl
Bill Yi
Andy Wickham
Federico Baron
Liran Binyamin
Uwais Ashraf
Jagrut Desai
Shamali Patwa
Ats Jenk
mpodolian
Schneider Victor-Tulias
Fengjiang Li