Commit Graph

78507 Commits

Author SHA1 Message Date
Schneider Victor-Tulias ecaf00a464 Update RecentsWindowSwipeHandler to animate home alpha properly
Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 366022874
Test: Attempted gesture from home and launched app
Change-Id: I553ad200b291f7765bbb026c314ea6652a3b5542
2024-10-17 15:41:01 +00:00
Sam Cackett 072970e1fa Merge "Draw live tile below Overview after launch animation" into main 2024-10-17 13:52:17 +00:00
samcackett ea788d92be Draw live tile below Overview after launch animation
A fix (see http://go/b320307512_problems) was put in to change layers
when swiping from Desktop Windowing to Overview, so that the blur effect
 didn't apply to the live tile. The result of this change was that the
 tasks now sat on top of Overview and if you didn't launch the task but
 went back to Overview, then you could interact with them and do things
 like resize the task and get into a very broken state.

This fix simply flips the layer ordering back after the animation
completes to ensure Overview sits on top.

Fix: 373400009
Flag: NONE bugfix
Test: Swipe from Desktop to Overview. Swipe down from Overview to launch
 the live tile, but then swipe back to Overview i.e. don't launch
 Desktop. Try to resize the DW window.

Change-Id: I80c8d72f76a8393eb8bd963df81723defd85ed97
2024-10-17 13:51:28 +00:00
Treehugger Robot c9b444c790 Merge "Fixed the opened folder on taskbar when NotifShade is shown" into main 2024-10-17 02:42:19 +00:00
Treehugger Robot 642e84e397 Merge "Cleanup for TAPL Debugging" into main 2024-10-17 02:18:08 +00:00
Randy Pfohl 2ff556131a Merge "Using synthetic recents transitions for Recents in Window" into main 2024-10-17 01:53:35 +00:00
Treehugger Robot 3cac51e141 Merge "Fix RecentsView crash when DesktopTask has only 1 task and it is in split mode" into main 2024-10-17 01:14:38 +00:00
Bill Yi fbe5044c4e Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I5e1473aede364901d9b4da42154df8c7c5f90ad5
2024-10-16 18:09:30 -07:00
Bill Yi 7cbcaa7b67 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ie3e674cb84d50b961c50a5beb5616fbd002957db
2024-10-16 18:08:40 -07:00
Sukesh Ram fc6cc4e409 Cleanup for TAPL Debugging
Cleaning up leftover log statements.

Flag: EXEMPT bugfix
Bug: 324419890
Test: Manual
Change-Id: I54145d07f0699f68c44aaa34e1692c8fe2f7b780
2024-10-16 16:55:45 -07:00
Winson Chung a2dea77229 Using synthetic recents transitions for Recents in Window
Bug: 366021931
Flag: com.android.launcher3.enable_fallback_overview_in_window
Test: manual with enableFallbackOverviewInWindow=true
Change-Id: I26fbc96373b55f0a4a87756fa99347f0e4f4361b
2024-10-16 13:23:17 -07:00
Wen-Chien Wang e37b479b17 Fixed the opened folder on taskbar when NotifShade is shown
This cl fixes the bug by closing all abstract floating views
including opened folders when the notification shade is shown.
Usually this was handled in the folder class where it intercepted
the touch event to close it by dispatching the back key, but this
didn't work when the virtual keyboard existed.

More context is added in the bug.

Flag: EXEMPT bug fix
Fixes: 267529599
Test: Ran on a 1P device

Change-Id: Ifdd357668ece2c11888ecfc69af64b1742c07d6e
2024-10-16 17:53:08 +00:00
Treehugger Robot dca74bcb24 Merge "Have external resource call init() explicitly." into main 2024-10-16 17:37:47 +00:00
Schneider Victor-Tulias 07669e9575 Improve test isolation in AbstractLauncherUiTests
- Removing suspicious duplicate uses of AbstractLauncherUiTest.initialize to prevent unnecesary launcher restarts
- Adding UiDevice#pressHome to AbstractLauncherUiTests.verifyLauncherState to ensure the next test starts with a known clean state

Flag: EXEMPT test fix
Fixes: 372956489
Test: AbstractLauncherUiTest
Change-Id: Id68ece4ab195a4f6c47aa401eb50a91b8ff70e10
2024-10-16 13:18:36 -04:00
Jordan Silva f4a21b7e5c Fix RecentsView crash when DesktopTask has only 1 task and it is in split mode
This CL fixes a crash happening when no other task is available in Desktop Windowing (DW), and the only task in DW is selected to be part of the pair (split mode). The crash is happening because of the following logic:

- applyLoadPlan skips the staged tasks (for split) from the groupTask when adding the TaskViews to RecentsView.
- If a groupTask has multiple tasks, and one of the tasks is staged, groupTask will be treated as a single task and applyLoadPlan uses the other task (not staged) to create a single TaskView in Overview.
- DesktopTasks returns true for hasMultipleTasks, even when only 1 task is in DW mode. This causes a crash when the only task available in DW is staged for split.

This fix will skip DesktopTaskView creation when split selection is active. In addition, it updates DesktopTask to report multiple tasks only when more than 1 task is its task list.

Fix: 372357270
Fix: 372375086
Fix: 372864249
Flag: EXEMPT bugfix
Test: Manual. Instructions on bug report.
Change-Id: I95e32252a5cac4f6b99296422703d69d129a5a47
2024-10-16 17:34:08 +01:00
Anushree Ganjam 46636f2230 Merge "Add User group logging for Omnient" into main 2024-10-16 16:31:04 +00:00
Kevin Lim 9c5d8a2059 Merge "[Tests] Clear MAIN_EXECUTOR in NavHandleLongPressInputConsumerTest#tearDown" into main 2024-10-16 00:50:55 +00:00
Mykola Podolian 79032facbf Merge "Created a helper method that calculates the hotseat icons shift X." into main 2024-10-16 00:12:44 +00:00
Anushree Ganjam 6beaa59710 Add User group logging for Omnient
Bug: 369604840
Test: Manual
Flag: EXEMPT Omnient feature is launched
Change-Id: I5184ebf001d5c741f36592360e5a7f7b2292c0d5
2024-10-15 17:12:38 -07:00
Brian Isganitis fa6ca0fe6f Have external resource call init() explicitly.
Change-Id: Ibdd444478d0d171353a58c060022f5a181f9d1c4
Flag: TEST_ONLY
Test: go/testedequals
Bug: 230027385
2024-10-15 23:43:31 +00:00
Brandon Dayauon 7e1149471a Update letter list textview background color to spec.
Spec: https://www.figma.com/design/uMzPkNMZpb7EyfHDo8usIa/V-%E2%80%A2-Toast-Butter?node-id=2746-180205&node-type=frame&m=dev

bug: 358673724
Test: manually - photo: https://drive.google.com/file/d/1RWlaSRHbXCYhsY1F3nzruldQnABszUiz/view?usp=sharing
Flag: com.android.launcher3.letter_fast_scroller
Change-Id: I03cd4fbf1e76a7ad34983ace18a69a52116e7834
2024-10-15 15:01:25 -07:00
Brandon Dayauon 347b149f6f Remove color animations when scrolling.
bug: 358673724
Test: manually
Flag: com.android.launcher3.letter_fast_scroller

Change-Id: I9601a01fbde3b74ad94e78fad151143820288f3e
2024-10-15 13:40:08 -07:00
Mykola Podolian 2eea74b623 Merge "Made the taskbar touchable during animation to home." into main 2024-10-15 20:29:05 +00:00
Treehugger Robot 8915d3c3b8 Merge "[Dagger] Make CustomWidgetManager provided by DaggerSingletonObject" into main 2024-10-15 19:19:36 +00:00
mpodolian d89732ef85 Made the taskbar touchable during animation to home.
Enabled taskbar touch processing while animating to home. Also excluded
quick search bar from touch region, so it is not interactable during the
animation & removed corresponding TODO from TaskbarView.

Fixes: 368419997
Test: Manual. Enable gesture navigation. Open any application. Swipe up
to go to the launcher home screen. Click any taskbar icon - the
corresponding application will open. If clicking on Quick search,
launcher search will be opened. Video:
http://recall/-/gx8ASgewUeUS3QYohfrd1J/g6UWhF9dQZq3QsFyH0EwtK
Perform the same test for buttons navigation mode. Video:
http://recall/-/gx8ASgewUeUS3QYohfrd1J/gvuoSRnQfXQlejewBG1Ex8
Flag: EXEMPT bug fix

Change-Id: I07280bce70dd25d5ab78210302f08c0614309130
2024-10-15 11:54:04 -07:00
Kevin Lim f36375d907 [Tests] Clear MAIN_EXECUTOR in
NavHandleLongPressInputConsumerTest#tearDown

Attempt at fixing flaky tests

Bug: b/359911511,b/355232772
Flag: EXEMPT Test change
Test: NavHandleLongPressInputConsumerTest
Change-Id: I8ea91f732e91b1a7df4b2e2816dc70e35f14d504
2024-10-15 18:32:35 +00:00
Treehugger Robot 242d5b9e26 Merge "Revert "Add screenrecord for testWorkspaceSwitchToAllApps"" into main 2024-10-15 17:58:28 +00:00
Gustav Sennton 6bb9d56ded Add animation runner for alt-tab desktop app launch
Create a remote transition supporting alt-tab app-launches (app launches
caused by a user using alt-tab to select a minimized app) and any
minimization caused by hitting the window limit during such an app
launch.

Test: manual, and WindowAnimatorTest
Bug: 349791584
Flag: com.android.window.flags.enable_desktop_app_launch_alttab_transitions
Change-Id: I6474fff351f3d7681ca25cd7331e4955e3d1c6e0
2024-10-15 17:34:53 +00:00
Tracy Zhou ada58203ad Merge "Disallow 2-finger swipe from the corners to trigger assistant from trackpad" into main 2024-10-15 17:30:53 +00:00
Brian Isganitis dc4f56040a Merge "Migrate to FakeLauncherPrefs for Taskbar unit tests." into main 2024-10-15 17:08:35 +00:00
Jordan Silva d2867286ff Merge "Update OverviewCommandHelper to use Executors.MAIN to reduce the percentage of missed frames" into main 2024-10-15 16:52:05 +00:00
Graciela Putri 19c00bb849 Merge "Add task menu item to move task to external display" into main 2024-10-15 16:51:20 +00:00
Federico Baron 44854ed9d5 Revert "Add screenrecord for testWorkspaceSwitchToAllApps"
This reverts commit 1d12cbcd23.

Reason for revert: bug resolved

Change-Id: Ie5a15594cb3b168c5368f6bd54aab2c6a9d718ae
2024-10-15 16:11:10 +00:00
Liran Binyamin cfd3326efd Merge "Update taskbar window size for flyout" into main 2024-10-15 13:26:11 +00:00
Treehugger Robot 28dbcc7260 Merge "Optimize updating hotseat items in overflown taskbar" into main 2024-10-15 07:28:45 +00:00
Sunny Goyal 2ee9a604b6 Merge "Fixing leak in LauncherAppWidgetProviderInfo" into main 2024-10-15 02:03:27 +00:00
Sukesh Ram bd923a2b98 Merge "Fix Taskbar Y-Translation with Visible Bottom Sheet" into main 2024-10-15 01:34:41 +00:00
Andy Wickham 9605643883 Merge "Migrate Contextual Search code to AOSP" into main 2024-10-15 00:47:02 +00:00
Liran Binyamin c33fe5bd56 Update taskbar window size for flyout
This change updates the taskbar window size after the flyout view
has measured itself. This ensure that the taskbar window is tall
enough to display the entire flyout.

When the flyout is removed we reset the taskbar window size.

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: builds successfully and tested manually -- code is not wired up
Change-Id: I5e8618e57443212e1c4f19ab20d1542ae2d1b865
2024-10-14 19:59:59 -04:00
Sukesh Ram d82503fc42 Fix Taskbar Y-Translation with Visible Bottom Sheet
When bottom sheet is visible, such as in SUW or when app launcher pauses, the taskbar three buttons are translated upwards clashing with SUW UI.

Flag: EXEMPT bugfix
Bug: 358532768
Test: Manual
Change-Id: I0d18bda5cb7aeae894f5058df89cc413e34c00fc
2024-10-14 23:41:38 +00:00
Sunny Goyal e4ce5ebc5e Fixing leak in LauncherAppWidgetProviderInfo
Bug: 372998377
Test: Presubmit
Flag: EXEMPT bugfix
Change-Id: Ibf7c66f2aba510f86d23825816639bc3197884aa
2024-10-14 16:22:52 -07:00
Sihua Ma 58fc65dedf [Dagger] Make CustomWidgetManager provided by DaggerSingletonObject
Test: presubmit
Bug: 361850561
Flag: NONE Dagger change
Change-Id: I9c2a9cc12aa2a409e8f9053a059426843f72deed
2024-10-14 22:35:59 +00:00
Brian Isganitis a3ec98e06d Migrate to FakeLauncherPrefs for Taskbar unit tests.
Deprecates the preference rules.

Flag: TEST_ONLY
Test: go/testedequals
Bug: 230027385
Change-Id: Ic3a9e589b556232d196942d687e2e2bddc000877
2024-10-14 18:13:23 -04:00
Treehugger Robot 3a0583272b Merge "Add screenrecord for testWorkspaceSwitchToAllApps" into main 2024-10-14 19:44:47 +00:00
Brandon Dayauon 33902557ec Set psDivider to gone in collapse due to updateAdapterItem suppression in test.
Set PSDivider to gone during collapse animation. This is to help with https://android-build.corp.google.com/test_hub/search/?filter=&invfilter=unhealthyInvocations&invfilter=staleInvocations&query=test%3Acom.android.quickstep.TaplPrivateSpaceTest%23testPrivateSpaceLockingBehaviour&tab=clusterView&clusterId=12644122704855694316 tapl issue saying divider is there. This is because we suppress updateAdapterItem call and ps container contents aren't completely refreshed.
This change is safe to do so anyways since floatingMaskView and decorator takes care of how the end result looks like.

bug: 373427348
test: presubmit/tapl/manually
Flag: NONE bugfixing for test flakiness
Change-Id: Ia422096e022ab8de6745071707620192f03661a5
2024-10-14 12:05:41 -07:00
Brian Isganitis db0da19752 Merge "Fix package name for TaskbarEduTooltipControllerTest" into main 2024-10-14 18:32:42 +00:00
Jordan Silva 7eae20bcb1 Update OverviewCommandHelper to use Executors.MAIN to reduce the percentage of missed frames
This change will reduce the increase in the amount of missed frames measured by crystalball. I believe coroutines launch is competing with Executors.MAIN for scheduling and running tasks in the main thread, thus the increase in missing frames.

Fix: 366077002
Flag: com.android.launcher3.enable_overview_command_helper_timeout
Test: OverviewCommandHelperTest
Test: android.platform.test.scenario.launcher.CloseApp3ButtonModeMicrobenchmark#testOpenLauncher
Test: atp:v2/android-crystalball-eng/health/microbench/launcher/main/launcher-action-suite
Change-Id: I4477879d4f065ec3883f2c3cb3ef044e973ce0cb
2024-10-14 17:46:14 +00:00
Sunny Goyal 0bf39fdf26 Merge "Removing unnecessary SafeClosable requirement from DaggerSingletonObject" into main 2024-10-14 17:06:13 +00:00
Sam Cackett 4676744257 Merge "Fix jank resulting from TaskView resizing" into main 2024-10-14 16:45:51 +00:00
fbaron 1d12cbcd23 Add screenrecord for testWorkspaceSwitchToAllApps
Flag: EXEMPT TEST_ONLY
Test: TaplTestsQuickstep#testWorkspaceSwitchToAllApps
Bug: 371615571
Change-Id: Ib2ce1d1b56b1710e65bad8eaa5de89949ec22c7e
2024-10-14 09:42:20 -07:00