Commit Graph

78507 Commits

Author SHA1 Message Date
Bill Yi 5777ef5e21 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ic8bc2a63d441cfa44b342e07c84c922e71de3bef
2024-08-19 14:41:14 -07:00
Winson Chung 69062b75b6 1/ Remove unused legacy recents paths
- We no longer support the legacy recents animation cancel path
  (it was already a no-op)
- Use the shell recents transition path instead of the legacy recents
  animation for remaining use cases

Flag: EXEMPT cleaning up unused code
Bug: 359608026
Test: Test both kb shortcut and desktop split invocation paths
Change-Id: I2726d52b3b4f3533afc4286b155c71eadcb57909
2024-08-19 20:28:51 +00:00
Alex Chau d326e17fe2 Add logs for getFocusedTaskHeightForTablet
Bug: 336660988
Bug: 360724626
Test: presubmit
Flag: TEST_ONLY
Change-Id: I67d4fc8211f24b77566bd24525d23054dfdded6e
2024-08-19 20:39:41 +01:00
Liran Binyamin bdd23572a7 Merge "Deflake BubbleViewScreenshotTest" into main 2024-08-19 19:19:03 +00:00
Shuming Hao f1d0df2867 Remove unused resources for split screen handle
Bug: 338079912
Test: Manually
Flag: EXEMPT cleanup
Change-Id: I09c02de82186f2080ce10ee75ecb75f9d7f8859a
2024-08-19 09:54:25 -07:00
Mady Mellor d22a0b84cb Include bubbles in the dragged items of taskbar UI controller
Flag: com.android.wm.shell.enable_bubble_bar
Test: manual - test dragging bubbles with the other CL
Bug: 345488529
Change-Id: I95085fd18f2710cd36a2d47640641da047aa48c7
2024-08-19 09:52:57 -07:00
fbaron 01fc975288 Add screenrecording for testOverview
Flag: EXEMPT TEST_ONLY
Bug: 355042336
Test: FallBackRecentsTest#testOverview
Change-Id: Ic512e3a1ce887f8d4e8158f6650d99dfb8121650
2024-08-19 09:47:07 -07:00
Liran Binyamin 63ef8cf1e7 Deflake BubbleViewScreenshotTest
Hiding the dot runs an animation which is flaky.
Instead the bubble is created with the suppress notification flag.

Flake: https://android-build.corp.google.com/abtd/run/L87700030005824088

ABTD 50x: https://android-build.corp.google.com/abtd/run/L03700030005851578

Flag: EXEMPT test only
Bug: 355454021
Test: atest BubbleViewScreenshotTest
Change-Id: I635eafb44a3e0ffb9b38fd83c8cc7b36822cce75
2024-08-18 08:39:30 -04:00
Winson Chung cafe06f63d Merge "Detach the nav bar from the app when going home" into main 2024-08-16 22:42:44 +00:00
Mykola Podolian 3bae9ff981 Merge "Fixed issue when hotseat icons are not touchable" into main 2024-08-16 22:26:56 +00:00
Shamali Patwa accd0f68c8 Merge "Update the scale on corner radii on scaled image drawable." into main 2024-08-16 20:37:57 +00:00
mpodolian 9367722dbc Fixed issue when hotseat icons are not touchable
The issue existed because of taskbar insets where set to the full height
of bubble and task bars. Added check that only adds bars touch area if
the user is currently not on the launcher home screen. Commented failing
tests.

Bug: 358301278
Bug: 359277238
Flag: com.android.wm.shell.enable_bubble_bar
Test: Manual.
http://recall/-/gx8ASgewUeUS3QYohfrd1J/hcgYuHUJwfbhlvPRsvdWYf
The touch area is within the red rectangle.

Change-Id: I3c2ad3633a049972b93fe5c5e45efd557c220e1f
2024-08-16 13:00:03 -07:00
Luca Zuccarini 0ad76ac07d Merge "Move some Shell utils to the Shared package." into main 2024-08-16 16:32:37 +00:00
Pat Manning 0c6e17020d Merge "Show and hide taskbar tooltips immediately." into main 2024-08-16 14:45:10 +00:00
Helen Cheuk 76b2dad620 Merge "Fix stuck focus outline after returning to home" into main 2024-08-16 10:51:56 +00:00
Treehugger Robot a21058eb88 Merge "Move TouchEventGenerator to multivalent" into main 2024-08-16 06:04:22 +00:00
Winson Chung 5db6d3dd8e Detach the nav bar from the app when going home
- Nothing currently detaches the nav bar from the app until the recents
  animation completes if onAnimationStart() happens after the end
  target is set

Flag: EXEMPT bugfix
Fixes: 343457097
Test: Artificially introduce delayed onRecentsAnimationStart and verify
      detachNavFromApp is called
Change-Id: I1ec0d8821d61f9fad9a811d6a12ce21e8417252f
2024-08-16 00:27:31 +00:00
Brandon Dayauon 109f516e3e Merge "Add logs for when sectionInfo is computed or added for bugreport." into main 2024-08-15 23:10:18 +00:00
Andrew Cole a1a6f2fef1 Merge "IconCacheUpdateHandlerTest" into main 2024-08-15 20:23:02 +00:00
Brandon Dayauon 71fff87e2d Add logs for when sectionInfo is computed or added for bugreport.
bug: 336947811
Test: manually/presubmit: https://screenshot.googleplex.com/A2st8q57pajFBcG
dump: https://screenshot.googleplex.com/8JGoqz2ixodHH94
Flag: NONE adding logs

Change-Id: I3edc953fa8ec58a3677cc65f858b50d95184592c
2024-08-15 11:40:31 -07:00
Xin Li 8b7ca72941 [automerger skipped] Merge 24Q3 (ab/AP3A.240905.015) to aosp-main-future am: 8d61e06a98 -s ours
am skip reason: Merged-In Icc555cad17b734e2a9c035991c19bbdc6b02de5d with SHA-1 aeecb1e8a5 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/28804256

Change-Id: Ic1600f796e38ea7adb0e4f9a91f1a340a8c3daff
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-15 18:23:55 +00:00
Stefan Andonian fb34891ba6 Add logs to check if onLayout is ever not called.
Bug: 349929393
Test: Verified locally that the logs are shown in a bugreport.
Flag: EXEMPT logs
Change-Id: Ie5b759a2616456db9e232efcb0cfd21fdd4cc291
2024-08-15 18:22:25 +00:00
Pat Manning b488c88fa3 Show and hide taskbar tooltips immediately.
Fix: 356352494
Test: TaskbarHoverToolTipControllerTest
Flag: EXEMPT bugfix
Change-Id: Ie7dc1f341cf059bb38f61fa185152cb2555e36b1
2024-08-15 17:59:59 +01:00
Treehugger Robot 1d94ee8627 Merge "If we're adding / removing a bubble, don't forget to add the overflow" into main 2024-08-15 16:49:46 +00:00
helencheuk 80896721ae Fix stuck focus outline after returning to home
Sometimes SmartspaceViewContainer is not the LastFocusedItem in ItemFocusIndicatorHelper when triggering changeFocus, it would skip the hiding outline animation which causes the stuck focus outline.
So the solution is to add a checking in "changeFocus" that if the LastFocusedItem is not the view calling changeFocus and it does not have focus now, it means no need to add or remove outline and could just return.

Bug: 349019294
Test: after going to notification panel, touch/click could make the outline disappears. https://drive.google.com/file/d/1aXQ38CEqvzJVj7gBM-KNTCJSpzfwYZsn/view?usp=sharing
Test: after going home from app in overview, touch/click make the outline disappears. https://drive.google.com/file/d/1DgYzAgIJqAHJ_DuYjswlCUBOiohprJze/view?usp=sharing
Flag: EXEMPT bugfix
Change-Id: I4613ba2fe92ec609055e48dc0b5ff53c2037a158
2024-08-15 16:41:18 +01:00
Treehugger Robot 3ed6885901 Merge "Fix launch animation issue for Desktop tile" into main 2024-08-15 12:17:58 +00:00
Liran Binyamin 02fdb75687 Revert^2 "Synchronize bar expansion with WM Shell"
799802cb7e

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 339683389
Test: atest BubbleBarViewAnimatorTest
Change-Id: Icd853eb76b20ee5ca035bd20c9360f5b60ecc00d
2024-08-15 10:35:36 +00:00
Liran Binyamin 246837aa59 Merge "Don't reset alpha after dragging to dismiss" into main 2024-08-15 08:03:13 +00:00
Xin Li 8d61e06a98 Merge 24Q3 (ab/AP3A.240905.015) to aosp-main-future
Bug: 347831320
Merged-In: Icc555cad17b734e2a9c035991c19bbdc6b02de5d
Change-Id: Ifc2f4879f01242b459614cc46fa66eb90cacd48d
2024-08-14 23:25:28 -07:00
Tracy Zhou 9944b989d6 Merge "Use isGestureNav signal from TaskbarActivityContext for getTaskbarPhoneDimensions" into main 2024-08-15 04:56:41 +00:00
Shamali P c7e1b5c975 Update the scale on corner radii on scaled image drawable.
The RoundedDrawableWrapper applies rounded corners on each draw, so,
on scaling, the corners look odd for small widgets.

This change, applies the same scale to corner radius as well.
There are some widgets whose preview images have embedded transparency,
but we don't do much for such previews.

Bug: 359860747
Test: Manual
Flag: EXEMPT bugfix
Change-Id: I5e58e29765503454f286d99050b13b497531d306
2024-08-15 02:54:17 +00:00
Treehugger Robot 9df623644a Merge "Register the bubble listener after everything has been initialized" into main 2024-08-15 01:51:24 +00:00
Tracy Zhou a51ee6a4dc Use isGestureNav signal from TaskbarActivityContext for getTaskbarPhoneDimensions
Somehow deviceProfile.isGestureMode doesn't have the right signal for tests.

We need to look into why dp doesn't have the right signal for isGestureMode in tests. Temporary fix here to unblock pushing the flag to staging

Bug: 359196354
Test: https://android-build.corp.google.com/builds/abtd/run/L05600030005823769
Flag: com.android.wm.shell.enable_taskbar_on_phones
Change-Id: Ie6451812cf4b0c3f034cabdfd4cec726322af0bc
2024-08-15 01:49:40 +00:00
Brandon Dayauon 36b02ec389 Merge "Set maxLines for private space header to 1." into main 2024-08-15 01:16:06 +00:00
Mady Mellor a7f2d83b61 If we're adding / removing a bubble, don't forget to add the overflow
One case I missed was a bubble being added/removed AND the overflow
showing... this isn't the nicest, but when the add/remove animation
is done, animate the overflow in.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 358304168
Test: manual - don't have the overflow showing, add a 6th bubble,
               observe that the overflow appears
Change-Id: I1a9cec3970f5535e935f3404fa6dbd6de2f69fa5
2024-08-14 16:23:07 -07:00
Andrew Cole d61fbd4140 IconCacheUpdateHandlerTest
This is the unit testing for the updates to IconCacheUpdateHandler

Bug: 357725795
Test: SELF
Flag: TEST_ONLY
Change-Id: I159f5ef70fcc9a5aae7bb319f06a3ff935f28246
2024-08-14 15:57:42 -07:00
Mady Mellor 173ac574d8 Register the bubble listener after everything has been initialized
Flag: com.android.wm.shell.enable_bubble_bar
Test: manual - have bubbles in bubble bar, switch between transient
               taskbar and pinned taskbar repeatedly.
Bug: 359096619
Change-Id: I02beacff64b12380ee6d134b7dcc64cfd27e4b0b
2024-08-14 15:22:21 -07:00
Sihua Ma 97ed80634d Move TouchEventGenerator to multivalent
Test: atest NexusLauncherRoboTests
Flag: TEST_ONLY
Change-Id: I6603b4764de6708cb0c3d7c2a52c0ffb81607771
2024-08-14 21:17:44 +00:00
Brandon Dayauon 4f7d4c2975 Set maxLines for private space header to 1.
This is an issue for large font/display that in the arabic language will clip the Private text.

bug: 357942579
Test manually: https://drive.google.com/file/d/1FFZpXmfwKlRG7mvmSCtc1dtjwUjuXjfW/view?usp=sharing
Flag: NONE bugix

Change-Id: I22943237e10b502edb6aae6845fbe6027fda1323
2024-08-14 13:47:37 -07:00
Saumya Prakash ce8353fdcc Merge "Disable split screen option in app menu in Desktop Mode" into main 2024-08-14 19:16:09 +00:00
Liana Kazanova (xWF) 4b4a045474 Merge "Revert "Synchronize bar expansion with WM Shell"" into main 2024-08-14 19:08:26 +00:00
Liana Kazanova (xWF) 799802cb7e Revert "Synchronize bar expansion with WM Shell"
Revert submission 28703070-bubbles-defer-expand

Reason for revert: DroidMonitor. Potential culprit for b/359765550 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Reverted changes: /q/submissionid:28703070-bubbles-defer-expand

Change-Id: I5651cc8f740b1f0718abcfa8065e18c174657224
2024-08-14 16:58:12 +00:00
Alex Chau 4bb08df3dc Fix launch animation issue for Desktop tile
- See http://go/b320307512_problems for details
- Adding the following to DesktopTaskView's launch animation
  - Problem 1: Animate away DesktopTaskView's background according to fullscreenProgress, instead of a jump cut
  - Problem 2: Animate Overview's background to transparent to reveal the wallpaper behind
  - Problem 3: Animate wallpaper's zoom back to 1
- Problem 4: Apply TaskRectTransltion in TaskViewSimualtor for DesktopTaksView as well, which is used to account for TaskView not in center.
- Problem 4: Also applied RecentsView zoom in animation when TaskView is not in center, to make the whole DesktopTaskView container (backgroundView) moves as a whole. This requires calculating a new pivot before applying the zoom.
- Problem 5: When swipe down or quick switch from home into Desktop, run DesktopRecentsTransitionController without animation to put everything in the end state immediately to avoid animating again
- Problem 6: For swipe down animation, we now let createAdjacentPageAnimForTaskLaunch handle the wallpaper zoom and splash alpha, instead of doubling the effort. In case of Desktop, wallpaper depth be aniamted to 0 (no zoom/blur)
- Problem 6: Bring Desktop live tile to front during swipe down to avoid wallpaper blur applying to the desktop
- Problem 7 and 8: Crop out desktop window outside full screen bound. This is done by calulating intersection between full screen Rect and desktop window's Rect
- Problem 8: Make swipe down to use thumbnailBounds instead of bounds of the first snapshotView, this fixes all situations that first snapshotView's height is different from TaskView (e.g. vertical split, DesktopTaskView)
- Problem 9: Desktop remote target's alpha should remain 1

Bug: 320307512
Test: TaplTestsOverviewDesktop, motion fixes are tested manually
Flag: com.android.window.flags.enable_desktop_windowing_mode
Change-Id: Iae6e594424dfc89851b4f7179b0fb5b5ac5e7f46
Signed-off-by: Alex Chau <alexchau@google.com>
2024-08-14 17:31:59 +01:00
Liran Binyamin afdad57bdf Don't reset alpha after dragging to dismiss
After dragging the bubble bar to dismiss, don't reset its alpha
value.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 359804931
Test: manual
      - Create a bubble in the bubble bar
      - Drag bubble bar to dismiss
      - Create another bubble
      - Observe the new bubble does not flicker
Change-Id: I8d56f71d38ec33acda8efade50735b59254d77d4
2024-08-14 08:08:40 -04:00
Liran Binyamin 229696a0e4 Check bubble count for initial state animation
With optional overflow, we need to check for actual bubble count
before animating the bubble bar to its initial state.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 359403793
Test: manual
       - create first bubble on home
       - observe bubble bar animates correctly to initial state
       - add second bubble
       - observe bubble bar bounces correctly and does not slide
         in from the bottom of the screen
Change-Id: I53a34bc00b24e8a6504bcca0532054755554b9ac
2024-08-14 03:47:35 -04:00
Liran Binyamin f544f7f164 Merge "Synchronize bar expansion with WM Shell" into main 2024-08-14 06:37:38 +00:00
Saumya Prakash eb950c1f44 Disable split screen option in app menu in Desktop Mode
The split screen app shortcut is not intended to work in Desktop Mode.
This change removes it from Taskbar and all apps in this mode to avoid
a crash.

Fix: 346333758
Test: Launch the app menu for different apps in Desktop mode and in
normal mode. Check that the split option only shows up in normal mode.
Flag: EXEMPT bugfix

Change-Id: I6e2535b41a490ad3eb5c0ebd924c49eaf5028669
2024-08-13 22:22:19 +00:00
Treehugger Robot 28cbc13413 Merge "Ensure that inactive archived icons in the folder preview are not shown as grey pending icons" into main 2024-08-13 22:19:44 +00:00
Treehugger Robot 1a7bd33654 Merge "Add screen recording to TaplTestsQuickstep#testQuickSwitchToPreviousAppForTablet" into main 2024-08-13 21:42:22 +00:00
Treehugger Robot 4a65dc603c [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev am: de7caa6162 -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/28776182

Change-Id: I34c6bbeb7ff14e0504a971b47fca8d6533dad7b1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-13 19:10:20 +00:00