Commit Graph

78507 Commits

Author SHA1 Message Date
Jagrut Desai bb92ca0855 Merge "Do not register Taskbar System Action when device is in phone mode" into main 2024-08-21 20:31:26 +00:00
Luca Zuccarini c1f0506da0 2/3 Move some Shell utils to the Shared package.
Bug: 322791067
Flag: EXEMPT move only
Test: NA
Change-Id: I076d41404f23bd44fa6157a5dc39a60e467c79c3
2024-08-21 19:47:12 +00:00
Treehugger Robot cbd92ce7e4 Merge "Move DesktopTask to front of RecentsView (1/2)" into main 2024-08-21 18:38:34 +00:00
Sebastián Franco 1ac0438aac Merge "Adding debug logs for Test event emitter" into main 2024-08-21 18:01:46 +00:00
Jon Miranda 7d783ff70f Add animation for the predicted icon ring
Animation is modeled after the notification dot animation.

- This avoids the ring jumping in after swiping up to home to
  a predicted app.
- Also decreased the amount of time the icon has to fade out so
  that it shows up less during the animation.

Fixes: 360115794
Test: open predicted app from hotseat, swipe up to return home
Flag: EXEMPT bugfix
Change-Id: I59659610eb2e9f375a408d553bb4aa80947a28c4
2024-08-21 17:30:19 +00:00
Vinay Joglekar eff3722286 Merge "DesktopTaskView rendered incorrectly in RTL" into main 2024-08-21 17:06:40 +00:00
Jordan Silva b06ff83808 Move DesktopTask to front of RecentsView (1/2)
This CL updates the DesktopTasks in the RecentsView to be displayed after the focused task, separated from the other tasks in the grid. The DesktopTasks will be larger, following the same size used for focused tasks.
It was necessary to do the following changes to support DesktopTask at the front of the list.
1. Sort the GroupTasks in applyLoadPlan to move DesktopTasks after all other tasks.
2. Update the target page to take into account the DesktopTasks after the running task.
3. updateGridProperties had to support DesktopTask and Focused Task to be positioned at the front of the list. This function updates view translations to support the grid with two rows and rebalacing the position after a task is dimissed.
4. Update the max and min page scroll. Updated getFirstViewIndex to check for a DesktopTaskView, and if it doesn't exist, it uses the focused task as reference.
5. TaskView.updateTaskSize was updated to prevent DesktopTaskView being resized. This change makes DesktopTaskView to have the same size of our current focused task.
6. Update several places using focused task to use isLargeTile.

Bug: 353947137
Fix: 353947516
Fix: 353947467
Fix: 353947334
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Test: OverviewDesktopTaskImageTest

Change-Id: Ic7c0d8340ca259e8644de180aa6859a3c968d66e
2024-08-21 17:43:36 +01:00
Uwais Ashraf e0a0ebeece Prevent requestLayout() when updating drawables that don't change size
Fix: 354224963
Test: presubmits passing, manual
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I31d9a51ed621f411bcafbb5bf885ee2587df057f
2024-08-21 15:45:05 +00:00
Uwais Ashraf f1c14902ca Fix splash icon size to 52dp
Fix: 360804090
Test: presubmits passing, manual
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I1bc14be7d2d25a985d26709eb59b8aa4887d4764
2024-08-21 15:44:03 +00:00
vinayjoglekar 297f371b3d DesktopTaskView rendered incorrectly in RTL
Test: Manual
BUG: 357151780
Flag: com.android.window.flags.enable_desktop_windowing_mode
Change-Id: I1ea2bd7a6e6355a5a226c3516747c5b0205b9cbc
2024-08-21 12:46:42 +01:00
Alex Chau 9109b81a95 Reset mTopRowIdSet in applyLoadPlan
- All taskViewIds become obsolete after removing and re-adding, so we'll need to reset mTopRowIdSet when removing all taskViews
- OverviewActionsView.updateActionButtonsVisibility can be called before updateDimension (where mDp is set), so a null check is necessary
- Fixed TestStaibilityRule failing when running FallbackRecentsTest alone. FallbackRecentsTest runs with 3P Launcher, in that case launcherPackageName is our test activity, and launcherVersion can be null. This can only occur in a local run, thus return LOCAL in this case.

Fix: 355042336
Test: FallbackRecentsTest and manually testing dismiss
Flag: EXEMPT BUG_FIX
Change-Id: I9125ea38a567deb0d3028e7d7407397d1dc06ade
2024-08-21 12:37:14 +01:00
Alex Chau 1eebacf636 Merge "Clean-up debug logs" into main 2024-08-21 10:53:21 +00:00
Uwais Ashraf 06ffcf8c61 Merge "Migrate model tests to multivalent" into main 2024-08-21 10:05:40 +00:00
Liran Binyamin b93e454737 Update both width and height in BubbleBarView
We currently only update the width of the bubble bar but the
height is only updated when the icon size changes, so it's often
inaccurate. This affects screenshot testing where the bubble bar
isn't fully visible in the screenshot.

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 355454021
Test: manual
       - used the bar normally to make sure it's not broken
Change-Id: If780308e10e7478a3651654e5fc2b3f9c4e36c14
2024-08-21 05:18:20 -04:00
Treehugger Robot ae34d3c464 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev am: f82981703e -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/28892740

Change-Id: Ifb9c284edddfbedd5e847cbe82b1cb96b36288c7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-21 08:28:18 +00:00
Bill Yi a352bd13cd [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 918ad70120 -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/28892740

Change-Id: I30e5f85a57ef90f3b8b1f58f8b16110f49bbb6ca
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-21 08:28:15 +00:00
Bill Yi 3210b83a7b [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 6fdcc2c9ae -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/28892402

Change-Id: I1fd7ae63234799bd7fa7ba8cf7dd4a646cb3e779
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-21 08:28:07 +00:00
Treehugger Robot 2f79414090 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-08-21 07:56:17 +00:00
Treehugger Robot 0e5173361a Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-08-21 07:56:17 +00:00
Treehugger Robot f82981703e Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev 2024-08-21 07:54:24 +00:00
Treehugger Robot f4a0244648 Merge "Dismiss the setup wizard for both presubmit and post submit tests." into main 2024-08-21 06:08:11 +00:00
Anushree Ganjam 77aed7422a Dismiss the setup wizard for both presubmit and post submit tests.
In the past we have faced setup wizard not dismissed issue but eng prod
team has not fixed this issue. See b/309008042 for more details.

Bug: 359658695
Bug: 359658158
Bug: 356695093
Bug: 355718051
Flag: TEST_ONLY
Test: Manual
Change-Id: Ief020483fa167946193875f9d6c089d1cfd55124
2024-08-20 17:07:30 -07:00
Tracy Zhou ee87fb8940 Merge "notifyTaskbarStatus in taskbar phone mode" into main 2024-08-20 22:38:06 +00:00
Shamali Patwa e4262972cc Merge changes from topic "sug-a11y" into main
* changes:
  Adjust tap target of the profile tabs in picker
  Focus on first item to match the behavior with widgets list
2024-08-20 21:50:44 +00:00
Mady Mellor c15fe691e7 Merge changes I964d213d,I95085fd1 into main
* changes:
  Make an input consumer for bubble bar
  Include bubbles in the dragged items of taskbar UI controller
2024-08-20 21:34:54 +00:00
Shuming Hao ee49cb2e26 Merge "Remove unused resources for split screen handle" into main 2024-08-20 21:16:16 +00:00
Treehugger Robot 85b03a9f78 Merge "Add logs to check if onLayout is ever not called." into main 2024-08-20 21:09:38 +00:00
Tracy Zhou a54e490eb1 notifyTaskbarStatus in taskbar phone mode
This fixes notification shade not being able to swipe up to the edge during animation because it listens to the task bar visibility signal

Fixes: 352365691
Test: https://b.corp.google.com/issues/352365691#comment28
Flag: com.android.wm.shell.enable_taskbar_on_phones
Change-Id: I10d6f49d087dd85b3a8bc5894f76f5d46ba4a865
2024-08-20 20:39:41 +00:00
Winson Chung ab06202228 Merge "1/ Remove unused legacy recents paths" into main 2024-08-20 20:02:50 +00:00
Alex Chau fdbfd3410b Clean-up debug logs
Fix: 336660988
Test: presubmit
Flag: TEST_ONLY
Change-Id: Ie66a34134881e4333f610d8979b2ac443d54a1cb
2024-08-20 19:01:19 +01:00
Treehugger Robot d064e58ff0 Merge "Handle multithreading in ActiveGestureLog" into main 2024-08-20 17:07:35 +00:00
Treehugger Robot 5f6f4b4342 Merge "Remove manual call to stash takbar from within onTaskbarIconLaunched." into main 2024-08-20 15:51:18 +00:00
Schneider Victor-tulias cb8b3f27d2 Handle multithreading in ActiveGestureLog
ArrayList.add is not thread-safe. Attempting rapid calls across threads is the only way for it to throw ArrayIndexOutOfBoundsException.

Flag: EXEMPT bug fix
Fixes: 360619084
Test: checked TIS logs
Change-Id: I66e5f2e13d5237717abcf42e56efa2942f317676
2024-08-20 11:10:09 -04:00
Liran Binyamin 873fbaaebf Merge "Check bubble count for initial state animation" into main 2024-08-20 14:08:14 +00:00
Treehugger Robot eda0a92d52 Merge "Read task size info from RecentsView directly" into main 2024-08-20 11:46:03 +00:00
Alex Chau 6d00b4b014 Read task size info from RecentsView directly
- Automatically determine the Overivew component to use the correct RecentsViewContainer
- Also added log on both pre-computed taskSize and newly calculated task size

Bug: 336660988
Test: presubmit
Flag: TEST_ONLY
Change-Id: Ic0adfba35af513e731007241416fc85760135f07
2024-08-20 10:56:52 +01:00
Sihua Ma 58e8573085 Migrate model tests to multivalent
Also migrating some other tests that have been verified

Test: SysUI studio
Test: atest NexusLauncherRoboTests
Flag: TEST_ONLY
Change-Id: I072201b8e7b98945ca88657fe813fef4727f16e4
2024-08-20 07:28:35 +00:00
Jeremy Sim bfb29a2e3f Merge "Add a contentDescription to splitscreen's first staged task" into main 2024-08-20 05:05:50 +00:00
Jeremy Sim 2e59268f3b Add a contentDescription to splitscreen's first staged task
Currently, when we stage the first app in a split, the floatingTaskView has no contentDescription and is announced by screen readers as "unlabeled".

This CL allows FloatingTaskView to copy a contentDescription from the underlying task or ItemInfo when it is created.

Also changes SplitConfigurationOptions#itemInfo to a private field with a public getter for mockito compatibility.

Fixes: 319783133
Test: Confirmed with TalkBack on Overview, contextual and Intent splits
Flag: EXEMPT bugfix
Change-Id: Ia5a95e403bfe8623e17d2ceac9073ef15c7bb476
2024-08-20 03:19:58 +00:00
Treehugger Robot e418ad51ce Merge "Add logs for getFocusedTaskHeightForTablet" into main 2024-08-20 01:19:29 +00:00
Sebastian Franco 8898fc4d09 Adding debug logs for Test event emitter
Bug: 352569050
Test: IntegrationReorderWidgetsTest
Flag: EXEMPT bugfix
Change-Id: Ib906f9a5ee74150aee331181c30145da9958baf2
2024-08-19 18:07:49 -07:00
Shamali P 8c965c67dc Adjust tap target of the profile tabs in picker
Uses insets on background drawable to maintain visual size.

Bug: 360245807
Test: Accessibility scanner
Flag: EXEMPT bugfix
Change-Id: I1fbc7c2c782a1e331dd1ba77b0a3bf8aad277792
2024-08-20 00:42:32 +00:00
Shamali P 64b0ad623a Focus on first item to match the behavior with widgets list
On opening suggestions, was focusing on entire right pane, instead,
focusing now on first item to match with the widget apps list below.

Bug: 359795405
Test: Talkback
Flag: EXEMPT bugfix
Change-Id: I4aaefc7642910b544f56522ac0b3cb10454626c7
2024-08-20 00:12:29 +00:00
Jon Miranda 173c218366 Remove manual call to stash takbar from within onTaskbarIconLaunched.
Taskbar does not know if the icon clicked will result in a translucent
activity. After this change, taskbar app stashing logic is now the same
between taskbar and home launches.

We should still stash after split screen, because in the case of
translucent activity the background becomes opaque.

Fixes: 354627538
Test: Pause app in hotseat, go to overview, launch paused app
      note that taskbar does not go away
Flag: EXEMPT bugfix
Change-Id: I3d3ed7a6ca10090c7207b45d0b272dc4fc928e32
2024-08-19 16:41:36 -07:00
Federico Baron 89306a057d Merge "Add screenrecording for testOverview" into main 2024-08-19 23:14:53 +00:00
Jagrut Desai 0f59383c62 Do not register Taskbar System Action when device is in phone mode
Bug: 359880840
Test: Presubmit
Flag: NONE bug fixing for taskbar system action

Change-Id: Idf34bd677a96cf711e80df1561d49441824ae4ba
2024-08-19 16:00:26 -07:00
Mady Mellor 788a6ebb74 Make an input consumer for bubble bar
Instead of unstashing bubble bar in TaskbarUnstashInputConsumer
handle it in its own input consumer instead. This is a nicer
separation of concerns and simplifies the logic in both places.

Additionally, this fixes issues where swiping up the bubble bar
handle might initiate / be handled by gesture nav (or all apps) when
really any events originating on bubble UI should be managed by
bubbles instead.

Adds some mostly mock'd tests to check that the static method used
to indicate if bubbles should take the event or not works correctly.

Flag: com.android.wm.shell.enable_bubble_bar
Test: manual - test swipe up on bubble bar handle in an app
             - test swipe up on bubble bar on home - it should
               open & all apps / launcher transition shouldn't happen
             - longpress to drag bubbles around on home and overview,
               try the collapsed bar & individual bubbles in the
               expanded bar
             - test dragging on the bubble bar after it's revealed
               in an app
Test: atest BubbleBarInputConsumerTest
Bug: 345488529
Change-Id: I964d213d71de15e4350cff5202dfb9343de1af14
2024-08-19 15:26:37 -07:00
Bill Yi 918ad70120 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I723ac0d2235ee0f7d7228f8546293db7cf84e59b
2024-08-19 14:43:11 -07:00
Bill Yi f81a5125f8 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I9e1c3f5d14d60f9c8c37dfcb217ba39ba992ed14
2024-08-19 14:42:43 -07:00
Bill Yi 6fdcc2c9ae Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I05984a6e13a206231cf60be7e40776f35c603258
2024-08-19 14:41:39 -07:00