PawletOS/Lawnchair
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
78,507 Commits 1 Branch 0 Tags
eedc7ab8fdb94de05201fa87537991558accbe8a
Commit Graph

78507 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Sunny Goyal 10c14c297d Merge "Overriding the default TextClock and AnalogClock behavior to avoid RPCs on main thread during onAttachToWindow" into main 2023-09-18 22:55:26 +00:00
Jagrut Desai 555d71f70f Merge "Taskbar Pinning Analytics Event" into main 2023-09-18 22:11:08 +00:00
Vinit Nayak 3a57263a7d Merge "Exit split selection state if launcher interrupted" into main 2023-09-18 21:56:07 +00:00
Schneider Victor-tulias 44de9caaeb Send ACTION_CANCEL motion event to TIS instead of finishing the recents animation on screen off 
Finishing the recents animation on screen off callback did not necessarily stop touch tracking, which would allow the user to double press the power button, but create a broken experience.

Sending ACTION_DOWN instead stops touch tracking and runs the proper clean up methods.

Flag: not needed
Fixes: 299235099
Test: single-pressed and double-pressed the power button mid-gesture
Change-Id: I2608053460f43703613bd6caead91ccb4ce08ceb
 2023-09-18 16:28:43 -04:00
Sunny Goyal 140883e599 Overriding the default TextClock and AnalogClock behavior to avoid RPCs on main thread 
during onAttachToWindow

Bug: 294352799
Test: Verified on device
Flag: N/A
Change-Id: I3cce6900cd62a6e9a57c155b74c15c2340c6011b
 2023-09-18 13:26:31 -07:00
Treehugger Robot 29296b3f8b Merge "Fix color in workspace. Where theme badge is applied when it shouldn't" into main 2023-09-18 20:04:42 +00:00
Brian Isganitis cd1b81e4c9 Merge "Optimize paths for all apps search drawables." into main 2023-09-18 20:03:16 +00:00
Schneider Victor-tulias a1a5e08713 Replace all uses of string concatenation with CompoundString in ActiveGestureLog 
Flag: not needed
Fixes: 300926831
Test: ran launcher, tested gestures and checked logs
Change-Id: Iede0881be315cb1ef0a30eaf2a9e17e020828586
 2023-09-18 15:51:14 -04:00
Jagrut Desai 4439af4191 Taskbar Pinning Analytics Event 
Inlcuded Analytics Event
- Taskbar Divider Popup Menu Open/Close
- Taskbar was pinned
- Taskbar was unpinned

Bug: 265436916
Test: Confirm with data scientist that data is being logged.
Flag: ENABLE_TASKBAR_PINNING
Change-Id: I307d000efe9ad8a32cdbe0b8df7248b19eabb08b
 2023-09-18 12:36:17 -07:00
Vadim Tryshev 8a80ae21fd Merge "Adding TestStabilityRule; otherwise @Stability annotation is ignored." into main 2023-09-18 18:51:11 +00:00
Mady Mellor b898a3c8d3 Fix bubbles taskbar scrim showing when notification panel is shown 
TaskbarScrimViewController was previously unaware of visibility
changes that happened to taskbar outside of when the sysui state
flags changed. Additionally, isTaskbarVisibileAndNotStashing is not
a reliable signal as the visibility might be GONE even though taskbar
is about to animate to be visible (i.e. shade is showing and then
you swipe it back up -- taskbar scrim wouldn't appear because when
the sysuiStateFlags changed, taskbar visibility would still be 'gone'
at that point so the taskbar scrim wouldn't animate back when
the shade is swiped up).

To resolve this, I've added a callback to notify the scrim
controller of visibility changes and it'll update if needed.

Bug: 270634233
Test: manual - enable 3 button nav
             - have a bubble
             - go to overview
             - expand bubbles
             => observe that scrim appears over taskbar
             - swipe down shade
             => observe that scrim fades out
             - swipe shade up
             => observe that scrim fades in

Change-Id: Ibaae8efb90b4558d30795298570208a52b31efb4
 2023-09-18 11:49:52 -07:00
Mady Mellor 2a76764d73 Merge "Only stash bubbles in overview when it's transient taskbar" into main 2023-09-18 18:48:58 +00:00
Tony Wickham 2b9b15325c Merge "Remove unused variables in FullscreenDrawParams and PreviewPositionHelper" into main 2023-09-18 17:41:06 +00:00
Tony Wickham 2a35b5801e Finish recents animation synchronously on cancel event am: 2316dc4750 am: e136b6a641 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24755062

Change-Id: I95fbc8c18584fe304696be81c75677d3e388ac5b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-18 17:08:27 +00:00
Schneider Victor-tulias 0afb0b740b Merge "Add overview button rate-limiter to fix recurring bug" into main 2023-09-18 16:52:19 +00:00
Tony Wickham 8e735c8234 Add some gesture logs 
- Log when a DelegateInputConsumer becomes active
- Add reason for NavHandleLongPressInputConsumer
- Fixed typo

Test: adb shell dumpsys activity service TouchInteractionService
locally and verify logs
Flag: ENABLE_LONG_PRESS_NAV_HANDLE
Bug: 300247322

Change-Id: Ie2cdc8f4bfc8a6c794536871e714ff913f36f46f
 2023-09-18 16:34:20 +00:00
Tony Wickham e136b6a641 Finish recents animation synchronously on cancel event am: 2316dc4750 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24755062

Change-Id: Ib8bd21048402db34caf681802599517b4a37cb94
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-18 16:11:14 +00:00
Pat Manning 9ea209b893 Merge "Add test to check swiping from app to overview without unstashing taskbar." into main 2023-09-18 15:39:23 +00:00
Pat Manning 66c1051e7e Merge "Remove taskbar tooltip hover delay." into main 2023-09-18 15:37:34 +00:00
Tony Wickham 2316dc4750 Finish recents animation synchronously on cancel event 
Fixes: 300247322
Test: invoke omnient via long press nav handle
Flag: ENABLE_LONG_PRESS_NAV_HANDLE

Change-Id: I5d7cd1d0a2a50da26a881a6daa203806bf857909
 2023-09-18 15:34:29 +00:00
Nicolò Mazzucato dcae359a76 [automerger skipped] Merge "Preload overview after unfold" into udc-qpr-dev am: 3c898a7550 am: 6eb5e0892b -s ours 
am skip reason: Merged-In I35a7036887cc9ea490f27d5ccd47fe423775350b with SHA-1 11ce5f85c9 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24771967

Change-Id: I20e1017baaef8072151b5b6bdd609bccd6632655
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-18 10:54:21 +00:00
Nicolò Mazzucato 6eb5e0892b Merge "Preload overview after unfold" into udc-qpr-dev am: 3c898a7550 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24771967

Change-Id: Ic4f1ca2b27cd408963ff33ad7972ec4d1fef5a66
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-18 09:53:20 +00:00
Nicolò Mazzucato 3c898a7550 Merge "Preload overview after unfold" into udc-qpr-dev 2023-09-18 08:37:56 +00:00
Vinit Nayak dd96f79b36 Merge "Provide bgExecutor for RotationButtonController" into udc-qpr-dev am: 8ad9393213 am: a6f66eeba7 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24761312

Change-Id: I3f6610ca6dd3087298e84d24ceb0570d3d2749ee
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-16 02:45:25 +00:00
Bill Yi 75602b2b48 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-d1-dev am: 025cd855b4 -s ours am: 4c053e5f6b -s ours am: b3debbd3f0 -s ours 
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24744205

Change-Id: Icb74feb841e51421f296f2addf043f60ca55cc93
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-16 02:30:29 +00:00
Bill Yi d634ed8206 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: d4b83ccdd2 -s ours am: 849137d43b -s ours am: b4aab39bd3 -s ours 
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24744205

Change-Id: I1e3ab092c8a32ab2d20c8de134bd763328873b58
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-16 02:30:16 +00:00
Bill Yi fd8e8f8a12 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-d1-dev am: 025cd855b4 -s ours am: cb209aed15 -s ours am: ba466befc1 -s ours 
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24744205

Change-Id: I6feef59c0dc02d8548041db015c5a67f272499ab
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-16 02:24:18 +00:00
Bill Yi 2203ab6c4c [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: d4b83ccdd2 -s ours am: edc976e7a9 -s ours am: c4d895d9dc -s ours 
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24744205

Change-Id: I11e25985d56b3620e8c5eb706ee5c1c1db2d41b9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-16 02:24:06 +00:00
Vadim Tryshev 403d945037 Adding TestStabilityRule; otherwise @Stability annotation is ignored. 
Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: Ic13a183ff285eca02ed69a2e09822cc66655797b
 2023-09-15 19:09:11 -07:00
Bill Yi afab494d4d [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: ff384a5c07 -s ours am: fefc1affdc -s ours am: 19db4a7207 -s ours am: e2e850837c -s ours 
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24743643

Change-Id: I8a1a90fda9b0f5dff6d8026155ab7243436eabfd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-16 01:47:43 +00:00
Bill Yi f950ad4acd [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: ff384a5c07 -s ours am: fefc1affdc -s ours am: e5e8ed942b -s ours am: 6fa872a3b3 -s ours 
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24743643

Change-Id: Ieb374ddc2749c56faff3b317120bdd189f4bd5b7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-16 01:42:02 +00:00
Bill Yi 034ca4c38b [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: ff384a5c07 -s ours am: d2b916b459 -s ours am: cebd154241 -s ours am: ec23500811 -s ours 
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24743643

Change-Id: I6e40bab3cb47ca19a524ee68e522c0401fd1852c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-16 01:34:03 +00:00
Vadim Tryshev 8413ce37fe Merge "Waiting for a TYPE_WINDOW_STATE_CHANGED event when starting Settings from task menu." into main 2023-09-16 01:24:52 +00:00
Android Build Coastguard Worker 7abfd8b9f2 Snap for 10817717 from 8ad9393213 to udc-qpr1-release 
Change-Id: Ib7e8bfbb887daccdd75c2259fe2e5df9450d5e00
 2023-09-16 01:23:20 +00:00
Pinyao Ting 88f4f2bf96 Disables local color extraction for widgets 
As discovered during investigation of system health issues, doing local
color extraction in widgets (for the purpose of making their color
matches the background during a drag) took many CPU cycle during layout
pass, which may have contributed to animation janks in various scenario.
This CL removes the feature in favors of better performance.

Bug: 266941872
Test: manually verified theme are still honored in widgets.
Change-Id: I63b13bc005907779af2322cd4bedbe141b0f3e27
 2023-09-16 00:13:20 +00:00
Vadim Tryshev ebba03501b Waiting for a TYPE_WINDOW_STATE_CHANGED event when starting Settings from task menu. 
We do this when starting apps from Launcher in other places.

Bug: 298114205
Test: presubmit
Flag: N/A
Change-Id: I1ff4466a2daa78b618cdc24910f90b8d4306d8b8
 2023-09-15 16:01:29 -07:00
Vadim Tryshev 58d24763a1 Merge "Re-promote testStressPressHome to presubmit" into main 2023-09-15 21:55:19 +00:00
Mady Mellor d23489af61 Only stash bubbles in overview when it's transient taskbar 
Bug: 284104811
Test: manual - enable 3 button nav
             - expand a bubble in overview
             => observe that scrim is shown on top of taskbar and it
                isn't stashed
             - repeat with transient taskbar but instead it stashes
               when bubbles are expanded in overview
Change-Id: I725513bb0015c85f26fb1eedbe22da5eb2612e55
 2023-09-15 12:48:02 -07:00
Tony Wickham 8179ac323e Remove unused variables in FullscreenDrawParams and PreviewPositionHelper 
Flag: none
Test: FullscreenDrawParamsTest
Bug: 293224095
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:d48be359b3773237ff659b660b0d7f80a3866fde)
Merged-In: Icbd71082b5278c0f9ce8a742eed25395b31d4284
Change-Id: Icbd71082b5278c0f9ce8a742eed25395b31d4284
 2023-09-15 19:46:36 +00:00
Uwais Ashraf f8da98a59b Set taskbar heights to 0 when taskbar is not present. 
Fix: 289769344
Test: DeviceProfileDumpTest
Change-Id: I53f8a629c8adc12feb1fdf9f5b40b4a680c97b78
Merged-In: I53f8a629c8adc12feb1fdf9f5b40b4a680c97b78
 2023-09-15 19:37:10 +00:00
Vinit Nayak af40345edc Merge "Add WorkProfileTest back into presubmit" into main 2023-09-15 19:13:10 +00:00
Schneider Victor-tulias 89d64bb346 Add overview button rate-limiter to fix recurring bug 
Processing the TYPE_TOGGLE command immediately makes it relatively easy to start overlapping animations that clobber each other and prevent clean up callbacks from running. This would cause a janky overview animation, a full command queue that can't be emptied and a recents tile than gets stuck on the screen. Added a rate limiter to (hopefully) prevent this type of bug from recurring.

Flag: not needed
Fixes: 298792963
Test: quickly and repeatedly pressed the overview button, checked logs to check that the error case never occurs anymore and rate-limiter procs instead.
Change-Id: I1575c932bb24d2405792539e8a14ed8d4171f5ae
 2023-09-15 18:51:46 +00:00
Liran Binyamin 070be25853 Merge "Adjust the hotseat when the bubble bar becomes visible" into main 2023-09-15 17:48:41 +00:00
Treehugger Robot b19c122046 Merge "Set taskbar heights to 0 when taskbar is not present." into main 2023-09-15 17:26:03 +00:00
Vinit Nayak a6f66eeba7 Merge "Provide bgExecutor for RotationButtonController" into udc-qpr-dev am: 8ad9393213 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24761312

Change-Id: Ib31bfdd11c5f1c62b1ffcfe24bcdd81fd4903633
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-15 17:24:13 +00:00
Vinit Nayak 8ad9393213 Merge "Provide bgExecutor for RotationButtonController" into udc-qpr-dev 2023-09-15 17:20:43 +00:00
Vinit Nayak d91f811ab6 Exit split selection state if launcher interrupted 
* Launcher gets paused as a natural part of
confirming a split, so only cancel when 1 app is
confirmed

Test: Start split from workspace, then go to
* double tap camera
* settings via notification drawer
* mic icon on QSB
Bug: 276361926

Change-Id: I048964403303defe35035ee24950cfbbfc201afd
 2023-09-15 17:19:13 +00:00
Vadim Tryshev a4853ab2b7 Merge "If running in presubmit, ignore @PortraitLandscape annotation. It's important to keep presubmits fast even if we will occasionally miss regressions in presubmit." into main 2023-09-15 16:53:14 +00:00
Uwais Ashraf 3602d1771f Set taskbar heights to 0 when taskbar is not present. 
Bug: 289769344
Fixes: 289769344
Test: DeviceProfileDumpTest
Change-Id: I53f8a629c8adc12feb1fdf9f5b40b4a680c97b78
 2023-09-15 15:17:07 +00:00
Vinit Nayak 9b3598f154 Provide bgExecutor for RotationButtonController 
Bug: 289341065
Test: Unfolded, checked perfetto trace, it
shows up not on UI thread

Change-Id: I9a080c9a5c3c57f38eb6719ed73952dde4f6bba1
 2023-09-15 10:46:00 -04:00