Commit Graph

78507 Commits

Author SHA1 Message Date
Jeremy Sim da230cf526 Request split launches using a new enum, snapPosition, rather than a float splitRatio
Split ratios are now stored as an int enum rather than float values. Previously, split ratios were stored as floats, which needed to be recalculated frequently and differed depending on device screen size. Now Shell to store and launch split screen setups using an enum rather than floats.

Bug: 274835596
Bug: 182839788
Test: Existing tests still pass
Change-Id: Iebb8d3c7e8f9d597a59b677e48072300ddea458f
2023-09-21 11:34:07 -07:00
Uwais Ashraf 02b3cc568c [automerger skipped] Merge "Set taskbar heights to 0 when taskbar is not present." into udc-qpr-dev am: d295e3510a am: 8dd54b27f1 -s ours
am skip reason: Merged-In I53f8a629c8adc12feb1fdf9f5b40b4a680c97b78 with SHA-1 3602d1771f is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24759056

Change-Id: If906a1827464abca8e7f35d6ac68ce81c3958e18
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-21 17:48:38 +00:00
randypfohl 2cf90775d7 Setting recentsView orientation to match recents activity orientation am: 03d29305ca am: 1c76ccfd6c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24804147

Change-Id: I408f74745a6f4e5714f6ef54857982c9cfc56066
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-21 17:47:45 +00:00
Brian Isganitis 40b6a19fd2 Merge "Make dismissByTappingOutsideForTablet an API of AllApps super class." into main 2023-09-21 17:21:57 +00:00
Uwais Ashraf 8dd54b27f1 Merge "Set taskbar heights to 0 when taskbar is not present." into udc-qpr-dev am: d295e3510a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24759056

Change-Id: I264b4f4cc0ce92f3140759fb6d3305f9018caa6b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-21 16:55:57 +00:00
Sunny Goyal 052c11d2fe Cleaning up screenrecord for fixed tests
Bug: 256898879
Test: Presubmit
Flag: N/A
Change-Id: Ib9d3b82219971c975e8a09968fcb9cc0c96637c3
2023-09-21 09:51:34 -07:00
randypfohl 1c76ccfd6c Setting recentsView orientation to match recents activity orientation am: 03d29305ca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24804147

Change-Id: I12f07376447009d58ee7519b9cd7433ac544191a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-21 16:51:04 +00:00
Uwais Ashraf d295e3510a Merge "Set taskbar heights to 0 when taskbar is not present." into udc-qpr-dev 2023-09-21 16:39:10 +00:00
Pablo Gamito e5ea6a2798 Add getter for ExpectedRotationCheckEnabled
Used by flicker to disable and then reset this value when performing certain actions that require ExpectedRotationCheckEnabled to be false but then we want to restore to the initial value.

Bug: 300065764

Test: n/a
Change-Id: I650e15b206984b5fd7a2313fb63308e4c551c30a
2023-09-21 16:34:03 +00:00
Schneider Victor-tulias 195fc85d73 Merge "Add error detection for missing recent tasks list in SystemUiProxy" into main 2023-09-21 14:48:34 +00:00
Jordan Silva e4d7aaa6fd Fix to prevent unsorted breakpoints returning wrong spec
It orders the breakpoint list to guarantee that the smallest breakpoint is always returned for a given availableWidth or availableHeight.

Fix: 301396419
Flag: ENABLE_RESPONSIVE_WORKSPACE
Test: CalculatedWorkspaceSpecTest
Change-Id: Ia545e84150027bd8daa8d0dde58ff6fc579c3b6a
2023-09-21 11:44:56 +01:00
fbaron 7f4bbfa599 Fix indexoutofbounds folder preview
The indexoutofbounds issue came from the fact that folder was being animated open when there are no items in preview. It might be a race condition where we try to open the folder at a time where it's actually being emptied. This check should prevent folders from running animateOpen() if there's <= 1 items, avoiding the outofbounds error

Fix: 298740874
Flag: no flag
Test: no test
Change-Id: I31ed53fbdf22a7f19bc9ec414242312afe7c6cd2
2023-09-20 23:57:00 -07:00
fbaron d87178460c Shortcut crash fix
Title was empty which caused launcher to crash. If title is empty the shortcut is invalid so we want to remove it.

Fix: 300213039
Flag: no flag
Test: no test
Change-Id: Ifa12877b9ac1d8bc266b74a95b6975b7f1bcf31e
2023-09-21 05:53:45 +00:00
fbaron ba0f7a0b17 Shortcut crash fix
Title was empty which caused launcher to crash. If title is empty the shortcut is invalid so we want to remove it.

Fix: 300213039
Flag: no flag
Test: no test
Change-Id: Ifa12877b9ac1d8bc266b74a95b6975b7f1bcf31e
2023-09-20 22:52:46 -07:00
Mady Mellor b604e71fe8 Merge "Fix bubbles taskbar scrim showing when notification panel is shown" into main 2023-09-21 01:25:07 +00:00
Garfield Tan d4018909e3 Show freeform button only when dev option is on
Now some Android tablets have desktop mode, which shouldn't be
entered by clicking the freeform button in Overview. Therefore still
keep it hidden when the device claims the support of freeform window
management, but the user didn't enable the freeform dev options
explicitly.

This button should also be hidden when desktop mode is enabled.

Bug: 299362754
Test: The button is hidden when the dev option is disabled.
Change-Id: Id919af4fd1a027da0bb335c4c4b7303d15d689f8
2023-09-20 18:05:20 -07:00
Android Build Coastguard Worker 6462d1e819 Snap for 10838116 from f17b59bb19 to udc-qpr1-release
Change-Id: Ie478c16128ed459dce8c66fb8872a4326a9fb425
2023-09-20 23:20:07 +00:00
Randy Pfohl bd585e4d42 Merge "Remove logs for bug investigation" into main 2023-09-20 23:14:33 +00:00
Treehugger Robot 34291f07fb Merge "Run leak detector in test isolation rule" into main 2023-09-20 23:04:01 +00:00
Sebastián Franco 8171e2fb84 Merge "Moving test related to Dragging to their own class from TaplTestsLauncher3" into main 2023-09-20 22:08:03 +00:00
randypfohl 03d29305ca Setting recentsView orientation to match recents activity orientation
Test: can no longer repro incorrect orientation when launching apps from all apps
      added logs to verify recents activity -> view were the same while rotating
      turned off auto rotate and verified state matched

Bug: 288984663
Bug: 301024104

Change-Id: I7fc3b47bff0a99756aaf877bf634e2d162838d6f
2023-09-20 15:04:55 -07:00
Pinyao Ting 602cb48c72 RESTRICT AUTOMERGE Fix permission bypass in legacy shortcut
Intent created for Chooser should not be allowed in legacy shortcuts
since it doesn't make sense for user to tap on a shortcut in homescreen
to share, the expected share flow started from ShareSheet.

Bug: 295334906, 295045199
Test: manual
Change-Id: I8d0cbccdc31bd4cb927830e5ecf841147400fdfa
2023-09-20 21:47:17 +00:00
Brian Isganitis 171b428984 Make dismissByTappingOutsideForTablet an API of AllApps super class.
Test: TAPL
Bug: 300147433
Flag: No
Change-Id: I66d602b5d26672e3e4338fb8c4ad631eb2ee4148
2023-09-20 17:28:13 -04:00
Brandon Dayauon 47000ae6e6 Fix big icon when dragging Toast by isolating the previous QL fix display to SEARCH_RESULT_APP_ROW
- Create another icon, "all_apps_predicted_row_icon" that will be the mDisplay for the predicted app row
in AllAppsList

Bug:299171695
Test: video
Before: https://drive.google.com/file/d/1HxNW0015nQHCc7eQiySf-gwsHrLs_JjR/view?usp=sharing
after: https://drive.google.com/file/d/1HyEwKI-yumILTCjglKcqovhTlRVjNGxg/view?usp=sharing - making sure that QL is fine and dragging regular Toast results are normal
Flag: N/a
Change-Id: Ie002cacb168396dbea39f79679bd6a04b80e374b
2023-09-20 14:21:10 -07:00
Sebastian Franco 6b059deea6 Moving test related to Dragging to their own class from TaplTestsLauncher3
Renaming the following test names:
 - testDragAppIconToWorkspaceCell to testDragAppIconToMultipleWorkspaceCells
 - testDragShortcutToMultipleWoCells to testDragShortcutToMultipleWorkspaceCells

Bug: 298234173
Test: atest OopTaplDragTest
Change-Id: I16707e0a882164c7a5acec6a4197bd0bea8514a7
2023-09-20 18:56:13 +00:00
Charlie Anderson 8c1cf2db26 Make sure to set Launcher restore pending as false after setting in RestoreDbTaskTest to not affect state of Launcher in tests.
See tearDown method in RestoreDbTaskTest for fix.

This reverts commit 2d86f3337a.

Reason for revert: fixing the issues for revert b/298077774
Test: running presubmit and affected test suite on CL

Change-Id: I94c643f38259c4e920869c231f706229390c7c2a
2023-09-20 18:43:35 +00:00
Treehugger Robot e745dda409 Merge "Use default taskbar stash duration when opening/closing all apps from taskbar." into main 2023-09-20 17:54:36 +00:00
Schneider Victor-tulias c6d3ea678f Add error detection for missing recent tasks list in SystemUiProxy
There are ways for launcher to lose the recent tasks reference, in which case SystemUiProxy will quietly fail to start the recents activity.

Flag: not needed
Fixes: 301257750
Test: programmatically forced the error condition and checked the logs
Change-Id: I1cad6a3dfd2605f275672d1dcd8c83bdb965d73f
2023-09-20 15:46:00 +00:00
helencheuk 2de7a979ff Add test to launch Lens from PSB
Fix: 292083393
Test: Qsb#launchLens
Change-Id: Ie01013ff31ee018d04740709ccc5d747a2443252
2023-09-20 16:14:27 +01:00
Sunny Goyal 48c7efb1f7 Fixing crash in SettingsCache am: f17b59bb19 am: 24d3af52e9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24804716

Change-Id: Iada63a729c600a6a498eba15fc011d42537a2ae2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-20 03:25:37 +00:00
Sunny Goyal 24d3af52e9 Fixing crash in SettingsCache am: f17b59bb19
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24804716

Change-Id: Ic0327d55354137aa19f21a74e0eae602419e9f44
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-20 02:29:53 +00:00
Vadim Tryshev 7772c32603 Run leak detector in test isolation rule
This will help to fail the test causing the leak, not the next one

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I07e2457a9c8b9794d9c3ecc4764500dcdd3bbb10
2023-09-19 18:25:58 -07:00
Pinyao Ting 9ce1a90b4a Merge "Disables local color extraction for widgets" into udc-qpr-dev am: ef9125e5cb am: 06dd1ab24d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24777924

Change-Id: I971778514082b4712ca5f4169760279121589b7d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-19 23:51:56 +00:00
Android Build Coastguard Worker cc2e383635 Snap for 10832001 from 5b86162853 to udc-qpr1-release
Change-Id: Ieacb30bb75b53e48c20b1b97d20bbc36b08a8d37
2023-09-19 23:19:51 +00:00
Pinyao Ting 06dd1ab24d Merge "Disables local color extraction for widgets" into udc-qpr-dev am: ef9125e5cb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24777924

Change-Id: If0f783a18c35265e98eb8402f0a3c07b1eb877b9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-19 22:56:52 +00:00
Sunny Goyal f17b59bb19 Fixing crash in SettingsCache
Bug: 301119252
Test: Presubmit
Flag: N/A
Change-Id: I1356e6c6ad693cc53716603a0a2ca5efd6af5ea9
2023-09-19 22:37:51 +00:00
Andy Wickham e257408101 Adds SystemActionConstants
This includes the previously added Taskbar System Action, as well
as a new one for Screen Search.

Bug: 299321919
Test: Manual
Change-Id: I4a8fa1dde402dc2de5f448cb2edbe712e128ff12
2023-09-19 22:12:40 +00:00
Pinyao Ting ef9125e5cb Merge "Disables local color extraction for widgets" into udc-qpr-dev 2023-09-19 21:48:27 +00:00
Brian Isganitis a4497e55b2 Merge "Remove onTaskCreated for hiding Taskbar overlay." into main 2023-09-19 21:20:38 +00:00
randypfohl dad61a0098 Remove logs for bug investigation
Test: built locally

Bug: 295069071

Change-Id: I88d41acb91ced876ab1f5a301e90ee5745119049
2023-09-19 14:13:58 -07:00
Jon Miranda 56ce010cd4 Use default taskbar stash duration when opening/closing all apps from taskbar.
Bug: 300156179
Test: from taskbar click on All Alls button
      exit All Apps
Change-Id: I54f19e6714c1da2f6caef31875769fdc312957d2
2023-09-19 19:55:20 +00:00
Sunny Goyal a1b7cbe00d Overriding the default TextClock and AnalogClock behavior to avoid RPCs on main thread am: 5b86162853 am: a6aa1c9466
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24795935

Change-Id: I0160e13995f8fc5191fc319498f730b67ce3e627
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-19 18:43:51 +00:00
Sunny Goyal a6aa1c9466 Overriding the default TextClock and AnalogClock behavior to avoid RPCs on main thread am: 5b86162853
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24795935

Change-Id: I9f4d5a9eb2590951fbe4091ff8050ad72f37bbd4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-19 18:36:04 +00:00
Brian Isganitis 8f45ef6bdf Merge "Reapply "Have backup TouchController of Taskbar All Apps AFV."" into main 2023-09-19 18:02:42 +00:00
Pat Manning 349f101411 Merge "Migrate ENABLE_CURSOR_HOVER_STATES to aconfig" into main 2023-09-19 16:56:45 +00:00
Stefan Andonian 4fc16ab256 Merge "Add unit tests for LoaderTask" into main 2023-09-19 16:02:50 +00:00
Sebastian Franco 8a3de21fcd Moving getters and setters to the end of the file
Parto of go/launcher_SoR

Test: compiles, this doesn't move logic and if it compiles everything is still there
Fix: 301003366
Change-Id: I07b73a60e162001c3cecb7beb51efb5474b562df
2023-09-19 15:31:50 +00:00
Schneider Victor-tulias f5099749be Merge changes I26080534,Iede0881b into main
* changes:
  Send ACTION_CANCEL motion event to TIS instead of finishing the recents animation on screen off
  Replace all uses of string concatenation with CompoundString in ActiveGestureLog
2023-09-19 12:59:35 +00:00
Android Build Coastguard Worker d0be946ba3 Snap for 10825434 from 2316dc4750 to udc-qpr1-release
Change-Id: I0ad3f58d6dd904a93e1917323dec809c3a1ea4b4
2023-09-18 23:19:23 +00:00
Sunny Goyal 5b86162853 Overriding the default TextClock and AnalogClock behavior to avoid RPCs on main thread
during onAttachToWindow

Bug: 294352799
Test: Verified on device
Flag: N/A
Change-Id: I3cce6900cd62a6e9a57c155b74c15c2340c6011b
2023-09-18 23:04:33 +00:00