Commit Graph

4240 Commits

Author SHA1 Message Date
Jihoon Kang 9f8e4b6b62 Make java_sdk_library dependencies explicit
modules should specify the submodule of java_sdk_library that the module
actually depends on

Test: CI
Bug: 358613520
Change-Id: If1b96a7ffa7ddde50c44817e0d96257ae2967a0e
2024-08-30 00:29:41 +00:00
Jagrut Desai a68e4fe0de Merge "Promote TaplAddWidgetTest#testResizeWidget" into main 2024-08-29 22:43:30 +00:00
Jagrut Desai 728096835a Promote TaplAddWidgetTest#testResizeWidget
Test: Presubmit
Bug: 316910614
Flag: TEST_ONLY
Change-Id: Ic4b927f523df7ac531fdbd88670adb12fc43df13
2024-08-29 09:27:57 -07:00
Treehugger Robot a587ea691e Merge "Promote testUninstallFromWorkspace to presubmit" into main 2024-08-29 00:27:34 +00:00
Vinit Nayak d42af4b55e Promote testUninstallFromWorkspace to presubmit
Bug: 311099513
Test: None
Flag: EXEMPT bugfix
Change-Id: I28731c173e4cdb473e4fc9fb954a82a5f57c02f5
2024-08-28 15:15:15 -07:00
Sebastián Franco b9ce69db9e Merge "Correctly map the drag view position to the Workspace" into main 2024-08-26 21:13:06 +00:00
Sebastian Franco 4bedb18466 Correctly map the drag view position to the Workspace
The drag view needs to be mapped to the drop target which in this
case is the Workspace instead of the CellLayout

Fix: 352569050
Test: IntegrationReorderWidgetsTest
Flag: TEST_ONLY
Change-Id: I233c2b3bf0b8637f80d74d201189b2290ef59c94
2024-08-25 20:41:00 -07:00
Sihua Ma a9e4324bd5 Rename test helper filegroup to robo
Test: N/A
Flag: EXEMPT filegroup rename
Change-Id: I8afeccc69fbca8e317c6b74a051d6b94239b8c52
2024-08-23 22:13:33 +00:00
Tony Wickham 3a47759619 Merge "Fix Taskbar being visible over Hotseat when recreated in Overview" into main 2024-08-22 18:51:55 +00:00
Sebastián Franco 6edce2ad75 Merge "Remove test to postsubmit while they are flaky" into main 2024-08-22 17:08:45 +00:00
Treehugger Robot 7369348ba8 Merge "Delete dead test SettingsActivityTest" into main 2024-08-22 10:01:55 +00:00
Alex Chau eececf272e Merge "Reset mTopRowIdSet in applyLoadPlan" into main 2024-08-22 09:49:27 +00:00
Sebastian Franco f989210f5b Remove test to postsubmit while they are flaky
Bug: 332527963
Test: ReorderAlgorithmUnitTest
Flag: TEST_ONLY
Change-Id: I29d631ba7dfe7f2c3a5323bfb414cb4da5b3321b
2024-08-21 15:20:18 -07:00
Tony Wickham 5c32af7e5b Fix Taskbar being visible over Hotseat when recreated in Overview
Debugging locally, it seems there were a couple of state changes
and the last one (which is correct) was getting clobbered by a
previously destroyed instance of TaskbarLauncherStateController.
Fixed this by updating the isDestroyed() call which previously
only checked TaskbarActivityContext to now check
TaskbarLauncherStateController's destroyed state directly. This
is needed because TaskbarLauncherStateController is part of
LauncherTaskbarUIController which can be destroyed independently
of the other Taskbar controllers when Launcher is destroyed.

Also fix a debug log that was not updated long ago in ag/21122190

Flag: EXEMPT bugfix
Test: Go to overview, change Font Scale or Dark Theme from Quick
settings, ensure Taskbar is not visible over Hotseat
Fixes: 302923055

Change-Id: I1299462955b51a2bf931f022177045b1cec039c5
2024-08-21 21:43:54 +00:00
Alex Chau 9109b81a95 Reset mTopRowIdSet in applyLoadPlan
- All taskViewIds become obsolete after removing and re-adding, so we'll need to reset mTopRowIdSet when removing all taskViews
- OverviewActionsView.updateActionButtonsVisibility can be called before updateDimension (where mDp is set), so a null check is necessary
- Fixed TestStaibilityRule failing when running FallbackRecentsTest alone. FallbackRecentsTest runs with 3P Launcher, in that case launcherPackageName is our test activity, and launcherVersion can be null. This can only occur in a local run, thus return LOCAL in this case.

Fix: 355042336
Test: FallbackRecentsTest and manually testing dismiss
Flag: EXEMPT BUG_FIX
Change-Id: I9125ea38a567deb0d3028e7d7407397d1dc06ade
2024-08-21 12:37:14 +01:00
Alex Chau 1eebacf636 Merge "Clean-up debug logs" into main 2024-08-21 10:53:21 +00:00
Uwais Ashraf 06ffcf8c61 Merge "Migrate model tests to multivalent" into main 2024-08-21 10:05:40 +00:00
Anushree Ganjam 77aed7422a Dismiss the setup wizard for both presubmit and post submit tests.
In the past we have faced setup wizard not dismissed issue but eng prod
team has not fixed this issue. See b/309008042 for more details.

Bug: 359658695
Bug: 359658158
Bug: 356695093
Bug: 355718051
Flag: TEST_ONLY
Test: Manual
Change-Id: Ief020483fa167946193875f9d6c089d1cfd55124
2024-08-20 17:07:30 -07:00
Alex Chau fdbfd3410b Clean-up debug logs
Fix: 336660988
Test: presubmit
Flag: TEST_ONLY
Change-Id: Ie66a34134881e4333f610d8979b2ac443d54a1cb
2024-08-20 19:01:19 +01:00
Alex Chau 6d00b4b014 Read task size info from RecentsView directly
- Automatically determine the Overivew component to use the correct RecentsViewContainer
- Also added log on both pre-computed taskSize and newly calculated task size

Bug: 336660988
Test: presubmit
Flag: TEST_ONLY
Change-Id: Ic0adfba35af513e731007241416fc85760135f07
2024-08-20 10:56:52 +01:00
Sihua Ma 58e8573085 Migrate model tests to multivalent
Also migrating some other tests that have been verified

Test: SysUI studio
Test: atest NexusLauncherRoboTests
Flag: TEST_ONLY
Change-Id: I072201b8e7b98945ca88657fe813fef4727f16e4
2024-08-20 07:28:35 +00:00
Alex Chau d326e17fe2 Add logs for getFocusedTaskHeightForTablet
Bug: 336660988
Bug: 360724626
Test: presubmit
Flag: TEST_ONLY
Change-Id: I67d4fc8211f24b77566bd24525d23054dfdded6e
2024-08-19 20:39:41 +01:00
Shamali Patwa accd0f68c8 Merge "Update the scale on corner radii on scaled image drawable." into main 2024-08-16 20:37:57 +00:00
Treehugger Robot a21058eb88 Merge "Move TouchEventGenerator to multivalent" into main 2024-08-16 06:04:22 +00:00
Shamali P c7e1b5c975 Update the scale on corner radii on scaled image drawable.
The RoundedDrawableWrapper applies rounded corners on each draw, so,
on scaling, the corners look odd for small widgets.

This change, applies the same scale to corner radius as well.
There are some widgets whose preview images have embedded transparency,
but we don't do much for such previews.

Bug: 359860747
Test: Manual
Flag: EXEMPT bugfix
Change-Id: I5e58e29765503454f286d99050b13b497531d306
2024-08-15 02:54:17 +00:00
Andrew Cole d61fbd4140 IconCacheUpdateHandlerTest
This is the unit testing for the updates to IconCacheUpdateHandler

Bug: 357725795
Test: SELF
Flag: TEST_ONLY
Change-Id: I159f5ef70fcc9a5aae7bb319f06a3ff935f28246
2024-08-14 15:57:42 -07:00
Sihua Ma 97ed80634d Move TouchEventGenerator to multivalent
Test: atest NexusLauncherRoboTests
Flag: TEST_ONLY
Change-Id: I6603b4764de6708cb0c3d7c2a52c0ffb81607771
2024-08-14 21:17:44 +00:00
Treehugger Robot 28cbc13413 Merge "Ensure that inactive archived icons in the folder preview are not shown as grey pending icons" into main 2024-08-13 22:19:44 +00:00
Charlie Anderson 08a0a65fca Ensure that inactive archived icons in the folder preview are not shown as grey pending icons
Bug: 350758155
Test: manually verified + PreviewItemManagerTest
Flag: com.android.launcher3.use_new_icon_for_archived_apps
Change-Id: Ic378c4f840ce05ecbcbbc3f4f57087c9acd7c1f5
2024-08-13 13:01:18 -04:00
Uwais Ashraf d39bc803c7 Merge "Improve performance of thumbnail retrieval - hot taskData flow" into main 2024-08-13 10:59:32 +00:00
Uwais Ashraf 60b62d734d Improve performance of thumbnail retrieval - hot taskData flow
Bug: 357542209
Test: TasksRepositoryTest, manual with reduced speed video
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: Ie94daf61d8e41c4b9c12d67f5f45166104879325
2024-08-12 16:49:24 +00:00
Treehugger Robot 50051adcc1 Merge "Revert AllAppsRecyclerViewPoolTest.kt" into main 2024-08-09 23:01:49 +00:00
Fengjiang Li 6554ab99e3 Revert AllAppsRecyclerViewPoolTest.kt
Manual revert of ag/28323761, will add it back after confirming preformance test regression has been resolved.

Fix: 354560500
Test: Revert of test
Flag: NONE
Change-Id: Ibc9ec7a641c7df80ac5a7f08933dadfdf0b8d1e6
2024-08-09 13:06:52 -07:00
My Name b7b872e7a7 Delete dead test SettingsActivityTest
Settings activity tests are UI heavy, so unlikely anyone would fix this
such that they are not flaky.

These tests are @Ignored for long time (> 1 year).

Bug: 199309785
Test: presubmit
Flag: NONE not a change in production code
Change-Id: I8c9e167469266af624ae345e8eaac8bb92e8cd69
2024-08-08 23:47:05 +00:00
Anushree Ganjam 3f6412e50d Merge "Remove debug logs" into main 2024-08-08 23:19:39 +00:00
Charlie Anderson 72c5d8ffde Merge "Use DoubleShadowIconDrawable to draw shadow behind archived cloud icon" into main 2024-08-08 17:38:51 +00:00
Treehugger Robot 3307f87b82 Merge "Implement e2e test for desktop windowing" into main 2024-08-08 11:32:10 +00:00
Alex Chau 1ceac5ddfe Implement e2e test for desktop windowing
Code changes:
- TaskView, GroupedTaskView and DesktopTaskView now uses different resId, so it can be differentiated by TAPL
- Extracted result handling of icon loading, so we can override in DesktopTaskView
- DesktopTaskView now load icons, so titleDescription can be loaded. When icons are loaded, contentDescription are applied to respective snapshotViews; icon unloading is ignored
- Track launchDesktopFromRecents and composeRecentsLaunchAnimator in TAPL events so we can test if the TaskView launch path is correct

Test changes:
- Added TaplTestsOverviewDesktop that move 2 TestActivities into Desktop, and launch the DesktopTaskView as static and live tile
- TaplTestsOverviewDesktop is limited to Tangor/cf_tablet only, and added LimitDeviceRule to AbstractLauncherUiTest to enable @AllowedDevices and @IgnoreLimit

TAPL changes (2 APIs added/modified):
- Changed TaskView matcher to use id/task_view_* to match all TaskView types
- When Overview is launcehd from Background, mark the currentTask after the launch as liveTile. When an OverviewTask has the same accessibility node as the liveTile, it'll expect different event when launching.
- [API change] BaseOverview.getTestActivityTask can now matches mutiple test activiites, useful for matching GroupedTaskView and DesktopTaskView; Fix a bug that getTestActivityTask wrongly use `getParent()` which is RecentsView to match activityName.
- In OverviewTask.open, we'll expect different events based on TaskView types and whether it's a live tile. Launching DesktopTaskView will in additional verify Desktop header is present on screen.
- [API change] In OverviewTaskMenu, support tapping Desktop menu and verify Desktop header is present on screen.
- Removed unused OverviewTaskMenuItem

Fix: 320313527
Test: TaplTestsOverviewDesktop
Flag: com.android.window.flags.enable_desktop_windowing_mode
Change-Id: I89261c787364901320f3acb18f01ddad5f62d17c
2024-08-08 10:37:40 +01:00
Anushree Ganjam 5c4ea5b0ca Remove debug logs
Bug: 339737008
Test: Manual
Flag: TEST_ONLY
Change-Id: I8177fc721f330267bc20abf6e7d587289e45477b
2024-08-07 14:08:10 -07:00
Jordan Silva 3645e88ae5 Merge "Add Jetpack Compose for Launcher3 and Quickstep behind a build flag (2/3)" into main 2024-08-07 17:08:39 +00:00
Charlie Anderson 99147f53e0 Use DoubleShadowIconDrawable to draw shadow behind archived cloud icon
- Refactor Launcher3 ShadowInfo out of DoubleShadowBubbleTextView

Bug: 350758155
Test: locally verified + screenshot test
Flag: com.android.launcher3.use_new_icon_for_archived_apps
Change-Id: I8e5e5936296fafbfbf3caf80a936ca1038c125e3
2024-08-07 11:56:33 -04:00
Jordan Silva 4afa195b5b Add Jetpack Compose for Launcher3 and Quickstep behind a build flag (2/3)
This CL adds a Soong build flag in Android.bp files to enable Compose code when building Launcher.
The flag is disabled by default, and it will be enabled once agreed with the System Health team. More details in go/launcher-enabling-compose-next-steps.

To turn this flag on, one simply has to `build-flag set RELEASE_ENABLE_COMPOSE_IN_LAUNCHER true` before compiling.

- When the flag is enabled, Launcher3 will use a ComposeFacade object that provides features implemented using Compose. This Facade also provides a function to check whether Compose is enabled or not.
- When the flag is disabled, Launcher3 will implement a ComposeFacade object that throws an exception if a feature using Compose is requested. Thus, it is important to always check isComposableAvailable function before requesting a Compose feature.

Bug: 346288480
Test: Builds
Flag: EXEMPT Build flag: RELEASE_ENABLE_COMPOSE_IN_LAUNCHER
Change-Id: I5f2703f74960aeb104d0386ed3ef49784ed85234
2024-08-06 18:47:22 +01:00
Sebastián Franco 99a76f1f64 Merge "Convert testing classest to Kotlin" into main 2024-08-06 00:21:18 +00:00
Fengjiang Li 77be7410c3 Merge "Fix jank regression from AllAppsRecyclerViewPoolTest" into main 2024-08-05 23:17:22 +00:00
Fengjiang Li ce638d69b7 Fix jank regression from AllAppsRecyclerViewPoolTest
Unit test ag/28323761 delays the preInflationCount check after creating ActivityContext on main thread, thus causing jank regression. This CL is a forward fix.

Fix: 354560500
Flag: NONE - jank fix
Test: Presubmit
Change-Id: I0e91dd765f1805b98895ce90804ec187e50285b4
2024-08-05 09:39:05 -07:00
Charlie Anderson 6b8e362247 Adds new bugfix flag for using new app archiving icon
Flag: com.android.launcher3.use_new_icon_for_archived_apps
Bug: 350758155
Test: locally
Change-Id: I7bacbacd85a8216e7975665e6d3c1ab98ed23235
2024-08-05 00:37:28 -04:00
Charlie Anderson e5ace06d81 Merge "Reapply "Handles Bold Text setting for inline icon by providing bolded cloud icon"" into main 2024-08-05 04:24:32 +00:00
Sebastian Franco ce4446c469 Convert testing classest to Kotlin
Bug: 324261526
Test: ImageTest
Test: FolderTest
Test: IntegrationReorderWidgets
Flag: TEST_ONLY
Change-Id: Ieb4e451cc44656fc98d87163203eaae379ec0512
2024-08-02 12:53:14 -07:00
Charlie Anderson fe23e711fd Reapply "Handles Bold Text setting for inline icon by providing bolded cloud icon"
This reverts commit 00fb1adab4.
Also fixes test applyIconAndLabel_setsImageSpan_whenInactiveArchivedApp.

Bug: 350758155
Fixes: 356166053
Test: unit test
Flag: com.android.launcher3.enable_new_archiving_icon

Change-Id: I93f2ac47dc3a8fa81d59e0f089385d2b3fe93306
2024-08-02 17:26:02 +00:00
Shamali Patwa b74b05336c Merge "Fix the getWidgetsByPackageItem method to return a copy" into main 2024-08-01 21:59:28 +00:00