Commit Graph

4240 Commits

Author SHA1 Message Date
Charlie Anderson 65c1010029 Update test activities with a non-default icon.
Check against default app icon in FolderIconLoadTest

Bug: 357441807
Bug: 369222239
Bug: 369240511
Flag: EXEMPT bc-triaged bugfix
Test: FolderIconLoadTest
Change-Id: I0e224f5b8bf8c0a8c51d88abd7c562d8e1ff7a55
2024-09-26 03:59:10 +00:00
Sunny Goyal 37182de670 Fixing flakiness in robo tests
Bug: 352288591
Flag: EXEMPT test fix
Test: Presubmit
Change-Id: I15dd91815f7ae4d3cf3c9e1fd4c2b5e07052ab3f
2024-09-25 10:52:14 -07:00
Treehugger Robot 9a77922424 Merge "Fix for bug where we don't use default grid on comet, and migrate normally if not in a B&R case" into main 2024-09-25 17:01:54 +00:00
fbaron b633b9aa2b Fix for bug where we don't use default grid on comet, and migrate normally if not in a B&R case
-The grid migration where we just copy the grid and move everything one row up should only occur in a B&R scenario, so now we add that restriction
-We should default to 4x5 in comet if migrating from a 4x4 grid if the device we're migrating from does not have any other grids saved
-if we have other grids saved, then we'll try using the saved grid if possible. If not possible, we use the default grid for the new device

Bug: 360462379
Test: GridSizeMigrationUtilTest
Flag: EXEMPT bugfix
Change-Id: Ia905081046431c08dc058bd61b2b4ab42dee0506
2024-09-24 16:52:05 -07:00
Sunny Goyal e1b7ca566e Merge "Moving various application into related methods to a separate class" into main 2024-09-24 22:05:52 +00:00
Schneider Victor-tulias b3983db5e4 Merge "Update goToOverviewUnchecked to account for desktop task visiblity" into main 2024-09-24 19:31:43 +00:00
Randy Pfohl 31aefc3290 Merge changes from topic "windowRecents" into main
* changes:
  Cleaning up unusued handlers
  Moving RecentsWindowManager away from the singleton pattern
  Limited recents in window introductory cl
  abstracting fallback views to support container instead of activity
2024-09-24 16:13:30 +00:00
Schneider Victor-Tulias 38deee2508 Update goToOverviewUnchecked to account for desktop task visiblity
Flag: com.android.launcher3.enable_desktop_task_alpha_animation
Fixes: 367646122
Test: SwitchToOverviewFromDesktopTest#switchToOverview
Change-Id: I600dfcd8507d2e24f5bfccf78164b6eec3ec80b1
2024-09-24 10:47:38 -04:00
Sunny Goyal 28d6bbd6b4 Moving various application into related methods to a separate class
> This avoids duplicate RPCs when trying to get multiple properties
  from AppInfo
> This would be used in a followup cl when AppInfo is added to caching
  logic in IconCache

Bug: 366237794
Test: atest ApplicationInfoWrapperTest
Flag: EXEMPT refactor
Change-Id: I55b964d4f8cfa1ff1770e310ac278719495e285d
2024-09-23 22:09:24 -07:00
Sunny Goyal f84b6edee7 Merge "Removing unnecessary package validation during grid migration" into main 2024-09-24 00:31:54 +00:00
Sunny Goyal c3dd1c380f Removing unnecessary package validation during grid migration
package validation happens during loader anyway. And using MATCH_INSTALLED
for checking cross user apps may not work all the time

Bug: 363324203
Test: atest GridSizeMigrationUtilTest
Flag: EXEMPT bug fix
Change-Id: Id36e8fdff132242705ef53c85dc6567fbde5d952
2024-09-23 15:16:37 -07:00
Jagrut Desai d3460af469 Merge "Refctor DisplayController#handleInfoChange" into main 2024-09-23 19:43:02 +00:00
Jagrut Desai 94c9fb7cf5 Refctor DisplayController#handleInfoChange
Test: Presubmit
Bug: 369140181
Flag: EXEMPT refactor DisplayController#handleInfoChange
Change-Id: I196fe0e843a60c518d882c25f9fbdcd3cb775ba6
2024-09-23 09:58:30 -07:00
Vaibhav Devmurari 22754e8622 Merge "Fix NumberFormatException in LauncherTests" into main 2024-09-23 11:00:00 +00:00
randypfohl c50aa8bf31 Limited recents in window introductory cl
Test: Built and tested locally

Flag: com.android.launcher3.enable_fallback_overview_in_window

Bug:292269949

Change-Id: I5352ba0b6c5bc196fbd1322d435a7e27e884f7b5
2024-09-20 16:09:50 -07:00
Treehugger Robot f0123c9129 Merge "Reset taskbarModePreference on tearDown()" into main 2024-09-20 16:10:26 +00:00
Sunny Goyal 621918feda Changing min-sdk version of Launcher to 31
Bug: 368071216
Flag: EXEMPT refactor -> dead code removal
Test: Presubmit
Change-Id: I1f0113c56de56f12f3a174eb31c3f8e8a09407e6
2024-09-20 06:00:10 +00:00
Toshiki Kikuchi 5cec59a41d Reset taskbarModePreference on tearDown()
This CL forcefully resets taskbarModePreference on tearDown() to ensure
the following tests are not affected by the changes made by
`testTaskbarPinningChangeInLockedTaskbarChange`.

Bug: 368322666
Flag: EXEMPT bug fix
Test: nexus_unit_test_multi_device_platform
Change-Id: I8bd8e8ca8b4b832ed17e86fbdfc9bda7bf9ab16e
2024-09-20 00:47:18 +00:00
Vaibhav Devmurari 21f06911aa Fix NumberFormatException in LauncherTests
If the key event flags contain 0x80000000 then it causes number
format exception during parsing to Integer

Bug: 358569822
Test: atest NexusLauncherTests
Flag: EXEMPT TEST_ONLY
Change-Id: I6371ab7b9d5d5e356d7199830543177daeda3eea
2024-09-19 13:17:50 +00:00
Sebastián Franco dee300f77d Merge "Removing screen record from TaplWorkProfileTest" into main 2024-09-19 01:44:36 +00:00
Toshiki Kikuchi 6ddfe9b179 Allow to show pinned taskbar when Launcher is visible
This CL allows freeform-first devices to lock the taskbar in a pinned
state when Launcher is visible.

Bug: 361419732
Flag: com.android.window.flags.enter_desktop_by_default_on_freeform_displays
Test: DisplayControllerTest
Test: manual

Change-Id: Ic0d2740e33fee19c676d88aa2bcf370eb64366e8
2024-09-18 10:49:52 +00:00
Treehugger Robot d60904d573 Merge "Add perfetto traces to LauncherInstrumentation" into main 2024-09-17 17:12:21 +00:00
Treehugger Robot 545440327d Merge "Update out-of-date TODO comment" into main 2024-09-17 16:25:49 +00:00
Schneider Victor-Tulias 0a815eae39 Update out-of-date TODO comment
These TODO comments will be adressed by b/342627272, so b/326565120 should be closed.

Flag: EXEMPT comment update
Bug: 326565120
Bug: 342627272
Test: none needed, comment update
Change-Id: I75637e1494a1abba5c542a292a8a1e8881cbedfc
2024-09-17 10:13:16 -04:00
Nicolo' Mazzucato 2e3d304273 Add perfetto traces to LauncherInstrumentation
This will help understanding what's taking time in those tests, and optimize the runtime to add more perfromance tests to presubmits.

Bug: 332823157
Test: perfetto trace
Flag: NONE adding traces
Change-Id: I806c2cd103ff58a4467e48b3da5e95f7f51743f3
2024-09-17 08:06:38 +00:00
Treehugger Robot 98d85d6dc0 Merge "Revert "Add screenrecord to testDragIconToPage2"" into main 2024-09-16 21:50:40 +00:00
Federico Baron 9045632654 Revert "Add screenrecord to testDragIconToPage2"
This reverts commit cf55a30dcf.

Reason for revert: no longer needed

Change-Id: I08a9a0c90e1298d7206c7544de08b557fd89b58e
2024-09-16 20:03:10 +00:00
Sunny Goyal 98001dd1dc Merge "Migrating prediction_undo to aconfig" into main 2024-09-16 17:26:58 +00:00
Alex Chau 03aa04d45b Revert "Adds new log constant to track overview select tooltip misalignment"
This reverts commit cbc8bf0443.

Reason for revert: b/332485341 is fixed, revert logging constant previous added

Change-Id: I970a3af9905037a51bd9748324f35ac80de9b06b
2024-09-16 10:37:50 +00:00
Sunny Goyal d94100a223 Migrating prediction_undo to aconfig
Flag: com.android.launcher3.enable_dismiss_prediction_undo
Test: atest SystemShortcutTest
Bug: 270394476
Change-Id: I5daef5d168c301115d860a1ae1d3c96f70a0f18f
2024-09-13 20:21:32 -07:00
Treehugger Robot e738e4bf07 Merge "Revert "Add screenrecord for testDragAppIcon"" into main 2024-09-14 02:21:30 +00:00
Treehugger Robot 2ff010dfbe Merge "Revert "Adding screen record to testEmptyPageDoesNotGetRemovedIfPagePairIsNotEmpty"" into main 2024-09-14 02:18:53 +00:00
Federico Baron c4bb97b64e Revert "Adding screen record to testEmptyPageDoesNotGetRemovedIfPagePairIsNotEmpty"
This reverts commit 2b724ec00d.

Reason for revert: cleanup

Change-Id: I59140f34ac86ef1d25e707509bd52ddeb3ddf061
2024-09-14 00:13:59 +00:00
Federico Baron 375c88b05e Revert "Add screenrecord for testDragAppIcon"
This reverts commit 701eef07ab.

Reason for revert: cleanup

Change-Id: I489e8e79924c402ed5228781af4bd4065daca42e
2024-09-14 00:13:22 +00:00
Treehugger Robot 925edf7906 Merge "Add tapl test for isTablet" into main 2024-09-14 00:12:27 +00:00
fbaron 6a65aebcc6 Add tapl test for isTablet
Bug: 366237798
Test: TaplIsTabletTest
Flag: EXEMPT TEST_ONLY
Change-Id: I806caa5e98b39fc6475c8807003646540f32b509
2024-09-13 11:11:06 -07:00
Kevin Lim f1b5855af7 [Testing] Renamed incorrectly named FloatingHeaderViewTest
FloatingHeaderviewTest was named with ...Tests (plural), preventing it from
being excluded from launcher-testing-helpers-robo and getting included
in some unintended tests.

Bug: b/341795751
Flag: EXEMPT test renaming.
Test: Running FloatingHeaderViewTest
Change-Id: I8149f0a5548e77674bb2a23a34bd7671e0a3b371
2024-09-12 20:57:14 +00:00
Treehugger Robot c912c8fb8b Merge "Improving regex for detecting a local platform build" into main 2024-09-11 19:48:47 +00:00
Vadim Tryshev 460192588f Improving regex for detecting a local platform build
Platform build can now have versions line "eng.himans"

Bug: 187761685
Test: online regex verifier
Flag: NONE test change
Change-Id: I86b9324dfbbc36272215eae58af836e9a3741d70
2024-09-11 10:39:31 -07:00
Sunny Goyal f2e2532e62 Merge "Remove obsolete features" into main 2024-09-09 22:43:14 +00:00
Mykola Podolian 5feb4a969a Merge "Fix falling tapl tests" into main 2024-09-09 17:19:12 +00:00
Nick Chameyev 02cc26f055 Merge "Capture Launcher icon positions by reusing UiObject2" into main 2024-09-09 10:43:10 +00:00
mpodolian 39383dd5b3 Fix falling tapl tests
Fix the root cause of falling tests.

Bug: 359277238
Flag: TEST_ONLY
Test: TaplTestsQuickstep,TaplTestPersistentTaskbar
Change-Id: I1e3138e26d0ab253dff7a64cbb3253c220a7db1a
2024-09-07 09:13:53 -07:00
Nick Chameyev 11c0ebcd57 Capture Launcher icon positions by reusing UiObject2
Reuse the same UiObject2/HomeAppIcon objects
when capturing Launcher icon positions.

When invoking 'launcher.workspace.allWorkspaceIcons'
we wait for the animation to finish which makes
the test fail as we expect to capture icon positions
midway through the animation.

Test: atest LauncherFoldAnimationTest
Bug: 315163608
Bug: 296991492
Flag: EXEMPT bugfix
Change-Id: I668d15165e4c777b3be24d66ad3f7888eaca2fea
2024-09-06 14:13:36 +00:00
Sebastian Franco 4e65f94200 Removing screen record from TaplWorkProfileTest
Fix: 322823478
Test: TaplWorkProfileTest
Flag: TEST_ONLY
Change-Id: I4f5b2da8e1909b90146025654d100b9eadd0e577
2024-09-05 11:00:10 -07:00
Sebastian Franco 750e8496ef Reducing the wait time for events for less than the Test timeout
The test timeout is the time the test infraestructure allows a test
to be idle for. Because of it, we don't get the event tiemout error
so reducing the timeout wait will allow us to get the event error.

Bug: 352569050
Test: IntegrationReorderWidgetsTest
Flag: TEST_ONLY
Change-Id: Ic43210a3ca5b5239b1156753bdf8253cd738bdec
2024-09-03 12:55:38 -07:00
vinayjoglekar 3359fa7f32 Fix talkback in split mode
1. Announce description of both snapshot in GroupedTaskView.
2. Announce them in correct order.

After setting right content description for both the apps in split mode, announcement order was reverse. Seems that order of the node tree which android sees was wrong. Also order did not change even in RTL mode.

see here https://paste.googleplex.com/6492038621298688.

The correct order is manually set using addChildrenForAccessibility in GroupedTaskView. (similarly being used in RecentsView since we use reverse order for overview). Also considered RTL.
See order after fix here
https://paste.googleplex.com/6492038621298688

https://drive.google.com/file/d/1BA1YKkcNsovEu4us9cvq5xOdXviTR1OV/view?usp=drive_link

Other alternatives tried were fixing order using android:accessibilityTraversalAfter and android:accessibilityTraversalBefore, both in layout and programatically which doesn't seem to work.

Test: Manual - Using Node tree debugging of talkback developer options.(Print and filter by tag TreeDebug)
BUG: 330424779
Flag: EXEMPT bugfix
Change-Id: If3c360277bd951d2d2b223bab7844e078e9c7d27
2024-09-03 15:22:30 +01:00
Jihoon Kang a2dc65a2a1 Merge "Make java_sdk_library dependencies explicit" into main am: 10f0f9a93b am: 612b153591
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/3250185

Change-Id: I37d8a779985f820befa52be51df8101f53ed12bd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-30 20:41:29 +00:00
Jihoon Kang 612b153591 Merge "Make java_sdk_library dependencies explicit" into main am: 10f0f9a93b
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/3250185

Change-Id: Ic156ed0a774b6d6a40af20a1852846503e229b77
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-30 20:11:39 +00:00
Sunny Goyal 7a548377eb Remove obsolete features
Flag: EXEMPT legacy ENABLE_TWOLINE_DEVICESEARCH, ENABLE_ICON_IN_TEXT_HEADER, ENABLE_PREMIUM_HAPTICS_ALL_APPS
Bug: 270396358
Bug: 201388851
Bug: 270395143
Test: Verified manually
Change-Id: I88ca7b255d2ae4eba393c1aee52153ef0a459140
2024-08-30 13:04:08 -07:00