Commit Graph

4240 Commits

Author SHA1 Message Date
Himanshu Gupta 739b3c9f22 Enabling Private Space Container in Launcher.
This CL adds the following:
1. Adds filtering and addition of Private Profile apps in main user
all apps recycler view
2. Enables decoration of Private Profile apps
3. Enables hiding Private Space container based upon a settings entry.

Flag: ACONFIG com.android.launcher3.Flags.enable_private_space DEVELOPMENT
Bug: 289223923
Test: Ran Launcher3 tests
Change-Id: I33dc55a3a39e75d3fc336ca6a488b282e2dd322c
2023-11-15 15:08:59 +00:00
Alex Chau 013af87a10 Merge "Use WindowConfiguration to match DeviceProfile in IDP.getDeviceProfile" into main 2023-11-15 10:06:53 +00:00
Vadim Tryshev 98a0efd2dc Revert "Increasing wait time for Launcher restart after enabling test provider"
This reverts commit 47bcb2b6c5.

Reason for revert: b/311023703

Change-Id: Ib0fea7682c8499c1e900c04e818db67363af311b
2023-11-14 22:16:00 +00:00
Vadim Tryshev 8ed8d67d63 Merge "Increasing wait time for Launcher restart after enabling test provider" into main 2023-11-14 19:48:39 +00:00
Alex Chau c09a98a87d Use WindowConfiguration to match DeviceProfile in IDP.getDeviceProfile
- Also fix WindowBounds.isLandscape to use full display bounds to determine isLandscape, otherwise both orientation will be treated as isLandscape when using availableSize

Bug: 309801705
Test: manual and presubmit
Flag: NONE
Change-Id: Ic7f4235e620d4760a9af356f23066fe5b23304e6
2023-11-14 18:38:51 +00:00
Himanshu Gupta 775f5ca9c6 Merge "Adding Private Space views to Launcher." into main 2023-11-14 18:33:42 +00:00
Vadim Tryshev 47bcb2b6c5 Increasing wait time for Launcher restart after enabling test provider
Of the the logcats indicates that Launcher gets killed eventually, but
it takes 17 sec, while the test waits for the Launcher restart to
compete in 10 sec.

Perhaps restart take longer than usual because the system is still busy
killing setup wizard.

This is the second attempt to land this CL; the first one was reverted
because the revert author believed this breaks their tests.

This time I'm icreasing the wait from 10 to 30 (not 60) secs.

Bug: 308489613
Test: presubmit
Flag: N/A
Change-Id: I18cff219cf6ec2732ed181c970cb5315bf568cab
2023-11-14 10:16:05 -08:00
Himanshu Gupta 08badb3f6f Adding Private Space views to Launcher.
This CL adds the following:
* Static View Elements to be added to AllApps recycler View
* View Controller to load the above elements dynamically
* Private Space Section Decorator
* PrivateProfile Manager containing the logic related to Private Space
* Abstract UserProfileManager as the super class of Work/Private
ProfileManager

Private Space Views Figma
[link](https://www.figma.com/file/K6bIIcG882EiJNjxvSWsFT/V%E2%80%A2-Private-Space?type=design&node-id=14535-111985&mode=design&t=JLz9W0O551TpzQYH-0)

Flag: ACONFIG com.android.launcher3.Flags.enable_private_space DEVELOPMENT
Bug: 289223923
Test: Ran Launcher3 tests
Change-Id: I8aa4247c78064a551e5e0d0b46d3fc033873f99d
2023-11-14 11:58:16 +00:00
Vadim Tryshev 18c1038ddf Merge "Making killing setup wizard a permanent solution" into main 2023-11-13 20:20:07 +00:00
Jordan Silva 1fb00ea561 Merge "Responsive grid cleanup" into main 2023-11-13 15:03:29 +00:00
Mike Schneider a9e73583bc Merge "Revert "Increasing wait time for Launcher restart after enabling test provider"" into main 2023-11-13 14:57:49 +00:00
Mike Schneider 27f0b77357 Revert "Increasing wait time for Launcher restart after enabling test provider"
This reverts commit a333756f0c.

Reason for revert: Seems to permanently break flickr tests with a timeout (https://android-build.corp.google.com/test_investigate/?invocationId=I84700010216659574&testResultId=TR17229044551287787)

Bug: 310269045
Change-Id: I49631dc10111e7bcd4b663ec5b26ee79885da246
2023-11-13 13:25:48 +00:00
Vadim Tryshev aecbc650fc Merge "Disabling strict activity leak check more aggressively than in ag/25340909" into main 2023-11-11 02:26:06 +00:00
Vadim Tryshev 4c2bf22c8d Merge "Demoting a couple of presubmit blocker tests" into main 2023-11-11 00:53:21 +00:00
Vadim Tryshev 94cb915d38 Disabling strict activity leak check more aggressively than in ag/25340909
That CL wasn't sufficient, still seeing:
https://android-build.corp.google.com/test_investigate/?blocking=warning&invocationId=I37300010216048087&status=none&testResultId=TR78329041431354974

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I36979a8929ccb996b81e8d41ec75b9713258c1c3
2023-11-10 16:41:42 -08:00
Vadim Tryshev 761b735728 Demoting a couple of presubmit blocker tests
Bug: 310242894
Test: presubmit
Flag: N/A
Change-Id: Ifd4dd430dbb645b5ab066742dd3ec861de3dfffa
2023-11-10 15:14:04 -08:00
Kevin Lim c3909d970b Merge "[Tiger] Re-adding PlatinumTest annotation" into main 2023-11-10 21:56:12 +00:00
Vadim Tryshev 1f8ff66235 Making killing setup wizard a permanent solution
It will be killed only in presubmit. In postsubmit, we want to be a true
e2e test exposed to all actual problems, including setup wizard that
doesn't go away.

Bug: 309471958
Test: presubmit
Flag: N/A
Change-Id: I2e877eade060e75e277eb3603d90b659207b5a47
2023-11-10 12:20:45 -08:00
Vadim Tryshev d315ffcb8f Merge "Increasing wait time for Launcher restart after enabling test provider" into main 2023-11-10 19:58:20 +00:00
Vadim Tryshev a333756f0c Increasing wait time for Launcher restart after enabling test provider
Of the the logcats indicates that Launcher gets killed eventually, but
it takes 17 sec, while the test waits for the Launcher restart to
compete in 10 sec.

Perhaps restart take longer than usual because the system is still busy
killing setup wizard.

Bug: 308489613
Test: presubmit
Flag: N/A
Change-Id: Idd576cacc300bce071bb40743209b4a111f18473
2023-11-10 10:31:14 -08:00
Pat Manning da5baa981a Merge "Fix focus nav of AllApps when Searching." into main 2023-11-10 18:20:01 +00:00
Pat Manning e7cb65009e Fix focus nav of AllApps when Searching.
- Do not focus the Icon in Small Icon Result Rows
- Use FocusIndicatorHelper when focusing search result icons

Flag: NONE
Bug: 296844600
Fix: 310173226
Test: Test: TaplKeyboardFocusTest
Change-Id: Icfc82ae41ffc8ef7c7ad42950f98f3d2dc805795
2023-11-10 16:48:21 +00:00
Kevin Lim 9bb62ee9c1 [Tiger] Re-adding PlatinumTest annotation
This undoes ag/24559527 as this test is no longer flaky.

Actual PlatinumTest presubmit restoration is done in cl/581071347

Bug: b/293944634
Flag: N/A
Test: Test only change
Change-Id: I605f8911fa3a3658c49642efee8d6166545ae89b
2023-11-10 01:37:15 +00:00
Jordan Silva 8f7986abae Responsive grid cleanup
This CL renames some of the variables to keep it consistent across the code. It removes workarounds that were made to facilitate easy code reviews without breaking the tests.
It is a cleanup of the responsive grid feature.

Bug: 299889733
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: CalculatedAllAppsSpecTest
Test: CalculatedFolderSpecTest
Test: CalculatedHotseatSpecTest
Test: CalculatedWorkspaceSpecTest
Test: AllAppsSpecsTest
Test: FolderSpecTest
Test: HotseatSpecsTest
Test: WorkspaceSpecsTest
Change-Id: I198fadfbcfc0d1b32a62a3076949b42ee1fbcf33
2023-11-09 22:06:03 +00:00
Uwais Ashraf 8e1e2a5155 Merge "Use instrumentation arg to prevent unnecessary delays in unit tests" into main 2023-11-09 16:03:20 +00:00
Uwais Ashraf b5d08b246e Use instrumentation arg to prevent unnecessary delays in unit tests
Bug: 308792359
Flag: NA
Test: presubmits passing
Change-Id: Ib38db86057998fcf859a44fa190e6cc4d82263dd
2023-11-09 12:07:18 +00:00
Vadim Tryshev 572b5b09fd Merge "Allowing ACTION_CANCEL events to come from device 0" into main 2023-11-09 01:42:16 +00:00
Vadim Tryshev a3f581d733 Merge "Diagnosing when Launcher is in invalid state" into main 2023-11-09 01:40:03 +00:00
Vadim Tryshev 7a1beb559f Allowing ACTION_CANCEL events to come from device 0
Tests assert that input events come to Launcher only from tests, which
sets deviceId to 0. This way, we spot when a cable touches a lab device
and breaks the tests, in which case deviceId will be != -1.

But CANCEL event, which is programmatic, now can legitimately come from
device 0.

Bug: 308489875
Test: presubmit
Flag: N/A
Change-Id: I84ee9ed8e008043f83e82d57b17b64a10677ee8d
2023-11-08 13:20:57 -08:00
Vadim Tryshev f0732e73d5 Merge "Workarounding setup wizard non-disappearance only in presubmit" into main 2023-11-08 20:29:00 +00:00
Vadim Tryshev 1c8e30b54c Merge "Making keyguard dismissal a permanent solution" into main 2023-11-08 20:24:11 +00:00
Jordan Silva 72bc6f53f7 Merge changes from topic "comet-landscape" into main
* changes:
  Update Responsive Grid tests with aspect ratio group
  Refactoring Responsive Grid XML specs for more flexibility
2023-11-08 11:16:21 +00:00
Vadim Tryshev 84aa57b2d1 Diagnosing when Launcher is in invalid state
Due to bugs, Launcher may end up showing incorrectly, i.e. Launcher app
is present, but no workspace, all apps etc is visible.
Improving diagnostics when this is the case.

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: Ibd0228bd26d2ba9ad710895ed8d2e5ece294db21
2023-11-07 16:22:58 -08:00
Vadim Tryshev e5a1b89220 Making keyguard dismissal a permanent solution
Before, it was considered to be a workaround while System UI has
keyguard bugs. But these bugs will happen in future, and they are
unlikely to be prevented by presubmit tests since they are usually flakes.

The solution that this CL makes permanent is: in presubmit attempt
to unlock SysUI if it's locked. In postsubmit, just make sure it's
unlocked. This way, in postsubmit, we'll know whether tere are active
keyguard bugs.

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: Ia9602bc6e9cc8400e939051c45aba92bc197d428
2023-11-07 14:45:58 -08:00
Vadim Tryshev 341e5598b5 Workarounding setup wizard non-disappearance only in presubmit
In postsubmit, we want to see the actual behavior to be aware of real e2e issues.

Bug: 309008042
Test: presubmit
Flag: N/A
Change-Id: Icedf381545dda32ea1dbdd8d215581265627bf3f
2023-11-07 12:33:21 -08:00
Federico Baron bc1d5791cd Merge "Ensure shortcuts show up in widget picker screenshot test" into main 2023-11-07 16:53:53 +00:00
Jordan Silva d7c7eaf837 Update Responsive Grid tests with aspect ratio group
Adding aspect ratio group and updating the responsive grid tests to match the refactored classes.

Bug: 299889733
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: AllAppsSpecsTest
Test: CalculatedAllAppsSpecTest
Test: HotseatSpecsTest
Test: CalculatedHotseatSpecTest
Test: WorkspaceSpecsTest
Test: CalculatedWorkspaceSpecTest
Test: ResponsiveFolderTest
Test: CalculatedFolderSpecTest
Change-Id: I918f4e28eb310bc9300fc6cc2b5b2af67d758a96
2023-11-07 11:51:28 +00:00
Himanshu Gupta 7d56e6ea23 Merge "Adding Prework for Private Space integration in Launcher" into main 2023-11-07 08:45:41 +00:00
Vadim Tryshev 06de17be39 Merge "Adding a TODO to productize killing/dismissal of setup wizard" into main 2023-11-06 22:19:23 +00:00
Vinit Nayak b16e4d8e18 Merge "Cleanup logs" into main 2023-11-06 22:16:48 +00:00
Vinit Nayak cca9148c68 Cleanup logs
Flag: None
Test: None
Fixes: 302551868
Change-Id: I617358b8c9ed3293efacff47ad3b1d7b275d5865
2023-11-06 12:45:56 -08:00
Vadim Tryshev ca90b8d7d9 Removing assert that setup wizard is visible
Bug: 309496273
Test: presubmit
Flag: N/A
Change-Id: Ie6b77673c120a94d211662c71467635923dda622
2023-11-06 12:38:35 -08:00
Vadim Tryshev a7e283b605 Adding a TODO to productize killing/dismissal of setup wizard
Bug: 309471958
Test: presubmit
Flag: N/A
Change-Id: I8ef3a7310829333132b03453dbb6f3c37b88c364
2023-11-06 10:31:29 -08:00
Vadim Tryshev 8b1881223b Merge "Waiting for the setup wizard to go away" into main 2023-11-06 18:17:46 +00:00
Himanshu Gupta 9aab4d4603 Adding Prework for Private Space integration in Launcher
This Cl adds the following:
1. Fixes for Quite Mode check maintained by Launcher
2. Addition of new Quite Mode broadcasts
3. Fixes for determining work profile user correctly.

Flag: ACONFIG com.android.launcher3.Flags.enable_private_space DEVELOPMENT
Bug: 289223923
Test: Ran Launcher3 tests
Change-Id: I5f6158b213723339e70ff99e66c5f439f5879e12
2023-11-05 12:31:10 +00:00
Vadim Tryshev 0fe753af2a Waiting for the setup wizard to go away
This is a workaround for b/309008042 where it appears that after being
dismissed by the test infra, setup wizard doesn't immediately go away.

This CL will wait 2 minutes for the dismissal, and provide a better
diags when the wizard doesn't go away after 2 min.

Bug: 309008042
Test: presubmit
Flag: N/A
Change-Id: I26eb2f202842702af08c424929d74fbd21eb872d
2023-11-04 21:37:25 -07:00
Priyanka Advani ebc9a3b5e1 Merge "Revert "Change TAPL to swipe to stash taskbar (instead of deprec..."" into main 2023-11-03 22:10:27 +00:00
Priyanka Advani 9aed56096c Revert "Change TAPL to swipe to stash taskbar (instead of deprec..."
Revert submission 24877128-cherrypick-tapl-transient-swipe-owubvwrsw6i

Reason for revert: Likely culprit for b/309158105

Reverted changes: /q/submissionid:24877128-cherrypick-tapl-transient-swipe-owubvwrsw6i

Change-Id: I8ee560f7e599bcfde09eff53f049309ba25ce77f
2023-11-03 21:31:45 +00:00
Pat Manning 89bd90927d Merge "Fix focus navigation of All Apps when using external keyboard." into main 2023-11-03 18:42:37 +00:00
Tony Wickham 075a67da15 Merge "Change TAPL to swipe to stash taskbar (instead of deprecated long press)" into main 2023-11-03 18:35:54 +00:00