Commit Graph

4240 Commits

Author SHA1 Message Date
Sebastián Franco 27614fc8ce Merge "Making sure the Launcher is present when running the test" into main 2023-11-28 21:16:30 +00:00
Jordan Silva 837fb91423 Merge "Validate responsive specs using more than 100% of remainder space" into main 2023-11-28 19:49:30 +00:00
Sebastian Franco afd0e4ab11 Making sure the Launcher is present when running the test
It seems that when a previous test fails this test starts failing
so we are not making sure we are in a correct state.

Bug: 303263644
Flag: NA
Test: will see if the flake rate goes down
Change-Id: I7ecdc0ea82914331d68fe20bf2665d2812bca46f
2023-11-28 12:35:39 -06:00
Sebastián Franco 4a708997a1 Merge "Moving the static initialization method from TaplTestsLauncher3 to AbstractLauncherUiTest" into main 2023-11-28 18:32:58 +00:00
Jordan Silva 4c09958671 Validate responsive specs using more than 100% of remainder space
Fix: 313463517
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: ResponsiveSpecsProviderTest
Change-Id: Ic80846d27dabd8d57f43b35581174bd2f2f3611b
2023-11-28 15:11:27 +00:00
Thales Lima 5fc47806f8 Merge "Make numFolderRows/numFolderColumns accept more values" into main 2023-11-28 11:22:27 +00:00
Sebastián Franco 463131427d Merge "Add unit test for CellLayout making sure the reorder are valid and fix Multipage CellLyout" into main 2023-11-28 00:27:21 +00:00
Sebastian Franco 6c7d817bc7 Add unit test for CellLayout making sure the reorder are valid and fix Multipage CellLyout
The new test generate hundreds of new boards using a fixed seed so the
test cases can be recreated if there is an error.

Some of the new clases where inside of CellLayoutBoard and moved
outside.

Flag: LEGACY FOLDABLE_SINGLE_PAGE DISABLED
Bug: 270395274
Test: ReorderAlgorithmUnitTest
Change-Id: I083fb6701b02b7c0b2cf24634ca71acb0c75902e
2023-11-27 17:12:43 -06:00
Pat Manning 37cf983825 Merge "Wait for IME to hide in test only if software keyboard." into main 2023-11-27 18:32:23 +00:00
Pat Manning b8145edf05 Wait for IME to hide in test only if software keyboard.
Fix: 311410127
Test: TaplKeyboardFocusTest#testAllAppsExitSearchAndFocusSearchResults
Flag: NONE.
Change-Id: I74f1023bdf9118abaa9cda651b881ef60636da34
2023-11-27 13:53:03 +00:00
Thales Lima 24051842c7 Make numFolderRows/numFolderColumns accept more values
Now they can hold values for different configurations, making it akin to iconSize.

Bug: 309800141
Test: DeviceProfileResponsiveDumpTest
Test: DeviceProfileResponsiveAlternativeDisplaysDumpTest
Test: DeviceProfileDumpTest
Test: DeviceProfileAlternativeDisplaysDumpTest
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Change-Id: I9d5cccda88a0311dbe0beecef194cc8d60c5c280
2023-11-24 15:54:56 +00:00
Jordan Silva 0bb6034f74 Merge "Extract cell size information to responsive grid structure" into main 2023-11-24 14:36:39 +00:00
Alex Chau c95a4e6b1d Merge "Revert "Remove logs for bug investigation"" into main 2023-11-24 14:02:39 +00:00
Jordan Silva 999dd2a06f Extract cell size information to responsive grid structure
Bug: 287975993
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: ResponsiveCellSpecsProviderTest
Test: DeviceProfileDumpTest
Test: DeviceProfileResponsiveDumpTest
Change-Id: I26a87d9b690fdfcff1599d862c09e97fe9f9f930
2023-11-24 12:39:36 +00:00
Pat Manning 78a2dd66b2 Merge "Close allapps on press of ESC key." into main 2023-11-24 12:30:04 +00:00
Jordan Silva 2e1b287038 Merge "Use DeviceProfile numFolderRows and numFolderColumns" into main 2023-11-24 12:29:19 +00:00
Pat Manning a7a04fe901 Close allapps on press of ESC key.
Fix: 310206847
Test: TaplOpenCloseAllApps
Flag: NONE
Change-Id: I9b9f958eb2889680b731dd7134fce2793e62eb74
2023-11-24 11:03:13 +00:00
Sebastián Franco 525b0343f8 Merge "Moving classes inside of CellLayout to their own file" into main 2023-11-24 01:27:13 +00:00
Sebastian Franco 5f0af4f633 Moving classes inside of CellLayout to their own file
This is a no-op change ensure this we have ReorderAlgorithmUnitTest.

Flag: NA
Bug: 229292911
Test: ReorderAlgorithmUnitTest
Change-Id: I6ffe2a1260f869a4686a9f1e652dd1ab6d406269
2023-11-23 23:13:56 +00:00
Alex Chau 58a8c12713 Revert "Remove logs for bug investigation"
This reverts commit dad61a0098.

Reason for revert: b/279059025

Change-Id: Id8fcd1ddf67d7df0a23c81e3ddf3849c26c529bd
2023-11-23 19:01:16 +00:00
Sebastian Franco 0e02d74cbf Moving the static initialization method from TaplTestsLauncher3 to AbstractLauncherUiTest
Flag: NA
Bug: 298234173
Test: atest TaplWorkspaceTest
Change-Id: I49dadefa17ef0ea78ca342b8b6d7bb9e38d4d0c9
2023-11-22 12:43:44 -06:00
Vadim Tryshev 93513ce3f5 Merge "Speeding up testDragShortcutToMultipleWorkspaceCells in presubmit" into main 2023-11-22 04:59:29 +00:00
Vadim Tryshev a2c32f7965 Speeding up testDragShortcutToMultipleWorkspaceCells in presubmit
On foldable, presubmit P90 is 38 min, and the requirement is to fit in
30 min.

testDragShortcutToMultipleWorkspaceCells takes around 3 min.
Making it enumerate less combinations in presubmit.

Bug: 295939967
Test: presubmit
Flag: N/A
Change-Id: Ic47223b3800fe502ed152488a2940f41c0edfb88
2023-11-21 19:05:38 -08:00
Vadim Tryshev 2e54a166a9 Merge "Demoting testUninstallFromWorkspace, which is a 4% presubmit blocker" into main 2023-11-21 23:09:50 +00:00
Sebastián Franco 7a3c354c48 Merge "Move classes inside of CellLayoutBoard to their own file" into main 2023-11-21 18:35:32 +00:00
Jagrut Desai 426f7f4d2f Merge "Logging for ActivityLeak - Launcher" into main 2023-11-21 16:57:24 +00:00
Pat Manning 06ecd24ee3 Allow right-click of taskbar icons to launch long-click menu.
Fix: 290459491
Test: TaplTestsTaskbar#testOpenMenuViaRightClick
Flag: NONE.
Change-Id: Ide85f62e5b08d5261f15871e85d3250cc66d0919
2023-11-21 14:45:31 +00:00
Thales Lima 07c6b8d96d Use DeviceProfile numFolderRows and numFolderColumns
Invariant hold values that are not related to current DP in use. This is a change needed for IDP to hold more values in the future akin to iconSize.

Bug: 309800141
Change-Id: Iefb388a5f6590d7da3452d2c388c02bd5e9d32bb
Flag: N/A
Test: NexusLauncherTests
2023-11-21 11:47:21 +00:00
Vadim Tryshev 615b744930 Demoting testUninstallFromWorkspace, which is a 4% presubmit blocker
Bug: 311099513
Flag: N/A
Test: presubmit
Change-Id: I699e3198eaa632f3977e89498c62ecb8e6956255
2023-11-20 18:48:54 -08:00
Vadim Tryshev a75fd790ea Merge "Avoiding unconditional 5 sec wait in the beginning of inproc tests" into main 2023-11-21 01:59:09 +00:00
Sebastian Franco d30100eaa9 Move classes inside of CellLayoutBoard to their own file
Previous step for adding unit testing for MultipageCellLayout.

Flag: LEGACY FOLDABLE_SINGLE_PAGE DISABLED
Bug: 270395274
Test: ReorderAlgorithmUnitTest
Change-Id: Ia5ca0b10481d7a21883594434b3406fb3a5ccf0b
2023-11-20 17:58:24 -06:00
Tony Wickham e1f770df2f Change TAPL to swipe to stash taskbar (instead of deprecated long press)
This also means Taskbar is transient by default in automated tests,
instead of persistent. Updated some checks accordingly.

Flag: LEGACY ENABLE_TRANSIENT_TASKBAR ENABLED
Test: TaskbarExpandCollapse#hideShowTaskbar; TaplTestsTaskbar;
TaplTestsTransientTaskbar; TaplTestsPersistentTaskbar
Bug: 270395798

Change-Id: I48b4c809025a9bab0a37ada1317adee823b1a8f9
2023-11-20 23:41:01 +00:00
Himanshu Gupta 23876959e5 Merge "Fixing Launcher crases due to methods being called on Ui Threads." into main 2023-11-20 23:02:46 +00:00
Vadim Tryshev 3f7e82e81d Avoiding unconditional 5 sec wait in the beginning of inproc tests
Also merging waiting after enabling test provider for the inproc and OOP
cases.

Bug: 311023703
Test: presubmit
Flag: N/A
Change-Id: I417111d984bb0b0d79bada61595e46a6b924ea7c
2023-11-20 13:55:13 -08:00
Himanshu Gupta 2b5620b295 Fixing Launcher crases due to methods being called on Ui Threads.
This CL fixes the following two issues:
1. Launcher crashing while calling `addPrivateSpaceSettingsButton` from
   BaseAllAppsAdapter as the thread is UI
2. Decorator is not removed from Private Space Header during reset to
   paused state. https://screenshot.googleplex.com/BZdLqaZQwdDApfV

Flag: ACONFIG com.android.launcher3.Flags.enable_private_space DEVELOPMENT
Bug: 311337961, 311342946
Test: Ran Launcher3 tests
Change-Id: I2763338ebf0f5468ad38f61a781e8a8334194c5c
2023-11-20 18:59:13 +00:00
Jagrut Desai 1a16edea37 Logging for ActivityLeak - Launcher
Test: Presubmit
Bug: 273347463
Flag: NONE
Change-Id: I9825fd18a89354bff2bedf1c43f0d3170a3b4795
2023-11-20 10:44:16 -08:00
Alex Chau 940fbe1e2d Merge "Avoid instantiating unnecessary OverviewTask in getCurrentTask loop" into main 2023-11-20 18:28:40 +00:00
Alex Chau 7d237cd83a Avoid instantiating unnecessary OverviewTask in getCurrentTask loop
- Replaced with moving each size getting methods to a lambda in getCurrentTask

Bug: 309820115
Test: presubmit
Flag: None
Change-Id: Ic625e30bd42f4289bbb1768c2ceeb95e98f51a15
2023-11-20 13:13:44 +00:00
Fengjiang Li e5f91a4c7a Only log COLD_DEVICE_REBOOTING startup latency logs
Fix: 305391017
Test: Unit test
Flag: NA
Change-Id: I976add25ea14d49e2ea84e395985edb9f559370c
2023-11-17 14:00:51 -08:00
Vinit Nayak 7056e2d2e4 Merge "Add logs for move pointer" into main 2023-11-16 20:16:44 +00:00
Vadim Tryshev 02a9f44ae1 Merge "Demoting testAllAppsExitSearchAndFocusSearchResults from presubmit" into main 2023-11-16 19:37:36 +00:00
Vadim Tryshev 620a826e40 Demoting testAllAppsExitSearchAndFocusSearchResults from presubmit
It's a 35% presubmit blocker

Bug: 295939967
Test: presubmit
Flag: N/A
Change-Id: I004112093d830bdf8586d0f10327355400d08103
2023-11-16 10:14:18 -08:00
Sebastián Franco da18b9e435 Merge "Use the number of shown hotseat icons instead of database items to store into the DB" into main 2023-11-16 15:33:51 +00:00
Sergey Pinkevich 172eb5896b Merge "Show split screen action for each task" into main 2023-11-16 10:03:44 +00:00
Sebastian Franco 2d023e26c6 Use the number of shown hotseat icons instead of database items to store into the DB
It seems this issue was originated from ag/14129534 and we should no
longer use numDatabaseHotseatIcons form IDP and use numShownHotseatIcons
from the DP.

Fix: 305119735
Flag: NA
Test: manuall testing, we don't have this test for landscape
Change-Id: Ie530748f9b77d89ac3298c187ae767643d505cb3
2023-11-15 21:34:38 -06:00
Vinit Nayak b39abc99cd Add logs for move pointer
* Appears in the flaky case we're getting a
long-press instead of a move.
Suspect performance might be an issue? Hopefully
the log between ACTION_DOWN and subsequent move can
show how long that is taking

Flag: None
Test: None
Bug: 311099513
Change-Id: I305dfdf7c6b64ef24ee5fec34a3f827ce6fbe2af
2023-11-15 16:42:40 -08:00
Hyunyoung Song 647be66c38 Merge "Enabling Private Space Container in Launcher." into main 2023-11-15 23:14:34 +00:00
Vadim Tryshev ebf08d8b75 Having longer period of waiting for Launcher restart only in Launcher test suites
This will help to avoid breaking other test suites by this increase.

Bug: 311023703
Test: presubmit
Flag: N/A
Change-Id: Ia91b03b72fa6592684e7a1673b9b56448f637dd4
2023-11-15 13:00:37 -08:00
Vadim Tryshev d940da38be Merge "Revert "Increasing wait time for Launcher restart after enabling test provider"" into main 2023-11-15 18:08:15 +00:00
Sergey Pinkevich ead5259f9a Show split screen action for each task
Remove previous condition:
1. `taskView.containsMultipleTasks()` - there is already a check to filter out "Split screen" item: https://googleplex-android.googlesource.com/platform/packages/apps/Launcher3/+/refs/heads/main/quickstep/src/com/android/quickstep/TaskOverlayFactory.java#68

Edit previous condition:
2. `notEnoughTasksToSplit` - condition saying if there is less than 2 recent tasks. We still should give the possibility to split the screen if Taskbar is not presented

Bug: 305958994
Flag: NONE
Test: manual - took a photo (https://screenshot.googleplex.com/7doU5z9AjxxETUo)

Change-Id: I3fdfea987c426d557a91b0a25af368069e8af3f8
2023-11-15 15:14:50 +00:00