a579db61b1
Prevent passing in GroupedTaskView when not animating split launch am: 8082401a83 am: 33b4935234
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23910406
Change-Id: Ibda7eac11e619668f631757980e4115ef869667b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-06 05:27:48 +00:00
33b4935234
Prevent passing in GroupedTaskView when not animating split launch am: 8082401a83
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23910406
Change-Id: I5cba930c740bac29dd12c615510c76130d52938a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-06 04:43:45 +00:00
8082401a83
Prevent passing in GroupedTaskView when not animating split launch
...
* With ag/23320818 we started always passing in GroupedTaskView,
which gets used downstream to mean that we are launching an app
from tapping on it in overview
* This caused a bug in the case where we quickswitched to the last
task. Now we pass in null for GroupedTaskView like before
Test: Prior bug (b/274540670) doesn't occur, nor do repro steps
for this one
Fixes: 289163668
Flag: None
Change-Id: I82dd8f26bfc286fefc0995822786cf3980da41d0
2023-07-05 18:21:59 -07:00
923c996b97
Merge "Remove flag ENABLE_LAUNCH_FROM_STAGED_APP" into udc-qpr-dev am: 66ec0f6a28 am: 5aab73311a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23848181
Change-Id: Ic2009f133ea2933453bf0d4048861960dcc3877e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-06 01:18:17 +00:00
ec565bcff5
Merge "Add logcat logs for splitscreen launch failures" into udc-qpr-dev am: 3137f65dcc am: 86cf2ea3c8
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23784840
Change-Id: Ie6c1d12d76fe7acb41beddc7b8667eab8c70aa37
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-06 01:04:16 +00:00
820cbaad4d
Ensure overflow isn't selected when bar is collapsed am: 16b05e251b am: 3c81efd136
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23900933
Change-Id: If381ac2bfaaea5a905901abc013c8ac700cb1955
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-06 00:28:19 +00:00
5aab73311a
Merge "Remove flag ENABLE_LAUNCH_FROM_STAGED_APP" into udc-qpr-dev am: 66ec0f6a28
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23848181
Change-Id: Ie893a904846f1f8387c358ae1d1dac565eee6abe
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-05 22:16:00 +00:00
86cf2ea3c8
Merge "Add logcat logs for splitscreen launch failures" into udc-qpr-dev am: 3137f65dcc
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23784840
Change-Id: I490a99f184fdb3d6432b93ea36ac79c0e8a51c66
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-05 22:15:20 +00:00
c06c7ff6fa
Update the bubble bar offset on Home
...
This is an initial change that positions the bubble bar aligning it
with the center of the hotseat icons. We still need to center it
with the taskbar when in overview.
This change also fixes the touch issues where sometimes the hotseat
icons don't respond to taps. The fix is twofold:
1. Make sure that taskbar insets are always updated when
BubbleStashController#setBubblesShowingOnHome is called.
2. Update the touchable region in TaskbarInsetsController to account
for the Y translation of the bubble bar bounds when the bubble
bar is visible.
Demo: https://screenshot.googleplex.com/6NRyu2CR7Bjs32x
Bug: 286247080
Test: Manual on a physical device
Change-Id: I00daff8341e4d8f5d141b5e0220726f6c03b437c
2023-07-05 17:29:52 -04:00
66ec0f6a28
Merge "Remove flag ENABLE_LAUNCH_FROM_STAGED_APP" into udc-qpr-dev
2023-07-05 21:22:22 +00:00
3137f65dcc
Merge "Add logcat logs for splitscreen launch failures" into udc-qpr-dev
2023-07-05 21:22:12 +00:00
2c1860e8c6
Sends user home when stashed taskbar handle is clicked.
...
TAPL, see: go/tapl-taskbar-hover-states
Fix: 249852605
Test: TaplTestsTransientTaskbar
Flag: ENABLE_CURSOR_HOVER_STATES
Change-Id: If3c31b9b43a7361bc4e1a97395486249a44ad0f6
2023-07-05 22:18:01 +01:00
3c81efd136
Ensure overflow isn't selected when bar is collapsed am: 16b05e251b
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23900933
Change-Id: I19c19e06e387ce56a78d10b8251edf8449ceb989
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-05 19:15:12 +00:00
16b05e251b
Ensure overflow isn't selected when bar is collapsed
...
After the bubble bar collapsing animation completes, and reordering
is finished, if the bubble overflow is selected, update the selected
bubble to be the first bubble. This ensures that the overflow
is not selected the next time the bubble bar is expanded.
This is done through a callback from the BubbleBarView to the
BubbleBarController with the key of the first bubble. Ideally the view
would just notify that the selected bubble needs to be updated, but
the controller doesn't hold ordering info.
Fixes: 289280431
Test: manual
- Add 2 bubbles to the bubble bar
- Expand the bubble bar. The first bubble A should be selected
- Select the second bubble B
- Select the overflow
- Tap on the overflow again to collapse the bubble bar
- Tap on the bubble bar to expand it
- Observe that bubble B is first and selected
Change-Id: I0f9c2d628cfaf3a80da55ff634284687425e949a
2023-07-05 12:20:46 -04:00
32e8934f61
Add initial trackpad tapl tests am: 323958007d am: b3f8477b94
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23744485
Change-Id: Id4d47e95cbac52a14d00ee8fd06a9e23991986c1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-03 21:10:07 +00:00
b3f8477b94
Add initial trackpad tapl tests am: 323958007d
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23744485
Change-Id: I76bf5d89ac5b141aad398ff62b3483535a0d6fc3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-03 20:28:39 +00:00
323958007d
Add initial trackpad tapl tests
...
- go home
Bug: 281732733
Test: presubmit
Change-Id: I538d63bde2bf427a02c2bc355eab71546d667bf9
2023-07-03 10:50:54 -07:00
9f3a115ab0
Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f am: d4b4e95bea am: 62dd220b69
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422
Change-Id: I616ad6bb87381eca5b452ddadd460d35f4b71414
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-01 00:29:18 +00:00
491b0f9028
Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f am: d4b4e95bea
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422
Change-Id: I9d438b3edda25a7407d30d702013b385b3fd9195
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-30 23:47:37 +00:00
62dd220b69
Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f am: d4b4e95bea
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422
Change-Id: I2c06c2637c4d7fefab71ea87af677b210cd2829c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-30 23:45:46 +00:00
2b01cb4bd4
Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f am: e88a949a17
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422
Change-Id: I0db039662d4a1d25104d7373e8c22affbdbea74c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-30 23:45:15 +00:00
7cc6f65011
Taskbar All Apps Shortcut Menu Acccessibility Focus
...
Bug: 280657266
Test: manual
Flag: not needed
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:53d953ccd24cd378418d9bd8c9964589fb1af44a )
Merged-In: I2426636067ce3635b8b24b9f5d093dad7d9ddf4c
Change-Id: I2426636067ce3635b8b24b9f5d093dad7d9ddf4c
2023-06-30 23:26:29 +00:00
df537ccdb7
Cleans up bad state when transient taskbar shows on home.
...
Bug: 279514548
Test: open transparent activity on top of launcher
unstash taskbar
go home
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:3bad3ebaad529a8be587b9c0eae61faf87ea8505 )
Merged-In: I13ab79b334e1f8feda441a82cc4d035c0142f513
Change-Id: I13ab79b334e1f8feda441a82cc4d035c0142f513
2023-06-30 23:26:22 +00:00
e88a949a17
Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422
Change-Id: Iee33ca78be02118b1e6471d9d558c82d05a786aa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-30 23:05:16 +00:00
fa2a81844f
Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev
2023-06-30 22:29:20 +00:00
1a9a98005d
[a11y] Fix crash when using talkback to add to home screen.
...
1. Fix a crash from http://cs/android-internal/packages/apps/Launcher3/src/com/android/launcher3/Launcher.java;l=1928;rcl=d677caa75de74f1c3a88367cad67ae405fd2903d . It can also be `ITEM_TYPE_SEARCH_ACTION`. Remove the `itemType` check and just use the `PendingAddItemInfo` class type.
2. Override `startConfigActivity` in `PinShortcutRequestActivityInfo`, so that `Launcher#onActivityResult` can be triggered properly from `Launcher#processShortcutFromDrop` (http://cs/android-internal/packages/apps/Launcher3/src/com/android/launcher3/Launcher.java;l=1939;rcl=d677caa75de74f1c3a88367cad67ae405fd2903d )
3. Then we call to `Launcher#completeAdd` -> `completeAddShortcut`. The original `info` passed to `processShortcutFromDrop` doesn’t have a `componentName` (new code), so remove the component non-null check from `completeAddShortcut`.
Bug: 287166186
Bug: 287167527
Bug: 287166771
Test: manual
Flag: N/A
Change-Id: Id3e1444de188f2d2af760f58e3d9814a2b7abd88
Merged-In: Id3e1444de188f2d2af760f58e3d9814a2b7abd88
(cherry picked from commit 35b9960b63
2023-06-30 20:49:33 +00:00
dd262b4617
Merge "Cleans up bad state when transient taskbar shows on home." into udc-dev am: 2c3c1e46c0 am: 4de15620c2 am: 120c78d24f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23852178
Change-Id: I852fc4d1f95af8ef5be6fa02dd1d1d404b8cd92a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-30 19:28:58 +00:00
bdd0859b8a
Merge "[a11y] Fix crash when using talkback to add to home screen." into udc-qpr-dev am: 18e0e1e50a am: d91ee8f9af
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23849395
Change-Id: I2c5cc943205c9fb6528090ee64d539e0f0dca3a5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-30 19:06:02 +00:00
957d46ae52
Merge "Cleans up bad state when transient taskbar shows on home." into udc-dev am: 2c3c1e46c0 am: 4de15620c2
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23852178
Change-Id: Idbb6ded338cf1fe3db8142ba75d54844a9bf1382
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-30 19:05:32 +00:00
120c78d24f
Merge "Cleans up bad state when transient taskbar shows on home." into udc-dev am: 2c3c1e46c0 am: 4de15620c2
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23852178
Change-Id: I1302f2aeaeb17fa95a1a64cb2e095febadcacba1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-30 19:03:05 +00:00
20fa45a004
Merge "Cleans up bad state when transient taskbar shows on home." into udc-dev am: 2c3c1e46c0 am: 67b5bc8c4c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23852178
Change-Id: Iab9ff4080c4f4d36918538c686dec5ea4af35fbe
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-30 19:03:05 +00:00
d91ee8f9af
Merge "[a11y] Fix crash when using talkback to add to home screen." into udc-qpr-dev am: 18e0e1e50a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23849395
Change-Id: I677a0e430b79b13a85f955a85421d78c5a166969
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-30 18:27:19 +00:00
67b5bc8c4c
Merge "Cleans up bad state when transient taskbar shows on home." into udc-dev am: 2c3c1e46c0
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23852178
Change-Id: I68510c624c597e572dd4e06b0e36c6d994c60ce1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-30 18:22:29 +00:00
18e0e1e50a
Merge "[a11y] Fix crash when using talkback to add to home screen." into udc-qpr-dev
2023-06-30 17:56:16 +00:00
2c3c1e46c0
Merge "Cleans up bad state when transient taskbar shows on home." into udc-dev
2023-06-30 17:45:50 +00:00
35b9960b63
[a11y] Fix crash when using talkback to add to home screen.
...
1. Fix a crash from http://cs/android-internal/packages/apps/Launcher3/src/com/android/launcher3/Launcher.java;l=1928;rcl=d677caa75de74f1c3a88367cad67ae405fd2903d . It can also be `ITEM_TYPE_SEARCH_ACTION`. Remove the `itemType` check and just use the `PendingAddItemInfo` class type.
2. Override `startConfigActivity` in `PinShortcutRequestActivityInfo`, so that `Launcher#onActivityResult` can be triggered properly from `Launcher#processShortcutFromDrop` (http://cs/android-internal/packages/apps/Launcher3/src/com/android/launcher3/Launcher.java;l=1939;rcl=d677caa75de74f1c3a88367cad67ae405fd2903d )
3. Then we call to `Launcher#completeAdd` -> `completeAddShortcut`. The original `info` passed to `processShortcutFromDrop` doesn’t have a `componentName` (new code), so remove the component non-null check from `completeAddShortcut`.
Bug: 287166186
Bug: 287167527
Bug: 287166771
Test: manual
Flag: N/A
Change-Id: Id3e1444de188f2d2af760f58e3d9814a2b7abd88
2023-06-30 08:42:31 -07:00
4fdf5684fe
Polish home-key from split to pip transition
...
Includes WINDOWING_MODE_MULTI_WINDOW closing target to the condition of
playing fallback animation. So the remaining splitting task won't be
play with iconview animation when home-key to auto-pip consumed another
splitting task in pip transition handler.
Bug: 281476331
Test: repro steps of the bug
Test: pass existing tests
Video: http://recall/-/fLARJNt42LVxc3tt86SneW/eelqATeE1REoOtOEDxeDVR
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:365105118220b218005225b038142273524877cc )
Merged-In: If05d8841a6a940e61f71683422ef1a3d4e3597c7
Change-Id: If05d8841a6a940e61f71683422ef1a3d4e3597c7
2023-06-30 03:17:29 +00:00
5bd1453eb7
Merge "Disable all apps from overview in some cases." into udc-qpr-dev am: 1b565681fe am: 5a56f8f111
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23835679
Change-Id: I80826678c725308991bbf234528fa624735371a2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-30 00:35:42 +00:00
5a56f8f111
Merge "Disable all apps from overview in some cases." into udc-qpr-dev am: 1b565681fe
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23835679
Change-Id: I02604078e3f4dcfc6413916a8c47f7c6cce934bb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-30 00:11:09 +00:00
1b565681fe
Merge "Disable all apps from overview in some cases." into udc-qpr-dev
2023-06-29 23:52:09 +00:00
70cda84fd7
Merge "Fix prediction row title consistency" into udc-qpr-dev am: aa9332af88 am: 69be4ccd17
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23815838
Change-Id: I05bf5293621c520d13ef248609f87e46b6d703d0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-29 23:00:02 +00:00
69be4ccd17
Merge "Fix prediction row title consistency" into udc-qpr-dev am: aa9332af88
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23815838
Change-Id: I38ea618a57778e567608de1c5ecbc8e76d02030c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-29 22:38:46 +00:00
aa9332af88
Merge "Fix prediction row title consistency" into udc-qpr-dev
2023-06-29 21:45:40 +00:00
e359184522
Merge "Polish home-key from split to pip transition" into udc-dev am: ca08d75e4a am: 93551e9496 am: 263aceeeea
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23833485
Change-Id: I55f4709943f4373b71a7dff8fbcd7c1f660a9a40
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-29 18:23:48 +00:00
49b9fbd188
Merge "Polish home-key from split to pip transition" into udc-dev am: ca08d75e4a am: 93551e9496
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23833485
Change-Id: I0a6ef4eee4dfc6244b5ee4a7716c1e625923d4b8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-29 17:58:16 +00:00
b2cefbeaed
Merge "Polish home-key from split to pip transition" into udc-dev am: ca08d75e4a am: 036ed78e3b
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23833485
Change-Id: I0910e0a8ada84d015cfee8e80581a4e86915ab8a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-29 17:56:59 +00:00
263aceeeea
Merge "Polish home-key from split to pip transition" into udc-dev am: ca08d75e4a am: 93551e9496
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23833485
Change-Id: I6d23eca98f12691d3f87af8fedf8049f27125194
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-29 17:56:29 +00:00
036ed78e3b
Merge "Polish home-key from split to pip transition" into udc-dev am: ca08d75e4a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23833485
Change-Id: If80e354c9e21be74828936960176353e0cea7179
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-06-29 17:36:05 +00:00
ca08d75e4a
Merge "Polish home-key from split to pip transition" into udc-dev
2023-06-29 17:17:03 +00:00
5cdfa120df
Workaround for handling the restart of an already visible task
...
- If a task is already visible, then startActivity is a no-op and the
remote transition that launcher expects to run is not started. As a
workaround (until restarts are an actual transition), listen for
the case where a task is restarted and invoke the end callbacks
Fixes: 286016555
Test: Repro steps on the bug
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:57c2a79e47bc583306bd77ea3039d821a8d33dde )
Merged-In: Iec3ab97c8817a5e95399cec90f891d65f369d234
Change-Id: Iec3ab97c8817a5e95399cec90f891d65f369d234
2023-06-29 03:39:15 +00:00
Vinit Nayak
Jeremy Sim
Liran Binyamin
patmanning
Tracy Zhou
Jagrut Desai
Jon Miranda
Holly Sun
Treehugger Robot
Jerry Chang
Brandon Dayauon
Hongwei Wang
Winson Chung