Commit Graph

20478 Commits

Author SHA1 Message Date
Vinit Nayak cf6b71a14e Merge "Allow pressing home button on recents if command queue not empty" into udc-qpr-dev 2023-07-12 20:58:59 +00:00
Vinit Nayak f909a72f3f Merge "Cleanup ENABLE_SPLIT_FROM_WORKSPACE flag" into udc-qpr-dev 2023-07-12 20:57:22 +00:00
Fengjiang Li 340afb8d12 Merge "Recreate hotseat predictor whenever we query it due to workspace change" into udc-qpr-dev am: 30b9bc7587
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23987658

Change-Id: I73ddd5b7b1f77f3312bc0840996b383ed5570232
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-12 20:48:13 +00:00
Liran Binyamin 6bd839f383 Merge "Check that the bubble bar has bubbles before showing it" into udc-qpr-dev am: d0121222a5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24024256

Change-Id: Id5be73c1a93b5c8e047993c46f25d302fd31b384
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-12 20:46:47 +00:00
Fengjiang Li 30b9bc7587 Merge "Recreate hotseat predictor whenever we query it due to workspace change" into udc-qpr-dev 2023-07-12 20:12:06 +00:00
Liran Binyamin d0121222a5 Merge "Check that the bubble bar has bubbles before showing it" into udc-qpr-dev 2023-07-12 19:58:16 +00:00
Brian Isganitis 3346e19b3b Initial Taskbar drag-n-drop support for search results.
- Includes initial support for obtaining PendingIntent for ITEM_TYPE_SEARCH_ACTION.
- Custom pre-drag conditions for search results can be provided through TaskbarSearchSessionController.
- Added detection for telling when DragView shift animation ends for
  pre-drag condition usage.

Test: Manual
Bug: 289261756
Flag: ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
Change-Id: I52510a6f3ee49968134ecb591ef7c4df711b9d3d
2023-07-12 14:42:02 -04:00
Ivan Tkachenko 8053234c58 Merge "Bubble bar drag to dismiss" into udc-qpr-dev am: e3d4a69749 am: e4e39296ec
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23879277

Change-Id: If03fd4dcf45928049c8cfb0e9bb3d9b9f71c9dda
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-12 18:13:32 +00:00
Liran Binyamin ac57606836 Merge "Don't show the bubble bar when it is empty" into udc-qpr-dev am: 7dd280eef3 am: d93bb84d9d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24024252

Change-Id: I9c50ad4479cbdf30051d24df1a71b2548591156b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-12 18:11:46 +00:00
Liran Binyamin d5c230d73f Merge "Pass bubble bar offsets instead of position to WMShell" into udc-qpr-dev am: 2c1e84b3a1 am: f8fcd3c9a6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24012984

Change-Id: Ieb26246065d8e70d420fdbc8af9f0bea3b439f5d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-12 18:05:45 +00:00
Ivan Tkachenko e4e39296ec Merge "Bubble bar drag to dismiss" into udc-qpr-dev am: e3d4a69749
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23879277

Change-Id: I82bd9a7499ddd73b9df80106a943a534690c3164
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-12 17:43:23 +00:00
Anushree Ganjam 5730f03c9f Introduce Default Ime height.
Assume IME_DEFAULT_HEIGHT_DP = 300.
When ime is yet to be shown but the UI is ready, then use
IME_DEFAULT_HEIGHT_DP.

For the 2nd time onwards save the actual ime height and use it when the
keyboard is not shown yet.

Bug: 285166099
Test: Manual
Change-Id: I33e38cbd5c2910f4a6dc4cc83c8dc4b6d94fbcff
2023-07-12 17:21:40 +00:00
Ivan Tkachenko e3d4a69749 Merge "Bubble bar drag to dismiss" into udc-qpr-dev 2023-07-12 17:13:50 +00:00
Fengjiang Li ff15fbffec Recreate hotseat predictor whenever we query it due to workspace change
Fix: b/289013842
Test: unit test, also verified moving icons will recreate hotseat predictor
Change-Id: I1f19b17654b87156132a4e4dee26e12312589dba
2023-07-12 10:11:12 -07:00
Mady Mellor e80734c540 Merge changes from topic "mm_bubbleInfoFlags" into udc-qpr-dev am: db3cdd4e97 am: 1bbcc8a90d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24010039

Change-Id: I77ad66e8ce94ff21b4a96f47486d70795d562c83
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-12 16:44:29 +00:00
Mady Mellor 3aa7647db4 Handle any image / label changes for bubble updates in bubble bar am: 1812924a53 am: 36eb8b089d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24010038

Change-Id: Ib9b4850d158996e5e693738913669451edadf7d8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-12 16:44:25 +00:00
Liran Binyamin 1d7494b4a5 Check that the bubble bar has bubbles before showing it
ag/24024252 relied on the bubble bar being invisible to indicate that
the bar is empty. But that assumption was wrong. The bubble bar gets
hidden when the device is locked. The result is that unlocking the
device leaves the bubble bar stashed.

This change actually verifies whether the bubble bar is empty before
showing it.

Fixes: 290608658
Test: Manual:
      - Have some bubbles in the bar
      - Lock the device and unlock
      - Observe that the bubble bar is unstashed
Change-Id: I4ca5c10e0cec57d3c6b4e056e06ebcf04aa1571a
2023-07-12 12:36:25 -04:00
Liran Binyamin d93bb84d9d Merge "Don't show the bubble bar when it is empty" into udc-qpr-dev am: 7dd280eef3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24024252

Change-Id: I7c6a545a1fc71ccbb74d97f702a6a9bc04852ac0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-12 15:34:12 +00:00
Liran Binyamin 7dd280eef3 Merge "Don't show the bubble bar when it is empty" into udc-qpr-dev 2023-07-12 15:09:21 +00:00
Liran Binyamin f8fcd3c9a6 Merge "Pass bubble bar offsets instead of position to WMShell" into udc-qpr-dev am: 2c1e84b3a1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24012984

Change-Id: Id2ca1b1de161e71bea2978e3231f4f1bba2cc22a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-12 14:55:22 +00:00
Liran Binyamin 2c1e84b3a1 Merge "Pass bubble bar offsets instead of position to WMShell" into udc-qpr-dev 2023-07-12 14:41:32 +00:00
Ivan Tkachenko eceb797d2f Bubble bar drag to dismiss
* Added dismiss view to the taskbar
* Bubble drag to dismiss of:
  * A single bubble when the bubble bar stack is expanded
  * All bubbles when the bubble bar stack is colapsed
* Added dismiss related calls to WMShell in SystemUI through SystemUIProxy

Bug: 271466616
Test: manual, TBD
Flag: WM_BUBBLE_BAR
Change-Id: Ibb62a0b1ab9fafa8a3acf07450ce2132ed605adc
2023-07-12 07:13:12 +01:00
Mady Mellor 1bbcc8a90d Merge changes from topic "mm_bubbleInfoFlags" into udc-qpr-dev am: db3cdd4e97
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24010039

Change-Id: Ic0e5a9ce061e1bc892a021c09153572e0c7b164d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-12 01:17:28 +00:00
Mady Mellor 36eb8b089d Handle any image / label changes for bubble updates in bubble bar am: 1812924a53
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24010038

Change-Id: Ib7d204f2bd06f8474613b134d25e9ff08e32c74d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-12 01:17:25 +00:00
Mady Mellor db3cdd4e97 Merge changes from topic "mm_bubbleInfoFlags" into udc-qpr-dev
* changes:
  Show / hide the "update" dot on bubbles in bubble bar
  Handle any image / label changes for bubble updates in bubble bar
2023-07-12 01:00:10 +00:00
Vinit Nayak 0eca85db74 Merge "Dismiss split select when tapping on home button" into udc-qpr-dev am: 64f3766ba7 am: d9fd3f2e58
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23986000

Change-Id: I0d8de9043cedd0468f0642a211d2d841be187346
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-12 00:07:34 +00:00
Vinit Nayak 46b2beea26 Cleanup ENABLE_SPLIT_FROM_WORKSPACE flag
Fixes: 270393906
Flag: none
Test: Compiles
Change-Id: I1431f544b26cef5cd417c9a5a97f183b49fe7adc
2023-07-11 17:05:17 -07:00
Vinit Nayak d9fd3f2e58 Merge "Dismiss split select when tapping on home button" into udc-qpr-dev am: 64f3766ba7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23986000

Change-Id: I6728ffc217017fad591b0ada439b4587197d6352
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-11 23:28:35 +00:00
Vinit Nayak 64f3766ba7 Merge "Dismiss split select when tapping on home button" into udc-qpr-dev 2023-07-11 23:06:47 +00:00
Mady Mellor c299ad645a Show / hide the "update" dot on bubbles in bubble bar
Updates BubbleView to include logic to render the update dot on a
bubble. This only shows for BubbleBarBubbles, not the overflow.

We only show the dot (and the badge) when:
- the bubble has new content / appropriate flags set
- AND the bubbles are expanded
  OR on the first bubble when bubbles are collapsed
- AND when the flyout is not animating (this bit doesn't exist yet)

If a bubble has a dot and is opened, the dot will animate away.
To do this, we update the flags set on a bubble.

The flag needs to be set on WMShell side as well as Launcher side.
When a bubble is shown by WMShell, it automatically updates the flag.
This CL adds code to update the flag on Launcher side when we call
into WMShell to show the bubble.

Test: manual
Bug: 269670235
Change-Id: I32f652effa9a73c567981aa5a2a5864e9c3c0c66
2023-07-11 15:09:29 -07:00
Liran Binyamin 05ef774e6e Don't show the bubble bar when it is empty
Sometimes the bubble bar shows when the launcher process starts up
even when there are no bubbles.

bubblesShowingOnHome is set to true when the launcher transitions into
Home, but that state also triggers a call to showBubbleBar() which will
eventually set the visibility on the bar.
During initialization we also call setHiddenForNoBubbles to hide the bubble
bar if it's empty, but these events happen separately so the bar may or
may not be hidden.

This change avoids calling showBubbleBar when setBubblesShowingOnHome is
called and the bar is invisible. Instead the bubble bar will become visible
once bubbles are added.

Fixes: 290608658
Test: manual
       - Toggle bubbles off and back on in settings
       - Restart launcher
       - Observe the bubble bar is not displayed
Change-Id: I30640764d7b6eae64e1c5b5c687760465bf9a7b1
2023-07-11 17:12:00 -04:00
Mady Mellor d4394e5bd5 Merge "Unify calls to sysuiProxy#showBubble into one method" into udc-qpr-dev am: 3e952e034c am: ecf080eb5c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24010037

Change-Id: Ib2637a8fbf6303f9ce423e218048b98965190ac0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-11 21:09:16 +00:00
Liran Binyamin 1c03ed001d Pass bubble bar offsets instead of position to WMShell
This allows WMShell to calculate the position of the expanded view
correctly when the bubble bar is being expanded from stashed.

Test: See ag/24012908
Change-Id: I7b917e761c827135942d918917c920b06650f496
2023-07-11 17:08:09 -04:00
Brian Isganitis 32c8f4179f Merge "Revert "Revert "Provide AllApps item OnLongClickListener through ActivityContext.""" into udc-qpr-dev am: 1a50287c08 am: 8d3ea8eeb5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24024243

Change-Id: Ia7a8640c6f14742160959d40547c89ed8b6369cc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-11 21:07:22 +00:00
Mady Mellor 1812924a53 Handle any image / label changes for bubble updates in bubble bar
When we get an update to a bubble it could mean that there's a new
message OR that something about the visual representation changed.

This CL modifies BubbleBarController to handle any visual changes
that might have occurred to an updated bubble (e.g. bubble image
changed).

It does this by updating the bubbleInfo on the existing bubble.

Test: manual
Bug: 269670235
Change-Id: I03d2510aef335dafccb32d6adcd4c6adf8b3297d
2023-07-11 13:34:46 -07:00
Mady Mellor ecf080eb5c Merge "Unify calls to sysuiProxy#showBubble into one method" into udc-qpr-dev am: 3e952e034c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24010037

Change-Id: Id9470422fa6e14e59432ef859cde823b3f588aa7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-11 20:28:39 +00:00
Brian Isganitis 8d3ea8eeb5 Merge "Revert "Revert "Provide AllApps item OnLongClickListener through ActivityContext.""" into udc-qpr-dev am: 1a50287c08
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24024243

Change-Id: I3a0e4e72548414078c673742ff1d3768cffc94ea
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-11 20:28:15 +00:00
Mady Mellor 3e952e034c Merge "Unify calls to sysuiProxy#showBubble into one method" into udc-qpr-dev 2023-07-11 20:24:14 +00:00
Brian Isganitis f54c6fa4b4 Revert "Revert "Provide AllApps item OnLongClickListener through ActivityContext.""
This reverts commit 853a5b9e0c.

Fixes SecondaryDisplayLauncher class by using lambda instead of method
reference for #getAllAppsItemLongClickListener. This change is necessary
because mDragLayer is late-init.

Test: Home Settings > Developer Options > Launch Secondary Display
Bug: 289261756
Flag: No
Change-Id: I7b83f81651dde360edea6ee7bea6cc82441e6bef
2023-07-11 13:21:47 -04:00
David Saff 69e4f72c4b Merge "Revert "Provide AllApps item OnLongClickListener through ActivityContext."" into udc-qpr-dev am: aaf3094540 am: 20d1f741b9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24017969

Change-Id: Icf176421f6f3ec05924ac3514c19499ab9c74c9d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-11 13:48:39 +00:00
David Saff 20d1f741b9 Merge "Revert "Provide AllApps item OnLongClickListener through ActivityContext."" into udc-qpr-dev am: aaf3094540
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24017969

Change-Id: I1048ccfe13a8b888d5c3dd6384cb801623e1c7e3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-11 13:12:21 +00:00
David Saff aaf3094540 Merge "Revert "Provide AllApps item OnLongClickListener through ActivityContext."" into udc-qpr-dev 2023-07-11 12:32:36 +00:00
David Saff 853a5b9e0c Revert "Provide AllApps item OnLongClickListener through ActivityContext."
This reverts commit 0acab2532d.

Reason for revert: b/290403189

Change-Id: Ie3f67f78a8ffce8c2d5a92f65a7e74d788c82a81
2023-07-11 10:45:33 +00:00
Schneider Victor-tulias e0600c6bca Handle onFlingFinished onRecentsAnimationStart
If the onRecentsAnimationStart callback runs after the user lifts their finger and onFlingFinished runs, then onFlingFinished never has another chance to run, leaving the user trapped in a state where the launcher is not started and the AllSetActivity is still present but invisible. Reverted to allow onFlingFinished to run onRecentsAnimationStart to handle this edge case.

Flag: not needed
Fixes: 285194839
Test: Ran AllSetActivty with a delay in onRecentsAnimationStart
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:1b2c2e694c6e233057570d3e8b4e5a0aa9c0c51a)
Merged-In: I33ce5c1d4955b34d4b77d3b740dc599621bd4ed1
Change-Id: I33ce5c1d4955b34d4b77d3b740dc599621bd4ed1
2023-07-11 00:39:11 +00:00
Mady Mellor 4e0ec1e458 Unify calls to sysuiProxy#showBubble into one method
This will make it easier to note that a bubble has been "visited"
so that we can hide the update dot (coming in future CL).

Test: manual
Bug: 269670235
Change-Id: Ie2dbbc478198ece65c05927295d3c3031a7be82e
2023-07-10 13:38:15 -07:00
Schneider Victor-tulias 6a86a11ade Merge "Handle onFlingFinished onRecentsAnimationStart" into udc-dev am: 3d1e78a496
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23796565

Change-Id: I93f964f879cf8de5148b256770991d102c86a22d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-10 19:08:36 +00:00
Schneider Victor-tulias 3d1e78a496 Merge "Handle onFlingFinished onRecentsAnimationStart" into udc-dev 2023-07-10 18:33:25 +00:00
Vinit Nayak f6c2e87747 Dismiss split select when tapping on home button
Bug: 276361926
Test: Initate split, dismiss whenever home is pressed,
doesn't dismiss when all apps dragged down
Flag: ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE

Change-Id: Idc95123e27963c3913d04c6eb27f0e4c9b1eb401
2023-07-10 11:06:42 -07:00
Tracy Zhou 13ca2d1263 Merge "Fix icon not showing in staged split from keyboard shortcut" into udc-qpr-dev am: 10b5a3903a am: 35fd1517bc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23996760

Change-Id: Ia14fe62163dc5021c0449df591d21d3d2a91242e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-10 18:06:19 +00:00
Tracy Zhou 35fd1517bc Merge "Fix icon not showing in staged split from keyboard shortcut" into udc-qpr-dev am: 10b5a3903a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23996760

Change-Id: Iceb6e903bd2c83a87b8ebe5289ed4fbfcb324fc6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-10 17:48:09 +00:00