Commit Graph

20478 Commits

Author SHA1 Message Date
Alex Chau 8b692c356b Don't wait for thumbnails to update if updatedThumbnails are empty
Fix: 366205521
Test: Double tap recents button in -1 screen
Test: RecentsViewModelTest
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I3eb854c8068fe70473bde32c5f7706af8d17a3cf
2024-09-16 10:39:23 +01:00
Treehugger Robot bacfdcd39a Merge "Add FLAG_DELAY_TASKBAR_BG_TAG to restrict when taskbar bg anim gets delayed." into main 2024-09-14 04:15:31 +00:00
Jon Miranda 86a4b653b9 Add FLAG_DELAY_TASKBAR_BG_TAG to restrict when taskbar bg anim gets delayed.
We set it only when user swipes up to unstash.

Fixes: 360778703
Test: swipe up to home, long click on taskbar icon before it settles
Flag: com.android.launcher3.enable_scaling_reveal_home_animation
Change-Id: I24ff466ee6730e3739d85307363567cfa1455cbf
2024-09-13 19:08:46 -07:00
Treehugger Robot 41d2d507a3 Merge "Revert "Add screen recording to TaplTestsQuickstep#testQuickSwitchToPreviousAppForTablet"" into main 2024-09-13 23:57:50 +00:00
Ats Jenk 61d45eb8d2 Merge changes I3cfdb715,Ic194afdb into main
* changes:
  Fix initial alpha when unstashing bubble bar
  Set additional bubble translation during stash
2024-09-13 22:38:24 +00:00
Schneider Victor-tulias ef404a786e Revert "Add screen recording to TaplTestsQuickstep#testQuickSwitchToPreviousAppForTablet"
This reverts commit 600c508569.

Reason for revert: test no longer fails
Fixes: 358607191

Change-Id: Ie944a7d79dab03fcb61ca62926929b0b462c1ba6
2024-09-13 21:49:24 +00:00
Treehugger Robot eb269053ba Merge "Remove unecessary uses of LauncherActivityInterface.INSTANCE" into main 2024-09-13 21:47:40 +00:00
Sunny Goyal 4f9ba255a4 Cleaning up some enabled features
Bug: 270394468
Bug: 270393900
Bug: 270390907
Bug: 270390930
Bug: 270390937
Bug: 270391693
Bug: 270391638
Bug: 270395177
Bug: 270395269
Flag: EXEMPT legacy flags cleanup
        ENABLE_SHOW_KEYBOARD_OPTION_IN_ALL_APPS
        ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
        ENABLE_DEVICE_SEARCH
        ENABLE_HIDE_HEADER
        ENABLE_TWOLINE_ALLAPPS
        IME_STICKY_SNACKBAR_EDU
        FOLDER_NAME_MAJORITY_RANKING
        SCROLL_TOP_TO_RESET
        ENABLE_SEARCH_UNINSTALLED_APPS
        ENABLE_HOME_TRANSITION_LISTENER

Test: Presubmit
Change-Id: Ia392c10fc65616405cc4d4a2b8ed566e3bb7d386
2024-09-13 14:24:27 -07:00
Alex Chau ca7df57c08 Reland "Separate desktop and fullscreen carousel"
This reverts commit a555f4ca1b, and relands commit 9420ba7515.

- attachAlpha should only be reset in onRecycle, otherwise applyLoadPlan or moveRunningTaskToFront will unexpectedly reset it via resetViewTransforms. This fixes TaplTestsQuickstep.testQuickSwitchFromApp which assert all visible task must be on the left hand side of the screen during swipe up

Fix: 353950224
Change-Id: If1c1524e435c8007844bcd51d8695a6d3b00450b
2024-09-13 22:00:29 +01:00
Liran Binyamin b30d0b49c7 Fix bubble tx when the bar is collapsed
The previous behavior positioned the second bubble correctly but all
other bubbles behind the second bubble.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 366254467
Test: manual
       - create multiple bubbles in the bubble bar
       - expand and collapse the bubble bar and observe bubbles
         move correctly from right to left when expanding and from
         left to right when collapsing
Change-Id: I1db6daf629826af8d079a27d582e0c7e89fe2289
2024-09-13 16:19:57 -04:00
Bill Yi 0827952dc0 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ic09ee793191a3a0f92fb2d297338a850b5cf6ff3
2024-09-13 11:59:10 -07:00
Ats Jenk 9b4484c974 Show bubble bar when hotseat icons are visible
Fixes a flicker with bubble bar briefly attempting to stash when swiping
up on home screen.
Keeps bubble bar visible when dragging an icon on home screen.

Bug: 365561149
Flag: com.android.wm.shell.enable_bubble_bar
Test: swipe up on home screen, check that bubble bar does not stash
Test: drag a home screen icon, check that bubble bar does not stash
Change-Id: Ic8f4bf6051ed437167f369e8581a631b73e839b2
2024-09-13 11:28:37 -07:00
Ats Jenk 9639315baa Fix initial alpha when unstashing bubble bar
For the stash and unstash animation we use separate timings for the
Bubble views and background. In other animations we animate the entire
bubble bar alpha as one.
To achieve this during unstash animation we set the bubble views and
background alpha to 0. And then set the bar alpha to 1.
Since alpha animation has a delay during unstash, we need to set the
initial values as the start of the entire animation and not just the
alpha part. Otherwise there are flickers in the animation.

We also need to set initial values for the alpha animator that the
AnimatedFloat creates. AnimatedFloat uses the current values as the
start value. If we update it later, the animator was already created and
it won't have an effect. To fix this, we set the start and end values
for the alpha animators created by AnimatedFloat.

Bug: 345488489
Flag: com.android.wm.shell.enable_bubble_bar
Test: slow down animations and unstash bubble bar, check that bubbles
  alpha slowly animates in

Change-Id: I3cfdb715e1703bd2195c809fd77751a216558176
2024-09-13 10:51:11 -07:00
Anushree Ganjam b41def0366 Merge "Add LauncherAppSingleton & LauncherActivityScope to dagger graph (3/n)" into main 2024-09-13 00:45:28 +00:00
mpodolian 04088ebef7 Update placement of the nav bar in persistent taskbar for 3 button nav
Implemented nav bar placement update to be located opposite to the
bubble bar.
When bubble bar is moved to the other side of the bar, 3 button nav will
swap sides (without animation).
If taskbar has to be repositioned it does that with the animation.

Test: TaskbarViewControllerTest
Bug: 346381754
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: Id031706183c60cbd9c67537b01530acb43bae614
2024-09-12 16:42:15 -07:00
Sunny Goyal 5ee3d98641 Cleaning up some enabled features
Flag: EXEMPT LEGACY
		CONTINUOUS_VIEW_TREE_CAPTURE
		ALL_APPS_GONE_VISIBILITY
		ENABLE_BACK_SWIPE_HOME_ANIMATION
		ENABLE_DYNAMIC_TASKBAR_THRESHOLDS
		PREEMPTIVE_UNFOLD_ANIMATION_START
		ENABLE_NEW_GESTURE_NAV_TUTORIAL
		ENABLE_ENFORCED_ROUNDED_CORNERS
		ENABLE_TRACKPAD_GESTURE
		ENABLE_KEYBOARD_QUICK_SWITCH
		ENABLE_KEYBOARD_TASKBAR_TOGGLE
		ENABLE_ALL_APPS_RV_PREINFLATION
Test: Presubmit
Bug: 270395171, 291651514, 270393426, 294252473,
     270397209, 270396257, 270393258, 271010401,
     270396844, 281726846, 288161355

Change-Id: I6ef1e12dfc2203a4cca8e91aa291485f1ff24c42
2024-09-12 15:12:08 -07:00
Alex Chau 98af6a906e Merge "Revert "Separate desktop and fullscreen carousel"" into main 2024-09-12 15:50:41 +00:00
Chaitanya Cheemala (xWF) a555f4ca1b Revert "Separate desktop and fullscreen carousel"
This reverts commit 9420ba7515.

Reason for revert: Likely culprit for b/366196741 and b/366191730

Bug: 353950224
Fix: 366196741
Fix: 366191730
Change-Id: Icc84aaaae1a6bd8b21f059331715fb25163793b8
2024-09-12 15:48:28 +00:00
Treehugger Robot b6332b9947 Merge "Fixing back animation for container views" into main 2024-09-12 13:57:02 +00:00
Liran Binyamin 6138138d99 Merge "Initial screenshot tests for bubble bar view" into main 2024-09-12 13:33:50 +00:00
Alex Chau 9420ba7515 Separate desktop and fullscreen carousel
- setRunningTaskHidden now changes attachAlpha only, stableAlpha is untouched as part of the attach animation, so both alpha can be set independently without interferring with each other
- During swipe up, hide task of differnt type (fullscreen/desktop) from the carousel, apply unhide when the gesture settles
- Update the min/max alpha calculation when a type of task is hidden from the carousel

Fix: 353950224
Test: Quick switch, swipe up, and scroll in Overview with and without Desktop tile, on phone and tablet
Test: presubmit test on quickswitch and swipe up
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Change-Id: I0a63da3ee3e55f4d1edbc53b2a4c5fccda2af387
2024-09-12 09:30:46 +00:00
Vinay Joglekar b3189d8404 Merge "Add keyboard navigation for all large tiles" into main 2024-09-12 09:09:02 +00:00
Sunny Goyal b55d9ca407 Fixing back animation for container views
> Looking up views during back instead of holding the reference
  This allows back animation even if Launcher restarts
> Fixing back animation not working with progressive back
> Fixing container animation overriding Launcher cookie used be gestureNav

Bug: 365866488
Test: Verified manually by enabling flag
Flag: com.android.launcher3.enable_container_return_animations
Change-Id: Ic235b238cca6a31e9a5502200ff6b07c72b4e4d7
2024-09-12 00:51:07 -07:00
Treehugger Robot 206e15b286 Merge "Move DesktopVisibilityController to TouchInteractionService" into main 2024-09-12 02:32:00 +00:00
Ats Jenk aad71bc532 Set additional bubble translation during stash
Fixes bubbles stash translation not getting cleared up after stash
animation finishes.

Bubbles are clipped using an outline animator during the stash
animation. They need separate translation applied to keep them within
the bounds of the bubble bar that is also shrinking and moving.

Set the translation for the bubbles in the stash controller so we can
reset the translation after the animation has finished.

Bug: 365829293
Flag: com.android.wm.shell.enable_bubble_bar
Test: TransientBubbleStashControllerTest
Test: have bubbles in bubble bar, trigger a new auto expanding bubble,
  check translation for bubbles
Change-Id: Ic194afdb4d650fcd525355d8bae08dd651d1ea05
2024-09-11 16:29:22 -07:00
Treehugger Robot 072d2e46b6 Merge "Cancel the stash animation if the stash controller is destroyed before then" into main 2024-09-11 21:01:36 +00:00
Anushree Ganjam fbc0f97410 Add LauncherAppSingleton & LauncherActivityScope to dagger graph (3/n)
* Add ApplicationContext qualifier and binding the application context instance so
that this context is available across dagger graph.

* Add QuickStepModule and LoggingModule
* Provide SettingsChangeLogger in dagger way. We are depending on
  MainThreadInitializedObject for cleanup. We need to define a way
  explicitly see how we can destroy singleton objects.

Bug: 361850561
Test: Manual
Flag: NONE Dagger Integration
Change-Id: Ia10cc500edb1d88adcca540119651f59b9bc8dc8
2024-09-11 13:56:23 -07:00
Sunny Goyal 8f8932b0f8 Merge "Adding open/close animartion when launching app-info target" into main 2024-09-11 20:31:34 +00:00
Mady Mellor f12caec1d0 Merge "Fix the overflow not being added sometimes" into main 2024-09-11 19:21:53 +00:00
Treehugger Robot e698c7237a Merge "Disallow long click on taskbar icons while animating home." into main 2024-09-11 19:08:24 +00:00
Treehugger Robot 7c9d8f9451 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-09-11 17:32:13 +00:00
Mady Mellor bd446142ae Fix the overflow not being added sometimes
The runnable to add the overflow was only being run when the view
was animated (i.e. while expanded); not when it was collapsed.

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 358304168
Test: manual - add more than 5 bubbles while collapsed
Change-Id: Ibdea61eaf8ecb1d2e3f9ea4fced679b2826d3f9b
2024-09-11 10:24:31 -07:00
Schneider Victor-Tulias 2b46c945a7 Move DesktopVisibilityController to TouchInteractionService
Moved DesktopVisibilityController to TIS for 3P launcher support.

Flag: EXEMPT bug fix
Fixes: 338063030
Fixes: 357859025
Test: Launched overview and resumed desktop task from desktop mode on 1P and 3P launchers
Change-Id: I64e99a32ed13bcb6e4a81a18c29df2643373dc35
2024-09-11 09:56:35 -07:00
vinayjoglekar 941a9e4f98 Add keyboard navigation for all large tiles
Currently large tiles are excluded from adding into collection which is used for keyboard navigation. This cl adds them if desktop windowing tile is enabled.

Test: TaskGridNavHelperTest
BUG: 361070854
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Change-Id: I63fbb6867c34bbd80df926d750a7a392860b70a0
2024-09-11 16:02:18 +01:00
Bill Yi adf8f378f3 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ibd88f5661e8ac07299137750c72a3669bd2a8dc2
2024-09-10 18:14:46 -07:00
Treehugger Robot 746d3e58fe Merge "Do not delay taskbar background animation when closing taskbar all apps." into main 2024-09-10 23:47:32 +00:00
Winson Chung 715b90fdb5 Merge "7/ Remove legacy recents animation controller no-op calls" into main 2024-09-10 21:49:59 +00:00
Treehugger Robot d41fe34ed1 Merge "Removing obsolete flags" into main 2024-09-10 21:29:09 +00:00
Sunny Goyal 65342edc89 Removing obsolete flags
Flag: EXEMPT legacy ENABLE_PARAMETRIZE_REORDER, KEYGUARD_ANIMATION, ENABLE_SCRIM_FOR_APP_LAUNCH
Bug: 289420844
Bug: 270390904
Bug: 270393276
Test: Verified manually
Change-Id: I0eb166168100419fdf4d264f7ccddeeba86524b7
2024-09-10 21:24:47 +00:00
Schneider Victor-Tulias 5945b311e2 Remove unecessary uses of LauncherActivityInterface.INSTANCE
Using LauncherActivityInterface.INSTANCE directly causes easy-to-miss issues with 3P launcher support. Removing all unecessary uses.

Flag: EXEMPT code cleanup
Fixes: 365827636
Test: ran launcher on 1P and 3P launcher
Change-Id: Ief227a682db3dd8ad378273b76936b29ef51d017
2024-09-10 13:52:13 -07:00
Sunny Goyal cb98fb26b8 Adding open/close animartion when launching app-info target
Bug: 356914468
Test: Verified manually
Flag: EXEMPT bugfix
Change-Id: I3a4e48363728153a96c75466824fb03de44c0ad9
2024-09-10 13:35:46 -07:00
Treehugger Robot 491e82df86 Merge "Improve the visibility of allapps item on talkback focus" into main 2024-09-10 20:32:39 +00:00
Jon Miranda ff72d154d7 Do not delay taskbar background animation when closing taskbar all apps.
Fixes: 362379633
Flag: EXEMPT bugfix
Test: open app, unstash transient taskbar, open Taskbar All Apps, close it
Change-Id: I0819ae12bd599be051cb0da4091ab02d0759984c
2024-09-10 12:13:39 -07:00
Jon Miranda 11a8ed8a53 Disallow long click on taskbar icons while animating home.
Fixes: 360778703
Test: swipe up to home, long click on taskbar icon before it settles
Flag: EXEMPT bugfix
Change-Id: I3c46b43b6b9c44b91c2516c9db453d3fa3692b00
2024-09-10 11:17:46 -07:00
Ats Jenk d72a0400eb Merge changes I485f6346,I24b0c646 into main
* changes:
  Animate alpha for bubbles and background (3/n)
  Use a reveal animator for bubble icons (2/n)
2024-09-10 18:03:00 +00:00
Liran Binyamin 3a2a7685b0 Initial screenshot tests for bubble bar view
Flag: com.android.wm.shell.enable_bubble_bar
Bug: 355454021
Test: atest BubbleBarViewScreenshotTests
Change-Id: Id74c78d99a8b4528bb473c5a751edb19bda34007
2024-09-10 13:59:01 -04:00
Liam Lee Pong Lam f9efc54493 Improve the visibility of allapps item on talkback focus
result: https://photos.app.goo.gl/TqTDboxa2WFfZUoz8

Flag: com.android.launcher3.accessibility_scroll_on_allapps
Bug: 265392261
Test: Manual

Change-Id: If1cce3d0bd501361837dafb24cbe2fde7bac0ac0
2024-09-10 17:40:14 +00:00
Jagrut Desai 3405c0425a Merge "Fix Taskbar Container not being aligned center in 3 button nav mode" into main 2024-09-10 16:28:23 +00:00
Treehugger Robot a926663c46 Merge "Removing obsolete flags" into main 2024-09-10 09:25:51 +00:00
Sunny Goyal b60b5bd594 Merge "Adding more properties in LaunchCookie, instead of just itemId This allows better matching of items who do not have a fixed id" into main 2024-09-10 07:33:41 +00:00