Commit Graph

20478 Commits

Author SHA1 Message Date
Vinit Nayak eabb37822f Merge "Change SplitInstructionsView cancel from X to "Cancel"" into main 2023-11-29 00:18:42 +00:00
Vinit Nayak 33a432a3c4 Pass through both the widget's pendingIntent and remoteView intent
* Both may be necessary to correctly launch a widget
* We pass it through as the second app's Bundle instead
of adding a new parameter.

Bug: 311263727
Test: Tested w/ 2 fresh launches, app + widget.
Also with existing task + widget.
Was not able to accurately test multiple tasks launched by the
widget since there are some issues with the allowlist check.
And the working case for multiple instances of Chrome didn't
work because none of the chrome widgets rely on the secondary
intent to launch any of the app's activities.
Flag: None, technically this code isn't reachable since widgets
are unsupported, but didn't seem worthwhile to add a separate flag
in the short duration we will begin supporting them again.
To run replace the early return in QuickstepInteractionHandler with
the call:
mLauncher.getSplitToWorkspaceController()
	.handleSecondWidgetSelectionForSplit(view, pendingIntent, options.first)

Change-Id: I1ebcb385b140d42a6a84368f589aba06c4bed2bd
2023-11-28 14:58:44 -08:00
Vinit Nayak e5277ab8e7 Remove unused animation of splitInstructionsView text
* The animation of the overall view is
sufficient and we don't need this separate one

Flag: None
Bug: 295983387
Test: Visually appears the same
Change-Id: I6e3fe7191df8af869a50abab820d30e95e23696c
2023-11-28 14:39:18 -08:00
Pat Manning ad6b044412 Adjust app chip menu top margin.
Include adjusting gap of menu when expanding app chip.

Fix: 313648444
Test: OverviewImageTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Change-Id: Iea8ea76873ac008b90b6a8f183dc99cba9237041
2023-11-28 22:38:22 +00:00
Vinit Nayak d6efde5cbb Change SplitInstructionsView cancel from X to "Cancel"
* Styling (accent color) is still a TODO,
just made it bold for now.

Flag: ACONFIG com.android.wm.shell.enable_split_contextual DEVELOPMENT
Bug: 295983387
Test: Tested w/ flag on and off, cancel doesn't show
with flag off

Change-Id: Id5214a86abbe0cf095e32f6f75522ea51d6b1f3c
2023-11-28 14:34:12 -08:00
Johannes Gallmann 8c197b9328 Merge "Fix task window losing scale when going back to home" into main 2023-11-28 20:35:13 +00:00
Johannes Gallmann b4f33ab7bb Merge "Fix crash in LauncherBackAnimationController" into main 2023-11-28 20:34:10 +00:00
Saumya Prakash 5feb491549 Add taskbar pinning education for new users and update other steps
This change updates the current transient taskbar education to include
the pinning feature and additional updates to Lottie animations. It also
removes the tutorial that teaches users to switch navigation modes. The
pinning education is gated behind an additional pinning education static flag.

Fixes: 302588455,300161174
Test: Went through taskbar education for persistent and transient
taskbar with the flag on and off.
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED

Change-Id: I836467091bfe694eee89ac46c4be597c490e1b3f
2023-11-28 20:20:25 +00:00
Schneider Victor-tulias 812bc2a9c5 Merge "Refactor LottieAnimationColorUtils to enforce proper usage" into main 2023-11-28 19:49:36 +00:00
Schneider Victor-tulias 891865dd60 Merge "Fix NPE in TaskAnimationManager" into main 2023-11-28 19:49:22 +00:00
Sunny Goyal eb67c99e5f Merge "Removing unnecessary iconFactory class when generating badged icon" into main 2023-11-28 19:02:02 +00:00
Sebastián Franco 4a708997a1 Merge "Moving the static initialization method from TaplTestsLauncher3 to AbstractLauncherUiTest" into main 2023-11-28 18:32:58 +00:00
Sergey Pinkevich d3087e3c16 Merge "Fix blinking for the active tile" into main 2023-11-28 18:31:07 +00:00
Tracy Zhou 898aec864d Merge "[taskbar/navbar unification] Do not shift back button after unlocking in phone mode" into main 2023-11-28 18:20:58 +00:00
Andy Wickham 9e6f276d41 Merge "Adds withPackageName to StatsLogger creation" into main 2023-11-28 17:15:55 +00:00
Schneider Victor-tulias e861fa05bc Merge "Refactor ActiveGestureLog and CompoundString in preparation for ProtoLog 2.0" into main 2023-11-28 16:23:47 +00:00
Schneider Victor-tulias ed2eba9beb Refactor ActiveGestureLog and CompoundString in preparation for ProtoLog 2.0
We will need to send formatted strings to the ProtoLog api, so it is simpler to use CompoundString as the default string storage in ActiveGestureLog.

Refactored CompoundString to be able to be broken down into a formattable string.

Flag: N/A
Fixes: 313640579
Test: ran launcher, completed gestures, dumped gesture logs
Change-Id: I5f290d1860c6bac5047cbf361537829fbe986685
2023-11-28 16:23:38 +00:00
Helen Cheuk 4a6d4994c3 Merge "Remove excess entry before putting new item" into main 2023-11-28 13:03:53 +00:00
Sergey Pinkevich 6c7ddc9b90 Fix blinking for the active tile
Call of `buildAnimationController` within `View#onApplyWindowInsets` if endTarget is not null.

Bug: 312439564
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Test: manual - took a screen recording:
Before - https://drive.google.com/file/d/1P2GsTi0xCZFjAsTQKonMMADHGkKuxMe0/view?usp=sharing
After - https://drive.google.com/file/d/1xkbFa-2Xp1OwmPrKLcqE2cYshVRXY2YV/view?usp=sharing

Change-Id: I6eb2a48bb548e20c1d36a058921ff8e1a0983cad
2023-11-28 12:24:40 +00:00
Johannes Gallmann 1de8952a30 Fix task window losing scale when going back to home
Bug: 305934426
Flag: NONE
Test: Manual, i.e. testing back to home with different devices and device orientations
Change-Id: I3eddbc918de95be713aecb469501b01e6b7b3d3b
2023-11-28 11:33:29 +01:00
Vadim Tryshev 8f2dc92364 Merge "Permanently demoting stress tests from presubmit to speed up presubmits" into main 2023-11-28 02:38:25 +00:00
Federico Baron f378be865d Merge "Fix activity leak in QuickstepLauncher" into main 2023-11-28 00:02:30 +00:00
Sunny Goyal 0069e54f1e Removing unnecessary iconFactory class when generating badged icon
Bug: 276957152
Test: Verified on device
Flag: None
Change-Id: I31ca3ef939684b16c0134d19f0add574b4b59706
2023-11-27 15:44:31 -08:00
Vadim Tryshev 5feaf596e6 Permanently demoting stress tests from presubmit to speed up presubmits
Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: Ib2edf419ad556d2a4bf5c77b5c026829f9b413b9
2023-11-27 11:54:22 -08:00
fbaron c04ad685f5 Fix activity leak in QuickstepLauncher
Fix: 312397873
Test: TaplAppIconMenuTest#testLaunchMenuItem
Flag: NONE
Change-Id: I63fe5fa5b3f2d301017dc6fb375e7a56e3e5fb4d
2023-11-27 18:10:45 +00:00
helencheuk f2fc14ec4c Remove excess entry before putting new item
It is to fix gpu memory usage increase. Remove excess entry first so its max memory usage should not increase

Fix: 309182285
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Test: N/A
Change-Id: I40b4ec50c09001e6ee9d012bdcdd1444230daac3
2023-11-27 14:57:38 +00:00
Helen Cheuk 946a2493eb Merge "Not show hover border on select mode" into main 2023-11-27 14:21:29 +00:00
Pat Manning 0f395e8a11 Update text style for icon app chip menu.
Bug: 311657856
Test: OverviewImageTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Change-Id: Ied1c5fddb94e3093729846cacfef9b257aad8df7
2023-11-25 11:24:45 +00:00
Alex Chau c95a4e6b1d Merge "Revert "Remove logs for bug investigation"" into main 2023-11-24 14:02:39 +00:00
Pat Manning 78a2dd66b2 Merge "Close allapps on press of ESC key." into main 2023-11-24 12:30:04 +00:00
Pat Manning a7a04fe901 Close allapps on press of ESC key.
Fix: 310206847
Test: TaplOpenCloseAllApps
Flag: NONE
Change-Id: I9b9f958eb2889680b731dd7134fce2793e62eb74
2023-11-24 11:03:13 +00:00
Johannes Gallmann e36c615716 Fix crash in LauncherBackAnimationController
Bug: 312949302
Flag: NONE
Test: Manual, i.e. testing quick fling back to home gesture
Change-Id: I670b2f02cab097b1d7a202a5b07fbda33d372ac8
2023-11-24 10:11:46 +01:00
Sebastián Franco 525b0343f8 Merge "Moving classes inside of CellLayout to their own file" into main 2023-11-24 01:27:13 +00:00
Sebastian Franco 5f0af4f633 Moving classes inside of CellLayout to their own file
This is a no-op change ensure this we have ReorderAlgorithmUnitTest.

Flag: NA
Bug: 229292911
Test: ReorderAlgorithmUnitTest
Change-Id: I6ffe2a1260f869a4686a9f1e652dd1ab6d406269
2023-11-23 23:13:56 +00:00
Schneider Victor-tulias 2b988e5fd2 Fix NPE in TaskAnimationManager
Flag: N/A
Fixes: 312949734
Test: ran launcher and launched overview from home and app
Change-Id: I7894749ac196dfd07b5e2bfa5d801040ef9b34c6
2023-11-23 14:16:17 -05:00
Alex Chau 58a8c12713 Revert "Remove logs for bug investigation"
This reverts commit dad61a0098.

Reason for revert: b/279059025

Change-Id: Id8fcd1ddf67d7df0a23c81e3ddf3849c26c529bd
2023-11-23 19:01:16 +00:00
Schneider Victor-tulias 71afdf2f19 Refactor LottieAnimationColorUtils to enforce proper usage
Flag: N/A
Fixes: 312941637
Test: launched all set page and gesture nav tutorial
Change-Id: Iaa320fea0e78a93c4e955f617cb821a47aac6f96
2023-11-23 18:28:10 +00:00
Pat Manning 3e43b8a996 Merge "Do not hide icon app chip menu when resetting color tint." into main 2023-11-23 14:23:24 +00:00
Pat Manning c078064450 Do not hide icon app chip menu when resetting color tint.
Fix: 312372713
Test: Manual.
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Change-Id: Iab860eb7e69ddb47913b01040ca706a8d829abe6
2023-11-23 12:25:02 +00:00
helencheuk b4cda2adbe Not show hover border on select mode
Fix: 295175854
Test: TaskViewTest
Flag: ACONFIG com.android.launcher3.enable_cursor_hover_states Nextfood
Change-Id: I81b1af27b590ea509e8ec84a9d3ff008f31da21f
2023-11-23 10:51:58 +00:00
Sebastian Franco 0e02d74cbf Moving the static initialization method from TaplTestsLauncher3 to AbstractLauncherUiTest
Flag: NA
Bug: 298234173
Test: atest TaplWorkspaceTest
Change-Id: I49dadefa17ef0ea78ca342b8b6d7bb9e38d4d0c9
2023-11-22 12:43:44 -06:00
Tracy Zhou 7ce0d39c41 [taskbar/navbar unification] Do not shift back button after unlocking in phone mode
Fixes: 312495129
Test: Back button doesn't move (stay on the left side) when unlocking from the small screen. Back button shifts from the right side to the final position after unlocking from the big screen
Change-Id: Idd9379cee0a0be49c443ee485b4dc0f4ea248366
2023-11-21 19:19:14 -08:00
Bill Yi 66f0200e50 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ie7f789feff97a375ab542ea6fc7fd841c66dc15e
2023-11-21 16:55:56 -08:00
Andy Wickham 2aee5ff67a Adds withPackageName to StatsLogger creation
This lets you specify a package name which will be logged by the
returned StatsLogger (rather than retrieving from the ItemInfo).

Bug: 292227499
Test: Manual with other change in topic
Change-Id: I3650f9f02f6cbe560e1c21262ba1cb893702a49e
2023-11-21 15:41:50 -08:00
Pat Manning 37edf2ed08 Merge "Add background to app chip menu so elevation shadow renders." into main 2023-11-21 18:09:32 +00:00
Andreas Agvard e55daa9449 Merge "Adds recovery flow for Search feature" into main 2023-11-21 15:16:28 +00:00
Pat Manning 4c5ea5fd02 Show taskbar pinning dialog on right-click.
Fix: 308768942
Test: Manual.
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED
Change-Id: I37e49452fada944186c8300562061bf9650a0d0a
2023-11-21 14:51:15 +00:00
Pat Manning 06ecd24ee3 Allow right-click of taskbar icons to launch long-click menu.
Fix: 290459491
Test: TaplTestsTaskbar#testOpenMenuViaRightClick
Flag: NONE.
Change-Id: Ide85f62e5b08d5261f15871e85d3250cc66d0919
2023-11-21 14:45:31 +00:00
Andreas Agvard b4be53477c Adds recovery flow for Search feature
Bug: 308840938
Flag: LEGACY ENABLE_LONG_PRESS_NAV_HANDLE TEAMFOOD
Test: Manual
Change-Id: Ia1dc7c644647503453c3f810569126fcb6407a5d
2023-11-21 13:36:18 +01:00
Sanatt Abrol a6b4e1bc43 Bug: b/307278302
Fix clipping of DesktopTaskView border on focus/ hover

Hover border: https://screenshot.googleplex.com/B9CUW49q6inMW75
Focus border: https://screenshot.googleplex.com/36uLJ4jC295t7PZ

`android:clipToOutline` prevents drawing outside view bounds and results in the focus/ hover border getting clipped, instead we can use `android:clipToPadding` with a small non-zero padding to clip children and allow drawing a border outside the bounds

Change-Id: I7e763f7ee8c7fd1090c7778c2c000d2b792bef06
2023-11-21 10:48:08 +00:00