Commit Graph

20478 Commits

Author SHA1 Message Date
Charlie Anderson 489f1ada5c Add wrapper for logging backup & restore metrics from Launcher
Bug: 25177913
Flag: ACONFIG com.android.launcher3.enable_launcher_br_metrics DEVELOPMENT
Test: locally

Change-Id: I220721f705eb7244a1f13ef8997682999d799f51
2023-12-11 17:01:28 -05:00
Tracy Zhou 6c24bf7c8e Merge "Do not set isImmersive in TaskbarDelegate" into main 2023-12-11 22:00:33 +00:00
Tracy Zhou 901b190153 Merge "Pass in navigation bar panel context created by task bar when taskbar navbar unification is on" into main 2023-12-11 21:47:59 +00:00
Sebastián Franco 1b86ab623f Merge "Testing if the test failing is because of an incorrect state" into main 2023-12-11 21:47:24 +00:00
Brian Isganitis 7eae1e6124 Split AFVs that controller should not intercept from TYPE_ACCESSIBLE.
TYPE_ACCESSIBLE no longer works for certain cases (see bug). This also
simplifies TouchControllers that would otherwise add or remove from
TYPE_ACCESSIBLE (such as ALL_APPS_EDU and TASKBAR_OVERLAYS).

Fix: 315507902
Test: Manual
Flag: N/A
Change-Id: I6f5d218dab87a8bcc8e7805d0ced9a6678f09c8e
2023-12-11 21:31:38 +00:00
Saumya Prakash ec514d054c Check that onAttach() is called before onResume() to prevent NPE.
Sometimes, the context is null in TutorialController which leads to an
NPE when relying on context specific functions. This change checks that
context is null and if so, defers the context specific functions that are
called until after onAttach() is called.

Fix: 307781152
Test: Set context to null in onResume() and check that the tutorial
continues like normal
Flag: None

Change-Id: I66e345f8361315787534bb88b9c1d12278708d78
2023-12-11 15:59:24 -05:00
Sebastian Franco 08d31d2595 Testing if the test failing is because of an incorrect state
Bug: 315525621
Flag: NA
Test: TaplTestsQuickstep#testPressBack
Change-Id: Iba41abac8e808fadd9e0513d8c0386bbfd63fdd6
2023-12-11 20:39:15 +00:00
Brian Isganitis 36ffc96382 Have Taskbar overlay window consume IME insets.
Test: Manual
Flag: N/A
Fix: 301321668
Change-Id: Ia12dec7560bd3a0269a9efdccaecc032c70b1630
2023-12-11 19:50:53 +00:00
Brandon Dayauon 96901c4541 Include a developer option sliding flag to toggle the different amount of apps to show
Bug: 299294792
Test: Verified SearchTransitionController didn't regress by turning off BACKGROUND_DRAWABLES flag.
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space DEVELOPMENT
Change-Id: I78ee3a9dbc2d60f1b7acaa5834a8c656217a07d8
2023-12-11 11:27:31 -08:00
Sergey Pinkevich 83462a488b Update secondary grid translation
In order to properly animate task on the vertical axis we need to update `taskSecondaryTranslation`.

Bug: 304782953
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Test: manual

Change-Id: I1afe78d4eb1575e9c967ff594cffedd7d3620541
2023-12-11 15:25:29 +00:00
Tracy Zhou f3e5382042 Do not set isImmersive in TaskbarDelegate
allow_gesture and immersive_mode are opposite of each other, and currently we set one or another, check one or another in different places. We should consolidate the two. Hence, we are removing all references of immersive_mode (allow_gesture has more usages).

Bug: 313033827
Test: N/A
Change-Id: I52d86c37cb39ef0bc04a04a0fa78d2b051a0e56e
2023-12-10 21:18:22 -08:00
Jeremy Sim 23fcbf2f73 App Pairs: Launch animation
[App Pairs 7/?]

This patch implements the app pair launch animation from icon. Adds a new function, composeFadeInSplitLaunchAnimator(), in SplitAnimationController, that builds the combined launcher + shell animation.

Bug: 309618233
Flag: ACONFIG com.android.wm.shell.enable_app_pairs DEVELOPMENT
Test: Manual
Change-Id: I8e95f629ae2a71f1bd6cbb356f5e33233e5c2906
2023-12-11 13:09:06 +09:00
Jeremy Sim d761f5c3bd Merge "App Pairs: Implement Taskbar functionality" into main 2023-12-09 02:20:45 +00:00
Vadim Tryshev 151751c014 Merge "Fixing non-sending wallpaper animation finish event" into main 2023-12-08 23:33:53 +00:00
Jeremy Sim 2987d95ba4 App Pairs: Implement Taskbar functionality
[App Pairs 8/?]

This CL adds taskbar functionality for app pairs:
- Ability to drag an app pair icon to Taskbar
- App pair launch from Home Taskbar
- App pair launch from Overview Taskbar
- App pair launch from in-app Taskbar

KNOWN ISSUES:
- Bug (b/315190686): if user is inside a running split pair and attempts to launch the same pair from an app pair icon on taskbar, Overview tiles get temporarily messed up (recoverable by leaving Overview)
- User can attempt to split with an app pair icon on the Taskbar. This should result in a "can't split with this" bounce animation on the SplitInstructionsView (to be implemented). Currently does nothing.

Bug: 274835596
Flag: ACONFIG com.android.wm.shell.enable_app_pairs DEVELOPMENT
Test: Manual
Change-Id: I5256547af236fc2deeb192d60bfe1f2b7ddc5647
2023-12-08 15:07:45 -08:00
Saumya Prakash 55fdc45ecc Merge "Ensure Taskbar stashes when launching an app from folder" into main 2023-12-08 22:59:45 +00:00
Sunny Goyal 41aca1e7b3 Adding support for getting task overlay
Test: Verified the flow in Launcher
Bug: 273828110
Flag: LEGACY USE_ACTIVITY_OVERLAY DISABLED

Change-Id: Ia61f4f165e328335820a33ceea2b810ac5e6c3af
2023-12-08 14:39:50 -08:00
Vinit Nayak fe22e7fa4d Merge "Only launch from split taskView if it's visible to user" into main 2023-12-08 22:34:33 +00:00
Vadim Tryshev 3277cbdb17 Fixing non-sending wallpaper animation finish event
Wallpaper animation may be interrupted with an animation to go to Normal state.
Then the animation won't succeed, but it will still end.

Bug: 315074923
Flag: N/A
Test: presubmit
Change-Id: I15a106de78030f6935978539d333cc85ee95b4e7
2023-12-08 14:11:55 -08:00
Saumya Prakash 86285d477d Ensure Taskbar stashes when launching an app from folder
We use the folder closing callback to trigger a call to stash the
taskbar if an app was launched. We can check whether an app was launched
from a folder based on whether a folder's view is open when
an app is launched. This ensures that the taskbar only stashes after the
folder is done animating.

Flag: NA
Fix: 295296529
Test: Launched an app in a folder on taskbar. Also ensured that other
taskbar behavior remains unchanged.

Change-Id: Ib5a797186978ee960e44b6b62c833eead03bccd0
2023-12-08 20:16:15 +00:00
Vadim Tryshev 229a181771 Disabling ViewCaptureRule
Looks like vire capture needs some time to stabilize; for now,
 it sometimes generates empty view capture data.

Bug: 315482167
Flag: N/A
Test: presubmit
Change-Id: I864ffacf4a3a28cfc01b300ac1df71890f93c5e1
2023-12-08 10:44:48 -08:00
Xin Li 861ce33a59 Merge UQ1A.231205.015
Bug: 308969284
Merged-In: I91dd8b4088f02af9dc5e603853d8e26606acc38f
Change-Id: I7f5bca7edd18631b36f2b9213e17554cf769cbc6
2023-12-07 15:48:03 -08:00
Vinit Nayak 14f3a795e1 Only launch from split taskView if it's visible to user
* Same logic that fullscreen tasks use to launch.
* If not on-screen it will use default fade in animation

Test: Repro-steps don't produce crash
Fixes: 313911097
Flag: None
Change-Id: I4ada7137bffc7c567e4f8184bdd65bdf9bad481e
2023-12-07 15:04:16 -08:00
Vadim Tryshev 76dd9d4eb9 Inserting waiting for wallpaper animation into "back" gesture from app to workspace
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: Ib0f6d62de5caba00823618bdf661d0e4f27e5650
2023-12-07 14:50:42 -08:00
Sebastian Franco 957e4e513e Make all tapl test start with Tapl
Flag: NA
Bug: 298234173
Test: only test name change
Change-Id: Ib2e67a569599568cf1e681a7f1ac44924da83b84
2023-12-07 22:27:53 +00:00
Will Leshner 531fc4985b Handle widget taps in WidgetPickerActivity.
Bug: 307306823
Test: atest Launcher3Tests
Flag: NA
Change-Id: I05cd42eae91447cfe99165096a735f6e04257203
2023-12-07 13:53:45 -08:00
William Leshner 5836cec7ec Merge "Show Launcher's widget picker in an activity." into main 2023-12-07 19:23:58 +00:00
Jagrut Desai a473968d24 Merge "Fixing/Adding Support for "Move to top/left" and "Move to bottom/right" Talkback Menu Item Action" into main 2023-12-07 19:11:51 +00:00
Tony Wickham 1482ec384c Merge "Remove ENABLE_TRANSIENT_TASKBAR and long-press stash support" into main 2023-12-07 19:11:07 +00:00
Johannes Gallmann 661f96066e Fix predictive back to home with pinned taskbar
Bug: 309969400
Flag: ACONFIG com.android.window.flags.predictive_back_system_animations DISABLED
Test: Manual, i.e. testing predictive back with pinned taskbar
Change-Id: Ic6f747e87f8ebb2bed58f4783736ed4dca43fb7e
2023-12-07 15:51:46 +01:00
Greg Kaiser d806c0abd1 Merge "Revert^3 "Refactor/clean up Overview Actions buttons"" into main 2023-12-07 14:06:19 +00:00
Greg Kaiser e8b1d45485 Revert^3 "Refactor/clean up Overview Actions buttons"
6b99fe1a00

Change-Id: I8f4054335b7bdee898ce3943f4a3798ba51c6fbc
2023-12-07 13:54:39 +00:00
Bill Yi aa84ba761e Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2023-12-07 00:09:23 +00:00
Andy Wickham fa1b3bd05b Merge "Improve touch finished logging" into main 2023-12-06 23:01:19 +00:00
Tony Wickham 18551f29fe Remove ENABLE_TRANSIENT_TASKBAR and long-press stash support
Flag: NA
Test: manual, TaplTestsTaskbar, TaplTestsPersistent, TaplTestsTransient
Fixes: 270395798
Change-Id: I4ecf5ddcd1206e846538175c684043c5e065fd5d
2023-12-06 22:13:10 +00:00
Vinit Nayak 5aac28a031 Merge "Revert^2 "Refactor/clean up Overview Actions buttons"" into main 2023-12-06 18:49:27 +00:00
Tony Wickham 5a26b1ce0f Merge "Change TAPL to swipe to stash taskbar (instead of deprecated long press)" into main 2023-12-06 18:06:44 +00:00
Sunny Goyal 0d152a5bf6 Merge "Revert "Revert "Removing unnecessary iconFactory class when gene..."" into main 2023-12-06 16:11:43 +00:00
Andreas Agvard cad2f1ed9c Improve touch finished logging
Test: Manual
Bug: 314993218
Flag: N/A
Change-Id: I1cf827ed3125071b722c617c384350b53e57fac5
2023-12-06 15:52:57 +01:00
Bill Yi 42dc5249ad Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ia0be1d60e62b547645acee5bb5e34af457ade67c
2023-12-05 18:25:53 -08:00
Vadim Tryshev 42476cc355 Merge "Waiting for wallpaper animation completion when configuring new widget" into main 2023-12-06 01:43:07 +00:00
Vinit Nayak 7b7dca38cb Merge "Pass through both the widget's pendingIntent and remoteView intent" into main 2023-12-06 01:24:05 +00:00
Jagrut Desai 66283595b9 Fixing/Adding Support for "Move to top/left" and "Move to bottom/right" Talkback Menu Item Action
Test: Manual
Bug: 307878012
Flag: NONE
Change-Id: I9d80c3c976193bfea911e1531ed180f4ee4aa8f5
2023-12-05 13:55:49 -08:00
Vadim Tryshev 61434924f0 Waiting for wallpaper animation completion when configuring new widget
This will help to ensure that Launcher state has settled before continuing the test.

Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: Ice7ae8a2517d68c53d135a34cc33e11f3203f788
2023-12-05 13:32:41 -08:00
Will Leshner 9dce65e05a Show Launcher's widget picker in an activity.
Bug: 307306823
Test: atest Launcher3Tests
Flag: NA

Change-Id: I28ef731abcdf1bd44c66366d42a135912dbcc5be
2023-12-05 13:12:05 -08:00
Tracy Zhou 7fae462565 Pass in navigation bar panel context created by task bar when taskbar navbar unification is on
When the flag is on, task bar is created with window context navigation bar. The floating rotation button window context should be in navigation bar panel.

Fixes: 309930089
Test: N/A
Change-Id: I730a4b898d9fb65cc5d7544dcb37dfe32d49a632
2023-12-05 12:53:51 -08:00
Tony Wickham d546564f3e Change TAPL to swipe to stash taskbar (instead of deprecated long press)
This also means Taskbar is transient by default in automated tests,
instead of persistent. Updated some checks accordingly.

Flag: LEGACY ENABLE_TRANSIENT_TASKBAR ENABLED
Test: TaskbarExpandCollapse#hideShowTaskbar; TaplTestsTaskbar;
TaplTestsTransientTaskbar; TaplTestsPersistentTaskbar
Bug: 270395798

Change-Id: Ie7b8fcedb94e33742b7bf18cb829dab55af74b7d
2023-12-05 20:38:41 +00:00
Sunny Goyal 1aaa3aa795 Merge "Revert^3 "Changing SystemUiProxy to kotlin"" into main 2023-12-05 17:23:24 +00:00
Tracy Zhou d4235f504b Merge "Do not apply rounded corner background to task bar when it's in phone mode" into main 2023-12-05 16:55:26 +00:00
Andreas Agvard 52b5113e8d Merge "Adds supportsCommitHaptic" into main 2023-12-05 12:48:15 +00:00