Commit Graph

20478 Commits

Author SHA1 Message Date
Anushree Ganjam 59ab86218b Fill CellX , CellY and Rank for predictionRowView iteminfo.
HotseatPreditionController already does this: https://source.corp.google.com/h/googleplex-android/platform/superproject/main/+/main:packages/apps/Launcher3/quickstep/src/com/android/launcher3/hybridhotseat/HotseatPredictionController.java;l=239;drc=fe3f542e614df52cdcfa761074dd52957788a670;bpv=0;bpt=0

PreparePredictionInfo: https://source.corp.google.com/h/googleplex-android/platform/superproject/main/+/main:packages/apps/Launcher3/quickstep/src/com/android/launcher3/hybridhotseat/HotseatPredictionController.java;l=413-419;drc=6cdf7ce91a2643e02156d5ab8fb0f1c416f80c29;bpv=0;bpt=0

adb shell dumpsys activity NexusLauncherActivity

Before: https://paste.googleplex.com/4907497231482880

After: https://paste.googleplex.com/5157313861648384

Test: Manual
Flag: NA
Bug: 332171918

Change-Id: Ic9522238b2df06eb7c96b7f8961bc174fae17c9c
2024-04-09 11:57:13 -07:00
Sunny Goyal 11117d9b2a Using resource override instead of code-swap for ApiWrapper
Bug: 330920490
Flag: None
Test: Presubmit
Change-Id: Iac19f32e64d2c76ed5b4f8592943ee4ae7af51b5
2024-04-09 11:14:44 -07:00
Schneider Victor-tulias 2dee591601 Fix BinderTests#testSwitchToOverview
This test has been failing because the "unexpected" Binder call is actually expected. Updated the test to account for this.

Flag: N/A
Fixes: 315075477
Test: BinderTests#testSwitchToOverview
Change-Id: I2f5d3d07f6ec373f394e7a6f3887000af5f63c7e
2024-04-09 14:04:34 -04:00
Holly Sun 9b11c40b01 [omni] Read and use touch slop multiplier for LPNH.
1) This part is missing from the previous set of CLs. `getLPNHCustomSlopMultiplier` is defined but unused. Similar as reading LPNHDuration, we should also read the touch slot multiplier in Launcher for LPNH.
2) Also, change type to float, which is consistent with our existing implementation and the definition in OverviewProxyService.
3) Slop value is in percentage and Launcher divide it by 100. We haven't got AGSA implementation yet so we can predefine this part.

Bug: 330444720
Bug: 330446188
Test: manual
Flag: legacy CUSTOM_LPNH_THRESHOLDS disabled
Change-Id: Id606a4bc765fe01464ef36a2806c280ee42d30cd
2024-04-09 10:10:10 -07:00
Alex Chau 45162f9cf0 Add debug log for RecentsView touch down
Bug: 318590728
Test: manual
Flag: None
Change-Id: I591ed74af748f0fe424e1b58b4f610a21a106124
2024-04-09 17:46:38 +01:00
Alex Chau 34bfc7a80b Add debug log for TaskView.onClick
Bug: 310064698
Test: manual
Flag: None
Change-Id: Ib772dd8995442d3b1af84aec0668b11828ab62e6
2024-04-09 17:45:30 +01:00
Helen Cheuk a0dc66c206 Merge "Add focus outline to overview clear all button" into main 2024-04-09 16:27:27 +00:00
Vadim Tryshev 6ae89d13ff Merge "Re-enabling stress tests in presubmit" into main 2024-04-09 16:26:17 +00:00
Brian Isganitis 093b432985 Merge "Reset allAppsVisible if folding to phone upon recreateTaskbar." into main 2024-04-09 16:22:16 +00:00
Brian Isganitis 4ba8346a34 Merge "Use translation shift setter when showing AllApps without animation." into main 2024-04-09 16:21:54 +00:00
Alex Chau 3c0729c462 Add task menu item to move task to Desktop
- Call SystemUiProxy.moveToDesktop to move existing Overview tasks to desktop
- Animation polish will be handled separately
- Refactored AbstractFloatingView method into a helper to allow testing

Fix: 320310347
Test: DesktopSystemShortcutTest, AbstractFloatingViewHelperTest
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Change-Id: I2e4e04182e46ba4750e0683ee1789ba8fada06ea
2024-04-09 16:35:55 +01:00
Liran Binyamin 60d4e8d3b8 Merge "Fix NPE when setting bubble bar bounds" into main 2024-04-09 14:04:19 +00:00
Sunny Goyal 8ecbaa422f Merge "Moving various nav-bar configs out of feature flags" into main 2024-04-09 05:45:21 +00:00
Vinit Nayak 26c11f2c49 Launch split tasks at beginning of animation instead of the end
* Ideally we animate the live leashes from the placeholder tasks,
that's a lot more changes at this moment so we don't do that
* Instead we just hold off fading in the leashes until the very
end of the animation
* This way taskbar can scale down correctly in both contextual and
app pair launch cases since now launcher visibility will be changed
at the same time

Bug: 308851855
Test: Launches are a bit snappier from workspace/all apps compared
to overview, but in a good way!(?)

Change-Id: I73a9284a2b1a993c5a020396e2aca8499fc5eb09
2024-04-08 22:28:01 -07:00
Jeremy Sim 6a60c3b113 Prevent menu items from showing on split tasks
This CL changes the TaskShortcutFactory for SCREENSHOT and MODAL so that the associated menu options ("Screenshot" and "Select") don't show up on split tasks. These actions are not fully supported on splitscreen tiles (they will only work on one of the two apps), so we disable them.

Bug: 327434215
Flag: N/A
Test: Manual
Change-Id: I121a9c28fa7570f10e13be2de6489182e3362cfc
2024-04-08 17:56:29 -07:00
Jeremy Sim fa3eae99a5 Merge "Fix bug where app pair title was not updating with language" into main 2024-04-09 00:22:19 +00:00
Vinit Nayak 674aa03862 Add CUJ Jank interactions for App Pair saving and launching
* Added finishCallback consumer to LauncherAccessibilityDelegate
to inform when adding an item to workspace was completed.
* The logic seemed to be dependent on the parameter
"focusForAccessibility", but all callers of that are currently
passing in true

Bug: 328646540
Test: https://paste.googleplex.com/6232597136408576
Newly added CUJs showing up when playing w/ device

Change-Id: Ia4944f8d23634bb92296938ea2d07a6babf6f77c
Merged-In: Ia4944f8d23634bb92296938ea2d07a6babf6f77c
2024-04-09 00:17:21 +00:00
Uwais Ashraf fe1a9c36b7 Merge "Use script to auto-enable all tests that are currently working" into main 2024-04-09 00:01:05 +00:00
Sunny Goyal 89931316a2 Moving various nav-bar configs out of feature flags
Bug: 332588958
Test: Presubmit
Flag: None
Change-Id: Ia4dc5b69bcf4d461e3444b9e37bb7334bb74aae4
2024-04-08 16:54:04 -07:00
Brian Isganitis 6d63e7796d Reset allAppsVisible if folding to phone upon recreateTaskbar.
For taskbar unification, we should reset this bit to false when folding
into phone orientation. Otherwise, we will reinit Taskbar AllApps over
the phone UI which is unexpected behavior.

Test: Manual
Flag: N/A
Fix: 293379641
Change-Id: I53c38c8b4df477191be3c21b7750c55a71c7336f
2024-04-08 15:36:31 -07:00
Brian Isganitis 514f866f5c Use translation shift setter when showing AllApps without animation.
The no-animation case used to be handled immediately upon inflating the
view, so we got away with reassigning the field to
TRANSLATION_SHIFT_OPENED directly. Since this happens in post of a
handler, we need to instead use the setter so that a relayout happens.

Test: Manual
Fix: 324268840
Flag: N/A
Change-Id: I089f15a8d64e0d22885ae387679214a540790ad0
2024-04-08 15:15:41 -07:00
Jordan Silva 65972d5ba4 Merge "Update save app pair test to validate when icon chip menu is disabled" into main 2024-04-08 22:08:49 +00:00
Liran Binyamin 4d257139ad Fix NPE when setting bubble bar bounds
The bubble bar bounds change listener is sometimes invoked before the IBubbles service has been initialized.
This change adds a null check before calling the service.

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Fixes: 332423960
Test: manual
Change-Id: Iaa048c62a60c90c5e416da05ba53467a5034d86c
2024-04-08 21:05:00 +00:00
Uwais Ashraf 7a0150d02e Use script to auto-enable all tests that are currently working
Fix: 325088906
Test: presubmits passing, gradle robo run passing locally
Flag: NA
Change-Id: I481bfe9caeb8cc18b3e01ec8b7a58fb0eb36fdaa
2024-04-08 20:59:23 +00:00
Jordan Silva a3eff1fe96 Update save app pair test to validate when icon chip menu is disabled
This CL adds a validation in the test to check if save app pair action is available in the overview actions. Kept the validation to check if save app pair is available in the menu only for overview icon menu flag enabled.

Bug: 330515672
Flag: N/A
Test: TaplTestsSplitscreen
Change-Id: I3097180a24b430f2310d11ddec36e6d6cf4982fb
2024-04-08 12:30:51 -07:00
Federico Baron 9462c3b604 Merge "Fix null pointer in FloatingWidgetView" into main 2024-04-08 18:52:43 +00:00
Treehugger Robot 8687018b09 Merge "Disable app chip menu height limit for bottom row" into main 2024-04-08 18:22:08 +00:00
Treehugger Robot 18694cc977 Merge "Add max height logic and avoidance of taskbar into task menu" into main 2024-04-08 18:22:08 +00:00
Liran Binyamin 9a9ef494ae Merge changes I74b09220,Id7e2db5f into main
* changes:
  Don't animate bubbles in the initial state update
  Suppress animation for bubbles that auto expand
2024-04-08 16:30:30 +00:00
Uwais Ashraf d9de4b0558 Add max height logic and avoidance of taskbar into task menu
Fix: 329842207
Test: Manually tested, see video in bug
Flag: NA
Change-Id: I08079f14cee63fe7973ba751529109ca66423bb6
2024-04-08 16:23:59 +00:00
Alex Chau 293d2cb867 Disable app chip menu height limit for bottom row
Bug: 326952853
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Test: manual
Change-Id: I104296979803eb8967b07793f4f2590e592f9df7
2024-04-08 16:24:45 +01:00
Alex Chau 7714b2cd32 Add more logs tracking gesture and recents animation in RecentsView
Bug: 332635097
Test: manual
Flag: None
Change-Id: I6f83806f783344c07f7f59fe87c37b7cc377fff2
2024-04-08 13:12:06 +01:00
Treehugger Robot dcb860a22a Merge "Explicitly set animation and timings for split cancel button" into 24D1-dev 2024-04-06 07:30:28 +00:00
Saumya Prakash 83646f9b82 Merge "Add Taskbar education for Circle to Search for pinned taskbar" into main 2024-04-06 05:39:28 +00:00
Saumya Prakash 5453c053b9 Add Taskbar education for Circle to Search for pinned taskbar
This change adds a new education tooltip for pinned taskbar that teaches
users how to use Circle to Search invoked through the action key. It won't run on
transient taskbar or if the user is in 3 button mode. The disclosures at
the bottom of the tooltip link to localized legal agreements for the feature.

Fix: 330401405
Test: Pin the taskbar and observe that the next time an app is launched
the edu shows up. After dismissal it shouldn't show up again.
Additionally, click on the disclosures and ensure they launch.
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning NEXTFOOD

Change-Id: I64aea3004aca77c3ec81b81dea0cfab7a9c1e272
2024-04-06 01:52:49 +00:00
Andy Wickham 29671bdf1f Adds AssistStateManager#supportsShowWhenLocked.
This indicates whether search can show over the lock screen.

Bug: 320444706
Test: Manual with supported and unsupported AGA APKs
Flag: NA
Change-Id: I06612af6731b991b38614e47f207e190db109c24
2024-04-05 17:48:03 -07:00
Liran Binyamin 0701ab166d Don't animate bubbles in the initial state update
When launcher receives the initial bubble state update from sysui, don't animate the bubbles. The initial update is sent when bubble bar is created and not when new bubbles are created.

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605846
Test: manual
Change-Id: I74b09220be22d7382fa6d7c1351d5e60a799a054
2024-04-05 20:15:52 -04:00
Sunny Goyal 8e1f37181d Merge "Allowing base class for ResourceBasedOverride to have Context based constructors" into main 2024-04-05 23:20:38 +00:00
Tony Wickham a6dcb11094 Merge "Apply insets to top-level providers, not just paramsForRotation" into main 2024-04-05 22:01:29 +00:00
Jeremy Sim 24284467b5 Fix bug where app pair title was not updating with language
This CL adds the ability for an app pair icon to update its title string when package changes are detected. It also reorganizes some code in the app pairs classes for readability.

Fixes: 316051810
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual
Change-Id: I833e4f9766b7da8c0a3a5fb4b9fc050d8897437e
2024-04-05 21:35:58 +00:00
Sunny Goyal 21f498c5f3 Merge "Moving all configs from overrides.xml to config.xml" into main 2024-04-05 20:04:15 +00:00
Sunny Goyal 9d28eee769 Allowing base class for ResourceBasedOverride to have Context based constructors
Bug: 330920490
Flag: None
Test: Presubmit
Change-Id: Ib4d1ef80133596a114a4fb32ea8ae918852a77f5
2024-04-05 12:56:36 -07:00
Tony Wickham 3205876bf5 Apply insets to top-level providers, not just paramsForRotation
Bug: 329012507
Flag: none
Test: trigger assistant, ensure bottom insets are removed in
gesture nav mode; also verify IME inset override correctly
applies in 3 button mode

Change-Id: I823d0d360a7e3b41cc291f6949d9371e0dc32efb
2024-04-05 19:46:11 +00:00
Anushree Ganjam 16a0f61078 Merge "Add dump for PredictionRowView." into main 2024-04-05 19:41:31 +00:00
Tony Wickham f95a6b73e5 Apply insets to top-level providers, not just paramsForRotation
Bug: 329012507
Flag: none
Test: trigger assistant, ensure bottom insets are removed in
gesture nav mode; also verify IME inset override correctly
applies in 3 button mode

Change-Id: I823d0d360a7e3b41cc291f6949d9371e0dc32efb
2024-04-05 19:40:06 +00:00
Sunny Goyal bd07c05446 Moving all configs from overrides.xml to config.xml
> Removing some used configs
> Moving ids to id.xml

Bug: 330920490
Flag: None
Test: Presubmit
Change-Id: I86bd22db49a3980c55f5d42350a7c6368fa86d21
2024-04-05 11:20:17 -07:00
Liran Binyamin c21852a186 Suppress animation for bubbles that auto expand
Check whether the state update indicates that the bubble bar is expanding, and pass that to the bubblebarviewcontroller so that we can suppress the new bubble animation if we're expanding from stashed.
Note that in some cases the notification service may not include the auto expand flag on the message it sends to sysui, so launcher will end up getting 2 separate messages. We may need to handle that separately.

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605846
Test: manual
       - create bubble that auto expands
       - observe that the bubble does not animate
       - note that in some cases the notification service may not include the auto expand flag, will look into that separately.
Change-Id: Id7e2db5fd32d391413c57d83effb4b23b1085125
2024-04-05 14:09:32 -04:00
Anushree Ganjam 1115b416bb Add dump for PredictionRowView.
adb shell dumpsys activity NexusLauncherActivity : https://paste.googleplex.com/4907497231482880

When AllApps prediction is off : https://paste.googleplex.com/5930628737925120

Bug: 332171918
Test: Manual
Flag: NA
Change-Id: I753ff876aab162026d99fd1b35f63edf2e712f70
2024-04-05 10:57:44 -07:00
Schneider Victor-tulias 09268637b4 Merge "Add debug logs to TaskView" into main 2024-04-05 16:46:55 +00:00
Tony Wickham fa696568e5 Unstash taskbar due to IME immediately when system gesture starts
This is reversing a previous change from a few years ago
(ag/16325264) because we now clip the recent apps on the bottom
during gesture nav, whereas before we left them unclipped until
you swiped up.

Flag: none
Fixes: 305977350
Test: verified visuals manually in persistent, transient, and 3
button nav; also tested interactions with All Apps

Change-Id: Ib3823a9bd9aebf923ad481c010c7e8544bcb6a4d
(cherry picked from commit a6b29968a4)
2024-04-05 15:50:15 +00:00