Commit Graph

20478 Commits

Author SHA1 Message Date
Saumya Prakash 92b20d89a6 Fix incorrect fragment in gesture tutorial when rotating the screen
This change makes the current fragment load on configuration changes for
the gesture navigation tutorial. Previously, the old fragment would be recreated causing inconsistencies when rotating the screen. Not marking a flag as this change is for both the previous gesture tutorial and the current one.

Fix: 317162126
Test: Run the tutorial and rotate the screen after each step. The
tutorial should progress like normal.
Flag: N/A

Change-Id: I09c40006dd0ef6e9e78fa44e36962a678918420a
(cherry picked from commit c028cc7699)
2024-04-11 22:04:32 +00:00
Saumya Prakash afc6cfcd3b Adjust where the back button is rendered for new SUW requirements.
Large screen devices in landscape mode and devices that have mostly a
square aspect ratio are undergoing a redesign in Setup wizard that makes
most screens two-pane. As part of this redesign, the back button is
aligned in this change. This change doesn't use a flag because the Setup
Wizard change is not flagged.

Fixes: 323778778
Fixes: 328017929
Test: Run Setup Wizard and see if the back button aligns with the Skip
button in two pane screens.
Flag: N/A

Change-Id: I22680f40c0ddf7cd03ab1da69406eb14184b0174
Merged-In: I22680f40c0ddf7cd03ab1da69406eb14184b0174
2024-04-11 21:25:49 +00:00
Vinit Nayak 559aeb2c45 Merge "Allow app pairs in folders" into 24D1-dev 2024-04-11 20:55:33 +00:00
Vadim Tryshev a46a55ed05 Promote goToOverviewFromApp to presubmit
It's stable now:
https://android-build.corp.google.com/test_hub/search/?filter=&invfilter=unhealthyInvocations&invfilter=staleInvocations&tab=tests&query=branch%3agit_main%20target%3a%28cf_x86_64_phone-trunk_staging-userdebug%7ccf_x86_64_tablet-trunk_staging-userdebug%7ccf_x86_64_foldable-trunk_staging-userdebug%29%20config%3a%28v2%2fgnl-eng%2funbundled%2flauncher%2fnexus_unit_test_multi_device_platform%7cv2%2fgnl-eng%2funbundled%2flauncher%2fnexus_oop_test_multi_device_platform%7cv2%2fgnl-eng%2funbundled%2flauncher%2flauncher3_test_platform%29%20test%3a%22com.android.quickstep.FallbackRecentsTest%23goToOverviewFromApp%22

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I9c8777b976e2683aecdfa7f97950dee4c5661a11
2024-04-11 20:14:07 +00:00
Andreas Agvard 98e57de7a8 Merge "Removes recovery" into 24D1-dev 2024-04-11 19:37:47 +00:00
Saumya Prakash 5bb103246b Merge "Adjust where the back button is rendered for new SUW requirements." into main 2024-04-11 19:05:52 +00:00
Jagrut Desai b625c2345a Remove PortraitLandscape from the TaplTestsTransientTaskbar
Test: Presubmit
Bug: 321083190
Flag: NONE
Change-Id: Ida1d902452280a9c161edbc63b1a0b9a4aad2e3f
2024-04-11 11:21:39 -07:00
Randy Pfohl c77a9ae116 Merge changes from topic "revert-26911513-revert-26414135-RecentsViewContainer-MEROZZOKJQ-WQFWDQZVKT" into main
* changes:
  Revert^2 "fixing tests to match new abstraction"
  Revert "Revert "abtracting Activity from recentsView through rec..."
2024-04-11 18:05:18 +00:00
Treehugger Robot 04d38ce5d2 Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev 2024-04-11 17:26:52 +00:00
Treehugger Robot eaaf350e2d Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-04-11 17:25:57 +00:00
Gustav Sennton 2744acfbf4 Implement IRecentTasksListener.onRunningTaskChanged()
Bug: 332504528
Test: N/A
Flag: NA
Change-Id: I7c98eb524bb7544a715f5b8226d3c28d05f72913
2024-04-11 16:58:42 +00:00
Saumya Prakash da26e19dd8 Adjust where the back button is rendered for new SUW requirements.
Large screen devices in landscape mode and devices that have mostly a
square aspect ratio are undergoing a redesign in Setup wizard that makes
most screens two-pane. As part of this redesign, the back button is
aligned in this change. This change doesn't use a flag because the Setup
Wizard change is not flagged.

Fixes: 323778778
Fixes: 328017929
Test: Run Setup Wizard and see if the back button aligns with the Skip
button in two pane screens.
Flag: N/A

Change-Id: I22680f40c0ddf7cd03ab1da69406eb14184b0174
2024-04-11 16:53:41 +00:00
Randy Pfohl c21b0000b5 Revert^2 "fixing tests to match new abstraction"
8e4c0b7afb

Change-Id: I9875d6f9c16f1406d0818164a98e790c2b101650
2024-04-11 08:58:22 -07:00
Randy Pfohl 819b835519 Revert "Revert "abtracting Activity from recentsView through rec..."
Revert submission 26911513-revert-26414135-RecentsViewContainer-MEROZZOKJQ

Reason for revert: Fix for issue has been found and will be included in this revert.

Reverted changes: /q/submissionid:26911513-revert-26414135-RecentsViewContainer-MEROZZOKJQ

Change-Id: I517e7d2fc0d82d250a6ed40862dd31c194d0a302
2024-04-11 08:58:08 -07:00
Liran Binyamin e79120af38 Update new bubble animation
This change is a rewrite of the new bubble animation. Previously we chained the handle animation and the bubble animation so that they run sequentially.
That caused the transition from the handle to the bubble to be jarring.

We now use a single spring animation along the y axis that starts from the position of the handle to the position of where the bubble will end up.
The animation is split into 3 logical parts, where initially the bubble animates out, then the bubble starts animating in, and the last part is the overshoot of the spring animation, which is used to mark the bubble fully visible and ensure that from that point on, the bubble is only moving but doesn't change in scale or transparency as the bounce effect is playing.
Using a single animation path allows for a smooth transition from the handle to the bubble view.

Demo: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/hHNUBdNJPiWi9gMbqy45UJ

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605846
Test: atest BubbleBarViewAnimatorTest
Change-Id: Ic1d3244574b8500d4aad2e9c718e61c1c34bd82a
2024-04-11 11:51:10 -04:00
Luca Zuccarini 926a10a3b0 Create a stubbed IRemoteTransition implementation.
Bug: 323863002
Flag: NA
Test: NA, new method is unused (still builds)
Change-Id: Ibc4187f469e41b2db91bef368c710ffbdcd33faf
2024-04-11 09:15:41 +00:00
Vinit Nayak 20c0b2f647 Merge "Add placeholder divider view when starting split tasks" into main 2024-04-11 05:10:35 +00:00
Vinit Nayak cdaabc6199 Add placeholder divider view when starting split tasks
* This prevents launcher underneath from peaking through
while the split apps are loading

Bug: 299640096
Test: Launched from recents, home and all apps
Doesn't seem to affect small screen since recents scrolls
away and the scrim is only left

Change-Id: I32e394a0bc361489473ee657161c8f3bcbf1e422
2024-04-11 05:09:49 +00:00
Tracy Zhou f5299f3168 Merge "Move AbstractFloatingView for stage split layering above all apps" into main 2024-04-11 05:05:01 +00:00
Jeremy Sim 9109e43f02 Allow app pairs in folders
This CL substantially refactors folders to be able to take contents of type AppPairInfo. App pairs can now be moved in and out of folders, and launch from folders.

This CL contains only logic and model changes; animation and style changes (for dropping items into folders, color changes to app pair surfaces, etc.) will be in a following CL. Another CL (hopefully) will contain tests. I'm planning to submit them together, but this patch should also be able to stand alone with no issues (except janky transitions).

Bug: 315731527
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual, more to follow in another CL.
Change-Id: I73732fcaefbdc61bf6e02a5be365962b8bbc3e41
(cherry picked from commit a596f589c4)
Merged-In: I73732fcaefbdc61bf6e02a5be365962b8bbc3e41
2024-04-11 03:51:53 +00:00
Tracy Zhou 3158bf7e43 Move AbstractFloatingView for stage split layering above all apps
- We don't need to worry about if it's in Overview. Only overview has task menus, so if there is no task menu, we place it at the top.

Fixes: 332465429
Test: Launch stage split using keyboard shortcuts with all apps open. Make sure it's above all apps.
Change-Id: Ic950d2897fe80ef407038dd840b86fc92d6d6287
2024-04-10 19:42:50 -07:00
Bill Yi ffdd0fe4cd Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I4d11fa2ea72763bfbd9875daca8e82f65e08a4a0
2024-04-10 18:53:31 -07:00
Bill Yi 0d81a8f979 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ic74edaf2283e8de9bd37ccef7e266c0c5e68dcdd
2024-04-10 18:53:04 -07:00
Priyanka Advani 1d6851083b Merge changes from topic "revert-26414135-RecentsViewContainer-MEROZZOKJQ" into main
* changes:
  Revert "abtracting Activity from recentsView through recentsview..."
  Revert "fixing tests to match new abstraction"
2024-04-10 23:58:09 +00:00
Sunny Goyal 63bf93cf65 Merge "Freezing legacy feature flags" into main 2024-04-10 22:29:24 +00:00
Priyanka Advani 3c71346147 Revert "abtracting Activity from recentsView through recentsview..."
Revert submission 26414135-RecentsViewContainer

Reason for revert: Probable culprit for b/333767026. Will be verifying through ABTD for confirmation and before submitting the revert.

Reverted changes: /q/submissionid:26414135-RecentsViewContainer

Change-Id: I25775cd6531355f1dc042ddb7a8d442ee0b36e58
2024-04-10 21:31:07 +00:00
Priyanka Advani 8e4c0b7afb Revert "fixing tests to match new abstraction"
Revert submission 26414135-RecentsViewContainer

Reason for revert: Probable culprit for b/333767026. Will be verifying through ABTD for confirmation and before submitting the revert.

Reverted changes: /q/submissionid:26414135-RecentsViewContainer

Change-Id: Ibafc66cf3677d24e7912d55cb45c948cb6519df7
2024-04-10 21:31:14 +00:00
Vinit Nayak 24f88860de Merge "Launch split tasks at beginning of animation instead of the end" into main 2024-04-10 20:16:08 +00:00
Jeremy Sim 00bf2488d1 Reparent folders and app pairs
Previously, app pairs and folders shared a common data model, FolderInfo. Now we need to separate them, so a new type, CollectionInfo, will serve as the parent of both types.

Bug: 315731527
Fixes: 326664798
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual, unit tests to follow
Change-Id: Ia8c429cf6e6a376f2554ae1866549ef0bcab2a22
Merged-In: Ia8c429cf6e6a376f2554ae1866549ef0bcab2a22
2024-04-10 18:44:12 +00:00
randypfohl f75709e78b fixing tests to match new abstraction
This change will let us move from activity to other parent views for recent viewss

Change-Id: I2424d94f799f87b2d2262da96b289aac6dfadee9
2024-04-10 09:14:38 -07:00
randypfohl 547d6fc472 abtracting Activity from recentsView through recentsviewcontainer and basecontainerinterface interfaces
This change will let us move from activity to other parent views for recent views.

Summary: In prep for new recentsview containers outside of activity we needed to decouple recentsview from activity and state.
This change will let us move from activity to other parent views for recent views.

Test: Built and tested locally for 1p and 3p launchers on tablet, and portrait modes. Verified working functionality.

Bug: 292269949

Flag: NONE

Change-Id: I5c72745f438d466362ece988c35a97d829e9c1b4
2024-04-10 09:14:28 -07:00
Holly Jiuyu Sun c2ee3f5001 Merge "[omni] Implement 2-stage for LPNH." into main 2024-04-10 15:35:54 +00:00
Jeremy Sim 4eac54565e Merge "Prevent menu items from showing on split tasks" into main 2024-04-10 15:25:27 +00:00
Alina Zaidi 0580379e30 Rename freeform tasks to desktop tasks
Bug: b/332878426
Test: refactoring CL. Existing unit tests still pass.
Flag: NONE

Change-Id: I24ad9699223dd383ff794ef3b028bf32beca96d7
2024-04-10 12:30:50 +00:00
Brian Isganitis 3f4e5812ce Merge "Prevent meta shortcut from cancelling split select state." into main 2024-04-10 07:34:47 +00:00
Holly Sun deee0d06f6 [omni] Implement 2-stage for LPNH.
Use existing override duration and touch slop multiplier values for the 1st stage. Times `TWO_STAGE_MULTIPLIER` for the 2nd stage.
See http://shortn/_WqYj0buH7R

Bug: 330446193
Test: manual
Flag: legacy ENABLE_LPNH_TWO_STAGES disabled
Change-Id: Ic200f431524578d17fd98ebfbc65e44e0971e31c
2024-04-09 17:00:15 -07:00
Holly Jiuyu Sun c072d44b4e Merge "[omni] Log LP duration & slop's data source and value." into main 2024-04-09 23:52:39 +00:00
Anushree Ganjam 586eb65c0d Merge "Fill CellX , CellY and Rank for predictionRowView iteminfo." into main 2024-04-09 23:26:58 +00:00
Brian Isganitis 84fbec0b16 Prevent meta shortcut from cancelling split select state.
There are two things that need to be changed for this to work:

1. Make the isInOverview condition check for any Overview UI (including
   the split select state, modal, etc.)
2. Toggle Home All Apps directly, because firing the intent will cause
   Launcher to pause and resume before the intent is handled. We
misinterpret the pause as a request to cancel split screen. Since
TaskbarManager has a reference to Launcher, we might as well call the
method directly.

Test: Manual
Fix: 319076403
Flag: N/A
Change-Id: Ib8899188f593a168a054a16717df4a95be098557
2024-04-09 16:10:56 -07:00
Sunny Goyal 8049369af8 Freezing legacy feature flags
Legacy feature flags will be locked to their current values in code.
All new feature development should use aconfig flags

Bug: 332588958
Flag: None
Test: Presubmit
Change-Id: Ie72dd8276b7135620de279835d6721a34f82ede4
2024-04-09 15:26:07 -07:00
Treehugger Robot b155421ada Merge "Add debug log for RecentsView touch down" into main 2024-04-09 21:32:52 +00:00
Himanshu Gupta 6c089d7ac1 Merge "Adding TAPL tests for Private Space in Quickstep." into main 2024-04-09 21:12:09 +00:00
Sunny Goyal 3b00e7909a Merge "Using resource override instead of code-swap for ApiWrapper" into main 2024-04-09 20:33:20 +00:00
Alex Chau 8ddacf2185 Merge "Add more logs tracking gesture and recents animation in RecentsView" into main 2024-04-09 20:32:19 +00:00
Alex Chau 55ef24c229 Merge "Add task menu item to move task to Desktop" into main 2024-04-09 20:31:47 +00:00
Holly Sun 6d8b85e83a [omni] Log LP duration & slop's data source and value.
For duration, the data source and value should be the same for LPNH and LPH. E.g., if AGSA overrides duration, it applies for both LPNH and LPH. When there is no AGSA override, there are cases that one of our feature flag is enabled and the other one is disabled. We just simply rely on LPNH's feature flag in this case. This should be fine because the purpose is to cross check the data source and its value.

Bug: 332722082
Test: manual
Flag: legacy CUSTOM_LPNH_THRESHOLDS enabled
Change-Id: I3f10b944257e7021ae7c930b782f1d963c0e505b
2024-04-09 13:27:41 -07:00
Holly Jiuyu Sun 887a88f149 Merge "[omni] Read and use touch slop multiplier for LPNH." into main 2024-04-09 20:17:51 +00:00
Treehugger Robot cb8ad6edde Merge "Add debug log for TaskView.onClick" into main 2024-04-09 19:54:11 +00:00
Treehugger Robot 58d913d996 Merge "Fix BinderTests#testSwitchToOverview" into main 2024-04-09 19:41:29 +00:00
Himanshu Gupta 0d400993a9 Adding TAPL tests for Private Space in Quickstep.
This CL adds an initial test, that creates
private profile and verifies the elements
present in unlocked state.

More tests will be followed in next CL.

Doc: go/private-space-tapl

Bug: 322882655
Test: TaplPrivateSpaceTest
Flag: NA
Change-Id: I6032f4531818031991a5d51e23cfad22518250e6
2024-04-09 20:30:31 +01:00