Commit Graph

20478 Commits

Author SHA1 Message Date
Schneider Victor-tulias dfeb22f7ab Add unit tests for MultiStateCallback
Flag: EXEMPT adding tests
Fixes: 355003429
Test: MultiStateCallbackTest
Change-Id: Id617ca79c44dcfa6226e47d574b9e3bfe6cfb140
2024-07-25 10:11:17 -04:00
Treehugger Robot acc4a81a97 Merge "Fix NPE when activity launch options are created before taskbaer init" into main 2024-07-25 14:03:30 +00:00
Vinay Joglekar fe7878c144 Merge "Dim TaskThumbnailView on Foreground scrim" into main 2024-07-25 13:03:49 +00:00
vinayjoglekar 36ef7bf6e7 Dim TaskThumbnailView on Foreground scrim
Bug: 349601769
Test: TaskThumbnailViewModelTest
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I3a9fa21d8a4c28ffe40279243030f0e47c957513
2024-07-25 11:18:20 +01:00
Jon Miranda 310e4c8038 Fix NPE when activity launch options are created before taskbaer init
Change-Id: Ibb8cf96ad4e528754aeb98ff0a702af2412e1052
Test: init
Fixes: 355231499
Flag: com.android.launcher3.enable_scaling_reveal_home_animation
2024-07-25 05:53:45 +00:00
mpodolian 6ba541642e Improvement for the Bubble Bar Bubbles' Shadows
The issue was caused by the alpha animation applied to the bubble bar.
Added code to check if the alpha applied to the bubble bar is less than
1 and instruct child bubble views not to provide a shadow outline in
such cases. While this is not a full fix, but rather an improvement,
b/345490679 should introduce a proper fix.

Bug: 345484712
Test: visual - go to any application and stash/unstash bubble bar
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: Icb6bdb009f4d5998ec1638f97de89f7a4c9feccf
2024-07-25 05:31:55 +01:00
Anushree Ganjam 7640b08ea3 Merge "Format dump logs so each of apps info prints in new line." into main 2024-07-24 23:43:54 +00:00
Treehugger Robot de1a7e067f Merge "Move TestExtensions.kt to quickstep for DeviceConfig overrides." into main 2024-07-24 22:42:00 +00:00
Ats Jenk 4e4b8a8402 Include bubble bar location in taskbar announcement
When bubble bar has bubbles, it will be expanded together with taskbar.
Include information about bubble bar appearing together with the taskbar
announcement. During expand include the location of the bubble bar,
whether it is on the left or right.

Bug: 344675357
Flag: com.android.wm.shell.enable_bubble_bar
Test: manual, enable talkback and check that taskbar expand announcement
  includes information about bubble bar, check that when bar is on left,
  announcement includes left and bar is right, announcement says right
Change-Id: I116ed531fe7032940478451508b37f4fd0bc98ff
2024-07-24 13:50:08 -07:00
Robin Lee 004849d2ec Skip launcher return for custom task transitions
Overriding the task exit transition requires a permission that indicates the exiting task already knows more than the launcher about what its exit is supposed to look like, so we
will let it play the animation it likes instead of the default return-to-launcher one.

Change-Id: I8f4b7292ae0863d378ec6319816e1b9cc7735c24
Test: atest transition-hotlaunch-phone
Flag: EXEMPT bugfix
Bug: 350712843
2024-07-24 20:49:39 +00:00
Liran Binyamin f93199cbe3 Merge "Fix squished hotseat due to bubbles" into main 2024-07-24 19:13:02 +00:00
Shamali Patwa b4d185e3cc Merge changes from topic "popup-refactor" into main
* changes:
  Delete the unused code from popup provider
  Update references that read popup data provider to use picker provider
  Update references that wrote widget data to popup data provider
  Move widget related listeners to widget picker data provider
  Define widget picker data provider separate from popup provider
  Create a separate class for widget related methods from popup provider
2024-07-24 18:46:35 +00:00
Liran Binyamin 2a47a4a68d Fix squished hotseat due to bubbles
Hotseat supports adjusting its layout to make room for bubbles when
needed. There are 2 events that trigger this:
  1. When Hotseat's layout is reset, it checks for whether bubbles
     are showing.
  2. When Bubble Bar visibility changes it notifies hotseat so that
     it can update itself.

Folding the device is recreated triggers both hotseat layout reset
and recreation of taskbar, but the order in which these happen is not
guaranteed. Sometimes hotseat checks for the status of bubble bar
which may be visible if taskbar hasn't been recreated yet.

This change makes sure that hotseat updates itself after taskbar is
recreated and the ui controller is set, so that it cleans up any
adjustments it may have if bubbles are not visible.

This change also updates the way QSB adjusts itself for bubbles.
Previously it always animated from the same start value to a target
value. Now the animation starts from its current width to the target,
so that if the current width is already equal to the target width,
there is no visible change.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 349430356
Test: manual
       - unfold the device
       - create bubbles
       - observe hotseat adjusts itself for the bubble bar
       - fold the device
       - observe bubble bar is gone and hotseat shows correctly
Test: manual
       - start a youtube video in full screen
       - swipe from the edge of the screen to show the gesture nav
       - swipe on the gesture nav to go home
       - observe that the QSB does not animate
Change-Id: Ia0267ec518d6af9c3c3b68f17bb20ea67a49e5fd
2024-07-24 12:49:17 -04:00
Alina Zaidi bd3bb00593 Merge "[Dev options][More flags] Update all usages of some flags to use DesktopModeFlags." into main 2024-07-24 10:26:17 +00:00
Treehugger Robot 562e93afac Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-07-24 05:15:14 +00:00
Treehugger Robot 5ace16c7b8 Merge "Only register RecentTasksChangedListener if flag is enabled" into main 2024-07-24 01:17:35 +00:00
Andy Wickham 75ce1a2cd6 Move TestExtensions.kt to quickstep for DeviceConfig overrides.
Fix: 353740808
Test: Run existing tests using this class
Flag: TEST_ONLY
Change-Id: Ie72fb86ea4d451e90a6629554dc717126db0b24c
2024-07-24 00:15:05 +00:00
Tony Wickham bbfa9fc181 Only register RecentTasksChangedListener if flag is enabled
Also unregister it if the feature becomes disabled (currently
this is only done in tests but in the future there will be a
user setting as well).

Added tests to verify getTasks() is not called while both
canShowRunningApps and canShowRecentApps are false.

Bug: 354087794
Test: TaskbarRecentAppsControllerTest
Flag: com.android.launcher3.enable_recents_in_taskbar
Flag: com.android.window.flags.enable_desktop_windowing_taskbar_running_apps
Change-Id: I3123501e7584ad7f877e13294454556501d2dbc8
2024-07-23 23:24:10 +00:00
Treehugger Robot 33a237e447 Merge "Fix ConcurrentModificationException in OmniInvokerTest" into main 2024-07-23 23:23:27 +00:00
Treehugger Robot ea4373c060 Merge "Add NavHandleLongPressInputConsumerTest." into main 2024-07-23 23:20:47 +00:00
Treehugger Robot f3e8844b8c Merge "Revert "Fix squished hotseat due to bubbles"" into main 2024-07-23 23:16:48 +00:00
Treehugger Robot e3078707a0 Merge "Move more tests to deviceless" into main 2024-07-23 23:16:08 +00:00
Anushree Ganjam 16f2206f24 Format dump logs so each of apps info prints in new line.
Bug: 353510823
Test: Manual
Flag: NONE BugFix
Change-Id: Id5b0deca68e7af3c63422206db21ce3eba5b0f3a
2024-07-23 15:21:42 -07:00
Liam Lee Pong Lam dfaaa4a258 Merge "[Launcher3] Hides AllApps education view for trackpad" into main 2024-07-23 22:04:04 +00:00
Mykola Podolian 126be5629b Merge "Added BubbleStashController interface" into main 2024-07-23 21:37:31 +00:00
Liam Lee Pong Lam c1d3fa453f Merge "Fixes SettingsChangeLoggerTest failures" into main 2024-07-23 21:35:41 +00:00
Sihua Ma ee4877f67d Fix ConcurrentModificationException in OmniInvokerTest
Test: atest NexusLauncherRoboTests
Flag: TEST_ONLY
Change-Id: I31402443426e055fe470e11d98b52d07d64e9ca2
2024-07-23 21:24:52 +00:00
Ats Jenk 17f9e70a49 Merge "Announce when bubble bar expands or collapses" into main 2024-07-23 21:22:38 +00:00
Ats Jenk 354d367c47 Merge "Create a11y menu for a bubble in bubble bar" into main 2024-07-23 21:12:23 +00:00
Anushree Ganjam 7c32ae9acf Move more tests to deviceless
Bug: 353339741
Test: Manual
Flag: TEST_ONLY
Change-Id: Ib43d5a17feb812b08d9749b1bf6dcacabf205d47
2024-07-23 13:57:28 -07:00
Liran Binyamin f9650bd236 Revert "Fix squished hotseat due to bubbles"
This reverts commit a7821390e2.

Reason for revert: b/354648445

Fixes: 354648445

Change-Id: I069d6d72a59ec273e8b7776512ef9015bdb862c0
2024-07-23 19:56:52 +00:00
Liam, Lee Pong Lam a457b0e016 [Launcher3] Hides AllApps education view for trackpad
Added an indicator `mShowAllAppsEducationView` to check if AllApps
education view should show.

Flag: EXEMPT bugfix
Bug: 342369675
Test: Manual with/without trackpad
Change-Id: Ib995c80467143dd73fe2cac0504dbe6d03834f25
2024-07-23 19:41:18 +00:00
Liam, Lee Pong Lam 80ffa83957 Fixes SettingsChangeLoggerTest failures
To revert the preference change on PreviewItemManagerTest for on-device
test.

Bug: 354157494
Test: Unit tests
Flag: EXEMPT bugfix
Change-Id: I966cbd7bf85b0336e131c6e9e4bb306b3700a928
2024-07-23 19:33:27 +00:00
mpodolian 08e98a2c3e Added BubbleStashController interface
Added common BubbleStashController interface and implementation for the
PersistentTaskBarStashController. Added tests for the implementation.

Bug: 346391377
Flag: com.android.wm.shell.enable_bubble_bar
Test: PersistentTaskBarStashControllerTest
Change-Id: I353e5a2cfa2d39e83b0e94980938aee8a1002fd9
2024-07-23 19:32:08 +01:00
Ats Jenk 8034c414c3 Announce when bubble bar expands or collapses
Add a talkback announcement that tells the user when bubble bar expands
or collapses. The announcement includes the bubble name.

Bug: 344670486
Flag: com.android.wm.shell.enable_bubble_bar
Test: expand bubble bar by tapping on it, hear the announcement
Test: collapse bubble bar by tapping on it, hear the announcement
Test: expand/collapse bubble bar from action menu, hear the announcement
Test: use action menu to move expanded bubble bar from one side to the
    other, make sure there is no announcement

Change-Id: I3908bda3eb9e3eb201067fb2c465c3a883ce73d4
2024-07-23 11:01:43 -07:00
Alina Zaidi 7c75e25f56 [Dev options][More flags] Update all usages of some flags to use
DesktopModeFlags.

Test: Current tests pass
Bug: 348193756
Flag: com.android.window.flags.show_desktop_windowing_dev_option
Change-Id: Ie418f511c3b5d21cb2b4e485d30249b853a463af
2024-07-23 13:41:41 +00:00
Alina Zaidi 65794ef777 [Dev options][Wallpaper flag] Update all usage of enableDesktopWindowingWallpaperActivity
flag to use DesktopModeFlags

Test: Current tests pass
Bug: 348193756
Flag: com.android.window.flags.show_desktop_windowing_dev_option
Change-Id: Ib1b1b01f6a94b4d9c49019a31d0e2269246c301b
2024-07-23 10:18:15 +00:00
Alina Zaidi 6bf1a01ff8 Merge "[Dev options][DW flag] Update all usage of enable_desktop_windowing_mode flag to use DesktopModeFlags" into main 2024-07-23 10:06:47 +00:00
Andy Wickham 8e4faffd0e Add NavHandleLongPressInputConsumerTest.
Tests LPNH for the standard conditions (no flags or AGA configs).

Specifically tests:
 - Delegate stealing focus
 - Long press triggers with steady hold or slight slop
 - Up, cancel, or excessive slop cancels the long press
 - Touch ignored if outside the nav handle (not centered)

Things behind flags / AGA config which are not yet tested:
 - 2 stage detection (double timeout after small slop)
 - Deep press
 - Custom timeout from AGA

Fix: 353613291
Test: NavHandleLongPressInputConsumerTest
Flag: TEST_ONLY
Change-Id: I5ada3a07ccec9062ac22fa21b00d5a030f6d134a
2024-07-23 01:23:45 +00:00
Shamali P 66614049eb Update references that wrote widget data to popup data provider
Migrates to write to widget picker data provider instead

Test: Existing tests
Flag: EXEMPT minor refactoring
Bug: 353347512
Change-Id: I1735151e133db0358dfd4f7fa824c6bc7d792307
2024-07-22 23:58:04 +00:00
Vinit Nayak bb37e19c4d Merge "Synchronize split dismiss timing w/ launcher state transition" into main 2024-07-22 22:20:00 +00:00
Ats Jenk 85d4b8bb72 Create a11y menu for a bubble in bubble bar
A11y that supports the following actions:
- collapse
- dismiss
- move bar to the left or right (depending on current location)

Bug: 347028716
Test: select bubble in expanded bubble bar, open action menu
Test: use action menu to:
  - collapse bubble bar
  - dismiss a bubble, ensure only selected bubble is dismissed
  - move bubble bar to other side
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I70d90877e045abadb1fca4665ce315476d33c713
2024-07-22 15:17:16 -07:00
Alina Zaidi 3835f93237 [Dev options][DW flag] Update all usage of enable_desktop_windowing_mode flag to use DesktopModeFlags
Test: Current tests pass
Bug: 348193756
Flag: com.android.window.flags.show_desktop_windowing_dev_option
Change-Id: I96107f7c2964ee8261ad0a161163491d6f7d4d39
2024-07-22 20:33:02 +00:00
Bill Yi d9d9e4efda Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I3fe97635c6a84dda1bcdc8c12d49c5f0cd27e86a
2024-07-22 12:40:26 -07:00
Vinit Nayak dfa99349c9 Synchronize split dismiss timing w/ launcher state transition
* Extract out common bits from SplitInstructionsView as well

Fixes: 321863575
Test: Dismissed split from overview, swipe to home, cancel button,
tapping on scrim. No thumbnail flashes
Flag: EXEMPT bugfix

Change-Id: I83d54c9b8309bdec64af12bbc8ed397c045e847d
2024-07-22 11:45:52 -07:00
Vinay Joglekar f3256e5ba4 Merge "Support sysUiStatusNavFlags for refactored TTV" into main 2024-07-22 14:35:47 +00:00
Treehugger Robot d603151ae7 Merge "Remove TODO for animating bubble bar view" into main 2024-07-22 13:50:59 +00:00
Sam Cackett 78524ae618 Merge "Convert IconView class to Kotlin" into main 2024-07-22 13:20:18 +00:00
vinayjoglekar 82bb770738 Support sysUiStatusNavFlags for refactored TTV
Bug: 350743460
Test: SysUiStatusNavFlagsUseCaseTest
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: Id7576cb2eda14e6c72f34fe3fea3323a104a5164
2024-07-22 12:44:52 +01:00
samcackett d256c912b1 Convert IconView class to Kotlin
Fix: 342594235
Test: Manual. Check IconView in Overview works
Flag: EXEMPT converting java class to Kotlin
Change-Id: Icef4c5ebe7c4ce05fb844448679d032b171ad1bb
2024-07-22 08:51:19 +01:00