Commit Graph

20478 Commits

Author SHA1 Message Date
Liran Binyamin ccb57d8330 Revert^2 "Initial view screenshot tests for BubbleView"
3795d3782b

Flag: Exempt test only
Bug: 355454021
Test: atest NexusLauncherViewScreenshotTest

Change-Id: Ib51491dd2a6910df8953ad972c1a04fd5d79be9f
2024-07-31 16:31:49 -04:00
Treehugger Robot c6290acda3 Merge "[dev_option][More flags 4/n] Update all usages of Taskbar-show running apps flag to use DesktopModeFlags." into main 2024-07-31 19:48:54 +00:00
Mykola Podolian fcde085beb Merge "Integrated new BubbleStashControllers into the existing code." into main 2024-07-31 16:43:17 +00:00
Alina Zaidi a9a5ecf3dc [dev_option][More flags 4/n] Update all usages of Taskbar-show running
apps flag to use DesktopModeFlags.

Test: Current tests pass
Bug: 348193756
Flag: com.android.window.flags.show_desktop_windowing_dev_option
Change-Id: Id63de7c9630fcc5ab2185829b42883e51774cfcf
2024-07-31 15:34:46 +00:00
Luca Zuccarini 3cdabb8864 Move some Shell utils to the Shared package.
Bug: 322791067
Flag: EXEMPT move only
Test: NA
Change-Id: I8a827a200340fd1ee0168ed16c4f5223150a1795
2024-07-31 14:10:54 +00:00
Alina Zaidi 00614eae0e Use DesktopModeStatus#canEnterDesktopMode instead of just Flag check.
Test: Existing tests pass
Bug: 349544589
Flag: EXEMPT minor refactoring
Change-Id: Idf572d48d35b8eeedd7fd1b8c608834d27a818e7
2024-07-31 10:47:16 +00:00
mpodolian 484ff0fe9c Integrated new BubbleStashControllers into the existing code.
Integrated the PersistentTaskbarStashController and the
TransientTaskbarStashController into the launcher code. Made changes to
the TaskbarInsetsController to set appropriate touchable zones. Updated
the TaskbarUIController to not start the overview transition on clicks
for the collapsed bubble bar.

Bug: 346391377
Fixes: 350065038
Fixes: 355664783
Flag: com.android.wm.shell.enable_bubble_bar_in_persistent_task_bar
Test: com.android.launcher3.taskbar package tests

persistent taskbar and transient taskbar manual testing:
- on launcher home screen expand bubble bar, switch between bubbles,
remove bubble via bubble menu, add bubble, remove bubble with the drug
gesture, add bubble, collapse bubble bar
- repeat previous test on launcher overview screen and inside any
application
- after last test drag expanded bubble view to the opposite side of the
screen

Change-Id: I50f2c510854c4895fdfc9bd453a261c2103286fd
2024-07-30 18:36:05 -07:00
Jagrut Desai f35cb42732 Merge "Initialize TaskbarFeatureEvaluator and SpecsEvaluator onlyu if customization is on" into main 2024-07-30 22:19:10 +00:00
Vinit Nayak 0e5e564557 Merge "Call FallbackRecentsView#init() before setContentView()" into main 2024-07-30 20:05:11 +00:00
Mykola Podolian bd8b839e0d Merge "Added scrim visibility check." into main 2024-07-30 18:19:01 +00:00
Bill Yi e240b1c2f5 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-07-30 18:13:51 +00:00
Vinit Nayak aeecb1e8a5 Call FallbackRecentsView#init() before setContentView()
* Init sets mSplitSelectStateController which RecentsView
then uses in onAttachedToWindow(). That needs to be set
before it gets attached to the window, which happens in
RecentsActivity#setContentView()

Fixes: 332643607
Test: Only presubmit, issue not reproducible
Flag: EXEMPT bugfix
Change-Id: Icc555cad17b734e2a9c035991c19bbdc6b02de5d
2024-07-30 10:48:40 -07:00
Mykola Podolian 0211d2e168 Merge "Change shadow drawing for bubble bar icons." into main 2024-07-30 17:16:51 +00:00
Treehugger Robot afc2f976e3 Merge "Revert "Initial view screenshot tests for BubbleView"" into main 2024-07-30 16:55:41 +00:00
Jon Miranda e8b47c540f Merge "Add support for taskbar background to wrap around hotseat" into main 2024-07-30 15:59:48 +00:00
Liran Binyamin 3795d3782b Revert "Initial view screenshot tests for BubbleView"
Revert submission 28447963-launcher-view-screenshot-tests

Reason for revert: breaks the build -- conflicts with another cl

Reverted changes: /q/submissionid:28447963-launcher-view-screenshot-tests

Change-Id: If40903403d72e8b1bf776feccaa34dbc3e3e8ae2
2024-07-30 15:04:21 +00:00
Liran Binyamin 419b917e74 Merge "Initial view screenshot tests for BubbleView" into main 2024-07-30 14:38:15 +00:00
Liran Binyamin 6c2e466edd Merge "Animate the bubble badge" into main 2024-07-30 12:35:32 +00:00
Alex Chau e7a87f3fa8 Merge "Don't show splash when thumbnail is null in SplashAlphaUseCaseTest" into main 2024-07-30 10:44:50 +00:00
Bill Yi e9f8e217aa Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I14929284692b154b650a199ae93fb7e7abc36dc4
2024-07-29 18:56:08 -07:00
Tracy Zhou 2003bc8dd8 Do not synchronizeNextDraw in phone mode
Bug: 355973871
Test: Needs to verify with perfetto traces
Flag: com.android.wm.shell.enable_taskbar_on_phones
Change-Id: I84c258020951274915792d75d67c263135bbf2a9
2024-07-29 18:27:09 -07:00
mpodolian c10de368a2 Change shadow drawing for bubble bar icons.
Removed an outline provider for the BubbleView, so framework shadows are
not drawn. Use BubbleBarBubbleIconsFactory to generate icon with the
shadow so it looks consistent with the taskbar and the hotseat bar.

Fixes: 345490679
Flag: com.android.wm.shell.enable_bubble_bar
Test: manual, screenshot before fix:
https://screenshot.googleplex.com/86ZhQENANboZK87
screenshot after fix:
https://screenshot.googleplex.com/3hNboaSaS9tZ9DS

Change-Id: I9ae3624e652e4f609b29ae0f57a47d4a6d01e94b
2024-07-29 16:25:54 -07:00
Jagrut Desai 5e8b535af6 Initialize TaskbarFeatureEvaluator and SpecsEvaluator onlyu if customization is on
Test: presubmit
Bug: 353841430
Flag: com.android.launcher3.enable_taskbar_customization
Change-Id: I5699e99eee0817327ca66598bfccb622801762ab
2024-07-29 15:14:55 -07:00
Liran Binyamin 612263104b Animate the bubble badge
The bubble badge now scales together with the expand and collapse
animation of the bubble bar. The badge for the selected bubble is
always kept at full scale.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 349826874
Test: manual
       - create some bubbles in the bubble bar
       - expand and collapse the bar
       - observe badge icons scale accordingly
Change-Id: I04e9174f4a921e404cb3162337f594c16478b16c
2024-07-29 08:06:55 -04:00
Alex Chau 2a640c61a7 Don't show splash when thumbnail is null in SplashAlphaUseCaseTest
- thumbnail is always null to begin with, and we don't want the splash icon to ever shown in Overview, so it should default to hidden

Fix: 356079562
Test: SplashAlphaUseCaseTestTest
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I2a010f911814fda2bbcf0ca7ebc7192580772076
2024-07-29 11:28:19 +01:00
Liran Binyamin 4b4122d02e Initial view screenshot tests for BubbleView
Flag: EXEMPT test only
Bug: 355454021
Test: atest NexusLauncherViewScreenshotTests

Change-Id: I32c2a190333143c1ec2fe977efef43b4c04fd469
2024-07-29 04:39:28 -04:00
Treehugger Robot 453734f09e Merge "Support switch to screenshot for TTV" into main 2024-07-27 00:14:26 +00:00
Jagrut Desai 65b5eb472e Merge "Unit Testing for TaskbarEduTooltipController" into main 2024-07-26 22:44:16 +00:00
Alex Chau 378622c907 Support switch to screenshot for TTV
- Moved live tile decision to TaskThumbnailViewModel, and added RecentsViewData for runningTask information
- Implemented a ThumbnailData override mechanism to override screenshot from TaskThunmbnailCache, the override will be added during switchToScreenshot and cleared when user exit recents (RecentsView.reset)
- During the thumbnail override, we wait until the new ThumbnailData propagates, before finsihing Recents animation to avoid a frame of flash

Bug: 343364498
Test: TaskThumbnailViewModelTest, TaskRepositoryTest, RecentsViewModelTest
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I776943ecdfa0d65d94b054692297b42686f59f8a
2024-07-26 21:25:58 +01:00
Andy Wickham 369a5e749b Merge "Add 2 stage LPNH tests." into main 2024-07-26 19:38:27 +00:00
Schneider Victor-tulias c8a533d542 Revert "Add debug logs to TopTaskTracker"
This reverts commit 86b9ad4ff7.

Reason for revert: debug logs no longer needed

Change-Id: Ia64f9e50934ac685f75f5109fc694720a07f17ac
2024-07-26 19:25:36 +00:00
Jagrut Desai 5af1bfbf52 Unit Testing for TaskbarEduTooltipController
This CL includes
	- TaskbarEduTooltipController Unit Test for all edu logic and hide tooltip
	- Test util class for taskbar controller test to run the test on main thread.
	- Refactored other controller test to use the new util function to run test on main thread.
	- Ability to disable running test in test harness mode.

Test: Presubmit
Bug: 346394824
Flag: TEST_ONLY
Change-Id: Ic623df8e7a58ac48d260e592ffab61d1f0658aef
2024-07-26 12:14:50 -07:00
Mykola Podolian 550927be44 Merge "Added TransientTaskbarStashController implementation." into main 2024-07-26 16:59:46 +00:00
Perry Wu f1e7136cce Merge "Fix launcher KCA updates when entering -1 screen" into main 2024-07-26 16:14:42 +00:00
Jon Miranda 5dc07d786f Add support for taskbar background to wrap around hotseat
Currently only enabled for app launch animation

Future work is planned:
- Overview to home
- App dismiss
- When QSB is drawn inline

Bug: 345768019
Test: Launch an app, taskbar background and stashed handle will
      first wrap around hotseat before transforming into the
      stashed handle.
      Verified by locally forcing taskbar background and
      stashed handle to always draw.
Flag: com.android.launcher3.enable_scaling_reveal_home_animation
Change-Id: I9ab1870f87247b6a1b53a352ac3eb0183b7a1a1d
2024-07-26 08:10:50 -07:00
Treehugger Robot b7b48bbbd3 Merge "Revert "Handle uiMode changes in QuickstepLauncher"" into main 2024-07-26 12:08:53 +00:00
Vinay Joglekar 084fe14c50 Merge "Remove todo to Support sysUiStatusNavFlags" into main 2024-07-26 11:52:35 +00:00
Alex Chau 2676385eb8 Revert "Handle uiMode changes in QuickstepLauncher"
Revert submission 27627108-b/339747262

Reason for revert: b/353914086
Fix: 353450667
Fix: 353914086
Bug: 339747262

Reverted changes: /q/submissionid:27627108-b/339747262

Change-Id: I9a71ee0fa4062b15e68eff41951f42d46ace19d3
2024-07-26 10:18:20 +00:00
vinayjoglekar 9f9cea38aa Remove todo to Support sysUiStatusNavFlags
Bug: 350743460
Test: NA
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: Ie61ffc6ef7876f2907cf3d223eb7ed11d72e28c4
2024-07-26 10:03:14 +00:00
mpodolian a5cd1a0dbb Added TransientTaskbarStashController implementation.
Added TransientTaskbarStashController implementation of
BubbleStashController interface. Added tests for the implementation.

Bug: 346391377
Flag: com.android.wm.shell.enable_bubble_bar
Test: TransientTaskbarStashController
Change-Id: Ie302086d6b4aac48a948473908b68c2c436e4b30
2024-07-26 02:19:00 +01:00
Tracy Zhou 7617787c80 Merge "Allow trackpad to tune RAPID_DECELERATION_FACTOR for gesture nav" into main 2024-07-26 00:35:02 +00:00
Andy Wickham e935438787 Add 2 stage LPNH tests.
Fix: 353613649
Test: NavHandleLongPressInputConsumerTest
Flag: TEST_ONLY

Change-Id: I99f4eb5f999d2769cc2d9e1eb1d04ae6c5ff27db
2024-07-25 23:21:16 +00:00
Evan Rosky e56cb3dbf5 Merge "Skip launcher return for custom task transitions" into main 2024-07-25 22:13:53 +00:00
Tracy Zhou 8e56fe3912 Allow trackpad to tune RAPID_DECELERATION_FACTOR for gesture nav
- RAPID_DECELERATION_FACTOR determines whether swipe up from app takes the user to overview vs. home

Bug: 355457714
Test: adb shell setprop trackpad_in_app_swipe_up_deceleration_factor 0.6f
Flag: EXEMPT bugfix

Change-Id: I205e72c82dc08b9e542420ca1adc8f7c0eb0953d
2024-07-25 12:52:03 -07:00
Mykola Podolian c4ae2f65b6 Merge "Improvement for the Bubble Bar Bubbles' Shadows" into main 2024-07-25 18:35:22 +00:00
Ats Jenk c11fd79ec4 Merge "Include bubble bar location in taskbar announcement" into main 2024-07-25 17:43:43 +00:00
Treehugger Robot 4a6c90d552 Merge "Add unit tests for MultiStateCallback" into main 2024-07-25 17:43:24 +00:00
Liam, Lee Pong Lam 85f3476943 Fixes SettingsChangeLoggerTest failures
The mLoggablePrefs was created on constructor, so move the system under test out of setup because the preference change needs to be made before it.
For details: https://source.corp.google.com/h/googleplex-android/platform/superproject/main/+/main:packages/apps/Launcher3/quickstep/src/com/android/quickstep/logging/SettingsChangeLogger.java;drc=c56711c6691e7957ed98a9de6b3acb79103abb66;l=95

Bug: 354157494
Test: Unit tests
Flag: EXEMPT bugfix

Change-Id: I2fd5eec5b10d7463c663df03cfefefb11bcefecc
2024-07-25 17:18:15 +00:00
Perry Wu 603f408bf8 Fix launcher KCA updates when entering -1 screen
Fix an issue where launcher incorrectly sets KCA as visible when
entering the -1 screen. This adds a check for whether we are on the
-1 screen.

Note that there is still a another callback that happens when
interacting or exiting the -1 screen, could be worth investigating
further.

Flag: EXEMPT bugfix
Test: enter -1 screen > verify pip moves down and KCA visible=false
Test: exit -1 screen > verify pip moves up and KCA visible=true
Bug: b/354080363
Change-Id: I1b8c05af21eca5a2accc8e94ab016f6c50c74c7c
2024-07-25 17:00:17 +00:00
Uwais Ashraf 06dd94c66a Add splash state to new TTV
Bug: 334826842
Test: test classes added in CL
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: Ia7c2de18b5ff932430946df6b4c27929d715e79c
2024-07-25 14:35:00 +00:00