PawletOS/Lawnchair
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
78,507 Commits 1 Branch 0 Tags
eedc7ab8fdb94de05201fa87537991558accbe8a
Commit Graph

20478 Commits

Author SHA1 Message Date
Winson Chung c0d4768083 Merge "Try to detect and handle delayed quickswitch task launch failure" into udc-dev am: 8e7e159645 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22841404

Change-Id: Ic56a7295e03f04c5b0f0613e9a025352929ac064
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-05-06 07:52:28 +00:00
Winson Chung 8e7e159645 Merge "Try to detect and handle delayed quickswitch task launch failure" into udc-dev 2023-05-06 07:12:18 +00:00
Treehugger Robot 1e0a0534b8 Merge "Updating SurfaceTransactionApplier to handle view not being attached" into udc-dev am: 8b0fcbffb0 am: 4f00ae9e76 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23066497

Change-Id: I14b23b570a9a63dd085ff9ad62dc8ffc856e7d3d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-05-06 03:21:11 +00:00
Treehugger Robot 4f00ae9e76 Merge "Updating SurfaceTransactionApplier to handle view not being attached" into udc-dev am: 8b0fcbffb0 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23066497

Change-Id: Id7faac43f67f98127b8fa223fa3dbd62b3a3d502
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-05-06 02:42:17 +00:00
Treehugger Robot 1815a4c555 Merge "Updating SurfaceTransactionApplier to handle view not being attached" into udc-dev am: 8b0fcbffb0 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23066497

Change-Id: Ie0d5beaaedb14adba33ee1f24a6c5c867b5f0780
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-05-06 02:38:25 +00:00
Treehugger Robot 8b0fcbffb0 Merge "Updating SurfaceTransactionApplier to handle view not being attached" into udc-dev 2023-05-06 01:57:51 +00:00
Saumya Prakash 2a4a5202c5 Merge "Remove unused Sandbox Mode in the gesture navigation tutorial" into udc-dev am: 958eabcd8f am: a6e71d3cf4 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23002490

Change-Id: Ia3ae03f51af73f26a7828fe3915615b5a1c3528d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-05-06 00:14:55 +00:00
Mady Mellor c37bf46381 Adds BubbleControllers to TaskbarControllers 
* BubbleControllers is optionally available (gated behind a flag).
* The bubble bar controllers follow init & onDestroy after the taskbar
  controllers.
* Adds the relevant views used by the bubble controllers to the
  transient taskbar layout.

Bug: 253318833
Test: manual, with other CLs, see go/bubble-bar-tests
Flag: WM_BUBBLE_BAR
Change-Id: I685163cdcc912768b1a720952762f4cbc602b14b
 2023-05-05 17:02:38 -07:00
Winson Chung df51c1ada8 Try to detect and handle delayed quickswitch task launch failure 
- The main issue arises when a task is successfully launched from
  overview, but the activity later finishes (ie. during resume) which
  prevents the usual logic of resetting Launcher to a good state
  (ie. it can get stuck in overview with a blank or empty snapshot)

  In this case, the Launch will "succeed" so that onTaskLaunchFailed
  is not called, but then also silently fail (launched task finishes
  and Launcher is again resumed) before Launcher stops, which does the
  usual resetting of the state back to normal state after quickswitching.

  This change checks for this case by listening for the activity and
  transition state, and in the case where Launcher has not been stopped
  or is resumed again after the transition finishes, returns the
  user to the default home state.

  This primarily only affects quickswitch for now, as other launch
  failures leave the user in a valid state (ie. overview) while this
  issue will leave the user in background state while quickswitching.

Bug: 268448123
Test: Quickswitch to an activity that finishes when resumed
Change-Id: I7d554f8fd521f7bc480dc06930ad91eeef0f1a1a
 2023-05-05 23:55:22 +00:00
Saumya Prakash a6e71d3cf4 Merge "Remove unused Sandbox Mode in the gesture navigation tutorial" into udc-dev am: 958eabcd8f 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23002490

Change-Id: Ia3d62df5f0585c84c18cb8eed34e87144113954e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-05-05 23:30:54 +00:00
Saumya Prakash 93a0cc9f01 Merge "Remove unused Sandbox Mode in the gesture navigation tutorial" into udc-dev am: 958eabcd8f 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23002490

Change-Id: I66a932e91d9969f284d6c978a3a901670acbf669
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-05-05 23:26:38 +00:00
Sunny Goyal 63cf4d07a8 Updating SurfaceTransactionApplier to handle view not being attached 
Bug: 278833389
Test: Presubmit
Flag: N/A
Change-Id: I88c240a1a7bdfe2e68c858c30e91cc5d06bc7bcf
 2023-05-05 15:57:42 -07:00
Saumya Prakash 958eabcd8f Merge "Remove unused Sandbox Mode in the gesture navigation tutorial" into udc-dev 2023-05-05 22:52:54 +00:00
Schneider Victor-tulias d86c5657e0 Fix null-pointers in SurfaceTransactionApplier constructor. 
A recurring class of null pointers are caused by using views with no view root implementation in SurfaceTransactionApplier from QuickstepTransitionManager. This can happen when we use launcher views after it has been destroyed.

- No longer using mDragLayer in getFallbackClosingWindowAnimators; simply applying the transaction immediately.
- Forcefully using getFallbackClosingWindowAnimators when launcher is destroyed.

Flag: not needed
Bug: 278833389
Test: launches and closed several apps in 3-button and gesture nav mode
Change-Id: I83b3aec1488fe9666bd0301a6044a181bb05dbdd
 2023-05-05 21:53:50 +00:00
Mady Mellor 50e8d0ff60 Add Bubbles and BubblesListener to SystemUiProxy and use it 
Adds a method to call into WMShell to set the listener and
indicate when a bubble is shown or when the expanded state
changes.

BubbleBarController sets or clears out the listener.

BubbleBarViewController calls SystemUiProxy when bubbles are shown
or when the expanded state changes.

Bug: 253318833
Test: manual, with other CLs, see go/bubble-bar-tests
Flag: WM_BUBBLE_BAR
Change-Id: I2364b9bbdea237fc268b0999d9c896585c194a86
 2023-05-05 14:18:00 -07:00
Qiao Yang 9a2b648a04 Merge "Revert "Revert "Listen for hover events over stashed taskbar.""" into udc-dev am: 1aee68df56 am: 5079b44fad 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23063440

Change-Id: I933714897c03dfb221ea390ce5bd27da83a82bb8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-05-05 19:52:58 +00:00
Liran Binyamin b7d3d64d68 Use a property instead of a getter function for key in BubbleBarBubble. Using a property here is more Kotlin idiomatic. 
https://kotlinlang.org/docs/coding-conventions.html#functions-vs-properties
go/kotlin/practices/properties#when

Bug: 281083629
Test: Verified on a physical device
Change-Id: I4c003c6633bf1913ee5e1e86224a679ff3442e2b
 2023-05-05 19:43:43 +00:00
Qiao Yang 5079b44fad Merge "Revert "Revert "Listen for hover events over stashed taskbar.""" into udc-dev am: 1aee68df56 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23063440

Change-Id: Id81af4051c206031901b560102f6c3e3d2bc9a47
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-05-05 19:35:36 +00:00
Qiao Yang b4204df189 Merge "Revert "Revert "Listen for hover events over stashed taskbar.""" into udc-dev am: 1aee68df56 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23063440

Change-Id: Ia2eb0ba323c37ccbd6694209f35695c80e9c4a21
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-05-05 19:34:38 +00:00
Qiao Yang 9482945a20 Merge "Revert "Listen for hover events over stashed taskbar."" into udc-dev am: 51669b612f am: 854b0bda4d 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23048070

Change-Id: I32d94b805a6b41b778a071f5e31ada6c65319ad4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-05-05 19:32:19 +00:00
Qiao Yang 1aee68df56 Merge "Revert "Revert "Listen for hover events over stashed taskbar.""" into udc-dev 2023-05-05 19:09:44 +00:00
Qiao Yang 2482c8dcd4 Revert "Revert "Listen for hover events over stashed taskbar."" 
This reverts commit c27605099c.

Reason for revert: DroidMonitor-triggered revert due to breakage <https://android-build.googleplex.com/builds/quarterdeck?branch=git_udc-dev&target=cf_x86_64_phone-userdebug&lkgb=10076607&lkbb=10076982&fkbb=10076788>, bug <281093059>

Change-Id: I71e7fd07232c27a004243df0ffb0457fe53fe13b
 2023-05-05 19:07:17 +00:00
Qiao Yang 611dca65e1 Merge "Revert "Listen for hover events over stashed taskbar."" into udc-dev am: 51669b612f 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23048070

Change-Id: I7ae65fafd4fbab42b8137e25bd7b07e3ef4d94ac
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-05-05 18:51:15 +00:00
Qiao Yang 854b0bda4d Merge "Revert "Listen for hover events over stashed taskbar."" into udc-dev am: 51669b612f 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23048070

Change-Id: Id347f25441e8551e19f17796b5304365dec7084e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-05-05 18:50:08 +00:00
Stefan Andonian 128b8a56ed Merge "Enforce setting up SystemUIProxy on the main thread." into udc-dev am: 5882e97857 am: f6925ba287 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23045938

Change-Id: I405518772027f74f20fc98905c5e223fc22f9cc8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-05-05 18:26:45 +00:00
Qiao Yang 51669b612f Merge "Revert "Listen for hover events over stashed taskbar."" into udc-dev 2023-05-05 18:05:16 +00:00
Stefan Andonian 54eafd482c Merge "Enforce setting up SystemUIProxy on the main thread." into udc-dev am: 5882e97857 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23045938

Change-Id: Ie899a18dfcda9ea0f5bb6e7d9981f1cea87f1b99
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-05-05 17:55:33 +00:00
Stefan Andonian f6925ba287 Merge "Enforce setting up SystemUIProxy on the main thread." into udc-dev am: 5882e97857 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23045938

Change-Id: Ia039dbbabb99f701bb10e68aaaf51da38c8b3fc5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-05-05 17:54:12 +00:00
Pat Manning c27605099c Revert "Listen for hover events over stashed taskbar." 
This reverts commit c5882bcdfc.

Reason for revert: b/281068877

Change-Id: I431678658fc464c995df0df5e3cac5491d91b052
 2023-05-05 17:22:21 +00:00
Stefan Andonian 5882e97857 Merge "Enforce setting up SystemUIProxy on the main thread." into udc-dev 2023-05-05 16:56:10 +00:00
Brian Isganitis f3135fea05 Don't close AFVs when opening Taskbar folder. 
Test: Manual
Fix: 276798702
Change-Id: I35fe528bf3ad7fb374b8d8ae83f0d525e131681e
 2023-05-04 23:55:23 -04:00
Brian Isganitis 9c311b2917 Keep persistent Taskbar visible over Taskbar All Apps. 
Additionally, this CL fixes some touchable insets issues with the
overlay window. Dragging and dropping is now reliable from taskbar while
All Apps or EDU is also open.

Change-Id: Ia612c1b5266a8fb2b7005a773fbd2b00ec4824db
Bug: 279465803
Bug: 275890048
Bug: 264463659
Flag: PERSISTENT_TASKBAR_OVER_TASKBAR_ALL_APPS (Teamfood)
Test: Taskbar is functional over All Apps and EDU.
 2023-05-04 23:54:27 -04:00
Treehugger Robot 889bbc9d88 Merge "Listen for hover events over stashed taskbar." into udc-dev am: b6f64a4465 am: 7ef7275a16 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22688404

Change-Id: I3f1456b6388344467f11c28d052f3cab0e0a8f92
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-05-05 00:20:44 +00:00
Treehugger Robot 6d4b9b52a8 Merge "Listen for hover events over stashed taskbar." into udc-dev am: b6f64a4465 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22688404

Change-Id: I62fd6d6e1bfc420904457bd26fe1fc47a56cbc8d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-05-05 00:00:52 +00:00
Treehugger Robot 7ef7275a16 Merge "Listen for hover events over stashed taskbar." into udc-dev am: b6f64a4465 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22688404

Change-Id: I39ff622d303c43de40883e5cc7b96a6a83c669de
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-05-05 00:00:16 +00:00
Brian Isganitis eee155dfcd Merge "Add header protection for Taskbar All Apps search bar." into udc-dev am: 64ee67c6b5 am: 2f7bbc40b6 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22466105

Change-Id: Ia3d84859e31ce2848f7d6a631f57af15a641b97a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-05-04 23:48:39 +00:00
Treehugger Robot b6f64a4465 Merge "Listen for hover events over stashed taskbar." into udc-dev 2023-05-04 23:15:44 +00:00
Brian Isganitis e273753af4 Merge "Add header protection for Taskbar All Apps search bar." into udc-dev am: 64ee67c6b5 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22466105

Change-Id: I9a75961ca892b36de5bd012d76589d2c480a8324
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-05-04 22:58:13 +00:00
Brian Isganitis 2f7bbc40b6 Merge "Add header protection for Taskbar All Apps search bar." into udc-dev am: 64ee67c6b5 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22466105

Change-Id: Ied72dab1c786491c6e0e0c21e95530066d3158ff
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-05-04 22:56:38 +00:00
Bill Yi 1d084748ec Merge "Import translations. DO NOT MERGE ANYWHERE" 2023-05-04 22:28:31 +00:00
Stefan Andonian 672fa7a9a9 Enforce setting up SystemUIProxy on the main thread. 
Bug: 280086782
Test: Added annotations and device did not crash under normal usage.
Change-Id: Ie587aafaaa018a3e6a5c33ca238e204f5cc0ea4e
 2023-05-04 22:28:26 +00:00
Brian Isganitis 64ee67c6b5 Merge "Add header protection for Taskbar All Apps search bar." into udc-dev 2023-05-04 22:20:46 +00:00
Liran Binyamin 481da63b39 Wire up the important conversation bit in BubbleBarController. 
Fixes: 269671451
Test: Tested on a physical device
Change-Id: Ice0bb081e19a817bd163141f38614ea7ecc21be9
 2023-05-04 16:45:49 -04:00
Brian Isganitis 23a1633522 Merge "Only close overlays onTaskMovedToFront for desktop prototype." into udc-dev am: cd7078372a am: 3fef8ec8c2 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22975846

Change-Id: I0a42222845605deb31eee7bbafc4fdcbdd0570b2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-05-04 20:05:28 +00:00
Brian Isganitis f7c6db9021 Merge "Only close overlays onTaskMovedToFront for desktop prototype." into udc-dev am: cd7078372a 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22975846

Change-Id: Ib728acfb1ad96c67fe9075495687a015d8d2d74b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-05-04 20:01:51 +00:00
Brian Isganitis 3fef8ec8c2 Merge "Only close overlays onTaskMovedToFront for desktop prototype." into udc-dev am: cd7078372a 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22975846

Change-Id: I8f01394cc7c9ccb60e9110ccbd46dd52f96a39b6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-05-04 20:00:40 +00:00
Pat Manning c5882bcdfc Listen for hover events over stashed taskbar. 
Bug: 243191650
Test: TaplTestsTaskbar
Flag: ENABLE_CURSOR_HOVER_STATES
Change-Id: Ia189ac6a6097d073c40c69ead6ecaf398d22eba8
 2023-05-04 20:35:44 +01:00
Brian Isganitis cd7078372a Merge "Only close overlays onTaskMovedToFront for desktop prototype." into udc-dev 2023-05-04 18:55:42 +00:00
Winson Chung 58717a70c5 Potential fix for end callback not being run in 3-button 
- Context: With shell transitions, the launch of a new task is merged
  into the same recents transition that is running, which means that it
  does not run as its own independent transition (this probably needs
  to be addressed in the transitions level somehow)
- Given the above, if there is somehow no running task id, then we still
  need to rely on the next task appeared to trigger the flush of the
  callback list (since the animation will not run to flush that callback)

Bug: b/255851262
Test: Manually simulate getRunningTaskViewId() == 1 and verify

Change-Id: I778f22fa59cb1620781f7aa442d244793352d74e
Signed-off-by: Winson Chung <winsonc@google.com>
 2023-05-04 18:01:19 +00:00
Schneider Victor-tulias 8b85219844 Merge "Revert "Fix broken TaplTestsTaskbar splitscreen test cases"" into udc-dev am: d1054fd86b am: 2b1a1ee0b2 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22915139

Change-Id: Idb0badfd0d3f7b6f700deee71ebaf6b8bb898f72
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-05-04 17:51:24 +00:00