Commit Graph

62737 Commits

Author SHA1 Message Date
Tracy Zhou ed96865005 Merge "Center taskbar nav buttons in small screen" into udc-qpr-dev 2023-08-08 00:12:54 +00:00
Jon @ e3d6188343 Merge "Enable ENABLE_DYNAMIC_TASKBAR_THRESHOLDS for teamfood." into udc-qpr-dev 2023-08-07 19:30:52 +00:00
Tracy Zhou c73ce34730 Merge "Teamfood ENABLE_SPLIT_FROM_FULLSCREEN_WITH_KEYBOARD_SHORTCUTS" into udc-qpr-dev 2023-08-07 18:29:58 +00:00
Jon Miranda fef90aa57f Enable ENABLE_DYNAMIC_TASKBAR_THRESHOLDS for teamfood.
Bug: 274467454
Test: manual
Change-Id: I5fe1e2ce2e4edaac1c6c4d2a1eda0ef99257e88a
2023-08-07 11:01:50 -07:00
Treehugger Robot 77204f4608 Merge "Add better logging around long launcher operations during unfold" into udc-qpr-dev 2023-08-07 17:25:05 +00:00
Treehugger Robot 93e088dc1c Merge changes Ifa66cfb7,Ied7867fb into udc-qpr-dev
* changes:
  Add dynamic thresholds for taskbar based on screen size.
  Add ENABLE_DYNAMIC_TASKBAR_THRESHOLDS feature flag.
2023-08-07 16:27:36 +00:00
Nicolo' Mazzucato e120fcfa47 Add better logging around long launcher operations during unfold
This logging helps understanding what's going on in Launcher main thread
 during unfold from perfetto traces.

Test: Perfetto trace after unfolding
Bug: 292472402
Change-Id: I7a037d9a129deb4bfe4310fdba664b87164ef2ca
2023-08-07 12:18:10 +00:00
Tracy Zhou dcae0e86ac Center taskbar nav buttons in small screen
Bug: 288311605
Test: All the buttons are in centered in all orientations
Change-Id: Ibb9dc57e38a2e61c426f1edfbf771634d5e3cbb1
2023-08-06 21:03:04 -07:00
Bill Yi 99f30cb125 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 19e80fd3e1 -s ours am: 39a0822389 -s ours am: 84f8b32a61 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24318969

Change-Id: I85ac520fb04443129ff224e368437c24cc649f32
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-05 08:19:19 +00:00
Bill Yi 84f8b32a61 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 19e80fd3e1 -s ours am: 39a0822389 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24318969

Change-Id: Ib753922c42e619bc7c3b42b6f48d5282f351a7c8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-05 07:55:47 +00:00
Bill Yi 39a0822389 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 19e80fd3e1 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24318969

Change-Id: I46480725d054efd82e8a465ccc6b570686263bd0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-05 07:11:17 +00:00
Tracy Zhou b7cd64d5b7 Merge "Update nav button color when nav button layout changes" into udc-qpr-dev 2023-08-05 07:01:07 +00:00
Bill Yi 830e67c5c5 Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-qpr-dev 2023-08-05 03:31:42 +00:00
Randy Pfohl 7d19aecf5a Merge "attempting to catch security exception to prevent full crash" into udc-qpr-dev 2023-08-04 22:50:40 +00:00
Jon Miranda a625f58737 Add dynamic thresholds for taskbar based on screen size.
Bug: 274467454
Test: Manually test that each threshold is as expected
Change-Id: Ifa66cfb78f544bb4d14391e70badc92589d47a26
2023-08-04 14:35:56 -07:00
Sunny Goyal b4ca0df78a [automerger skipped] Merge "Log appear animation's scale factor" into udc-dev am: 7a080a7e0f am: 0b1089978f -s ours
am skip reason: Merged-In Ic33dc94806b838a03a2203bdd5701a1eeaeeb7bf with SHA-1 da718e9749 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24154592

Change-Id: Id59a2612f5c40894ba3ba53e4a380f1820efd1c7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-04 21:04:24 +00:00
randypfohl d6568db503 attempting to catch security exception to prevent full crash
Test: built locally

Bug: 283074997
Change-Id: I9b60740c6de04422f69534e6a17d1858018f61e9
2023-08-04 13:40:01 -07:00
Sunny Goyal 0b1089978f Merge "Log appear animation's scale factor" into udc-dev am: 7a080a7e0f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24154592

Change-Id: Ibf1f54176e73578fc9cd1cc2510022e3c6a84237
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-04 20:39:57 +00:00
Holly Jiuyu Sun 9235ef85ce Merge "Refresh mNumAppsPerRowAllApps when device profile changes." into udc-qpr-dev 2023-08-04 20:27:49 +00:00
Sunny Goyal 7a080a7e0f Merge "Log appear animation's scale factor" into udc-dev 2023-08-04 20:13:43 +00:00
Treehugger Robot c5ef96a424 Merge changes Iafdad8f2,Ia85c1e84 into udc-qpr-dev
* changes:
  Turn off ENABLE_ALL_APPS_RV_PREINFLATION and ALL_APPS_GONE_VISIBILITY
  Revert "Revert "Make AllAppsRecyclerViewContainer GONE when hidden""
2023-08-04 19:45:11 +00:00
Federico Baron 410344860c Merge "Add logs around BaseDepthController to investigate b/291401432" into udc-qpr-dev 2023-08-04 19:44:40 +00:00
Bill Yi 93974f4803 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 39e9688873 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24316145

Change-Id: If9783604a548ba1f32f4644ff47f89ac53f3c50a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-04 19:36:33 +00:00
Jon Miranda f762e17fa3 Add ENABLE_DYNAMIC_TASKBAR_THRESHOLDS feature flag.
Bug: 294252473
Bug: 274467454
Test: N/A
Change-Id: Ied7867fbae602303c699afc3da7f88eef7aeb728
2023-08-04 11:43:27 -07:00
Ats Jenk f00906cc3d Merge "Use window corner radius for desktop task snapshots" into udc-qpr-dev 2023-08-04 17:55:12 +00:00
Fengjiang Li 2f2306c14b Turn off ENABLE_ALL_APPS_RV_PREINFLATION and ALL_APPS_GONE_VISIBILITY
Test: Tested in ag/24107285
Bug: 264341825
Change-Id: Iafdad8f2aabe4296befc00800dc9a1fdfd58dc6f
2023-08-04 10:29:03 -07:00
Fengjiang Li 98c91a65cf Revert "Revert "Make AllAppsRecyclerViewContainer GONE when hidden""
This reverts commit a163646c7a.

Reason for revert: Re-submit with ENABLE_ALL_APPS_RV_PREINFLATION and ALL_APPS_GONE_VISIBILITY turned off in child CL (submit together)

Test: Tested in ag/24107285
Change-Id: Ia85c1e8447c45ff44814ad4bfe0f178a72d0e7d3
2023-08-04 10:28:36 -07:00
Bill Yi 19e80fd3e1 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I1cab0c87deec793f9deb39d01005d9a90e8d5d8b
2023-08-03 21:56:44 -07:00
Bill Yi 39e9688873 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ic65ee5796da63c3999571e23307fffec332bebfe
2023-08-03 21:56:20 -07:00
Inseob Kim 40a44e08b9 Merge "Revert "Make AllAppsRecyclerViewContainer GONE when hidden"" into udc-qpr-dev 2023-08-04 04:13:28 +00:00
Inseob Kim a163646c7a Revert "Make AllAppsRecyclerViewContainer GONE when hidden"
This reverts commit df59c2e535.

Reason for revert: b/293944420

Change-Id: I0ae830e1a5ba8affb6815c9e96ffee1b20c6e8d0
2023-08-04 02:18:44 +00:00
Bill Yi 98830fcbd6 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ib3a3dee039404b6f7fdad4d2ac524ea78262a5d3
2023-08-03 18:58:26 -07:00
Fengjiang Li 2303acd7d4 Log appear animation's scale factor
Test: Grabbed a bug report b/291974797
Flag: N/A
Bug: 290320302
Change-Id: Ic33dc94806b838a03a2203bdd5701a1eeaeeb7bf
Merged-In: Ic33dc94806b838a03a2203bdd5701a1eeaeeb7bf
2023-08-03 14:25:00 -07:00
Holly Sun 19f6525546 Refresh mNumAppsPerRowAllApps when device profile changes.
The return value of SrollableLayoutManager#getItemsHeight is wrong, which is caused by the return value of `incrementTotalHeight` (https://source.corp.google.com/h/googleplex-android/platform/superproject/main/+/main:packages/apps/Launcher3/src/com/android/launcher3/util/ScrollableLayoutManager.java;l=151-163). In AllAppsGridAdapter#incrementTotalHeight (https://source.corp.google.com/h/googleplex-android/platform/superproject/main/+/main:packages/apps/Launcher3/src/com/android/launcher3/allapps/AllAppsGridAdapter.java;l=172), `item.rowAppIndex` is still the staled value after app grid change / device fold & unfold. This value is calculated in AlphabeticalAppsList (https://source.corp.google.com/h/googleplex-android/platform/superproject/main/+/main:packages/apps/Launcher3/src/com/android/launcher3/allapps/AlphabeticalAppsList.java;l=276-280). The mod `mNumAppsPerRowAllApps` is staled. So add an setter in `AlphabeticalAppsList` to update `mNumAppsPerRowAllApps`.

Bug: 262003765
Bug: 284940820
Test: manual
Flag: N/A
Change-Id: I74a99a3dc58ee45f066bcefb3e9c56be02b62f82
2023-08-03 09:39:18 -07:00
Alex Chau c325c686c7 Fix return condition in getWorkspacePageTranslationProvider
- When EDIT_MODE was introduced, it added a wrong condition to make it always return DEFAULT_PAGE_TRANSLATION_PROVIDER

Bug: 294228521
Test: manual
Change-Id: If970949c8ab55bc67f98f987a7654ec2db89cdfb
2023-08-03 14:38:33 +00:00
Vinit Nayak 3adfa41951 Merge "Ensure matching insets for taskbar gesture and 3 button nav" into udc-qpr-dev 2023-08-03 00:49:21 +00:00
Treehugger Robot 42b3ff1cc9 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-d1-dev am: 2234a8252d -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24300134

Change-Id: I519b7dde4ddec84da367dd0321eaa6fbd9999fa9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-03 00:38:02 +00:00
Bill Yi e0310ac878 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 22c51bf135 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24300134

Change-Id: Ia057c2a207c61ef3650b1c0cd35bb7c88e9d3edb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-03 00:37:46 +00:00
Treehugger Robot 2234a8252d Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-d1-dev 2023-08-03 00:02:58 +00:00
Sunny Goyal a2a8c566b3 [automerger skipped] Merge "[Unfold animation] Do not preemptively start the animation if it has run already" into udc-dev am: 343b896081 am: 9e10ffc553 -s ours
am skip reason: Merged-In Ic437ff4d19cbd5764635f3007d99880622150f5b with SHA-1 6d756970e7 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23447960

Change-Id: I4a51f0dc07628f51694eb91641007f5704882678
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-02 22:01:26 +00:00
Sunny Goyal 9e10ffc553 Merge "[Unfold animation] Do not preemptively start the animation if it has run already" into udc-dev am: 343b896081
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23447960

Change-Id: I38c903a70bb637d78403a29a468d6722269553dd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-02 21:34:25 +00:00
Vinit Nayak 1fd1b68870 Ensure matching insets for taskbar gesture and 3 button nav
* WM checks that the number of insets don't change for
a given window once it's added. Previously when we changed
nav modes the window was removed and a new one was added, so
changing insets amounts/types didn't matter.
* Now that we use the same window and re-provide the insets,
the number of them provided have to match (insets values themselves
can change as much as needed)
* Fix minor bug when checking bit mask for gravity

Test: Switch between nav modes, no crash; no change in behavior
w/ flag turned off
Bug: 274517647
Flag: persist.wm.debug.hide_navbar_window
Change-Id: I750f843e8210ba1c800b61ac79664265924c054a

Change-Id: Idba4e8e1888fa58bf872c04cb042f77a8b5b0573
2023-08-02 14:21:31 -07:00
Bill Yi 22c51bf135 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I289e821ff4b091ffa506a3176f27a884e0c1dde3
2023-08-02 14:18:50 -07:00
Sunny Goyal 343b896081 Merge "[Unfold animation] Do not preemptively start the animation if it has run already" into udc-dev 2023-08-02 20:51:13 +00:00
Pat Manning a0e328abe7 Merge "Add test to access overview app menu." into udc-qpr-dev 2023-08-02 18:02:29 +00:00
Pat Manning ccf611234a Add test to access overview app menu.
Approved tapl DD: go/tapl-overview-task-menu-app-info

Fix: 292081139
Test: TaplTestsQuickstep.
Change-Id: Ic74267ec80b0a8c6af502a445d355f0420d8f569
2023-08-02 17:20:03 +01:00
Nick Chameyev 2e53f5ef97 [Unfold animation] Do not preemptively start the animation if it has run already
Currently if we open an app, unfold the device and then go to home
screen we will start the unfold animation preemptively in Launcher
because Launcher activity will receive updated configuration change
(where isTablet = true) only after going back to home screen, not
when unfolding the device.

This causes a problem because SystemUI won't send the unfold animation
events after going back home as the animation has already run, so we
end up with wrongly started animation in Launcher.

This CL fixes the issues by checking if SystemUI has finished the
animation (or if it is currently running) to avoid preemptive animation
start in this case. This is done by subscribing to the original
unfold transition progress provider which emits progress events
sent through IPC from SystemUI.

Bug: 285150685
Bug: 293131586
Test: open an app on folded screen, unfold, go to home screen =>
  check that icons are not squished
Test: fold/unfold when launcher is open
Change-Id: Ic437ff4d19cbd5764635f3007d99880622150f5b
Merged-In: Ic437ff4d19cbd5764635f3007d99880622150f5b
(cherry picked from commit 6d756970e7)
2023-08-02 11:41:53 +00:00
Ats Jenk 7313bc7800 Use window corner radius for desktop task snapshots
Desktop task snapshots are shown inside the desktop tile in overview.
They use the window corner radius, when shown on the desktop. Keep the
same radius for the snapshots in overview. Only the desktop tile
background should use the task corner radius.

Bug: 280827930
Flag: persist.wm.debug.desktop_mode_2
Test: open some apps on desktop, swipe up for overview, observe the
      desktop task corner radius remains the same as when on desktop
Change-Id: I55ced9f704b83a6c7619508aa3e7a8080ccc5c35
2023-08-01 14:28:06 -07:00
Vadim Tryshev a1877d2888 Merge "Ignoring alpha jumps in ArrowTipView and its children." into udc-qpr-dev 2023-08-01 19:36:54 +00:00
Tracy Zhou a6bf4c25c8 Update nav button color when nav button layout changes
Bug: 288311605
Test: Rotate the screen in small screen, make sure the button colors are correct
Change-Id: I36ae980fbe239ea4e1ebb63200ee876b690cf218
2023-08-01 11:14:27 -07:00