Commit Graph

77781 Commits

Author SHA1 Message Date
Jordan Silva ebfae18529 Refactoring OverviewCommandHelper (2/3)
This CL should not affect the behavior of OverviewCommandHelper.
- It splits executeCommand into smaller functions
- Rearrange public/private functions
- Adds extra logs.

Bug: 352046797
Bug: 351122926
Flag: EXEMPT bugfix.
Test: Manual.
Change-Id: I283f179794af812973a559db6291febe19e3c6d7
2024-08-30 12:30:54 +01:00
Jordan Silva e7ae4e31ae Refactoring OverviewCommandHelper (1/3)
- Updates pendingCommands to be a ConcurrentLinkedDeque and make the list safe across multiple threads.
- Introduces CommandStatus to clear only IDLE and COMPLETED commands.
- Adds CommandType enum to prevent adding an invalid command value into the queue and having an unexpected behavior.
- Log messages improved

Bug: 352046797
Bug: 351122926
Flag: EXEMPT bugfix.
Test: Manual.
Change-Id: I80705dca0be579e62cb9e2bd923808dd33c4d633
2024-08-28 17:09:29 +01:00
Treehugger Robot 4fd9449d64 Merge "Convert DigitalWellBeingToast to Kotlin" into main 2024-08-28 12:22:03 +00:00
Charlie Anderson 7f4e40c958 Merge "Slightly lower icon shadow insets to avoid accidental shrinking or padding" into main 2024-08-28 11:24:01 +00:00
Charlie Anderson 5e319c2a11 Merge "Add logging for onPackageAdded callback to see if installed packages are added to Launcher." into main 2024-08-28 11:23:09 +00:00
Pat Manning 632444a266 Merge "Add 4dp vertical offset to taskbar hover tooltip." into main 2024-08-28 11:07:25 +00:00
Alex Chau 141a4c9857 Convert DigitalWellBeingToast to Kotlin
Bug: DigitalWellBeingToast
Test: manual
Flag: EXEMPT refactor
Change-Id: I9998269b32e89725e311c3ca88e924a55c196412
2024-08-28 11:46:15 +01:00
Treehugger Robot f35a60136f Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-08-28 02:48:37 +00:00
Treehugger Robot 989ee1262b Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-08-28 02:48:37 +00:00
Tracy Zhou 59a4dfdcd8 Merge "Skip taskbar animations from launcher state changes in phone mode" into main 2024-08-28 00:19:54 +00:00
Treehugger Robot 4503c2c60c Merge "Polish transition between desktop mode and overview" into main 2024-08-27 23:57:21 +00:00
Sunny Goyal 3aa9668bef Merge "Cleanup unused workspacePageIndicator" into main 2024-08-27 23:03:20 +00:00
Charlie Anderson 0c54dbd4a5 Slightly lower icon shadow insets to avoid accidental shrinking or padding
Bug: 350758155
Test: locally
Flag: com.android.launcher3.use_new_icon_for_archived_apps
Change-Id: I5d0396c3e4710873ff797a35b97fad7e79a14495
2024-08-27 22:41:42 +00:00
Sunny Goyal 42becd041b Cleanup unused workspacePageIndicator
Fix: 270395278
Flag: NONE removing dead code
Test: verify everything still works the same
Change-Id: Id0eda5c5994c3323a8d16900678fbd7b39911b62
2024-08-27 12:23:21 -07:00
Tracy Zhou 65eaea39cc Merge "Skip animating stashed handle color based on color sampling if it's the same" into main 2024-08-27 18:41:43 +00:00
Schneider Victor-tulias 51433debcd Polish transition between desktop mode and overview
Fixing desktop task in place along the x-axis and animating its background's alpha to more smoothly handle the transition.

Flag: com.android.launcher3.enable_desktop_task_alpha_animation
Fixes: 320307666
Test: swiped to and from desktop mode and overview
Change-Id: I38d62d0c966733f96c2f4d4ecfa4a9418039fd48
2024-08-27 18:15:06 +00:00
Charlie Anderson 70ac7a055e Add logging for onPackageAdded callback to see if installed packages are added to Launcher.
Bug: 350144057
Flag: NONE just logs
Test: locally
Change-Id: Iba08aea3e370ce1a992f3d680790470d9ab193fd
2024-08-27 13:38:23 -04:00
Tracy Zhou 111d05c913 Skip taskbar animations from launcher state changes in phone mode
Based on https://b.corp.google.com/issues/361593564#comment4

Bug: 361593564
Test: manual
Flag: EXEMPT bugfix
Change-Id: I93d1cfc3b0eaec6b9496d13acc14d20c4de6d3b1
2024-08-27 09:33:05 -07:00
Sebastián Franco dd981d78b5 Merge "Adding logs to find which call is responsible for the animation error" into main 2024-08-27 16:28:09 +00:00
Pat Manning fd2f14c845 Add 4dp vertical offset to taskbar hover tooltip.
Bug: 356352494
Test: TaskbarHoverToolTipControllerTest
Flag: EXEMPT bugfix
Change-Id: Iba546b009abcd6a30abc60349961028f27d2bf26
2024-08-27 15:33:35 +01:00
Shamali Patwa 94c4dbfbbb Merge "Reuse widget picker's surface color in add item dialog." into main 2024-08-27 13:55:03 +00:00
Treehugger Robot 565f7e73b5 Merge "Convert OverviewCommandHelper to Kotlin" into main 2024-08-27 12:54:04 +00:00
Bill Yi 89cf733f24 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ibda937ad6b5ad93bbccac97b15f5f0a934a8a7bf
2024-08-27 00:22:17 -07:00
Bill Yi 05ea1f752e Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I7afdcb2bca36df6f83a871c4eb0d2c33f8949450
2024-08-27 00:21:28 -07:00
Tracy Zhou 9146984e69 Merge "Only call notifyUpdateLayoutParams when the params is changed" into main 2024-08-27 02:31:15 +00:00
Treehugger Robot fe4cb0de51 Merge "Add logging around InstallSessionTracker to verify PackageInstaller is communicating with Launcher." into main 2024-08-27 00:55:49 +00:00
Sebastian Franco 7f9518145a Adding logs to find which call is responsible for the animation error
Bug: 311077782
Test: not aplicable
FLag: EXEMPT bugfix
Change-Id: I2d5a28a8244819a795402fdcf599009ad1abd0dc
2024-08-26 17:08:01 -07:00
Shamali P 0cac409a60 Reuse widget picker's surface color in add item dialog.
In ag/28129361 add item dialog's color was changed to reference
material color token defined in launcher theme. But add item activity
inherits from Theme.Translucent.NoTitleBar for its appearance (while
launcher theme uses deviceDefault.Light), so, cannot inherit as is from
the launcher theme. Since, there is already a token specific for widget
picker surface color imported via widgetTheme, using it so it stays
in sync with main picker.

Bug: 354604590
Test: Manual
Flag: EXEMPT BUGFIX
Change-Id: I61ed5e65b0efd065490a54251028cde5888e4391
2024-08-26 23:16:25 +00:00
Charlie Anderson e745aa87fc Add logging around InstallSessionTracker to verify PackageInstaller is communicating with Launcher.
Bug: 350144057
Flag: NONE just logs
Test: Locally
Change-Id: I600cac50d7202458abf968fc0707eba58ffc0e65
2024-08-26 19:15:58 -04:00
Bryce Lee 4d2091e8f0 Merge "Show Taskbar when Glanceable Hub is showing." into main 2024-08-26 21:50:18 +00:00
Sebastián Franco b9ce69db9e Merge "Correctly map the drag view position to the Workspace" into main 2024-08-26 21:13:06 +00:00
Brandon Dayauon 412821fadf Merge "Create an alpha letter scroller" into main 2024-08-26 20:21:17 +00:00
Treehugger Robot cc22b62109 Merge "Recreate icon alignment controller when isIconAlignedWithHotseat changes." into main 2024-08-26 19:10:31 +00:00
Brandon Dayauon 1f8f88696b Create an alpha letter scroller
- The function used is a raised cosine function to determine the sections to animate.

Tested flag: adb shell device_config put launcher com.android.launcher3.letter_fast_scroller true
Based on recent figmaspec, size of selected letter is 28dp and regular is 20dp. That means scaling should be 28/20.
Colors are:
onSurface for letter
surfaceContainer for background.
Figma shows selected colors are materialColorOnSecondary

bug:358673724
Test manually: https://drive.google.com/file/d/1gvJd5KoK8X_Sv8jXg1cZ65R4AuqHuvcd/view?usp=sharing
Flag: com.android.launcher3.letter_fast_scroller

Change-Id: Ia86eb0e8c41bc043fda3c44aeaf59e204429f337
2024-08-26 11:21:26 -07:00
Jon Miranda f9e46eaa15 Recreate icon alignment controller when isIconAlignedWithHotseat changes.
Before: when launching an app and immediately swiping home, the icon alignment
animation would become stale, which lead us to playing the wrong interpolator
for the action key alpha animator.

Fixes: 359579152
Test: open app, then immediately swipe home
Flag: EXEMPT bugfix
Change-Id: Ief08bd0fcb9fdc60efd0b8dd0821c1122cfa6f4f
2024-08-26 17:24:46 +00:00
Winson Chung e584fb3b31 Merge "Fix regression in ending recents transition while locked" into main 2024-08-26 16:12:18 +00:00
Mykola Podolian d56fb26f84 Merge "Fixed issue with the bottom zone of launcher is not touchable." into main 2024-08-26 15:43:39 +00:00
Liran Binyamin 9720472a8a Merge "Revert^2 "Synchronize bar expansion with WM Shell"" into main 2024-08-26 11:29:31 +00:00
Liran Binyamin b0801dcc3c Merge "Update both width and height in BubbleBarView" into main 2024-08-26 11:28:19 +00:00
Luca Zuccarini 6bf20cd965 Merge "2/3 Move some Shell utils to the Shared package." into main 2024-08-26 10:07:55 +00:00
Sebastian Franco 4bedb18466 Correctly map the drag view position to the Workspace
The drag view needs to be mapped to the drop target which in this
case is the Workspace instead of the CellLayout

Fix: 352569050
Test: IntegrationReorderWidgetsTest
Flag: TEST_ONLY
Change-Id: I233c2b3bf0b8637f80d74d201189b2290ef59c94
2024-08-25 20:41:00 -07:00
Winson Chung 6d1dcc2b4e Fix regression in ending recents transition while locked
- Prior to ag/28807475 we would not finish the recents transition
  when ending to home while the device is locked, so we need to
  continue to skip that now.

Flag: EXEMPT bugfix
Bug: 361950809
Bug: 359608026
Test: Lock the device, open camera and swipe up
Change-Id: I66ba065ebd0084ecd51ea803e88e31bf8acbfdcb
2024-08-25 20:45:03 +00:00
Tracy Zhou 81fe9da956 Skip animating stashed handle color based on color sampling if it's the same
Based on https://b.corp.google.com/issues/361593564#comment4

Bug: 361593564
Test: manual
Flag: EXEMPT bugfix
Change-Id: I56251a5971c34415084b3b9ff773f5ddb5f40de7
2024-08-23 21:12:25 -07:00
Tracy Zhou e5be9281c5 Only call notifyUpdateLayoutParams when the params is changed
Bug: 361405157
Test: manual
Flag: com.android.wm.shell.enable_taskbar_on_phones
Change-Id: Ieddcfbc8a8deea9415fe9815926e5fa5552b4be3
2024-08-24 03:10:42 +00:00
Treehugger Robot 9de3b46abf Merge "Rename test helper filegroup to robo" into main 2024-08-23 23:44:00 +00:00
mpodolian dcd76d56c7 Fixed issue with the bottom zone of launcher is not touchable.
Updated logic of the touch area configuration. Only add the taskbar
bounds if the taskbar is being shown inside the app or on overview.

Fixes: 358301278
Fixes: 361653416
Test: Manual:
http: //recall/-/gx8ASgewUeUS3QYohfrd1J/lpzJER3iGI5PpZrQqv7b7
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: Id9902058c5ec873dab6257a34b4c3a87aec5ae6b
2024-08-23 16:43:37 -07:00
Vinit Nayak 8f53b7be9f Merge "Move CUJ trace start closer to AppPair launch animation" into main 2024-08-23 22:44:49 +00:00
Sihua Ma a9e4324bd5 Rename test helper filegroup to robo
Test: N/A
Flag: EXEMPT filegroup rename
Change-Id: I8afeccc69fbca8e317c6b74a051d6b94239b8c52
2024-08-23 22:13:33 +00:00
Bryce Lee 6668ab9cab Show Taskbar when Glanceable Hub is showing.
This changelist ensures that the Taskbar is not hidden when the
Glanceable Hub is showing. Logic for hiding the Taskbar when dreaming
was suppressing it from showing when Glanceable Hub was present. The
surrounding condition has been updated to now not trigger is Glanceable
Hub is showing.

Test: manual - verified Taskbar was properly displayed and hidden
      between glanceable hub and dreaming.
Flag: EXEMPT bugfix
Fixes: 353803584
Change-Id: I58a61617baff65041757ae0df96687a071120880
2024-08-23 13:31:09 -07:00
Charlie Anderson 19b9344636 Merge "Use bugfix flag for archived broadcast extras" into main 2024-08-23 20:07:06 +00:00