Commit Graph

34209 Commits

Author SHA1 Message Date
Bob Badour 3be35ec269 Merge "[LSC] Add LOCAL_LICENSE_KINDS to packages/apps/Launcher3" am: 541d0855ac
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/1587746

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Icc96bfa8a3d59a19194a154baeaffaea1281af0a
2021-02-24 22:25:46 +00:00
Steven Ng fb853435f4 Merge "Replace horizontal ScrollViews with tables in the full widgets picker" into sc-dev 2021-02-24 22:22:31 +00:00
Steven Ng fdeee141d9 Replace the no preview layout check with Resources.ID_NULL(0)
TODO: open up the RemoteViews(ApplicationInfo) API so that Launcher
      can inflate a layout from a work profile app.

Test: Before this CL, install tasks app in work profile. Observed
      crash when tapping Tasks header in the widgets picker.
      After this CL, no crash observed when tapping Tasks header in
      the widgets picker.

Bug: 181061277
Change-Id: I16c2b9aec5f4cabf15da35fea09f68c10797f5fa
2021-02-24 22:01:06 +00:00
Samuel Fufa 226c4af911 Merge "Restore divider between app predictions and apps" into sc-dev 2021-02-24 20:50:10 +00:00
Pierre Barbier de Reuille b2526feb24 Launcher changes for go/widget-size-specification
Makes sure the launcher:

1 - Send the list of actual sizes the widget in all situations.
2 - Gives the current size to the framework on inflation.

Also needed to guard the new border changes introduced in
http://ag/13532637 with the corresponding flag.

Change-Id: I2a33e9501b921f2fc393684e8ce91ee077626bf7
Test: By hand using a local widget.
Bug: 179025145
2021-02-24 20:40:41 +00:00
Steven Ng e8d92342fa Replace horizontal ScrollViews with tables in the full widgets picker
Test: Run gnl test, AddWidgetTest
      Run Robolectric tests for widgets
      Manual test video: https://drive.google.com/file/d/1uwCtVNIlC9150kv5eEfILfP5r5M7ARYm/view?usp=sharing

Bug: 179797520
Change-Id: I2f4cdf84338a91b63967879d0c9268c312ace19b
2021-02-24 19:49:15 +00:00
Bob Badour 541d0855ac Merge "[LSC] Add LOCAL_LICENSE_KINDS to packages/apps/Launcher3" 2021-02-24 19:19:03 +00:00
thiruram 9f53d61334 [AA+] Use different launcher event to log all apps entry with device search.
Bug: 178562918
Test: Manual
Change-Id: I56357e871dd57257ccd56a073cccc7e38529c6c6
2021-02-24 10:57:20 -08:00
Tony Wickham 2fb22af840 Merge "Ensure taskbar visibility callbacks are called in init()" into sc-dev 2021-02-24 17:16:45 +00:00
Tony Wickham 7801bf68d1 Merge "Make RecentsView INVISIBLE instead of GONE" into sc-dev 2021-02-24 17:15:58 +00:00
Samuel Fufa b984cf7fa6 Restore divider between app predictions and apps
Screenshot: https://screenshot.googleplex.com/89jJLU3JXV8tRXM
Bug: 180017741
Test: Manual
Change-Id: Iab1764fe94340f120770054cf5a59bd3ed9e45a4
2021-02-24 10:31:57 -06:00
Samuel Fufa c7d72e55ec Merge "Break up nasa search results" into sc-dev 2021-02-24 13:39:12 +00:00
Samuel Fufa c2da3c60fe Merge "Allow badging with ComponentNames" into sc-dev 2021-02-24 13:38:49 +00:00
Andy Wickham f480a87423 Changes ENABLE_SMARTSPACE_ENHANCED to be a DeviceFlag.
This lets us toggle it server-side.

Bug: 181077020
Test: Manually toggled using
adb shell device_config put launcher ENABLE_SMARTSPACE_ENHANCED true

Change-Id: I5172bf6f977729f4c1c813b1eaba3b8b34bfc44e
2021-02-23 21:57:55 -08:00
Sreyas 25992f12e5 Fix DWB cutting off above inset when translating down.
Bug: 180979788
Test: Manual
Change-Id: I08577db4149b339fa217cab6401250a3fca10e65
2021-02-23 19:10:47 -08:00
Tony Wickham 752ebfcef2 Ensure taskbar visibility callbacks are called in init()
We're initializing the correct values, but the callback only runs if
the value is different than the default value of 0. Thus we weren't
updating the visibility according to the value 0 in init().

Test: Initialize taskbar while launcher is resumed
Fixes: 180103543
Change-Id: I3f754cac59e2bd5ad542de050e8b4c3146d5eebf
2021-02-23 17:08:40 -08:00
Tony Wickham 29016e8e46 Make RecentsView INVISIBLE instead of GONE
This ensures it gets laid out to compute things like page scrolls.

Test: Repro steps to both bugs below
- Force stop launcher, swipe up slightly, hold, and let go to return
  to the current task; ensure no jumps or jank
- Force stop launcher, swipe up and hold to go to Overview, ensure
  no jump on motion pause

Fixes: 180736503
Fixes: 175064755
Change-Id: I44581f87600b02a3c9ddefcb8c94bb3845cd9152
2021-02-23 17:02:36 -08:00
Sreyas Rangaraju 1408c6459c Merge "ShareTargets animations and styling." into sc-dev 2021-02-23 21:15:53 +00:00
Lucas Dupin 85df1c291f Merge "Overlay property instead of style" into sc-dev 2021-02-23 19:10:12 +00:00
Samuel Fufa 85dfc2e032 Allow badging with ComponentNames
Bug: 180909579
Test: Manual
Change-Id: I2ee6dc2edb97ef0eb2470e7b7e8f849d451a77dd
2021-02-23 12:48:37 -06:00
Vadim Tryshev 06df8d7262 Merge "Instrumenting swiping up to all apps for jank" into sc-dev 2021-02-23 18:32:23 +00:00
Steven Ng 6936040def Merge "Add personal / work tabs for work profile widgets" into sc-dev 2021-02-23 10:58:35 +00:00
Xin Li aec90be631 [automerger skipped] Merge ab/7061308 into stage. am: d7927e46dc -s ours am: 6b965bbd7f -s ours
am skip reason: Change-Id Ib590035a7b3f124b2a767279623d51bc8c0dbd18 with SHA-1 dc0b212582 is in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13658527

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I9c9fcb1ba347d19f9cdc44f14f0dc56bc75575d4
2021-02-23 10:34:18 +00:00
Xin Li 6b965bbd7f [automerger skipped] Merge ab/7061308 into stage. am: d7927e46dc -s ours
am skip reason: Change-Id Ib590035a7b3f124b2a767279623d51bc8c0dbd18 with SHA-1 dc0b212582 is in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13658527

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I7c95710f428c920c0c43d7cea1429224b86c63cc
2021-02-23 09:05:04 +00:00
thiruram d0ab1a0eed [AA+] Add WW logging for Slice actions.
Bug: 178562918
Test: Manual
Change-Id: I515ee3c0990dea2c30e68d5919568dc1773912ee
2021-02-22 20:07:29 -08:00
thiruram 97710ffbb2 [AA+] Log additional UI events with Launcher snapshot logging.
Bug: 180418845
Test: Manual
Change-Id: I74ab1faafe6c21a8fbf6992a8aebe918cc31d85e
2021-02-23 02:59:43 +00:00
thiruram b8bb677616 [AA+] Skip title logging when search result type is PEOPLE.
Bug: 178562918
Test: Manual
Change-Id: Ia2fb8018efcdfb6ad947c590d559094cb460ce83
2021-02-22 17:10:38 -08:00
Lucas Dupin 3cdc6f86af Overlay property instead of style
Overlaying the whole style with sw720dp will override dark theme styles.
Let's instead define the attribute that needs to be different and put it
in a config xml.

Test: set smallest width to 720, flip to dark theme
Fixes: 180003967
Change-Id: I423f3401b612e7e87a63f3f14f972b9d863d8a17
2021-02-22 16:34:51 -08:00
Tony Wickham f3b8797f77 Merge "Increase taskbar size to match latest specs" into sc-dev 2021-02-22 23:51:04 +00:00
thiruram f8f2a6ed0a [AA+] Log tap on SearchActionItem.
Bug: 178562918
Test: Presubmit
Change-Id: I42a44de4f3cc02ca331c4f99c107891c4658995d
2021-02-22 22:39:41 +00:00
Tony Wickham 40fbc96a0a Increase taskbar size to match latest specs
Test: Ran it locally, verified it looked as expected
Bug: 171917176
Change-Id: I8a467db57b579f1ad29d2108927eef3bd10b273a
2021-02-22 11:59:43 -08:00
Steven Ng 391404fcb7 Add personal / work tabs for work profile widgets
Video: https://drive.google.com/file/d/1TORRNcvVM7fIvNd_WZaajLbI7D9z4VFA/view?usp=sharing


Test: Main profile only: run AddConfigWidgetTest.
      With work profile: manually launch the full widgets sheet.
      Go to the personal tab: only personal widgets are shown.
      Go to the work tab: only work widgets are shown
      Successfully add personal / work widgets from the full widgets
      sheet.

Bug: 179797520

Change-Id: Iad8b90c2af35e0580319d7a05510ec88e4f8b86c
2021-02-22 16:10:09 +00:00
Samuel Fufa 9ffaee3110 Break up nasa search results
+ replace IME feature flag launcher setting

Test: Manual
Bug: 178638266
Change-Id: Id013cd247cfa2b33cdf62ee3239ad1bacc35b5da
2021-02-22 09:10:18 -06:00
Hyunyoung Song 1739c5c68e When in search mode, do not refresh rescycler view, on package update
Bug: 180570580
Test: manual

TL;DR;; when new app install happens in search mode, no reset
when new app install happens in a-z mode, recycler view refreshes

Change-Id: I8a6bf327ecd3dbef4837eca560f10016731b78e0
2021-02-22 02:32:23 -08:00
Bob Badour 4bdf380625 [LSC] Add LOCAL_LICENSE_KINDS to packages/apps/Launcher3
Added SPDX-license-identifier-Apache-2.0 to:
  Android.bp
  Android.mk
  robolectric_tests/Android.mk
  tests/Android.mk

Bug: 68860345
Bug: 151177513
Bug: 151953481

Test: m all

Exempt-From-Owner-Approval: janitorial work

Change-Id: Ia348bba8ca075e87070ff8a605ca79ffcbea9982
Merged-in: Ia348bba8ca075e87070ff8a605ca79ffcbea9982
2021-02-21 20:34:37 -08:00
Xin Li d7927e46dc Merge ab/7061308 into stage.
Bug: 180401296
Merged-In: Ib590035a7b3f124b2a767279623d51bc8c0dbd18
Change-Id: I5cf1081160fac6f8450261bf8af9d118db2cf194
2021-02-21 09:25:10 -08:00
Hyunyoung Song dfdeddc66a Merge "Add group highlighting to AA+ result" into sc-dev 2021-02-19 20:48:37 +00:00
TreeHugger Robot aa14b19725 Merge changes Id68b6c37,I16d39d3e into sc-dev
* changes:
  Fix a couple of crashes when taskbar isn't yet attached
  Subtract taskbar size from DeviceProfile#availableHeight
2021-02-19 19:01:38 +00:00
Steven Ng 4236451069 Merge "Extract common codes for personal / work profile tabs" into sc-dev 2021-02-19 18:10:48 +00:00
TreeHugger Robot fed6b8cb5c Merge "Update popup container to match spec." into sc-dev 2021-02-19 17:40:01 +00:00
Steven Ng 36322d8621 Merge "Render preview layout in full widgets sheet and bottom widgets sheet" into sc-dev 2021-02-19 10:31:19 +00:00
TreeHugger Robot 4e50f9915c Merge "Always loading high-res icon for apps." into sc-dev 2021-02-19 03:00:45 +00:00
Tony Wickham 786dd93f2b Fix a couple of crashes when taskbar isn't yet attached
- Handle back to back addTaskbarIfNecessary(). Specifically, handle
  cleanup() before the previous add was attached. This is already
  handled on WM side, just had to remove isAttachedToWindow() check.
- Add isAttachedToWindow() check to isViewInTaskbar()

Test: call addTaskbarIfNecessary() three times back to back, ensure no crash.

Fixes: 180509238
Bug: 171917176
Change-Id: Id68b6c376029eb5c651f47afa56666391c516aef
2021-02-18 15:40:33 -08:00
thiruram 4c45d5f1eb Replace Optional.ifPresent with simple if clause.
Bug: 178562918
Test: Manual
Change-Id: Icb8f07f276555aaf43ee29bf33f995c3bb446f69
2021-02-18 22:21:45 +00:00
Alex Chau 0bd7c9bf46 Merge "Use PersistedTaskSnapshotData to calculate TaskView size" into sc-dev 2021-02-18 21:15:10 +00:00
Tony Wickham 15883891ea Subtract taskbar size from DeviceProfile#availableHeight
Normally availableHeight excludes system insets, but taskbar is added
after availableHeight is calculated. This discrepency causes some bad
calculations such as TaskView size.

Test: touch nav bar when in an app with taskbar present, ensure the
task doesn't jump due to incorrect calculation

Fixes: 179478728
Bug: 171917176
Change-Id: I16d39d3e1d9708e2a64c81b1ac24466f9567d1b9
2021-02-18 11:39:10 -08:00
Jon Miranda cabc13a376 Update popup container to match spec.
Bug: 175329686
Bug: 178935485
Test: manual
Change-Id: Ia7507bd4dd6c6db0cdd6a29a0c1d0695aae7d488
2021-02-18 14:11:41 -05:00
Sunny Goyal 13f656e15e Always loading high-res icon for apps.
Low res support will be completely removed in a followup cl

Bug: 179962824
Test: Verified on device
Change-Id: Ibb19d1892bfcdf5d26178e807f54f40462704e33
2021-02-18 10:09:31 -08:00
Sunny Goyal 40ff7e4e41 Merge "Fixing shortcut intent getting cleared during backup/restore" into sc-dev 2021-02-18 17:32:06 +00:00
Alex Chau 2b509cd45a Merge "Refresh DisplayContext to prevent getting stale DisplayMetrics" into sc-dev 2021-02-18 13:57:59 +00:00