Commit Graph

34209 Commits

Author SHA1 Message Date
Steven Ng 46b0d8e291 Inflate layout preview for work profile
Also fix a bug which LivePreviewCells are not used in full widgets
sheet.

Test: Temporarily replace the previewLayout with initialLayout
      from the code. Then, open both the full and bottom widgets
      sheet. Observe initial layout is rendered correctly for both
      personal and work profile.

Screenshot: https://screenshot.googleplex.com/BgJycVjzeoU3PNf.png

Bug: 181061277
Change-Id: Id635ee778008b6f94009f50bf4373d3b0f545417
2021-03-05 20:02:31 +00:00
Tony Wickham 6643088959 Nullify taskbar hotseatView tag when the cell is empty
This ensures that a removed view becomes invisible.

Test: turn off hotseat suggestions, drag an item out
and verify it's removed from taskbar as well
Bug: 179886115
Bug: 171917176

Change-Id: Iec509c2f0c420cee6f86feb293419bb2249a8dc4
2021-03-05 10:25:15 -08:00
Steven Ng 1f4a3414f1 Merge "Add shortcuts count as a subtitle in the full widgets sheet" into sc-dev 2021-03-05 17:56:11 +00:00
Samuel Fufa 119110ab4e Merge "Defer AllAppsUpdate while edu test is running" into sc-dev 2021-03-05 17:45:20 +00:00
Tracy Zhou 72d748f718 Merge "Reset primary and secondary translation of mLiveTileSimulator after settling into Overview" into sc-dev 2021-03-05 17:28:22 +00:00
Alex Chau 718d0c3e2f Animate task from overview grid when launching
Bug: 174464863
Test: Manually launching from different grid positions
Change-Id: Iafb03b86c6b85fb0ebabc0f2ba98acf89d7ea971
2021-03-05 16:59:29 +00:00
TreeHugger Robot bd16cc3cf3 Merge "Fix scrolling bugs in full widgets sheet" into sc-dev 2021-03-05 16:55:44 +00:00
Alina Zaidi 94b622da80 Merge "Interface for WidgetPickerSearchPipeline." into sc-dev 2021-03-05 16:50:38 +00:00
wilsonshih 77c1673e64 Let Launcher able to receive task launching callback(4/N)
Ref doc: go/starting_window_android_s
Test: build/flash
Bug: 131311659
Bug: 131727939
Bug: 152480470

Change-Id: I4354ef33fe60c6026ab7f5e47fa024011e637359
2021-03-05 20:57:45 +08:00
Steven Ng 7f7b2f7ee9 Fix scrolling bugs in full widgets sheet
Bugs:
1. Layout margins were not taken into account
2. Fast scroller offset has a different scale to the recycler view
3. Update padding & margin in onMeasure rather than in onLayout

TODO: fast scroller measurement doesn't take into account of
      expanded item. It naively use the same height for all items
      from the recycler view adapter.

Test: Open full widgets sheet for both work profile and non-work
      profile setup. Scrollbar initial position is correct. Scroll
      up and down to confirm views vertical translation is correct.

Video: https://drive.google.com/file/d/1kp3iSm23RVk_otBNeYalEPPkWjjWMOY0/view?usp=sharing

Bug: 181629430
Change-Id: I398a94510751782e78aa8f426f37b03ecca8ec99
2021-03-05 11:44:47 +00:00
Pierre Barbier de Reuille 18d159a250 Correct Launcher3 for new sizes in App Widgets.
This follow recommendations from the API council review.

Also removes two public functions introduced recently by
http://ag/13473552 and are not needed anymore.

Bug: 181611658
Test: Manual testing with local widget.
Change-Id: I8d0c90a80a0d45981bd5d16e69cd86639d5ec7d8
2021-03-05 11:44:11 +00:00
Steven Ng bcab2a808a Add shortcuts count as a subtitle in the full widgets sheet
Screenshot: https://screenshot.googleplex.com/9Ds55rsFSNajLWN.png

Test: Open full widgets sheet and observe widgets and shortcuts
      counts are correctly displayed.

Bug: 180725078
Change-Id: Ibf43c14cc06c0e9bf245c53f190095d0eaeace12
2021-03-05 09:54:56 +00:00
Tracy Zhou 6f25775978 Remove LiveTileOverlay
Since we place app on top during the initial swipe up, LiveTileOverlay is no longer necessary. LiveTileOverlay was used to hole punch during the initial swipe when we place app under. After the initial swipe up settles in overview, hole punching job is given to the TaskView.

Fixes: 181937887
Test: manual
Change-Id: If5293dc0143af8be9db9d2745f567c4c680010a0
2021-03-05 01:10:08 -08:00
Tracy Zhou e2dc985f59 Reset primary and secondary translation of mLiveTileSimulator after settling into Overview
Fixes: 181929353
Test: manual
Change-Id: I1ca36f77f0efc32803f5128eedd21b89e2b1d2b5
2021-03-04 22:43:50 -08:00
Sunny Goyal befaad269e Merge "Fixing empty page not removed when drag ends" into sc-dev 2021-03-05 06:29:33 +00:00
Sunny Goyal a0bc6d964e Removing some animation special casing for 2-button mode
This would simplify reusing the same code for 3-button mode

Test: Verified on device
Bug: 175137718
Change-Id: Ia757eec069efc251475baa6af38c690431325f66
2021-03-04 22:25:30 -08:00
Winson Chung b93119e3b9 Merge "SystemUI proxy updates for managing split screen" into sc-dev 2021-03-05 04:25:11 +00:00
Tony Wickham 64edc22c8b Space out empty taskbar hotseat views when on home screen
This ensures the taskbar hotseat aligns with the home screen
hotseat, as the latter supports empty cells. When in apps,
the taskbar still collapses the empty cells.

Test: Turn off hotseat predictions, remove some hotseat items,
and ensure the taskbar hotseat spreads out when on home.

Bug: 179886115
Bug: 171917176
Change-Id: I6047c3c5691685edcd8b3519e0305812b1295550
2021-03-04 23:54:34 +00:00
Tony Wickham 634f600848 Merge "Align real hotseat with taskbar hotseat during drag and drop" into sc-dev 2021-03-04 23:53:55 +00:00
Steven Ng 239101c512 Merge "Remove unused widgets_scroll_container layout" into sc-dev 2021-03-04 23:22:17 +00:00
Winson Chung 0613af3587 Add some logging for failure to get recents
Bug: 177472267
Test: Presubmit
Change-Id: I64a01ef076a58bc3118840ff3171177f61edc3f5
2021-03-04 14:18:41 -08:00
Samuel Fufa 3531778a08 Defer AllAppsUpdate while edu test is running
Bug: 159671700
Test: Presubmit
Change-Id: I6f1421117286225d80a1538e45fbf2592229b586
2021-03-04 14:11:38 -06:00
Winson Chung 13c20193eb Removing old logs
Bug: 156095088
Test: Presubmit
Change-Id: I61b44fd4ee96de405482f9cf9b6a06d87a295898
2021-03-04 06:16:41 +00:00
Xin Li 9cde419ee0 [automerger skipped] Merge "Merge RQ2A.210305.007" am: b1826d09b5 -s ours am: 3aa15f3f6b -s ours am: f053b13529 -s ours
am skip reason: Change-Id Icc96bfa8a3d59a19194a154baeaffaea1281af0a with SHA-1 3be35ec269 is in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/1613681

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I90209e1790bc22ad0b3603172a6dd3b0e36ddbd3
2021-03-04 00:11:58 +00:00
Xin Li f053b13529 [automerger skipped] Merge "Merge RQ2A.210305.007" am: b1826d09b5 -s ours am: 3aa15f3f6b -s ours
am skip reason: Change-Id Icc96bfa8a3d59a19194a154baeaffaea1281af0a with SHA-1 3be35ec269 is in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/1613681

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Ib6f3a42ec8a6ddddb8572ea391431c0833b66b39
2021-03-03 23:36:59 +00:00
Xin Li 3aa15f3f6b [automerger skipped] Merge "Merge RQ2A.210305.007" am: b1826d09b5 -s ours
am skip reason: Change-Id Icc96bfa8a3d59a19194a154baeaffaea1281af0a with SHA-1 3be35ec269 is in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/1613681

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I6a0fb0f0fb011feaab78b67e08cc3c6d29cc3d71
2021-03-03 22:28:30 +00:00
Xin Li b1826d09b5 Merge "Merge RQ2A.210305.007" 2021-03-03 21:41:29 +00:00
Schneider Victor-tulias eac03af4a1 Merge "Fix incremental download progress of workspaceiteminfos." into sc-dev 2021-03-03 21:19:44 +00:00
Tony Wickham a29a046d83 Align real hotseat with taskbar hotseat during drag and drop
Remove hotseat space from workspace in DeviceProfile if
taskbar is present, and instantly swap between taskbar and
hotseat when entering SpringLoadedMode. To allow for an exact
handoff, we also scale up the TaskbarView such that its icons
match the hotseat icon size when on the home screen.

Note that this CL only supports dragging to the taskbar, not
out of it (which still triggers system drag and drop instead).

Test: In RTL and LTR, drag a workspace item and ensure hotseat
seamlessly swaps with the taskbar hotseat and allows drops.

Bug: 179886115
Bug: 171917176

Change-Id: Id6462075b9b0b66b06d51a78c9c0b3e11e83e84d
2021-03-03 11:16:42 -08:00
Schneider Victor-tulias eedab487e3 Fix incremental download progress of workspaceiteminfos.
WorkspaceItemInfo intent package names could be null, while the item info itself had a non-null package name. Added a helper method checking component package names first, then intent package names as a fallback for deep shortcuts.

Demo: https://drive.google.com/file/d/1No44OD7SAD9qdmu-O6g3WaGdFjFLu2in/view?usp=sharing

Fixes: 181261930
Test: Manually on device
Change-Id: Ie2e10a79865b4898038fbdd4bbd9a7e9e1d42366
2021-03-03 18:56:10 +00:00
Tracy Zhou 162ed05ac9 Add NavigationModeFeatureFlag
3 Button mode doesn't use recents animation so live tile would not work on 3 button mode before migration to recents animation happens.

Bug: 169694902
Test: manual
Change-Id: I9574c624f3d220834fa18e910637cd64460adb0c
2021-03-03 10:52:12 -08:00
Yogisha Dixit b4c268ee28 Update app widget resize frame UI.
Mock: https://docs.google.com/presentation/d/1UxdDh8EFhPbdRWRwzjbpgL-j02ew4Ew3eG3XBCeoYdo/edit#slide=id.8YyBaHq
Implementation: https://screenshot.googleplex.com/BEFwWBmXXx8xXdS

I will update the drag handles in a follow-up CL since their specs
aren't ready yet.

Test: manual
Bug: 181774580
Change-Id: I19a99e6dbe106754da0fac56a5c2e7eb9eb90cef
2021-03-03 18:44:11 +00:00
Xin Li 66ff39e1bc Merge RQ2A.210305.007
Bug: 180401296
Merged-In: Icc96bfa8a3d59a19194a154baeaffaea1281af0a
Change-Id: I399d98f43a2799fbdada6e73afe450edcba6eec7
2021-03-03 09:12:18 -08:00
Tony Wickham 4092352a99 Merge "Add debug log for initInputMonitor()" into sc-dev 2021-03-03 16:42:33 +00:00
Steven Ng ab522e85b2 Remove unused widgets_scroll_container layout
Test: Compile NexusLauncher successfully

Bug: 181701011
Change-Id: I35d1c9324990e86496c45ca6db5f32f9588c7279
2021-03-03 13:54:02 +00:00
Alex Chau aa47630ecd Merge "Show TaskView as grid in large screens" into sc-dev 2021-03-03 10:08:01 +00:00
TreeHugger Robot 161b27d5c5 Merge "Better diagnosing leaked activities." into sc-dev 2021-03-03 08:26:34 +00:00
Jonathan Miranda 41a5c37009 Merge "Use grid border spacing as widget padding if possible." into sc-dev 2021-03-03 00:24:27 +00:00
Sunny Goyal 97c2e513b3 Fixing empty page not removed when drag ends
Bug: 179550470
Test: Verified on device
Change-Id: Ie9b20dfde1a64b385041f6e4d32fe47e3c6e5a7d
2021-03-02 13:00:22 -08:00
Alina Zaidi b8ad633b7e Interface for WidgetPickerSearchPipeline.
Test: not required
Bug: b/157286785
Change-Id: Ib0a4d2915bd678304e7971cdfd7296811ea8587b
2021-03-02 20:30:03 +00:00
TreeHugger Robot ce7961a493 Merge "Fix some issues with TwoButtonNavbarTouchController" into sc-dev 2021-03-02 20:14:32 +00:00
Jon Miranda 611dba4c94 Use grid border spacing as widget padding if possible.
Widget padding is added by the system to create reliable consistency
between widgets.

Now that we have added border spacing between cells on the launcher
grid, we have significantly decreased the available space for widgets
on home screens: widget padding is 8dp on all sides, border spacing is
currently spec'd to be 16dp.

We can inset the widget padding added by the system, and instead rely
on the border spacing between cells to create reliable consistency
between widgets.

Bug: 175329686
Test: manual
      turn CellLayout#VISUALIZE_GRID debug flag on
      test drag and drop, resizing using drag handles
      view measurements in go/web-hv
Change-Id: Iabb9f45e82e4ae039f55d7fd27fbd0d23be60191
2021-03-02 15:06:46 -05:00
TreeHugger Robot fe67c6be0b Merge "Fix NPE in FlingToDeleteHelper" into sc-dev 2021-03-02 20:00:53 +00:00
Jonathan Miranda a9bb9394a5 Merge "More grid changes, closer to final specs." into sc-dev 2021-03-02 19:19:08 +00:00
Sunny Goyal d197ebcfd5 Moving data sanitization before bind
Data sanitization changes the launcher model data, which makes it
out of sync with what Launcher is displaying.
This would lead to widgetsIds getting deleted when they are created
by Launcher on UI thread, but have not yet been updated in the model
Also clearing all ghost widgets on every load. This would remove
the flaky behavior where widget update depends on folder and
other icons getting removed

Test: Presubmit
Bug: 181680555
Change-Id: I3cce69383d9d92a283c5197c3f99fbb539d93dbb
2021-03-02 10:58:16 -08:00
Tony Wickham b96cf5cdf2 Fix some issues with TwoButtonNavbarTouchController
- Use same swipe height as the tests use to get to Overview
- Use mStartState instead of fromState when determining
  target state, to disallow swiping through states, i.e.
  from NORMAL to OVERVIEW back to NORMAL in one long swipe
  up gesture. Instead, now swipe up from NORMAL goes to
  OVERVIEW and swipe up from OVERVIEW goes to NORMAL.

Fixes: 177316094
Change-Id: Ic8e9c8650d4cf11eec344802e3569413bfd5d7bc
(cherry picked from commit a24b9ff69d)
2021-03-02 18:14:03 +00:00
Alex Chau b794ea64c7 Show TaskView as grid in large screens
- Introduced gridProgress to RecentsView/TaskView ofr animating into grid
- Introduced gridProgress dependant translation and scale properties in TaskView
- Animate running task into grid with TaskViewSimulator
- Remove overview actions (for now) but keep clear all button in large screens
- Adjust ClearAllButton translation to acoomodate for grid
- Use screen width +-50% to calculate task visibility
- Use the position where TaskView is on screenEnd as pageScroll
- TODO: Handle separate recents activity

Doc: go/foldables-launcher-overview
Video: http://dr/file/d/107Aydii1LoFCwP63nWG3Twr2PBDE5ZgD/view?resourcekey=0-aUjdnx8ezimS9tmAgao9ag
Test: Test Launchering overview and launching overview from apps with folloiwng combination:
- large / small screen sizes
- portrait / landscape
- thumbnails from different screen sizes / orientations
Bug: 174464863
Fixes: 181509346

Change-Id: I4b691cde774f2e37532b68ba83c6eed399f2332e
2021-03-02 17:10:45 +00:00
Jon Miranda 2839c20c1a Fix NPE in FlingToDeleteHelper
Bug: 171543835
Test: not able to repo bug, but this prevents the NPE
Change-Id: I153dd0665705b2f5fd7f46786e815ba57dec4720
2021-03-02 12:01:03 -05:00
Steven Ng 13d5079e90 Merge "Add widget description to WidgetCell" into sc-dev 2021-03-02 09:57:22 +00:00
Yogisha Dixit a6554759aa Merge "Move widget files into widget folder + add tests." into sc-dev 2021-03-02 09:30:02 +00:00