Commit Graph

34209 Commits

Author SHA1 Message Date
Lucas Dupin 20a13047ae Use launcher surface when removing launch target
Otherwise events won't be dispatched properly and window opacity will be
wrong.

Test: manual
Fixes: 191149025
Change-Id: Ice7ea86252282c7dc1cb5925dd1bdb8cade89c08
2021-07-02 17:39:10 -07:00
Samuel Fufa d733ce3f94 Merge "Allapps layout polishes" into sc-dev am: e67baf65f2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15190139

Change-Id: If7a94da5112c1ae01924a52b32e0fed8953259a6
2021-07-02 22:16:44 +00:00
Samuel Fufa e67baf65f2 Merge "Allapps layout polishes" into sc-dev 2021-07-02 22:05:26 +00:00
Tracy Zhou ac869d72d1 [automerger skipped] Merge "[DO NOT MERGE] Make the cutout slightly smaller" into sc-dev am: ee5dc1149e -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15081309

Change-Id: I2334540ce061839aaf4e9b2093a2603f16aef324
2021-07-02 21:42:36 +00:00
Tracy Zhou ee5dc1149e Merge "[DO NOT MERGE] Make the cutout slightly smaller" into sc-dev 2021-07-02 21:41:28 +00:00
Hyunyoung Song 6700b07b95 Merge "Revert "Don't use ProxyActivity when launching from SearchActionItemInfo intent"" into sc-dev am: 933d2536da
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15184812

Change-Id: I11f7a50edec21c2ed2adca381f7841a4844b2580
2021-07-02 21:36:55 +00:00
vadimt 7bd2a77144 Adding more diags for TAPL actions
Ones that change Launcher state.

Test: presubmit
Bug: 187761685
Change-Id: I11a29956613a4a211d49ee3df6d78e0000b80ced
2021-07-02 21:36:11 +00:00
Hyunyoung Song 933d2536da Merge "Revert "Don't use ProxyActivity when launching from SearchActionItemInfo intent"" into sc-dev 2021-07-02 21:18:18 +00:00
Hyunyoung Song 5881b910e9 Revert "Don't use ProxyActivity when launching from SearchActionItemInfo intent"
This reverts commit 878dedfb84.

Reason for revert: b/192558017
Bug: 192558017

Change-Id: I41e64ab74c00d7b255be6f3ef1b783c01571d641
2021-07-02 21:18:10 +00:00
Alex Chau 3c7bde72f7 Merge "Fix TaplTestsLauncher.testWorkspace's page expectation for 2 panel" into sc-v2-dev 2021-07-02 21:00:48 +00:00
Hyunyoung Song 40729fbdd6 Merge "Remove flicker when dismissing snackbar" into sc-dev am: 2d8856537e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15190712

Change-Id: I96da9d1380c2131849080e7835ed30b2b17f16a2
2021-07-02 20:42:24 +00:00
Tracy Zhou 26f47c711a [DO NOT MERGE] Make the cutout slightly smaller
Temporary fix for S. Leaving the bug open for a proper fix in T.

Bug: 189265196
Test: https://screenshot.googleplex.com/75fgCva736rqwg5
Change-Id: Ice3b189a41f759e090334e360e44543eabc4836d
2021-07-02 13:35:50 -07:00
Hyunyoung Song 2d8856537e Merge "Remove flicker when dismissing snackbar" into sc-dev 2021-07-02 20:29:59 +00:00
TreeHugger Robot fc9d97164c Merge "Fix NPE inside dispatchRestoreInstanceState" into sc-dev am: 04d4d0d4f9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15184364

Change-Id: I2ab86183cc5cd32b233b596364acfd329d8211a9
2021-07-02 19:05:02 +00:00
Alex Chau fc27bd17af Fix TaplTestsLauncher.testWorkspace's page expectation for 2 panel
- In tablet, workspace is scrollable only if page count > 2 instead of 1

Bug: 191344757
Test: TaplTestsLauncher.testWorkspace
Change-Id: I1db4e03bc1edd7976a75b2a5f6fedf69eea7b435
2021-07-02 19:55:25 +01:00
TreeHugger Robot 04d4d0d4f9 Merge "Fix NPE inside dispatchRestoreInstanceState" into sc-dev 2021-07-02 18:46:30 +00:00
Sunny Goyal 535c4957e6 Merge "Fix some touch issues during gesture nav transition" into sc-dev am: 6348858734
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15137733

Change-Id: I298c261a148e909d1f68926b6d865fa6f2b44825
2021-07-02 18:37:41 +00:00
Tracy Zhou cd5ebbdaf4 Merge "Check if live tile targetSet is null in launchSideTaskInLiveTileModeForRestartedApp" into sc-dev am: fa72529b05
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15184810

Change-Id: I9cb5e7e4ca2269c56ef835eee93bdc5b605583ac
2021-07-02 18:37:22 +00:00
Hyunyoung Song 1b68cbb822 Remove flicker when dismissing snackbar
Bug: 191972314
Test: manual

Change-Id: Icf185b89c07b363ec44c77ba3ac1bdeb34e30e59
2021-07-02 11:35:53 -07:00
Sunny Goyal 6348858734 Merge "Fix some touch issues during gesture nav transition" into sc-dev 2021-07-02 18:33:34 +00:00
Tracy Zhou fa72529b05 Merge "Check if live tile targetSet is null in launchSideTaskInLiveTileModeForRestartedApp" into sc-dev 2021-07-02 18:18:23 +00:00
Samuel Fufa 8b1461d212 Allapps layout polishes
Bug: 192666217
Bug: 192648043
Bug: 192648475
Test: Manual
Change-Id: Ib108a6cae8317571520d367334f3bd26b259f04a
2021-07-02 13:03:11 -05:00
Alex Chau 34c449d72e Merge "Add screen record for failing TaplTestsQuickstep" into sc-v2-dev 2021-07-02 17:20:30 +00:00
Alex Chau befa11295b Allow dragging outside TaskView on fallback recents
- Similar to LauncherRecentsView.onTouchEvent, don't allow touch to escape if overview UI is shown
- Add FLAG_OVERVIEW_UI to RecentsState

Fix: 192658511
Test: FallbackRecentsTest.testOverview on pixel_jumbojack
Change-Id: I80270da6c077e8302f75384edeb521cfa81266ec
2021-07-02 16:36:47 +01:00
Pierre Barbier de Reuille c167b0bdf3 Merge changes Id2a8d12e,I06353ba4 into sc-dev am: 6788b73970
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15171715

Change-Id: I40b331817125cd8f4f56302d004bb77e79ca635b
2021-07-02 14:20:17 +00:00
Alex Chau b297c7e615 Add screen record for failing TaplTestsQuickstep
- For debugging failures that only happnes on cuttlefish

Bug: 191344757
Test: TaplTestsQuickstep
Change-Id: Iac16e222dc7b60f94e1eb7f305c5ccb909161783
2021-07-02 15:14:05 +01:00
Pierre Barbier de Reuille 6788b73970 Merge changes Id2a8d12e,I06353ba4 into sc-dev
* changes:
  Use the computation of the widget size including padding.
  Avoid calling AppWidgetHostViedw#updateAppWidgetSize
2021-07-02 14:05:08 +00:00
Alex Chau 60cacdf373 Notify System UI about taskbar state
We want to move the rotation suggestion button to the middle
of the taskbar when it is visible and not stashed.
To do this we need to update System UI about the current
state of the taskbar.

Test: manual
Fixes: 187410455
Change-Id: Id918e10a44631362f7c3a8a8bb624ee80bdd3c8b
2021-07-02 10:48:04 +01:00
Pierre Barbier de Reuille a7b3a14e75 Use the computation of the widget size including padding.
Found all the uses of getWidgetSizePx and replaced them with the
computation of padded sizes (checked it all made sense).

Test: Try the various widget pickers.
Bug: 191612352
Change-Id: Id2a8d12ee7ce6baabef186dbb78d817975ea2212
2021-07-02 10:04:06 +01:00
Pierre Barbier de Reuille 199aec50ad Avoid calling AppWidgetHostViedw#updateAppWidgetSize
We cannot call it anymore, because the system padding is not always
used.

Bug: 191612352
Test: Manually, using CtsVerifier and dedicated widgets
Change-Id: I06353ba49a8e62127e593cdbcb86fadcf89ecb24
2021-07-02 10:03:44 +01:00
Tracy Zhou 3022d5f9f3 [automerger skipped] Enable live tile in 3 button mode am: 1fe5fda3d8 -s ours
am skip reason: Merged-In Iffaea18afb2179b5bb7dadda49e56efefa5658bc with SHA-1 d09ebe660f is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14254546

Change-Id: I1c104b0ff71d9a9571a3be3da019d600e948fab7
2021-07-02 06:52:37 +00:00
Tracy Zhou d2039614e0 Check if live tile targetSet is null in launchSideTaskInLiveTileModeForRestartedApp
Fixes: 192458435
Test: N/A
Change-Id: I3f0b828bf9fa9645bbd253612aa073f37b21e4b2
2021-07-01 23:52:34 -07:00
Hyunyoung Song 9804c0472e Fix NPE inside dispatchRestoreInstanceState
Bug: 192559704
Test: manual
Change-Id: I212518ac4a7feddd8e87f4be601332ea62e99313
2021-07-01 23:26:57 -07:00
Tracy Zhou 1fe5fda3d8 Enable live tile in 3 button mode
- Previously we rely on whether launcher is resumed as a signal to see what "toggle" means. This no longer works since launcher is not resumed in Overview. Instead, we need to check the live tile signals.
- Use screenshot doesn't propagate after setting a new current task. So followed the logic around mRunningTaskIconScaledDown to work it out.
- Get rid of NavigationModeFeatureFlag, pending on 3rd party launcher change ag/14409355

Fixes: 185934639
Test: (1) Toggle overview from home screen and toggle back to fullscreen. (2) Toggle overview from app and keep toggling.

Change-Id: Iffaea18afb2179b5bb7dadda49e56efefa5658bc
Merged-In: Iffaea18afb2179b5bb7dadda49e56efefa5658bc
2021-07-02 05:19:32 +00:00
Tracy Zhou d09ebe660f Enable live tile in 3 button mode
- Previously we rely on whether launcher is resumed as a signal to see what "toggle" means. This no longer works since launcher is not resumed in Overview. Instead, we need to check the live tile signals.
- Use screenshot doesn't propagate after setting a new current task. So followed the logic around mRunningTaskIconScaledDown to work it out.
- Get rid of NavigationModeFeatureFlag, pending on 3rd party launcher change ag/14409355

Fixes: 185934639
Test: (1) Toggle overview from home screen and toggle back to fullscreen. (2) Toggle overview from app and keep toggling.

Change-Id: Iffaea18afb2179b5bb7dadda49e56efefa5658bc
2021-07-01 18:40:56 -07:00
Alex Chau e526fd6a00 Merge "Restore previous currentPage in applyLoadPlan in case task is re-ordered" into sc-dev am: 679f8bb9ca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15175270

Change-Id: I4cc43374c577299c7be3d63bb8a7393a90447231
2021-07-01 22:28:30 +00:00
Alex Chau 679f8bb9ca Merge "Restore previous currentPage in applyLoadPlan in case task is re-ordered" into sc-dev 2021-07-01 22:12:54 +00:00
Tracy Zhou 1dd0ca7bec [automerger skipped] Merge "Do not switch to screenshot and finish recents animation for menu options that already do so" into sc-dev am: e54f789de9 -s ours
am skip reason: skipped by user tracyzhou

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15176734

Change-Id: Ic5c12013c702c683417ab706c06d6c71b26ecb4f
2021-07-01 20:15:54 +00:00
Tracy Zhou e54f789de9 Merge "Do not switch to screenshot and finish recents animation for menu options that already do so" into sc-dev 2021-07-01 19:32:39 +00:00
Jonathan Miranda e6f0509d1d Merge "Fix bug where app icon is gone for first frame on cold start." into sc-dev am: 3334c32120
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15164770

Change-Id: I38ace4adec4591e9259a8859ed547e1b951b922c
2021-07-01 18:36:20 +00:00
Jonathan Miranda aa560506ba Merge "Cancel existing preview item animation during non-animated update." into sc-dev am: 81501a563c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15164771

Change-Id: I667763f65219cf259b8cf0db929d7dc0c848163e
2021-07-01 18:36:16 +00:00
Jonathan Miranda 3334c32120 Merge "Fix bug where app icon is gone for first frame on cold start." into sc-dev 2021-07-01 18:34:47 +00:00
Jonathan Miranda 81501a563c Merge "Cancel existing preview item animation during non-animated update." into sc-dev 2021-07-01 18:32:49 +00:00
Sunny Goyal 2e5176e51f Merge "Fixing some dimentions in AllSet activity" into sc-dev am: f3d3dcf4a1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15160037

Change-Id: I3e8d01451a9ad4b14128bf90a9d758e922d04f4e
2021-07-01 18:32:02 +00:00
Sunny Goyal f3d3dcf4a1 Merge "Fixing some dimentions in AllSet activity" into sc-dev 2021-07-01 18:16:45 +00:00
Tracy Zhou 99adef95b3 Do not switch to screenshot and finish recents animation for menu options that already do so
The issue is that in landscape mode we add overview shortcuts (e.g. screenshot) to the task view menu, where we switch to screenshot and finish recents animation before executing the shortcut action. However for shortcut actions like screenshot, we do the same, resulting in two chained "switch to screenshot and finish". This is a temporary fix for S given it's late in the cycle and we don't want to introduce unwanted regressions.

Fixes: 192272546
Test: manual
Change-Id: I7ef596e8bce6c15aa4a27163197beac12359b691
2021-07-01 17:46:44 +00:00
Alex Chau e0fcee01b3 Restore previous currentPage in applyLoadPlan in case task is re-ordered
Fix: 186537288
Test: Repeatededly launch task from home and swipe to home, animation is correct
Test: Quick switch, launch task then swipe up, there is no jump
Change-Id: I9fd7416d9811ce4e54a1c6d20374d89d00417cd5
2021-07-01 18:43:20 +01:00
Tony Wickham 5fac02bc5e Fix some touch issues during gesture nav transition
- Don't recreate the laucher transition controller if we've already ended it, as it could clobber a touch interaction that started in the meantime
  - Test: swipe up from an app to overivew, swipe to dismiss it during the transition.
  - Previously, we were ending the controller twice (once on touch down as we started proxying, and again in setupLauncherUiAfterSwipeUpToRecentsAnimation()), and the second one could happen after starting the dismiss interaction.

- Don't recreateControllers() if orientation didn't change
  - Test: swipe up to go from an app to home, swipe up to all apps during the transition.
  - Previously, we were getting the following sequence:
    1. Touch down on home to start swiping to all apps - all current controllers get this down event to start determining whether to intercept
    2. Before reaching touch slop, we recreateControllers(), so all new controllers won't get the down event and thus won't intercept
  - Now, we avoid unnecessarily recreateControllers(), so the original controllers can still intercept.

Test: see above
Fixes: 189700453
Change-Id: I7b5fb3d21ab7a7a7044fcec7f2c1e39afe23c5dd
2021-07-01 07:39:59 -10:00
Winson Chung 2ae6a3e3c9 Merge "Defer cleaning up screenshot until after we actually switch to screenshot" into sc-dev am: eb0a38c5f2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15160033

Change-Id: I4183018dbe6ad644824f842cae259ab0786c9657
2021-07-01 17:15:48 +00:00
Cyrus Boadway 270a9c734f Merge "Use nullable field and boolean rather than optional" into sc-dev am: 048a858575
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15171711

Change-Id: I6b6b6bf2ecb367f81fdb82321c7e7bb3cd8a228a
2021-07-01 17:15:38 +00:00