Commit Graph

6522 Commits

Author SHA1 Message Date
vadimt ca383ffdf5 Postponing CUJ start by 1 frame
for CUJ_APP_LAUNCH_FROM_ICON, CUJ_APP_CLOSE_TO_HOME,
CUJ_APP_LAUNCH_FROM_WIDGET and CUJ_APP_LAUNCH_FROM_RECENTS

Test: Local perfetto run
Bug: 190858586
Change-Id: I7a26d91c44a0a4c767bde3230d39a096a26d7b75
2021-06-24 11:44:57 -07:00
Zak Cohen 95d23f9a4d Revert "Fix some touch issues during gesture nav transition"
This reverts commit 1351c2214d.

Reason for revert: Suspect causing test failures: https://b.corp.google.com/issues/191946109

Change-Id: Ib1b5545b3a612e89923ea06a890e4a07be9fa857
2021-06-24 18:11:36 +00:00
Alex Chau 7a9972289f Add touch event of on taskbar for various cases
- Temporarily disable leak detection on tablets until b/191449914 is resolved
- Add touch event on taskbar when interacting with navigation buttons
- Added TaplTestsLauncher3.initialize to StartLauncherViaGestureTests which is present in TaplTestQuickstep to solve LauncherInstrumentation being null problem on tablets

Bug: 191344757, 191449914
Test: TaplTestQuickstep and StartLauncherViaGestureTests
Change-Id: I49accc458d133717f290140abe80aae8a683f6c0
2021-06-24 18:00:12 +01:00
Pat Manning 99191fdf3f Hide overview on fold/unfold when live tile is active.
Test: manual
Fix: 184846394
Change-Id: I97ae328234bf0932712c7cf3ca97813cae7c46a7
2021-06-24 16:18:03 +00:00
Tony Wickham 9f7eae758f Merge "Fix some touch issues during gesture nav transition" into sc-dev am: 8db306f3c5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15081302

Change-Id: I95ef73ae3b9352e70d16ff3a97ae74abf0b69656
2021-06-24 01:18:10 +00:00
TreeHugger Robot bd80a07da1 Merge "Ensure InputConsumer is non-null in remaining cases" into sc-dev am: 862224f913
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15084524

Change-Id: If699c0ba7e4ef2e1bcb8026de6a16ed5fc599c6d
2021-06-24 01:18:03 +00:00
Tony Wickham 8db306f3c5 Merge "Fix some touch issues during gesture nav transition" into sc-dev 2021-06-24 01:08:43 +00:00
TreeHugger Robot 862224f913 Merge "Ensure InputConsumer is non-null in remaining cases" into sc-dev 2021-06-24 01:04:18 +00:00
Tony Wickham f64f9a14d8 Ensure InputConsumer is non-null in remaining cases
Anywhere that was using mResetGestureInputConsumer now uses getDefaultInputConsumer, which returns NO_OP if mResetGestureInputConsumer is null.

Test: none
Bug: 191684742
Change-Id: I1ae02b01a9629fa0830955dfe4d83c95a4759c14
2021-06-23 16:39:44 -07:00
Vinit Nayak d86a9948f9 Add rounded corners to TaskMenu Items
Bug: 188168717
Test: Manual
Change-Id: I7cce42fb08f03a9689b4c5d56ed8208d6f60f7d7
2021-06-23 23:16:01 +00:00
Hilary Huo cb4475f7d8 Merge "[settings-pixel-search] Add ww logging to track slice fetching timeout" into sc-dev am: 08843d8e37
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15068624

Change-Id: I58da46b9fc9fd83205c352996c78453885666397
2021-06-23 22:29:13 +00:00
Hilary Huo 08843d8e37 Merge "[settings-pixel-search] Add ww logging to track slice fetching timeout" into sc-dev 2021-06-23 22:18:00 +00:00
Schneider Victor-tulias e6b93993d1 Update Gesture navigation tutorial activity permissions
Temporarily removed REBOOT permission requirement from GESTURE_SANDBOX.

Fixes: 188035141
Test: manual
Change-Id: I11788d7c6dd5a7b10e8cc4400b17f5f2fec967f7
2021-06-23 13:08:21 -07:00
Tony Wickham 1351c2214d Fix some touch issues during gesture nav transition
- Don't recreate the laucher transition controller if we've already ended it, as it could clobber a touch interaction that started in the meantime
  - Test: swipe up from an app to overivew, swipe to dismiss it during the transition.
  - Previously, we were ending the controller twice (once on touch down as we started proxying, and again in setupLauncherUiAfterSwipeUpToRecentsAnimation()), and the second one could happen after starting the dismiss interaction.
- Don't recreateControllers() if orientation didn't change
  - Test: swipe up to go from an app to home, swipe up to all apps during the transition.
  - Previously, we were getting the following sequence:
    1. Touch down on home to start swiping to all apps - all current controllers get this down event to start determining whether to intercept
    2. Before reaching touch slop, we recreateControllers(), so all new controllers won't get the down event and thus won't intercept
  - Now, we avoid unnecessarily recreateControllers(), so the original controllers can still intercept.

Test: see above
Fixes: 189700453
Change-Id: Icfa5b6cdb32122adaf6ac8e8cb197b0c477dac60
2021-06-23 13:07:18 -07:00
Tracy Zhou 2f8342d791 Merge "Finish recents animation on task dismissal only if the task is a live tile task" into sc-dev 2021-06-23 19:40:15 +00:00
Lucas Dupin 8ee65b1d75 Merge "Disable blurs when dev setting or battery saver" into sc-dev am: 697e51cd8c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15069844

Change-Id: Ia7bcf27ad8aba1a9115481f5ba4f9d77bf56d3a8
2021-06-23 19:00:14 +00:00
Lucas Dupin 697e51cd8c Merge "Disable blurs when dev setting or battery saver" into sc-dev 2021-06-23 18:40:43 +00:00
Vadim Tryshev 46aab40dd5 Merge "Detect leaks only on test success Bug: 191690396 Test: presubmit" into sc-dev am: 9d7ff51901
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15068626

Change-Id: I15ec31f5147ee3a484d33dedc3e6ae5dfe25abbd
2021-06-23 17:52:35 +00:00
Vadim Tryshev 9d7ff51901 Merge "Detect leaks only on test success Bug: 191690396 Test: presubmit" into sc-dev 2021-06-23 17:50:47 +00:00
Zak Cohen 2f3d6822d4 Merge "Sets a simple locus id when Overview is enabled" into sc-dev am: e43edc74ef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15053498

Change-Id: I682014c857a2d977d0333eb7cb5f3415b92c5002
2021-06-23 17:44:29 +00:00
Schneider Victor-tulias 3908e51796 Merge "Update gesture nav tutorial back left and right videos" into sc-dev am: bef29071b5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14969574

Change-Id: I9961ffcd4c490576628782bd59b142ed3caa20f3
2021-06-23 17:44:12 +00:00
Zak Cohen e43edc74ef Merge "Sets a simple locus id when Overview is enabled" into sc-dev 2021-06-23 17:38:16 +00:00
Schneider Victor-tulias bef29071b5 Merge "Update gesture nav tutorial back left and right videos" into sc-dev 2021-06-23 17:28:35 +00:00
Tracy Zhou d537968b35 Finish recents animation on task dismissal only if the task is a live tile task
Fixes: 191831190
Test: manual
Change-Id: Ie1dd02a2e8cc401a613a0ed2199400712c6d5291
Merged-In: Ie1dd02a2e8cc401a613a0ed2199400712c6d5291
2021-06-23 17:18:00 +00:00
Hilary Huo e83189593a [settings-pixel-search] Add ww logging to track slice fetching timeout
Test: https://paste.googleplex.com/6310936320147456
Bug: 191297465
Change-Id: I0a4a65295e7290b55dccdb63830ff60c6838fbb2
2021-06-23 10:16:21 -07:00
Lucas Dupin b60fff3929 Disable blurs when dev setting or battery saver
Stop rendering blurs whenever a user:
- disables blurs on developer settings
- enables battery saver

Test: manual
Bug: 191814337
Change-Id: I8fd04796054d92171732c8db95b64cfa3ec469ec
2021-06-23 08:37:27 -07:00
Tracy Zhou 2591768d54 Finish recents animation on task dismissal only if the task is a live tile task
Fixes: 191831190
Test: manual
Change-Id: Ie1dd02a2e8cc401a613a0ed2199400712c6d5291
2021-06-23 05:31:09 +00:00
vadimt 143748fbf4 Detect leaks only on test success
Bug: 191690396
Test: presubmit

Change-Id: Ie59c3b944d420ac25ebba86bf500fcf33700ca99
2021-06-22 18:49:34 -07:00
Thiru Ramasamy a829f96bff [AA+] Adds CorrectedDeviceSearchResultContainer to log user interactions on search results from corrected queries. am: 2f65e7f274
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14969368

Change-Id: If77091b49579165e42ff384b13b515496845b2dc
2021-06-23 00:41:35 +00:00
zakcohen e2c4687e51 Sets a simple locus id when Overview is enabled
Bug: 189968849
Test: Ran with logcat to check correct locus is set
Change-Id: I5253d83b4cf5862e49c3183a843bf8f26dce149e
2021-06-22 16:46:30 -07:00
Thiru Ramasamy 2f65e7f274 [AA+] Adds CorrectedDeviceSearchResultContainer to log user interactions on search results from corrected queries.
Bug: 188840584
Test: Local
Change-Id: Ibbf2b228537a19be1e77993efee5edc421ff70eb
2021-06-22 15:40:22 -07:00
Winson Chung 76d5158c66 Merge "Don't finish to home when launching a task from recents" into sc-dev am: d27f127b3a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15057896

Change-Id: Iaa2522dca2785a3fa0094c75dc55f201cc000940
2021-06-22 19:10:08 +00:00
Winson Chung d27f127b3a Merge "Don't finish to home when launching a task from recents" into sc-dev 2021-06-22 18:54:14 +00:00
Winson Chung 856cd1bd4d Don't finish to home when launching a task from recents
- When launching without a task view, we should also not be finishing
  to home (similar to composeRecentsLaunchAnimator) since it will
  clobber the newly launched task

Fixes: 191182965
Test: Open overview with live tile, try to open usb debugging settings
      page
Change-Id: If7464ebf155cee33e81205fbf4899e9ab49a52d0
2021-06-22 18:54:03 +00:00
Cyrus Boadway 32f7517f19 Merge "Use icon splash screen when starting activity from widget interaction" into sc-dev am: 9dd0351ed1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15062776

Change-Id: I86e28dc686e769da4760959ec4343d659a4fd602
2021-06-22 18:20:50 +00:00
Sunny Goyal 9ffb0f803b Merge "Fixing TaskView.launchTask.onEndCallback is not called" into sc-dev am: eb3367796a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15032513

Change-Id: I0b76512550814f23fde9c95a59e90e50280e3dde
2021-06-22 18:20:46 +00:00
Cyrus Boadway 9dd0351ed1 Merge "Use icon splash screen when starting activity from widget interaction" into sc-dev 2021-06-22 18:13:52 +00:00
Sunny Goyal eb3367796a Merge "Fixing TaskView.launchTask.onEndCallback is not called" into sc-dev 2021-06-22 18:08:25 +00:00
Tracy Zhou 6b4c93b0dc Merge "Null check on target set before rendering task open animation" into sc-dev am: 578b45f919
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14698046

Change-Id: I12121c440cf1fb95347b01cd5704a28ac088c951
2021-06-22 17:45:22 +00:00
Tracy Zhou 578b45f919 Merge "Null check on target set before rendering task open animation" into sc-dev 2021-06-22 17:21:32 +00:00
Zak Cohen a6dd5b49d7 Merge "Fade overview action buttons faster in overview -> home" into sc-dev am: 049c2f578b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15054721

Change-Id: I680d45f36df17c08936a29b502c8e09765df3f72
2021-06-22 17:03:20 +00:00
Matt Casey f37285049a Merge "Send a zero for assist invocation on animation end" into sc-dev am: 3a65795298
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15065435

Change-Id: Ib5837248faef0c9ee2160b34dbd1e3adb40b0699
2021-06-22 17:02:36 +00:00
Zak Cohen 049c2f578b Merge "Fade overview action buttons faster in overview -> home" into sc-dev 2021-06-22 16:53:52 +00:00
Matt Casey 3a65795298 Merge "Send a zero for assist invocation on animation end" into sc-dev 2021-06-22 16:46:41 +00:00
Matt Casey eeac1aba30 Send a zero for assist invocation on animation end
When a corner gesture doesn't complete, we animate the progress from its
current value back to 0. When it hits 0, sysui will perform some cleanup
e.g. removing the window. However, it's possible the animator won't
return exactly 0 and will complete, so we should send an explicit 0
whenever the animator completes.

Bug: 187768368
Test: We don't have a repro for the bug, but expect this should be more
      robust. Tested to validate it didn't regress.
Change-Id: Id65f94534363c326fc2c8d0a9114a3c036aa55e4
2021-06-22 10:46:10 -04:00
Cyrus Boadway f158ec33d8 Use icon splash screen when starting activity from widget interaction
Set the flag to use the icon splash screen rather than the empty splash
screen when starting an activity from a widget interaction.

Bug: 191738655
Test: manual
Change-Id: Iff771a43648bbf6dfb88e2a6749c4526fd17da07
2021-06-22 10:14:06 +00:00
Tracy Zhou 8af0dd3e0c Null check on target set before rendering task open animation
Fixes: 190854921
Test: N/A
Change-Id: Iae7ef7cf3f4d2309223bfabe6d40f24b7e34439c
2021-06-21 21:33:28 -07:00
Sunny Goyal 49537a8942 Merge "Simplifying Launcher binding callbacks" into sc-v2-dev 2021-06-22 03:42:28 +00:00
Lucas Dupin f87cd286d5 Merge "Apply depth even when surface is null" into sc-dev am: 818ed4b794
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15055654

Change-Id: I8ecba7fb05ad49dfadba39d849167b0b696304f3
2021-06-22 01:26:46 +00:00
Lucas Dupin 818ed4b794 Merge "Apply depth even when surface is null" into sc-dev 2021-06-22 01:10:23 +00:00